<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286313] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286313">286313</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-11-30 12:08:27 -0800 (Tue, 30 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Rename "queueTaskToEventLoop" to "queueMicrotaskToEventLoop"
https://bugs.webkit.org/show_bug.cgi?id=233639

Patch by Alexey Shvayka <ashvayka@apple.com> on 2021-11-30
Reviewed by Mark Lam.

This change improves grep-ability and avoids confusion since JSDOMWindowBase's
queueMicrotaskToEventLoop() is capable only of scheduling microtasks (hence its signature).
ECMA-262 has no notion of macrotasks, and now JSC hasn't as well.

No behavior change.

* API/JSAPIGlobalObject.cpp:
* API/JSAPIGlobalObject.mm:
* jsc.cpp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::queueMicrotask):
* runtime/JSGlobalObject.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSAPIGlobalObjectcpp">trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSAPIGlobalObjectmm">trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.mm</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorejsccpp">trunk/Source/JavaScriptCore/jsc.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjecth">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSAPIGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.cpp (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.cpp    2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.cpp       2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">     &supportsRichSourceInfo,
</span><span class="cx">     &shouldInterruptScript,
</span><span class="cx">     &javaScriptRuntimeFlags,
</span><del>-    nullptr, // queueTaskToEventLoop
</del><ins>+    nullptr, // queueMicrotaskToEventLoop
</ins><span class="cx">     &shouldInterruptScriptBeforeTimeout,
</span><span class="cx">     nullptr, // moduleLoaderImportModule
</span><span class="cx">     nullptr, // moduleLoaderResolve
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSAPIGlobalObjectmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.mm (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.mm     2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/API/JSAPIGlobalObject.mm        2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">     &supportsRichSourceInfo,
</span><span class="cx">     &shouldInterruptScript,
</span><span class="cx">     &javaScriptRuntimeFlags,
</span><del>-    nullptr, // queueTaskToEventLoop
</del><ins>+    nullptr, // queueMicrotaskToEventLoop
</ins><span class="cx">     &shouldInterruptScriptBeforeTimeout,
</span><span class="cx">     &moduleLoaderImportModule, // moduleLoaderImportModule
</span><span class="cx">     &moduleLoaderResolve, // moduleLoaderResolve
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/ChangeLog       2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-11-30  Alexey Shvayka  <ashvayka@apple.com>
+
+        Rename "queueTaskToEventLoop" to "queueMicrotaskToEventLoop"
+        https://bugs.webkit.org/show_bug.cgi?id=233639
+
+        Reviewed by Mark Lam.
+
+        This change improves grep-ability and avoids confusion since JSDOMWindowBase's
+        queueMicrotaskToEventLoop() is capable only of scheduling microtasks (hence its signature).
+        ECMA-262 has no notion of macrotasks, and now JSC hasn't as well.
+
+        No behavior change.
+
+        * API/JSAPIGlobalObject.cpp:
+        * API/JSAPIGlobalObject.mm:
+        * jsc.cpp:
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::queueMicrotask):
+        * runtime/JSGlobalObject.h:
+
</ins><span class="cx"> 2021-11-30  Saam Barati  <sbarati@apple.com>
</span><span class="cx"> 
</span><span class="cx">         GetMyArgumentByValOutOfBounds needs to check for negative indices
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejsccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jsc.cpp (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jsc.cpp      2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/jsc.cpp 2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -743,7 +743,7 @@
</span><span class="cx">     &shellSupportsRichSourceInfo,
</span><span class="cx">     &shouldInterruptScript,
</span><span class="cx">     &javaScriptRuntimeFlags,
</span><del>-    nullptr, // queueTaskToEventLoop
</del><ins>+    nullptr, // queueMicrotaskToEventLoop
</ins><span class="cx">     &shouldInterruptScriptBeforeTimeout,
</span><span class="cx">     &moduleLoaderImportModule,
</span><span class="cx">     &moduleLoaderResolve,
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp   2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp      2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -522,7 +522,7 @@
</span><span class="cx">     &supportsRichSourceInfo,
</span><span class="cx">     &shouldInterruptScript,
</span><span class="cx">     &javaScriptRuntimeFlags,
</span><del>-    nullptr, // queueTaskToEventLoop
</del><ins>+    nullptr, // queueMicrotaskToEventLoop
</ins><span class="cx">     &shouldInterruptScriptBeforeTimeout,
</span><span class="cx">     nullptr, // moduleLoaderImportModule
</span><span class="cx">     nullptr, // moduleLoaderResolve
</span><span class="lines">@@ -2554,8 +2554,8 @@
</span><span class="cx"> 
</span><span class="cx"> void JSGlobalObject::queueMicrotask(Ref<Microtask>&& task)
</span><span class="cx"> {
</span><del>-    if (globalObjectMethodTable()->queueTaskToEventLoop) {
-        globalObjectMethodTable()->queueTaskToEventLoop(*this, WTFMove(task));
</del><ins>+    if (globalObjectMethodTable()->queueMicrotaskToEventLoop) {
+        globalObjectMethodTable()->queueMicrotaskToEventLoop(*this, WTFMove(task));
</ins><span class="cx">         return;
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h (286312 => 286313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h     2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h        2021-11-30 20:08:27 UTC (rev 286313)
</span><span class="lines">@@ -219,8 +219,8 @@
</span><span class="cx">     typedef RuntimeFlags (*JavaScriptRuntimeFlagsFunctionPtr)(const JSGlobalObject*);
</span><span class="cx">     JavaScriptRuntimeFlagsFunctionPtr javaScriptRuntimeFlags;
</span><span class="cx"> 
</span><del>-    typedef void (*QueueTaskToEventLoopFunctionPtr)(JSGlobalObject&, Ref<Microtask>&&);
-    QueueTaskToEventLoopFunctionPtr queueTaskToEventLoop;
</del><ins>+    typedef void (*QueueMicrotaskToEventLoopFunctionPtr)(JSGlobalObject&, Ref<Microtask>&&);
+    QueueMicrotaskToEventLoopFunctionPtr queueMicrotaskToEventLoop;
</ins><span class="cx"> 
</span><span class="cx">     typedef bool (*ShouldInterruptScriptBeforeTimeoutPtr)(const JSGlobalObject*);
</span><span class="cx">     ShouldInterruptScriptBeforeTimeoutPtr shouldInterruptScriptBeforeTimeout;
</span></span></pre>
</div>
</div>

</body>
</html>