<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[286063] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/286063">286063</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2021-11-19 08:53:01 -0800 (Fri, 19 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>:hover with descendant selector not invalidated correctly in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=233354

Reviewed by Antoine Quint.

Source/WebCore:

We optimize :hover and :active by only invalidating for descendant selectors with a single tree walk.
This doesn't work correctly for shadow trees as their scoped style may differ and the invalidation
is limited to a single scope anyway.

Fix by doing descendant invalidation for each affected scope.

Test: fast/selectors/hover-descendant-shadow-tree.html

* dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):

We need to perform scoped descendant invalidation for elements that are parented to ShadowRoot.

LayoutTests:

* fast/selectors/hover-descendant-shadow-tree-expected.html: Added.
* fast/selectors/hover-descendant-shadow-tree.html: Added.
* platform/ios/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiosTestExpectations">trunk/LayoutTests/platform/ios/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastselectorshoverdescendantshadowtreeexpectedhtml">trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastselectorshoverdescendantshadowtreehtml">trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (286062 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-11-19 15:57:39 UTC (rev 286062)
+++ trunk/LayoutTests/ChangeLog 2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-11-19  Antti Koivisto  <antti@apple.com>
+
+        :hover with descendant selector not invalidated correctly in shadow tree
+        https://bugs.webkit.org/show_bug.cgi?id=233354
+
+        Reviewed by Antoine Quint.
+
+        * fast/selectors/hover-descendant-shadow-tree-expected.html: Added.
+        * fast/selectors/hover-descendant-shadow-tree.html: Added.
+        * platform/ios/TestExpectations:
+
</ins><span class="cx"> 2021-11-19  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION(r285859) [GTK][WPE] a number of accessibility/* tests crash on GTK and WPE
</span></span></pre></div>
<a id="trunkLayoutTestsfastselectorshoverdescendantshadowtreeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree-expected.html (0 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree-expected.html                              (rev 0)
+++ trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree-expected.html 2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<style>
+.parent {
+  width: 100px;
+  height: 100px;
+  background: blue;
+}
+  
+.child {
+  width: 30px;
+  height: 30px;
+  background: green;
+}
+
+</style>
+<div class="parent">
+  <div class="child">
+  </div>
+</div>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastselectorshoverdescendantshadowtreehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree.html (0 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree.html                               (rev 0)
+++ trunk/LayoutTests/fast/selectors/hover-descendant-shadow-tree.html  2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -0,0 +1,44 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<template id="template">
+<style>
+.parent {
+  width: 100px;
+  height: 100px;
+  background: blue;
+}
+  
+.child {
+  width: 30px;
+  height: 30px;
+}
+
+.parent:hover .child { 
+    background: green;
+}
+
+</style>
+<div class="parent">
+  <div class="child">
+  </div>
+</div>
+</template>
+
+<script>
+customElements.define('custom-element', class extends HTMLElement {
+  connectedCallback() {
+    this.attachShadow({mode: 'open'}).append(template.content.cloneNode(true));
+  }
+});
+</script>
+
+<custom-element id=target></custom-element>
+
+<script>
+if (window.eventSender) {
+    var x = target.offsetLeft + target.offsetWidth / 2;
+    var y = target.offsetTop + target.offsetHeight / 2;
+    eventSender.mouseMoveTo(x, y);
+}
+</script>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiosTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios/TestExpectations (286062 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios/TestExpectations  2021-11-19 15:57:39 UTC (rev 286062)
+++ trunk/LayoutTests/platform/ios/TestExpectations     2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -710,6 +710,7 @@
</span><span class="cx"> fast/selectors/active-hover-strict.html [ Skip ]
</span><span class="cx"> fast/selectors/active-quirks.html [ Skip ]
</span><span class="cx"> fast/selectors/active-strict.html [ Skip ]
</span><ins>+fast/selectors/hover-descendant-shadow-tree.html [ Skip ]
</ins><span class="cx"> fast/selectors/hover-invalidation-descendant-clear.html [ Skip ]
</span><span class="cx"> fast/selectors/hover-invalidation-descendant-dynamic.html [ Skip ]
</span><span class="cx"> fast/selectors/hover-quirks.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (286062 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-11-19 15:57:39 UTC (rev 286062)
+++ trunk/Source/WebCore/ChangeLog      2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-11-19  Antti Koivisto  <antti@apple.com>
+
+        :hover with descendant selector not invalidated correctly in shadow tree
+        https://bugs.webkit.org/show_bug.cgi?id=233354
+
+        Reviewed by Antoine Quint.
+
+        We optimize :hover and :active by only invalidating for descendant selectors with a single tree walk.
+        This doesn't work correctly for shadow trees as their scoped style may differ and the invalidation
+        is limited to a single scope anyway.
+
+        Fix by doing descendant invalidation for each affected scope.
+
+        Test: fast/selectors/hover-descendant-shadow-tree.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateHoverActiveState):
+
+        We need to perform scoped descendant invalidation for elements that are parented to ShadowRoot.
+
</ins><span class="cx"> 2021-11-19  Matt Woodrow  <matt.woodrow@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Don't modify fragment-only or empty image URLs
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (286062 => 286063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp    2021-11-19 15:57:39 UTC (rev 286062)
+++ trunk/Source/WebCore/dom/Document.cpp       2021-11-19 16:53:01 UTC (rev 286063)
</span><span class="lines">@@ -7480,7 +7480,16 @@
</span><span class="cx">     auto changeState = [](auto& elements, auto pseudoClassType, auto&& setter) {
</span><span class="cx">         if (elements.isEmpty())
</span><span class="cx">             return;
</span><ins>+
</ins><span class="cx">         Style::PseudoClassChangeInvalidation styleInvalidation { *elements.last(), pseudoClassType, Style::InvalidationScope::Descendants };
</span><ins>+
+        // We need to do descendant invalidation for each shadow tree separately as the style is per-scope.
+        Vector<Style::PseudoClassChangeInvalidation> shadowDescendantStyleInvalidations;
+        for (auto& element : elements) {
+            if (hasShadowRootParent(*element))
+                shadowDescendantStyleInvalidations.append({ *element, pseudoClassType, Style::InvalidationScope::Descendants });
+        }
+
</ins><span class="cx">         for (auto& element : elements)
</span><span class="cx">             setter(*element);
</span><span class="cx">     };
</span></span></pre>
</div>
</div>

</body>
</html>