<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285930] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285930">285930</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2021-11-17 07:10:51 -0800 (Wed, 17 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes.
https://bugs.webkit.org/show_bug.cgi?id=233222

Reviewed by Antti Koivisto.

See https://drafts.csswg.org/css-text/#overflow-wrap-property

* layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::InlineContentBreaker):
(WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):
* layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::isIntrinsicWidthMode const):
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
* layout/formattingContexts/inline/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::isIntrinsicWidthMode const):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorelayoutformattingContextsinlineInlineContentBreakercpp">trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp</a></li>
<li><a href="#trunkSourceWebCorelayoutformattingContextsinlineInlineContentBreakerh">trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h</a></li>
<li><a href="#trunkSourceWebCorelayoutformattingContextsinlineInlineLineBuildercpp">trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCorelayoutformattingContextsinlineInlineLineBuilderh">trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (285929 => 285930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-11-17 15:08:14 UTC (rev 285929)
+++ trunk/Source/WebCore/ChangeLog      2021-11-17 15:10:51 UTC (rev 285930)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-11-17  Alan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes.
+        https://bugs.webkit.org/show_bug.cgi?id=233222
+
+        Reviewed by Antti Koivisto.
+
+        See https://drafts.csswg.org/css-text/#overflow-wrap-property
+
+        * layout/formattingContexts/inline/InlineContentBreaker.cpp:
+        (WebCore::Layout::InlineContentBreaker::InlineContentBreaker):
+        (WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):
+        * layout/formattingContexts/inline/InlineContentBreaker.h:
+        (WebCore::Layout::InlineContentBreaker::isIntrinsicWidthMode const):
+        * layout/formattingContexts/inline/InlineLineBuilder.cpp:
+        (WebCore::Layout::LineBuilder::placeInlineContent):
+        (WebCore::Layout::LineBuilder::initialConstraintsForLine const):
+        * layout/formattingContexts/inline/InlineLineBuilder.h:
+        (WebCore::Layout::LineBuilder::isIntrinsicWidthMode const):
+
</ins><span class="cx"> 2021-11-17  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Increase CoreAudioCaptureSource capture verify timer to handle the case of device change
</span></span></pre></div>
<a id="trunkSourceWebCorelayoutformattingContextsinlineInlineContentBreakercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp (285929 => 285930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp   2021-11-17 15:08:14 UTC (rev 285929)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp      2021-11-17 15:10:51 UTC (rev 285930)
</span><span class="lines">@@ -125,6 +125,11 @@
</span><span class="cx">     return { };
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+InlineContentBreaker::InlineContentBreaker(bool isInIntrinsicWidthMode)
+    : m_isInIntrinsicWidthMode(isInIntrinsicWidthMode)
+{
+}
+
</ins><span class="cx"> bool InlineContentBreaker::shouldKeepEndOfLineWhitespace(const ContinuousContent& continuousContent) const
</span><span class="cx"> {
</span><span class="cx">     // Grab the style and check for white-space property to decide whether we should let this whitespace content overflow the current line.
</span><span class="lines">@@ -646,13 +651,16 @@
</span><span class="cx">             return *wordBreakRule;
</span><span class="cx">         return { };
</span><span class="cx">     };
</span><ins>+
+    // Soft wrap opportunities introduced by break-word are not considered when calculating min-content intrinsic sizes.
+    auto breakWordIsApplicable = !isInIntrinsicWidthMode();
</ins><span class="cx">     // For compatibility with legacy content, the word-break property also supports a deprecated break-word keyword.
</span><span class="cx">     // When specified, this has the same effect as word-break: normal and overflow-wrap: anywhere, regardless of the actual value of the overflow-wrap property.
</span><del>-    if (style.wordBreak() == WordBreak::BreakWord && !hasWrapOpportunityAtPreviousPosition)
</del><ins>+    if ((breakWordIsApplicable && style.wordBreak() == WordBreak::BreakWord) && !hasWrapOpportunityAtPreviousPosition)
</ins><span class="cx">         return includeHyphenationIfAllowed(WordBreakRule::AtArbitraryPosition);
</span><span class="cx">     // OverflowWrap::BreakWord/Anywhere An otherwise unbreakable sequence of characters may be broken at an arbitrary point if there are no otherwise-acceptable break points in the line.
</span><span class="cx">     // Note that this applies to content where CSS properties (e.g. WordBreak::KeepAll) make it unbreakable. 
</span><del>-    if ((style.overflowWrap() == OverflowWrap::BreakWord || style.overflowWrap() == OverflowWrap::Anywhere) && !hasWrapOpportunityAtPreviousPosition)
</del><ins>+    if (((breakWordIsApplicable && style.overflowWrap() == OverflowWrap::BreakWord) || style.overflowWrap() == OverflowWrap::Anywhere) && !hasWrapOpportunityAtPreviousPosition)
</ins><span class="cx">         return includeHyphenationIfAllowed(WordBreakRule::AtArbitraryPosition);
</span><span class="cx">     // Breaking is forbidden within “words”.
</span><span class="cx">     if (style.wordBreak() == WordBreak::KeepAll)
</span></span></pre></div>
<a id="trunkSourceWebCorelayoutformattingContextsinlineInlineContentBreakerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h (285929 => 285930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h     2021-11-17 15:08:14 UTC (rev 285929)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h        2021-11-17 15:10:51 UTC (rev 285930)
</span><span class="lines">@@ -38,6 +38,8 @@
</span><span class="cx"> 
</span><span class="cx"> class InlineContentBreaker {
</span><span class="cx"> public:
</span><ins>+    InlineContentBreaker(bool isInIntrinsicWidthMode);
+
</ins><span class="cx">     struct PartialRun {
</span><span class="cx">         size_t length { 0 };
</span><span class="cx">         InlineLayoutUnit logicalWidth { 0 };
</span><span class="lines">@@ -148,7 +150,9 @@
</span><span class="cx">     };
</span><span class="cx">     OptionSet<WordBreakRule> wordBreakBehavior(const RenderStyle&, bool hasWrapOpportunityAtPreviousPosition) const;
</span><span class="cx">     bool shouldKeepEndOfLineWhitespace(const ContinuousContent&) const;
</span><ins>+    bool isInIntrinsicWidthMode() const { return m_isInIntrinsicWidthMode; }
</ins><span class="cx"> 
</span><ins>+    bool m_isInIntrinsicWidthMode { false };
</ins><span class="cx">     bool n_hyphenationIsDisabled { false };
</span><span class="cx"> };
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorelayoutformattingContextsinlineInlineLineBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (285929 => 285930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp      2021-11-17 15:08:14 UTC (rev 285929)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-11-17 15:10:51 UTC (rev 285930)
</span><span class="lines">@@ -268,8 +268,8 @@
</span><span class="cx">     return boxGeometry.marginBoxWidth();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-LineBuilder::LineBuilder(InlineFormattingContext& inlineFormattingContext, FloatingState& floatingState, HorizontalConstraints rootHorizontalConstraints, const InlineItems& inlineItems, IsIntrinsicWidthMode isIntrinsicWidthMode)
-    : m_isIntrinsicWidthMode(isIntrinsicWidthMode == IsIntrinsicWidthMode::Yes)
</del><ins>+LineBuilder::LineBuilder(InlineFormattingContext& inlineFormattingContext, FloatingState& floatingState, HorizontalConstraints rootHorizontalConstraints, const InlineItems& inlineItems, IsInIntrinsicWidthMode isInIntrinsicWidthMode)
+    : m_isInIntrinsicWidthMode(isInIntrinsicWidthMode == IsInIntrinsicWidthMode::Yes)
</ins><span class="cx">     , m_inlineFormattingContext(inlineFormattingContext)
</span><span class="cx">     , m_inlineFormattingState(&inlineFormattingContext.formattingState())
</span><span class="cx">     , m_floatingState(&floatingState)
</span><span class="lines">@@ -279,8 +279,8 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-LineBuilder::LineBuilder(const InlineFormattingContext& inlineFormattingContext, const InlineItems& inlineItems, IsIntrinsicWidthMode isIntrinsicWidthMode)
-    : m_isIntrinsicWidthMode(isIntrinsicWidthMode == IsIntrinsicWidthMode::Yes)
</del><ins>+LineBuilder::LineBuilder(const InlineFormattingContext& inlineFormattingContext, const InlineItems& inlineItems, IsInIntrinsicWidthMode isInIntrinsicWidthMode)
+    : m_isInIntrinsicWidthMode(isInIntrinsicWidthMode == IsInIntrinsicWidthMode::Yes)
</ins><span class="cx">     , m_inlineFormattingContext(inlineFormattingContext)
</span><span class="cx">     , m_line(inlineFormattingContext)
</span><span class="cx">     , m_inlineItems(inlineItems)
</span><span class="lines">@@ -392,7 +392,7 @@
</span><span class="cx"> LineBuilder::CommittedContent LineBuilder::placeInlineContent(const InlineItemRange& needsLayoutRange)
</span><span class="cx"> {
</span><span class="cx">     auto lineCandidate = LineCandidate { layoutState().shouldIgnoreTrailingLetterSpacing() };
</span><del>-    auto inlineContentBreaker = InlineContentBreaker { };
</del><ins>+    auto inlineContentBreaker = InlineContentBreaker { isInIntrinsicWidthMode() };
</ins><span class="cx"> 
</span><span class="cx">     auto currentItemIndex = needsLayoutRange.start;
</span><span class="cx">     size_t committedInlineItemCount = 0;
</span><span class="lines">@@ -550,7 +550,7 @@
</span><span class="cx">         auto textIndent = root.style().textIndent();
</span><span class="cx">         if (textIndent == RenderStyle::initialTextIndent())
</span><span class="cx">             return { };
</span><del>-        if (m_isIntrinsicWidthMode && textIndent.isPercent()) {
</del><ins>+        if (isInIntrinsicWidthMode() && textIndent.isPercent()) {
</ins><span class="cx">             // Percentages must be treated as 0 for the purpose of calculating intrinsic size contributions.
</span><span class="cx">             // https://drafts.csswg.org/css-text/#text-indent-property
</span><span class="cx">             return { };
</span></span></pre></div>
<a id="trunkSourceWebCorelayoutformattingContextsinlineInlineLineBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h (285929 => 285930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h        2021-11-17 15:08:14 UTC (rev 285929)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h   2021-11-17 15:10:51 UTC (rev 285930)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx"> 
</span><span class="cx"> class LineBuilder {
</span><span class="cx"> public:
</span><del>-    enum class IsIntrinsicWidthMode { No, Yes };
-    LineBuilder(InlineFormattingContext&, FloatingState&, HorizontalConstraints rootHorizontalConstraints, const InlineItems&, IsIntrinsicWidthMode = IsIntrinsicWidthMode::No);
-    LineBuilder(const InlineFormattingContext&, const InlineItems&, IsIntrinsicWidthMode = IsIntrinsicWidthMode::Yes);
</del><ins>+    enum class IsInIntrinsicWidthMode { No, Yes };
+    LineBuilder(InlineFormattingContext&, FloatingState&, HorizontalConstraints rootHorizontalConstraints, const InlineItems&, IsInIntrinsicWidthMode = IsInIntrinsicWidthMode::No);
+    LineBuilder(const InlineFormattingContext&, const InlineItems&, IsInIntrinsicWidthMode = IsInIntrinsicWidthMode::Yes);
</ins><span class="cx"> 
</span><span class="cx">     struct InlineItemRange {
</span><span class="cx">         bool isEmpty() const { return start == end; }
</span><span class="lines">@@ -112,6 +112,8 @@
</span><span class="cx">     InlineLayoutUnit inlineItemWidth(const InlineItem&, InlineLayoutUnit contentLogicalLeft) const;
</span><span class="cx">     bool isLastLineWithInlineContent(const InlineItemRange& lineRange, size_t lastInlineItemIndex, bool hasPartialTrailingContent) const;
</span><span class="cx"> 
</span><ins>+    bool isInIntrinsicWidthMode() const { return m_isInIntrinsicWidthMode; }
+
</ins><span class="cx">     const InlineFormattingContext& formattingContext() const { return m_inlineFormattingContext; }
</span><span class="cx">     InlineFormattingState* formattingState() { return m_inlineFormattingState; }
</span><span class="cx">     FloatingState* floatingState() { return m_floatingState; }
</span><span class="lines">@@ -121,7 +123,7 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     bool m_isFirstLine { false };
</span><del>-    bool m_isIntrinsicWidthMode { false };
</del><ins>+    bool m_isInIntrinsicWidthMode { false };
</ins><span class="cx">     const InlineFormattingContext& m_inlineFormattingContext;
</span><span class="cx">     InlineFormattingState* m_inlineFormattingState { nullptr };
</span><span class="cx">     FloatingState* m_floatingState { nullptr };
</span></span></pre>
</div>
</div>

</body>
</html>