<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285549] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285549">285549</a></dd>
<dt>Author</dt> <dd>megan_gardner@apple.com</dd>
<dt>Date</dt> <dd>2021-11-09 17:17:01 -0800 (Tue, 09 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Turn on selection flipping by default.
https://bugs.webkit.org/show_bug.cgi?id=232853

Reviewed by Wenson Hsieh.

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

* fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:
* fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiosdoubletaponeditablecontentforselectionthendragrighttochangeselectedtexthtml">trunk/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendragdowntochangeselectedtextexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendragdowntochangeselectedtexthtml">trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendraguptochangeselectedtextexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendraguptochangeselectedtexthtml">trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioslongpressthendragrighttochangeselectedtexthtml">trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFScriptsPreferencesWebPreferencesInternalyaml">trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/ChangeLog 2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2021-11-09  Megan Gardner  <megan_gardner@apple.com>
+
+        Turn on selection flipping by default.
+        https://bugs.webkit.org/show_bug.cgi?id=232853
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:
+        * fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt:
+        * fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html:
+        * fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt:
+        * fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:
+        * fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:
+
</ins><span class="cx"> 2021-11-09  Antoine Quint  <graouts@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION(r272201): Safari showed red distortion on webview after using Web Inspector, returning from another app
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiosdoubletaponeditablecontentforselectionthendragrighttochangeselectedtexthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html        2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html   2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -79,10 +79,10 @@
</span><span class="cx">             output += '<br>';
</span><span class="cx"> 
</span><span class="cx">             var result = await touchAndDragFromPointToPoint(dragX, dragY, dragX4, dragY);
</span><del>-            if (document.getSelection().toString() == "m")
</del><ins>+            if (document.getSelection().toString() == "lore ")
</ins><span class="cx">                 output += 'PASS: Correct Selection';
</span><span class="cx">             else
</span><del>-                output += 'FAIL: failed to reduce selection to a single character by dragging left. Incorrect Selection: ' + document.getSelection().toString();
</del><ins>+                output += 'FAIL: failed to flip selection by dragging left. Incorrect Selection: "' + document.getSelection().toString() + '"';
</ins><span class="cx">             output += '<br>';
</span><span class="cx">             output += result;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendragdowntochangeselectedtextexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt       2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text-expected.txt  2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> PASS: Has Selection
</span><span class="cx"> PASS: Selection Changed
</span><span class="cx"> PASS: Selection Changed
</span><del>-PASS: Selection Did Not Change
</del><ins>+PASS: Selection Changed
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendragdowntochangeselectedtexthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html       2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html  2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -23,6 +23,7 @@
</span><span class="cx">             var fontHeight = 30;
</span><span class="cx"> 
</span><span class="cx">             var selectionChangedCount = 0;
</span><ins>+            var lastSelectionChangeCount = 0;
</ins><span class="cx">             document.addEventListener("selectionchange", () => {
</span><span class="cx">                 selectionChangedCount++;
</span><span class="cx">             });
</span><span class="lines">@@ -41,26 +42,28 @@
</span><span class="cx"> 
</span><span class="cx">             await touchAndDragFromPointToPoint(grabberMidpoint.x, grabberMidpoint.y, grabberMidpoint.x, grabberMidpoint.y + (fontHeight * 2));
</span><span class="cx"> 
</span><del>-            if (selectionChangedCount == 2)
</del><ins>+            if (selectionChangedCount > lastSelectionChangeCount)
</ins><span class="cx">                 output += 'PASS: Selection Changed </br>';
</span><span class="cx">             else
</span><span class="cx">                 output += 'FAIL: Selection did not change <br>' + selectionChangedCount;
</span><span class="cx"> 
</span><ins>+            lastSelectionChangeCount = selectionChangedCount;
</ins><span class="cx">             grabberMidpoint = UIHelper.midPointOfRect(await UIHelper.getSelectionEndGrabberViewRect());
</span><del>-            await touchAndDragFromPointToPoint(grabberMidpoint.x, grabberMidpoint.y, grabberMidpoint.x, grabberMidpoint.y - (fontHeight * 2));
</del><ins>+            await touchAndDragFromPointToPoint(grabberMidpoint.x, grabberMidpoint.y, grabberMidpoint.x, grabberMidpoint.y - (fontHeight));
</ins><span class="cx"> 
</span><del>-            if (selectionChangedCount == 3)
</del><ins>+            if (selectionChangedCount > lastSelectionChangeCount)
</ins><span class="cx">                 output += 'PASS: Selection Changed </br>';
</span><span class="cx">             else
</span><span class="cx">                 output += 'FAIL: Selection did not change <br>' + selectionChangedCount;
</span><span class="cx"> 
</span><ins>+            lastSelectionChangeCount = selectionChangedCount;
</ins><span class="cx">             grabberMidpoint = UIHelper.midPointOfRect(await UIHelper.getSelectionEndGrabberViewRect());
</span><span class="cx">             await touchAndDragFromPointToPoint(grabberMidpoint.x, grabberMidpoint.y, grabberMidpoint.x, grabberMidpoint.y - (fontHeight * 4));
</span><span class="cx"> 
</span><del>-            if (selectionChangedCount == 3)
-                output += 'PASS: Selection Did Not Change </br>';
</del><ins>+            if (selectionChangedCount > lastSelectionChangeCount)
+                output += 'PASS: Selection Changed </br>';
</ins><span class="cx">             else
</span><del>-                output += 'FAIL: Selection changed <br>' + selectionChangedCount;
</del><ins>+                output += 'FAIL: Selection did not change <br>' + selectionChangedCount;
</ins><span class="cx"> 
</span><span class="cx">             var editableElement = document.getElementById('editable');
</span><span class="cx">             editableElement.parentNode.removeChild(editableElement);
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendraguptochangeselectedtextexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt 2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text-expected.txt    2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> PASS: Has Selection
</span><span class="cx"> PASS: Selection Changed
</span><span class="cx"> PASS: Selection Changed
</span><del>-PASS: Selection Did Not Change
</del><ins>+PASS: Selection Changed
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioslongpressoneditablecontentthendraguptochangeselectedtexthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html 2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html    2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -57,8 +57,8 @@
</span><span class="cx">             grabberMidpoint = UIHelper.midPointOfRect(await UIHelper.getSelectionStartGrabberViewRect());
</span><span class="cx">             await touchAndDragFromPointToPoint(grabberMidpoint.x, grabberMidpoint.y , grabberMidpoint.x, grabberMidpoint.y + (fontHeight * 2));
</span><span class="cx"> 
</span><del>-            if (selectionChangedCount == 5)
-                output += 'PASS: Selection Did Not Change </br>';
</del><ins>+            if (selectionChangedCount == 7)
+                output += 'PASS: Selection Changed </br>';
</ins><span class="cx">             else
</span><span class="cx">                 output += 'FAIL: Selection changed <br>' + selectionChangedCount;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioslongpressthendragrighttochangeselectedtexthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html  2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html     2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -63,10 +63,10 @@
</span><span class="cx">             output += '<br>';
</span><span class="cx"> 
</span><span class="cx">             var result = await touchAndDragFromPointToPoint(dragX, dragY, dragX4, dragY);
</span><del>-            if (document.getSelection().toString() == "m")
</del><ins>+            if (document.getSelection().toString() == "lore ")
</ins><span class="cx">                 output += 'PASS: Correct Selection';
</span><span class="cx">             else
</span><del>-                output += 'FAIL: failed to reduce selection to a single character by dragging left. Incorrect Selection: ' + document.getSelection().toString();
</del><ins>+                output += 'FAIL: failed to flip selection by dragging left. Incorrect Selection: ' + document.getSelection().toString();
</ins><span class="cx">             output += '<br>';
</span><span class="cx">             output += result;
</span><span class="cx">             document.getElementById('target').innerHTML = output;
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/Source/WTF/ChangeLog  2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-11-09  Megan Gardner  <megan_gardner@apple.com>
+
+        Turn on selection flipping by default.
+        https://bugs.webkit.org/show_bug.cgi?id=232853
+
+        Reviewed by Wenson Hsieh.
+
+        * Scripts/Preferences/WebPreferencesInternal.yaml:
+
</ins><span class="cx"> 2021-11-09  Commit Queue  <commit-queue@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, reverting r285536.
</span></span></pre></div>
<a id="trunkSourceWTFScriptsPreferencesWebPreferencesInternalyaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (285548 => 285549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-11-10 01:09:29 UTC (rev 285548)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml    2021-11-10 01:17:01 UTC (rev 285549)
</span><span class="lines">@@ -703,7 +703,7 @@
</span><span class="cx">   webcoreBinding: none
</span><span class="cx">   defaultValue:
</span><span class="cx">     WebKit:
</span><del>-      default: false
</del><ins>+      default: true
</ins><span class="cx"> 
</span><span class="cx"> # FIXME: This is not implemented for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
</span><span class="cx"> ServiceWorkersEnabled:
</span></span></pre>
</div>
</div>

</body>
</html>