<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285351] branches/safari-613.1.7-branch/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285351">285351</a></dd>
<dt>Author</dt> <dd>repstein@apple.com</dd>
<dt>Date</dt> <dd>2021-11-05 12:53:38 -0700 (Fri, 05 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/285231">r285231</a>. rdar://problem/85082384

    [ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
    https://bugs.webkit.org/show_bug.cgi?id=232676

    Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-03
    Reviewed by Eric Carlson.

    In <a href="http://trac.webkit.org/projects/webkit/changeset/284743">r284743</a> we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
    Remove some unsafe early returns.

    * platform/ios/VideoFullscreenInterfaceAVKit.mm:
    (-[WebAVPlayerLayer layoutSublayers]):
    (-[WebAVPlayerLayer resolveBounds]):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285231 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari61317branchSourceWebCoreChangeLog">branches/safari-613.1.7-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari61317branchSourceWebCoreplatformiosVideoFullscreenInterfaceAVKitmm">branches/safari-613.1.7-branch/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari61317branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-613.1.7-branch/Source/WebCore/ChangeLog (285350 => 285351)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-613.1.7-branch/Source/WebCore/ChangeLog  2021-11-05 19:33:46 UTC (rev 285350)
+++ branches/safari-613.1.7-branch/Source/WebCore/ChangeLog     2021-11-05 19:53:38 UTC (rev 285351)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2021-11-05  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r285231. rdar://problem/85082384
+
+    [ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
+    https://bugs.webkit.org/show_bug.cgi?id=232676
+    
+    Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-03
+    Reviewed by Eric Carlson.
+    
+    In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
+    Remove some unsafe early returns.
+    
+    * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+    (-[WebAVPlayerLayer layoutSublayers]):
+    (-[WebAVPlayerLayer resolveBounds]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-11-03  Alex Christensen  <achristensen@webkit.org>
+
+            [ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
+            https://bugs.webkit.org/show_bug.cgi?id=232676
+
+            Reviewed by Eric Carlson.
+
+            In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
+            Remove some unsafe early returns.
+
+            * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+            (-[WebAVPlayerLayer layoutSublayers]):
+            (-[WebAVPlayerLayer resolveBounds]):
+
</ins><span class="cx"> 2021-11-03  Alan Coon  <alancoon@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Cherry-pick r285110. rdar://problem/84994696
</span></span></pre></div>
<a id="branchessafari61317branchSourceWebCoreplatformiosVideoFullscreenInterfaceAVKitmm"></a>
<div class="modfile"><h4>Modified: branches/safari-613.1.7-branch/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (285350 => 285351)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-613.1.7-branch/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm      2021-11-05 19:33:46 UTC (rev 285350)
+++ branches/safari-613.1.7-branch/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2021-11-05 19:53:38 UTC (rev 285351)
</span><span class="lines">@@ -289,9 +289,6 @@
</span><span class="cx">     if ([_videoSublayer superlayer] != self)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    if (![_avPlayerController delegate])
-        return;
-
</del><span class="cx">     [_videoSublayer setPosition:CGPointMake(CGRectGetMidX(self.bounds), CGRectGetMidY(self.bounds))];
</span><span class="cx"> 
</span><span class="cx">     if (self.videoDimensions.height <= 0 || self.videoDimensions.width <= 0)
</span><span class="lines">@@ -328,8 +325,6 @@
</span><span class="cx"> - (void)resolveBounds
</span><span class="cx"> {
</span><span class="cx">     [NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(resolveBounds) object:nil];
</span><del>-    if (![_avPlayerController delegate])
-        return;
</del><span class="cx">     
</span><span class="cx">     if ([_videoSublayer superlayer] != self)
</span><span class="cx">         return;
</span></span></pre>
</div>
</div>

</body>
</html>