<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285181] branches/safari-612.3.3.0-branch/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285181">285181</a></dd>
<dt>Author</dt> <dd>kocsen_chung@apple.com</dd>
<dt>Date</dt> <dd>2021-11-02 14:20:01 -0700 (Tue, 02 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/283732">r283732</a>. rdar://problem/84944569

    Add feature flag for COOP / COEP violation reporting and turn off by default
    https://bugs.webkit.org/show_bug.cgi?id=231371

    Reviewed by Youenn Fablet.

    Add feature flag for COOP / COEP violation reporting and turn off by default since our
    implementation doesn't match the latest specification.

    Source/WebCore:

    * loader/CrossOriginEmbedderPolicy.cpp:
    (WebCore::sendCOEPPolicyInheritenceViolation):
    (WebCore::sendCOEPCORPViolation):
    * loader/CrossOriginOpenerPolicy.cpp:
    (WebCore::sendViolationReportWhenNavigatingToCOOPResponse):
    (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse):

    Source/WTF:

    * Scripts/Preferences/WebPreferencesExperimental.yaml:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283732 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari612330branchSourceWTFChangeLog">branches/safari-612.3.3.0-branch/Source/WTF/ChangeLog</a></li>
<li><a href="#branchessafari612330branchSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml">branches/safari-612.3.3.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml</a></li>
<li><a href="#branchessafari612330branchSourceWebCoreChangeLog">branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari612330branchSourceWebCoreloaderCrossOriginEmbedderPolicycpp">branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp</a></li>
<li><a href="#branchessafari612330branchSourceWebCoreloaderCrossOriginOpenerPolicycpp">branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari612330branchSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-612.3.3.0-branch/Source/WTF/ChangeLog (285180 => 285181)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.3.3.0-branch/Source/WTF/ChangeLog    2021-11-02 21:08:07 UTC (rev 285180)
+++ branches/safari-612.3.3.0-branch/Source/WTF/ChangeLog       2021-11-02 21:20:01 UTC (rev 285181)
</span><span class="lines">@@ -1,3 +1,43 @@
</span><ins>+2021-11-02  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r283732. rdar://problem/84944569
+
+    Add feature flag for COOP / COEP violation reporting and turn off by default
+    https://bugs.webkit.org/show_bug.cgi?id=231371
+    
+    Reviewed by Youenn Fablet.
+    
+    Add feature flag for COOP / COEP violation reporting and turn off by default since our
+    implementation doesn't match the latest specification.
+    
+    Source/WebCore:
+    
+    * loader/CrossOriginEmbedderPolicy.cpp:
+    (WebCore::sendCOEPPolicyInheritenceViolation):
+    (WebCore::sendCOEPCORPViolation):
+    * loader/CrossOriginOpenerPolicy.cpp:
+    (WebCore::sendViolationReportWhenNavigatingToCOOPResponse):
+    (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse):
+    
+    Source/WTF:
+    
+    * Scripts/Preferences/WebPreferencesExperimental.yaml:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-07  Chris Dumez  <cdumez@apple.com>
+
+            Add feature flag for COOP / COEP violation reporting and turn off by default
+            https://bugs.webkit.org/show_bug.cgi?id=231371
+
+            Reviewed by Youenn Fablet.
+
+            Add feature flag for COOP / COEP violation reporting and turn off by default since our
+            implementation doesn't match the latest specification.
+
+            * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
</ins><span class="cx"> 2021-10-26  Alan Coon  <alancoon@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Cherry-pick r284344. rdar://problem/84625558
</span></span></pre></div>
<a id="branchessafari612330branchSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml"></a>
<div class="modfile"><h4>Modified: branches/safari-612.3.3.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285180 => 285181)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.3.3.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml  2021-11-02 21:08:07 UTC (rev 285180)
+++ branches/safari-612.3.3.0-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml     2021-11-02 21:20:01 UTC (rev 285181)
</span><span class="lines">@@ -309,6 +309,18 @@
</span><span class="cx">     WebCore:
</span><span class="cx">       default: false
</span><span class="cx"> 
</span><ins>+CoopCoepViolationReportingEnabled:
+  type: bool
+  humanReadableName: "COOP and COEP violations reporting"
+  humanReadableDescription: "Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy reporting"
+  defaultValue:
+    WebKitLegacy:
+      default: false
+    WebKit:
+      default: false
+    WebCore:
+      default: false
+
</ins><span class="cx"> CoreImageAcceleratedFilterRenderEnabled:
</span><span class="cx">   type: bool
</span><span class="cx">   webcoreOnChange: setNeedsRelayoutAllFrames
</span></span></pre></div>
<a id="branchessafari612330branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog (285180 => 285181)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog        2021-11-02 21:08:07 UTC (rev 285180)
+++ branches/safari-612.3.3.0-branch/Source/WebCore/ChangeLog   2021-11-02 21:20:01 UTC (rev 285181)
</span><span class="lines">@@ -1,3 +1,48 @@
</span><ins>+2021-11-02  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r283732. rdar://problem/84944569
+
+    Add feature flag for COOP / COEP violation reporting and turn off by default
+    https://bugs.webkit.org/show_bug.cgi?id=231371
+    
+    Reviewed by Youenn Fablet.
+    
+    Add feature flag for COOP / COEP violation reporting and turn off by default since our
+    implementation doesn't match the latest specification.
+    
+    Source/WebCore:
+    
+    * loader/CrossOriginEmbedderPolicy.cpp:
+    (WebCore::sendCOEPPolicyInheritenceViolation):
+    (WebCore::sendCOEPCORPViolation):
+    * loader/CrossOriginOpenerPolicy.cpp:
+    (WebCore::sendViolationReportWhenNavigatingToCOOPResponse):
+    (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse):
+    
+    Source/WTF:
+    
+    * Scripts/Preferences/WebPreferencesExperimental.yaml:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-07  Chris Dumez  <cdumez@apple.com>
+
+            Add feature flag for COOP / COEP violation reporting and turn off by default
+            https://bugs.webkit.org/show_bug.cgi?id=231371
+
+            Reviewed by Youenn Fablet.
+
+            Add feature flag for COOP / COEP violation reporting and turn off by default since our
+            implementation doesn't match the latest specification.
+
+            * loader/CrossOriginEmbedderPolicy.cpp:
+            (WebCore::sendCOEPPolicyInheritenceViolation):
+            (WebCore::sendCOEPCORPViolation):
+            * loader/CrossOriginOpenerPolicy.cpp:
+            (WebCore::sendViolationReportWhenNavigatingToCOOPResponse):
+            (WebCore::sendViolationReportWhenNavigatingAwayFromCOOPResponse):
+
</ins><span class="cx"> 2021-10-28  Alan Coon  <alancoon@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Apply patch. rdar://problem/84630680
</span></span></pre></div>
<a id="branchessafari612330branchSourceWebCoreloaderCrossOriginEmbedderPolicycpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp (285180 => 285181)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp     2021-11-02 21:08:07 UTC (rev 285180)
+++ branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp        2021-11-02 21:20:01 UTC (rev 285181)
</span><span class="lines">@@ -101,6 +101,9 @@
</span><span class="cx"> // https://html.spec.whatwg.org/multipage/origin.html#queue-a-cross-origin-embedder-policy-inheritance-violation
</span><span class="cx"> void sendCOEPPolicyInheritenceViolation(Frame& frame, const WebCore::SecurityOriginData& embedderOrigin, const String& endpoint, COEPDisposition disposition, const String& type, const URL& blockedURL)
</span><span class="cx"> {
</span><ins>+    if (!frame.settings().coopCoepViolationReportingEnabled())
+        return;
+
</ins><span class="cx">     ASSERT(!endpoint.isEmpty());
</span><span class="cx">     PingLoader::sendReportToEndpoint(frame, embedderOrigin, endpoint, "coep"_s, contextURLForReport(frame), frame.loader().userAgent(blockedURL), [&](auto& body) {
</span><span class="cx">         body.setString("disposition"_s, disposition == COEPDisposition::Reporting ? "reporting"_s : "enforce"_s);
</span><span class="lines">@@ -113,6 +116,9 @@
</span><span class="cx"> void sendCOEPCORPViolation(Frame& frame, const SecurityOriginData& embedderOrigin, const String& endpoint, COEPDisposition disposition, FetchOptions::Destination destination, const URL& blockedURL)
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!endpoint.isEmpty());
</span><ins>+    if (!frame.settings().coopCoepViolationReportingEnabled())
+        return;
+
</ins><span class="cx">     PingLoader::sendReportToEndpoint(frame, embedderOrigin, endpoint, "coep"_s, contextURLForReport(frame), frame.loader().userAgent(blockedURL), [&](auto& body) {
</span><span class="cx">         body.setString("disposition"_s, disposition == COEPDisposition::Reporting ? "reporting"_s : "enforce"_s);
</span><span class="cx">         body.setString("type"_s, "corp");
</span></span></pre></div>
<a id="branchessafari612330branchSourceWebCoreloaderCrossOriginOpenerPolicycpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp (285180 => 285181)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp       2021-11-02 21:08:07 UTC (rev 285180)
+++ branches/safari-612.3.3.0-branch/Source/WebCore/loader/CrossOriginOpenerPolicy.cpp  2021-11-02 21:20:01 UTC (rev 285181)
</span><span class="lines">@@ -205,6 +205,9 @@
</span><span class="cx"> // https://html.spec.whatwg.org/multipage/origin.html#coop-violation-navigation-to
</span><span class="cx"> void sendViolationReportWhenNavigatingToCOOPResponse(Frame& frame, CrossOriginOpenerPolicy coop, COOPDisposition disposition, const URL& coopURL, const URL& previousResponseURL, const SecurityOrigin& coopOrigin, const SecurityOrigin& previousResponseOrigin, const String& referrer, const String& userAgent)
</span><span class="cx"> {
</span><ins>+    if (!frame.settings().coopCoepViolationReportingEnabled())
+        return;
+
</ins><span class="cx">     auto& endpoint = coop.reportingEndpointForDisposition(disposition);
</span><span class="cx">     if (endpoint.isEmpty())
</span><span class="cx">         return;
</span><span class="lines">@@ -221,6 +224,9 @@
</span><span class="cx"> // https://html.spec.whatwg.org/multipage/origin.html#coop-violation-navigation-from
</span><span class="cx"> void sendViolationReportWhenNavigatingAwayFromCOOPResponse(Frame& frame, CrossOriginOpenerPolicy coop, COOPDisposition disposition, const URL& coopURL, const URL& nextResponseURL, const SecurityOrigin& coopOrigin, const SecurityOrigin& nextResponseOrigin, bool isCOOPResponseNavigationSource, const String& userAgent)
</span><span class="cx"> {
</span><ins>+    if (!frame.settings().coopCoepViolationReportingEnabled())
+        return;
+
</ins><span class="cx">     auto& endpoint = coop.reportingEndpointForDisposition(disposition);
</span><span class="cx">     if (endpoint.isEmpty())
</span><span class="cx">         return;
</span></span></pre>
</div>
</div>

</body>
</html>