<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285103] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285103">285103</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2021-11-01 07:11:59 -0700 (Mon, 01 Nov 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix a typo in EWS emails</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsCISupportewsbuildstepspy">trunk/Tools/CISupport/ews-build/steps.py</a></li>
<li><a href="#trunkToolsCISupportewsbuildsteps_unittestpy">trunk/Tools/CISupport/ews-build/steps_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsCISupportewsbuildstepspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/ews-build/steps.py (285102 => 285103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/ews-build/steps.py 2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/CISupport/ews-build/steps.py    2021-11-01 14:11:59 UTC (rev 285103)
</span><span class="lines">@@ -1775,7 +1775,7 @@
</span><span class="cx">             if logs:
</span><span class="cx">                 logs = logs.replace('&', '&amp;').replace('<', '&lt;').replace('>', '&gt;')
</span><span class="cx">                 email_text += '\n\nError lines:\n\n<code>{}</code>'.format(logs)
</span><del>-            email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_jain@apple.com'
</del><ins>+            email_text += '\n\nTo unsubscribe from these notifications or to provide any feedback please email aakash_jain@apple.com'
</ins><span class="cx">             self._addToLog('stdio', 'Sending email notification to {}'.format(patch_author))
</span><span class="cx">             send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
</span><span class="cx">         except Exception as e:
</span><span class="lines">@@ -2622,7 +2622,7 @@
</span><span class="cx">             email_text += ' for <a href="{}">Bug {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)
</span><span class="cx">             email_text += '\n\nFull details are available at: {}\n\nPatch author: {}'.format(build_url, patch_author)
</span><span class="cx">             email_text += '\n\nLayout test failure{}:\n{}'.format(pluralSuffix, test_names_string)
</span><del>-            email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_jain@apple.com'
</del><ins>+            email_text += '\n\nTo unsubscribe from these notifications or to provide any feedback please email aakash_jain@apple.com'
</ins><span class="cx">             self._addToLog('stdio', 'Sending email notification to {}'.format(patch_author))
</span><span class="cx">             send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
</span><span class="cx">         except Exception as e:
</span></span></pre></div>
<a id="trunkToolsCISupportewsbuildsteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (285102 => 285103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/ews-build/steps_unittest.py        2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py   2021-11-01 14:11:59 UTC (rev 285103)
</span><span class="lines">@@ -4266,7 +4266,7 @@
</span><span class="cx">     def test_load_contributors_from_disk(self):
</span><span class="cx">         ValidateCommiterAndReviewer._addToLog = lambda cls, logtype, log: sys.stdout.write(log)
</span><span class="cx">         contributors = filter(lambda element: element.get('name') == 'Aakash Jain', ValidateCommiterAndReviewer().load_contributors_from_disk())
</span><del>-        self.assertEqual(list(contributors)[0]['emails'], ['aakash_jain@apple.com'])
</del><ins>+        self.assertEqual(list(contributors)[0]['emails'][0], 'aakash_jain@apple.com')
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> class TestCheckPatchStatusOnEWSQueues(BuildStepMixinAdditions, unittest.TestCase):
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (285102 => 285103)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/ChangeLog       2021-11-01 14:11:59 UTC (rev 285103)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-11-01  Aakash Jain  <aakash_jain@apple.com>
+
+        Fix a typo in EWS emails
+
+        Unreviewed minor fix.
+
+        * CISupport/ews-build/steps.py:
+        (AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
+        (AnalyzeLayoutTestsResults.send_email_for_new_test_failures):
+        * CISupport/ews-build/steps_unittest.py: Unit-test fix after 243670@main.
+
</ins><span class="cx"> 2021-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Layer tree should not be stuck in frozen state after explicitly stopping a page load
</span></span></pre>
</div>
</div>

</body>
</html>