<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[285071] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/285071">285071</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2021-10-29 19:44:22 -0700 (Fri, 29 Oct 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Rename ImageBuffer.logicalSize to ImageBuffer.truncatedLogicalSize
https://bugs.webkit.org/show_bug.cgi?id=232515
<rdar://problem/84829689>

Reviewed by Tim Horton.

Source/WebCore:

This is a purely mechanical change, and is the first step in
https://bugs.webkit.org/show_bug.cgi?id=225377. Once we have both logicalSize()
and truncatedLogicalSize(), we can start migrating callers to the correct one
and away from the trucated one.

I did this rename by adding truncatedImageSize, and then temporarily renaming
logicalSize() to some dummy value - to force compilation failures at every call
to logicalSize(). Then, once compiling found all the call sites, I renamed it
back to just logicalSize().

No new tests because there is no behavior change.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpImageBitmap):
* html/CanvasBase.cpp:
(WebCore::CanvasBase::setImageBuffer const):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toMediaSample):
* html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createPromise):
* html/ImageBitmapBacking.cpp:
(WebCore::ImageBitmapBacking::width const):
(WebCore::ImageBitmapBacking::height const):
* html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::putImageData):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
* page/PageColorSampler.cpp:
(WebCore::sampleColor):
* platform/graphics/ConcreteImageBuffer.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):
* platform/graphics/ImageBuffer.h:
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::WTF_REQUIRES_LOCK):
* platform/graphics/displaylists/DisplayListImageBuffer.h:
(WebCore::DisplayList::ImageBuffer::ImageBuffer):
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::platformApplySoftware):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::platformApplySoftware):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::platformApplySoftware):
* rendering/CSSFilter.cpp:
(WebCore::CSSFilter::allocateBackingStoreIfNeeded):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):

Source/WebKit:

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getShareableBitmapForImageBufferWithQualifiedIdentifier):
* WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlCanvasBasecpp">trunk/Source/WebCore/html/CanvasBase.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementcpp">trunk/Source/WebCore/html/HTMLCanvasElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageBitmapcpp">trunk/Source/WebCore/html/ImageBitmap.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlImageBitmapBackingcpp">trunk/Source/WebCore/html/ImageBitmapBacking.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2DBasecpp">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp">trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageColorSamplercpp">trunk/Source/WebCore/page/PageColorSampler.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsConcreteImageBufferh">trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsContextcpp">trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsImageBufferh">trunk/Source/WebCore/platform/graphics/ImageBuffer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsShadowBlurcpp">trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListImageBufferh">trunk/Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEBlendcpp">trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEColorMatrixcpp">trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFECompositecpp">trunk/Source/WebCore/platform/graphics/filters/FEComposite.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsfiltersFEDropShadowcpp">trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamgstreamerMockRealtimeVideoSourceGStreamercpp">trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingCSSFiltercpp">trunk/Source/WebCore/rendering/CSSFilter.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGResourcePatterncpp">trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitGPUProcessgraphicsRemoteRenderingBackendcpp">trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessGPUgraphicsRemoteImageBufferProxyh">trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h</a></li>
<li><a href="#trunkSourceWebKitWebProcessGPUgraphicsRemoteRenderingBackendProxycpp">trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/ChangeLog      2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -1,3 +1,62 @@
</span><ins>+2021-10-29  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Rename ImageBuffer.logicalSize to ImageBuffer.truncatedLogicalSize
+        https://bugs.webkit.org/show_bug.cgi?id=232515
+        <rdar://problem/84829689>
+
+        Reviewed by Tim Horton.
+
+        This is a purely mechanical change, and is the first step in
+        https://bugs.webkit.org/show_bug.cgi?id=225377. Once we have both logicalSize()
+        and truncatedLogicalSize(), we can start migrating callers to the correct one
+        and away from the trucated one.
+
+        I did this rename by adding truncatedImageSize, and then temporarily renaming
+        logicalSize() to some dummy value - to force compilation failures at every call
+        to logicalSize(). Then, once compiling found all the call sites, I renamed it
+        back to just logicalSize().
+
+        No new tests because there is no behavior change.
+
+        * bindings/js/SerializedScriptValue.cpp:
+        (WebCore::CloneSerializer::dumpImageBitmap):
+        * html/CanvasBase.cpp:
+        (WebCore::CanvasBase::setImageBuffer const):
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::toMediaSample):
+        * html/ImageBitmap.cpp:
+        (WebCore::ImageBitmap::createPromise):
+        * html/ImageBitmapBacking.cpp:
+        (WebCore::ImageBitmapBacking::width const):
+        (WebCore::ImageBitmapBacking::height const):
+        * html/canvas/CanvasRenderingContext2DBase.cpp:
+        (WebCore::CanvasRenderingContext2DBase::putImageData):
+        * html/canvas/WebGLRenderingContextBase.cpp:
+        (WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
+        * page/PageColorSampler.cpp:
+        (WebCore::sampleColor):
+        * platform/graphics/ConcreteImageBuffer.h:
+        * platform/graphics/GraphicsContext.cpp:
+        (WebCore::GraphicsContext::drawImageBuffer):
+        (WebCore::GraphicsContext::drawConsumingImageBuffer):
+        * platform/graphics/ImageBuffer.h:
+        * platform/graphics/ShadowBlur.cpp:
+        (WebCore::ScratchBuffer::WTF_REQUIRES_LOCK):
+        * platform/graphics/displaylists/DisplayListImageBuffer.h:
+        (WebCore::DisplayList::ImageBuffer::ImageBuffer):
+        * platform/graphics/filters/FEBlend.cpp:
+        (WebCore::FEBlend::platformApplySoftware):
+        * platform/graphics/filters/FEColorMatrix.cpp:
+        (WebCore::FEColorMatrix::platformApplySoftware):
+        * platform/graphics/filters/FEComposite.cpp:
+        (WebCore::FEComposite::platformApplySoftware):
+        * platform/graphics/filters/FEDropShadow.cpp:
+        (WebCore::FEDropShadow::platformApplySoftware):
+        * rendering/CSSFilter.cpp:
+        (WebCore::CSSFilter::allocateBackingStoreIfNeeded):
+        * rendering/svg/RenderSVGResourcePattern.cpp:
+        (WebCore::RenderSVGResourcePattern::buildPattern):
+
</ins><span class="cx"> 2021-10-29  Jean-Yves Avenard  <jya@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Have PlatformMediaResourceClient use SharedBuffer
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp       2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp  2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -1113,7 +1113,7 @@
</span><span class="cx"> 
</span><span class="cx">         // FIXME: We should try to avoid converting pixel format.
</span><span class="cx">         PixelBufferFormat format { AlphaPremultiplication::Premultiplied, PixelFormat::RGBA8, buffer->colorSpace() };
</span><del>-        const IntSize& logicalSize = buffer->logicalSize();
</del><ins>+        const IntSize& logicalSize = buffer->truncatedLogicalSize();
</ins><span class="cx">         auto pixelBuffer = buffer->getPixelBuffer(format, { IntPoint::zero(), logicalSize });
</span><span class="cx">         if (!pixelBuffer) {
</span><span class="cx">             code = SerializationReturnCode::ValidationError;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlCanvasBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/CanvasBase.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/CanvasBase.cpp 2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/CanvasBase.cpp    2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -209,8 +209,8 @@
</span><span class="cx">         returnBuffer = std::exchange(m_imageBuffer, WTFMove(buffer));
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    if (m_imageBuffer && m_size != m_imageBuffer->logicalSize())
-        m_size = m_imageBuffer->logicalSize();
</del><ins>+    if (m_imageBuffer && m_size != m_imageBuffer->truncatedLogicalSize())
+        m_size = m_imageBuffer->truncatedLogicalSize();
</ins><span class="cx"> 
</span><span class="cx">     size_t previousMemoryCost = m_imageBufferCost;
</span><span class="cx">     m_imageBufferCost = memoryCost();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp  2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp     2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -777,7 +777,7 @@
</span><span class="cx">     // FIXME: This can likely be optimized quite a bit, especially in the cases where
</span><span class="cx">     // the ImageBuffer is backed by GPU memory already and/or is in the GPU process by
</span><span class="cx">     // specializing toMediaSample() in ImageBufferBackend to not use getPixelBuffer().
</span><del>-    auto pixelBuffer = imageBuffer->getPixelBuffer({ AlphaPremultiplication::Unpremultiplied, PixelFormat::BGRA8, DestinationColorSpace::SRGB() }, { { }, imageBuffer->logicalSize() });
</del><ins>+    auto pixelBuffer = imageBuffer->getPixelBuffer({ AlphaPremultiplication::Unpremultiplied, PixelFormat::BGRA8, DestinationColorSpace::SRGB() }, { { }, imageBuffer->truncatedLogicalSize() });
</ins><span class="cx">     if (!pixelBuffer)
</span><span class="cx">         return nullptr;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageBitmapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageBitmap.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageBitmap.cpp        2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/ImageBitmap.cpp   2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -572,7 +572,7 @@
</span><span class="cx"> 
</span><span class="cx">     // 4. Let the ImageBitmap object's bitmap data be a copy of the image argument's
</span><span class="cx">     //    bitmap data, cropped to the source rectangle with formatting.
</span><del>-    auto sourceRectangle = croppedSourceRectangleWithFormatting(existingImageBitmap->buffer()->logicalSize(), options, WTFMove(rect));
</del><ins>+    auto sourceRectangle = croppedSourceRectangleWithFormatting(existingImageBitmap->buffer()->truncatedLogicalSize(), options, WTFMove(rect));
</ins><span class="cx">     if (sourceRectangle.hasException()) {
</span><span class="cx">         promise.reject(sourceRectangle.releaseException());
</span><span class="cx">         return;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageBitmapBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageBitmapBacking.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageBitmapBacking.cpp 2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/ImageBitmapBacking.cpp    2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -48,13 +48,13 @@
</span><span class="cx"> unsigned ImageBitmapBacking::width() const
</span><span class="cx"> {
</span><span class="cx">     // FIXME: Is this the right width?
</span><del>-    return m_bitmapData ? m_bitmapData->logicalSize().width() : 0;
</del><ins>+    return m_bitmapData ? m_bitmapData->truncatedLogicalSize().width() : 0;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> unsigned ImageBitmapBacking::height() const
</span><span class="cx"> {
</span><span class="cx">     // FIXME: Is this the right height?
</span><del>-    return m_bitmapData ? m_bitmapData->logicalSize().height() : 0;
</del><ins>+    return m_bitmapData ? m_bitmapData->truncatedLogicalSize().height() : 0;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2DBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp        2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp   2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -2248,7 +2248,7 @@
</span><span class="cx">     IntSize destOffset { dx, dy };
</span><span class="cx">     IntRect destRect = clipRect;
</span><span class="cx">     destRect.move(destOffset);
</span><del>-    destRect.intersect(IntRect { { }, buffer->logicalSize() });
</del><ins>+    destRect.intersect(IntRect { { }, buffer->truncatedLogicalSize() });
</ins><span class="cx">     if (destRect.isEmpty())
</span><span class="cx">         return;
</span><span class="cx">     IntRect sourceRect { destRect };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp   2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp      2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -7798,7 +7798,7 @@
</span><span class="cx">         if (!m_buffers[i])
</span><span class="cx">             break;
</span><span class="cx">         ImageBuffer& buf = m_buffers[i]->second.get();
</span><del>-        if (m_buffers[i]->first != colorSpace || buf.logicalSize() != size)
</del><ins>+        if (m_buffers[i]->first != colorSpace || buf.truncatedLogicalSize() != size)
</ins><span class="cx">             continue;
</span><span class="cx">         bubbleToFront(i);
</span><span class="cx">         if (fillOperator != CompositeOperator::Copy && fillOperator != CompositeOperator::Clear)
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageColorSamplercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageColorSampler.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageColorSampler.cpp   2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/page/PageColorSampler.cpp      2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx">     if (!snapshot)
</span><span class="cx">         return std::nullopt;
</span><span class="cx"> 
</span><del>-    auto pixelBuffer = snapshot->getPixelBuffer({ AlphaPremultiplication::Unpremultiplied, PixelFormat::BGRA8, colorSpace }, { { }, snapshot->logicalSize() });
</del><ins>+    auto pixelBuffer = snapshot->getPixelBuffer({ AlphaPremultiplication::Unpremultiplied, PixelFormat::BGRA8, colorSpace }, { { }, snapshot->truncatedLogicalSize() });
</ins><span class="cx">     if (!pixelBuffer)
</span><span class="cx">         return std::nullopt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsConcreteImageBufferh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h     2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h        2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -90,7 +90,8 @@
</span><span class="cx">         }
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    IntSize logicalSize() const override { return IntSize(m_parameters.logicalSize); }
</del><ins>+    FloatSize logicalSize() const override { return m_parameters.logicalSize; }
+    IntSize truncatedLogicalSize() const override { return IntSize(m_parameters.logicalSize); } // You probably should be calling logicalSize() instead.
</ins><span class="cx">     float resolutionScale() const override { return m_parameters.resolutionScale; }
</span><span class="cx">     DestinationColorSpace colorSpace() const override { return m_parameters.colorSpace; }
</span><span class="cx">     PixelFormat pixelFormat() const override { return m_parameters.pixelFormat; }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp       2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp  2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -591,12 +591,12 @@
</span><span class="cx"> 
</span><span class="cx"> void GraphicsContext::drawImageBuffer(ImageBuffer& image, const FloatPoint& destination, const ImagePaintingOptions& imagePaintingOptions)
</span><span class="cx"> {
</span><del>-    drawImageBuffer(image, FloatRect(destination, image.logicalSize()), FloatRect(FloatPoint(), image.logicalSize()), imagePaintingOptions);
</del><ins>+    drawImageBuffer(image, FloatRect(destination, image.truncatedLogicalSize()), FloatRect(FloatPoint(), image.truncatedLogicalSize()), imagePaintingOptions);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void GraphicsContext::drawImageBuffer(ImageBuffer& image, const FloatRect& destination, const ImagePaintingOptions& imagePaintingOptions)
</span><span class="cx"> {
</span><del>-    drawImageBuffer(image, destination, FloatRect(FloatPoint(), FloatSize(image.logicalSize())), imagePaintingOptions);
</del><ins>+    drawImageBuffer(image, destination, FloatRect(FloatPoint(), FloatSize(image.truncatedLogicalSize())), imagePaintingOptions);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void GraphicsContext::drawImageBuffer(ImageBuffer& image, const FloatRect& destination, const FloatRect& source, const ImagePaintingOptions& options)
</span><span class="lines">@@ -609,7 +609,7 @@
</span><span class="cx"> {
</span><span class="cx">     if (!image)
</span><span class="cx">         return;
</span><del>-    IntSize imageLogicalSize = image->logicalSize();
</del><ins>+    IntSize imageLogicalSize = image->truncatedLogicalSize();
</ins><span class="cx">     drawConsumingImageBuffer(WTFMove(image), FloatRect(destination, imageLogicalSize), FloatRect(FloatPoint(), imageLogicalSize), imagePaintingOptions);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -617,7 +617,7 @@
</span><span class="cx"> {
</span><span class="cx">     if (!image)
</span><span class="cx">         return;
</span><del>-    IntSize imageLogicalSize = image->logicalSize();
</del><ins>+    IntSize imageLogicalSize = image->truncatedLogicalSize();
</ins><span class="cx">     drawConsumingImageBuffer(WTFMove(image), destination, FloatRect(FloatPoint(), FloatSize(imageLogicalSize)), imagePaintingOptions);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsImageBufferh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ImageBuffer.h     2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h        2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -86,7 +86,8 @@
</span><span class="cx">     virtual void changeDestinationImageBuffer(RenderingResourceIdentifier) { }
</span><span class="cx">     virtual void prepareToAppendDisplayListItems(DisplayList::ItemBufferHandle&&) { }
</span><span class="cx"> 
</span><del>-    virtual IntSize logicalSize() const = 0;
</del><ins>+    virtual FloatSize logicalSize() const = 0;
+    virtual IntSize truncatedLogicalSize() const = 0; // This truncates the real size. You probably should be calling logicalSize() instead.
</ins><span class="cx">     virtual float resolutionScale() const = 0;
</span><span class="cx">     virtual DestinationColorSpace colorSpace() const = 0;
</span><span class="cx">     virtual PixelFormat pixelFormat() const = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsShadowBlurcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp    2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp       2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx">         });
</span><span class="cx"> 
</span><span class="cx">         // We do not need to recreate the buffer if the current buffer is large enough.
</span><del>-        if (m_imageBuffer && m_imageBuffer->logicalSize().width() >= size.width() && m_imageBuffer->logicalSize().height() >= size.height())
</del><ins>+        if (m_imageBuffer && m_imageBuffer->truncatedLogicalSize().width() >= size.width() && m_imageBuffer->truncatedLogicalSize().height() >= size.height())
</ins><span class="cx">             return m_imageBuffer;
</span><span class="cx"> 
</span><span class="cx">         // Round to the nearest 32 pixels so we do not grow the buffer for similar sized requests.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsdisplaylistsDisplayListImageBufferh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h     2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h        2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> template<typename BackendType>
</span><span class="cx"> class ImageBuffer : public ConcreteImageBuffer<BackendType> {
</span><span class="cx">     using BaseConcreteImageBuffer = ConcreteImageBuffer<BackendType>;
</span><ins>+    using BaseConcreteImageBuffer::truncatedLogicalSize;
</ins><span class="cx">     using BaseConcreteImageBuffer::logicalSize;
</span><span class="cx">     using BaseConcreteImageBuffer::baseTransform;
</span><span class="cx"> 
</span><span class="lines">@@ -51,7 +52,7 @@
</span><span class="cx"> 
</span><span class="cx">     ImageBuffer(const ImageBufferBackend::Parameters& parameters, std::unique_ptr<BackendType>&& backend)
</span><span class="cx">         : BaseConcreteImageBuffer(parameters, WTFMove(backend))
</span><del>-        , m_drawingContext(logicalSize(), baseTransform())
</del><ins>+        , m_drawingContext(truncatedLogicalSize(), baseTransform())
</ins><span class="cx">         , m_writingClient(makeUnique<InMemoryDisplayList::WritingClient>())
</span><span class="cx">         , m_readingClient(makeUnique<InMemoryDisplayList::ReadingClient>())
</span><span class="cx">     {
</span><span class="lines">@@ -61,7 +62,7 @@
</span><span class="cx"> 
</span><span class="cx">     ImageBuffer(const ImageBufferBackend::Parameters& parameters, RecorderImpl::Delegate* delegate = nullptr)
</span><span class="cx">         : BaseConcreteImageBuffer(parameters)
</span><del>-        , m_drawingContext(logicalSize(), baseTransform(), delegate)
</del><ins>+        , m_drawingContext(truncatedLogicalSize(), baseTransform(), delegate)
</ins><span class="cx">         , m_writingClient(makeUnique<InMemoryDisplayList::WritingClient>())
</span><span class="cx">         , m_readingClient(makeUnique<InMemoryDisplayList::ReadingClient>())
</span><span class="cx">     {
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEBlendcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp       2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp  2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()));
</span><del>-    filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->logicalSize()), { CompositeOperator::SourceOver, m_mode });
</del><ins>+    filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->truncatedLogicalSize()), { CompositeOperator::SourceOver, m_mode });
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEColorMatrixcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp 2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp    2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -286,7 +286,7 @@
</span><span class="cx">         resultImage->context().drawImageBuffer(*inBuffer, drawingRegionOfInputImage(in->absolutePaintRect()));
</span><span class="cx"> 
</span><span class="cx">     PixelBufferFormat format { AlphaPremultiplication::Unpremultiplied, PixelFormat::RGBA8, resultColorSpace() };
</span><del>-    IntRect imageRect(IntPoint(), resultImage->logicalSize());
</del><ins>+    IntRect imageRect(IntPoint(), resultImage->truncatedLogicalSize());
</ins><span class="cx">     auto pixelBuffer = resultImage->getPixelBuffer(format, imageRect);
</span><span class="cx">     if (!pixelBuffer)
</span><span class="cx">         return;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFECompositecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEComposite.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEComposite.cpp   2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/filters/FEComposite.cpp      2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -278,19 +278,19 @@
</span><span class="cx">     }
</span><span class="cx">     case FECOMPOSITE_OPERATOR_OUT:
</span><span class="cx">         filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()));
</span><del>-        filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()), IntRect(IntPoint(), imageBuffer2->logicalSize()), CompositeOperator::DestinationOut);
</del><ins>+        filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()), IntRect(IntPoint(), imageBuffer2->truncatedLogicalSize()), CompositeOperator::DestinationOut);
</ins><span class="cx">         break;
</span><span class="cx">     case FECOMPOSITE_OPERATOR_ATOP:
</span><span class="cx">         filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()));
</span><del>-        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->logicalSize()), CompositeOperator::SourceAtop);
</del><ins>+        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->truncatedLogicalSize()), CompositeOperator::SourceAtop);
</ins><span class="cx">         break;
</span><span class="cx">     case FECOMPOSITE_OPERATOR_XOR:
</span><span class="cx">         filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()));
</span><del>-        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->logicalSize()), CompositeOperator::XOR);
</del><ins>+        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->truncatedLogicalSize()), CompositeOperator::XOR);
</ins><span class="cx">         break;
</span><span class="cx">     case FECOMPOSITE_OPERATOR_LIGHTER:
</span><span class="cx">         filterContext.drawImageBuffer(*imageBuffer2, drawingRegionOfInputImage(in2->absolutePaintRect()));
</span><del>-        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->logicalSize()), CompositeOperator::PlusLighter);
</del><ins>+        filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), IntRect(IntPoint(), imageBuffer->truncatedLogicalSize()), CompositeOperator::PlusLighter);
</ins><span class="cx">         break;
</span><span class="cx">     default:
</span><span class="cx">         break;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsfiltersFEDropShadowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp  2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp     2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -100,7 +100,7 @@
</span><span class="cx">     ShadowBlur contextShadow(blurRadius, offset, m_shadowColor);
</span><span class="cx"> 
</span><span class="cx">     PixelBufferFormat format { AlphaPremultiplication::Premultiplied, PixelFormat::RGBA8, resultColorSpace() };
</span><del>-    IntRect shadowArea(IntPoint(), resultImage->logicalSize());
</del><ins>+    IntRect shadowArea(IntPoint(), resultImage->truncatedLogicalSize());
</ins><span class="cx">     auto pixelBuffer = resultImage->getPixelBuffer(format, shadowArea);
</span><span class="cx">     if (!pixelBuffer)
</span><span class="cx">         return;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamgstreamerMockRealtimeVideoSourceGStreamercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp 2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp    2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx">     if (!imageBuffer)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto pixelBuffer = imageBuffer->getPixelBuffer({ AlphaPremultiplication::Premultiplied, PixelFormat::BGRA8, DestinationColorSpace::SRGB() }, { { }, imageBuffer->logicalSize() });
</del><ins>+    auto pixelBuffer = imageBuffer->getPixelBuffer({ AlphaPremultiplication::Premultiplied, PixelFormat::BGRA8, DestinationColorSpace::SRGB() }, { { }, imageBuffer->truncatedLogicalSize() });
</ins><span class="cx">     if (!pixelBuffer)
</span><span class="cx">         return;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingCSSFiltercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/CSSFilter.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/CSSFilter.cpp     2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/rendering/CSSFilter.cpp        2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -332,7 +332,7 @@
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     IntSize logicalSize { m_sourceDrawingRegion.size() };
</span><del>-    if (!sourceImage() || sourceImage()->logicalSize() != logicalSize) {
</del><ins>+    if (!sourceImage() || sourceImage()->truncatedLogicalSize() != logicalSize) {
</ins><span class="cx"> #if USE(DIRECT2D)
</span><span class="cx">         setSourceImage(ImageBuffer::create(logicalSize, renderingMode(), &targetContext, filterScale(), DestinationColorSpace::SRGB(), PixelFormat::BGRA8));
</span><span class="cx"> #else
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGResourcePatterncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp  2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp     2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx">     if (!tileImage)
</span><span class="cx">         return nullptr;
</span><span class="cx"> 
</span><del>-    const IntSize tileImageSize = tileImage->logicalSize();
</del><ins>+    const IntSize tileImageSize = tileImage->truncatedLogicalSize();
</ins><span class="cx"> 
</span><span class="cx">     auto copiedImage = ImageBuffer::sinkIntoNativeImage(WTFMove(tileImage));
</span><span class="cx">     if (!copiedImage)
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebKit/ChangeLog       2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2021-10-29  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Rename ImageBuffer.logicalSize to ImageBuffer.truncatedLogicalSize
+        https://bugs.webkit.org/show_bug.cgi?id=232515
+        <rdar://problem/84829689>
+
+        Reviewed by Tim Horton.
+
+        * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+        (WebKit::RemoteRenderingBackend::getShareableBitmapForImageBufferWithQualifiedIdentifier):
+        * WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
+        (WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+        (WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
+
</ins><span class="cx"> 2021-10-29  Kate Cheney  <katherine_cheney@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Crash setting up AVCaptureSession
</span></span></pre></div>
<a id="trunkSourceWebKitGPUProcessgraphicsRemoteRenderingBackendcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp       2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp  2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -307,7 +307,7 @@
</span><span class="cx">         if (!image)
</span><span class="cx">             return;
</span><span class="cx">         auto backendSize = imageBuffer->backendSize();
</span><del>-        auto resultSize = preserveResolution == WebCore::PreserveResolution::Yes ? backendSize : imageBuffer->logicalSize();
</del><ins>+        auto resultSize = preserveResolution == WebCore::PreserveResolution::Yes ? backendSize : imageBuffer->truncatedLogicalSize();
</ins><span class="cx">         auto bitmap = ShareableBitmap::createShareable(resultSize, { imageBuffer->colorSpace() });
</span><span class="cx">         if (!bitmap)
</span><span class="cx">             return;
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessGPUgraphicsRemoteImageBufferProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h     2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h        2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx">     RemoteImageBufferProxy(const WebCore::ImageBufferBackend::Parameters& parameters, RemoteRenderingBackendProxy& remoteRenderingBackendProxy)
</span><span class="cx">         : BaseConcreteImageBuffer(parameters)
</span><span class="cx">         , m_remoteRenderingBackendProxy(remoteRenderingBackendProxy)
</span><del>-        , m_remoteDisplayList(*this, remoteRenderingBackendProxy, { { }, BaseConcreteImageBuffer::logicalSize() }, BaseConcreteImageBuffer::baseTransform())
</del><ins>+        , m_remoteDisplayList(*this, remoteRenderingBackendProxy, { { }, BaseConcreteImageBuffer::truncatedLogicalSize() }, BaseConcreteImageBuffer::baseTransform())
</ins><span class="cx">     {
</span><span class="cx">         ASSERT(m_remoteRenderingBackendProxy);
</span><span class="cx">         m_remoteRenderingBackendProxy->remoteResourceCacheProxy().cacheImageBuffer(*this);
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessGPUgraphicsRemoteRenderingBackendProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (285070 => 285071)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp      2021-10-30 02:08:19 UTC (rev 285070)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-10-30 02:44:22 UTC (rev 285071)
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> 
</span><span class="cx"> void RemoteRenderingBackendProxy::createRemoteImageBuffer(ImageBuffer& imageBuffer)
</span><span class="cx"> {
</span><del>-    sendToStream(Messages::RemoteRenderingBackend::CreateImageBuffer(imageBuffer.logicalSize(), imageBuffer.renderingMode(), imageBuffer.resolutionScale(), imageBuffer.colorSpace(), imageBuffer.pixelFormat(), imageBuffer.renderingResourceIdentifier()));
</del><ins>+    sendToStream(Messages::RemoteRenderingBackend::CreateImageBuffer(imageBuffer.truncatedLogicalSize(), imageBuffer.renderingMode(), imageBuffer.resolutionScale(), imageBuffer.colorSpace(), imageBuffer.pixelFormat(), imageBuffer.renderingResourceIdentifier()));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> RefPtr<ImageBuffer> RemoteRenderingBackendProxy::createImageBuffer(const FloatSize& size, RenderingMode renderingMode, float resolutionScale, const DestinationColorSpace& colorSpace, PixelFormat pixelFormat)
</span></span></pre>
</div>
</div>

</body>
</html>