<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[284280] branches/safari-612-branch/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/284280">284280</a></dd>
<dt>Author</dt> <dd>repstein@apple.com</dd>
<dt>Date</dt> <dd>2021-10-15 15:38:53 -0700 (Fri, 15 Oct 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/281879">r281879</a>. rdar://problem/83954217

    Improve time precision when cross-origin isolated via COOP+COEP
    https://bugs.webkit.org/show_bug.cgi?id=228137
    <rdar://problem/81197138>

    Reviewed by Ryosuke Niwa.

    Increase the precision of our high precision time (used by performance.now()) from
    1ms to 20us when cross-origin isolated via COOP=same-origin + COEP=require-corp.
    Precision remains the same (1ms) when not cross-origin isolated.

    This aligns our behavior with Firefox.

    Note that Chrome provides higher precision (100us in general and 5us when
    cross-origin-isolated).

    * dom/ScriptExecutionContext.cpp:
    (WebCore::ScriptExecutionContext::setCrossOriginMode):
    * page/Performance.cpp:
    (WebCore::Performance::reduceTimeResolution):
    (WebCore::Performance::allowHighPrecisionTime):
    * page/Performance.h:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281879 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari612branchSourceWebCoreChangeLog">branches/safari-612-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari612branchSourceWebCoredomScriptExecutionContextcpp">branches/safari-612-branch/Source/WebCore/dom/ScriptExecutionContext.cpp</a></li>
<li><a href="#branchessafari612branchSourceWebCorepagePerformancecpp">branches/safari-612-branch/Source/WebCore/page/Performance.cpp</a></li>
<li><a href="#branchessafari612branchSourceWebCorepagePerformanceh">branches/safari-612-branch/Source/WebCore/page/Performance.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari612branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (284279 => 284280)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/ChangeLog      2021-10-15 22:37:24 UTC (rev 284279)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-15 22:38:53 UTC (rev 284280)
</span><span class="lines">@@ -1,5 +1,58 @@
</span><span class="cx"> 2021-10-15  Russell Epstein  <repstein@apple.com>
</span><span class="cx"> 
</span><ins>+        Cherry-pick r281879. rdar://problem/83954217
+
+    Improve time precision when cross-origin isolated via COOP+COEP
+    https://bugs.webkit.org/show_bug.cgi?id=228137
+    <rdar://problem/81197138>
+    
+    Reviewed by Ryosuke Niwa.
+    
+    Increase the precision of our high precision time (used by performance.now()) from
+    1ms to 20us when cross-origin isolated via COOP=same-origin + COEP=require-corp.
+    Precision remains the same (1ms) when not cross-origin isolated.
+    
+    This aligns our behavior with Firefox.
+    
+    Note that Chrome provides higher precision (100us in general and 5us when
+    cross-origin-isolated).
+    
+    * dom/ScriptExecutionContext.cpp:
+    (WebCore::ScriptExecutionContext::setCrossOriginMode):
+    * page/Performance.cpp:
+    (WebCore::Performance::reduceTimeResolution):
+    (WebCore::Performance::allowHighPrecisionTime):
+    * page/Performance.h:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-09-01  Chris Dumez  <cdumez@apple.com>
+
+            Improve time precision when cross-origin isolated via COOP+COEP
+            https://bugs.webkit.org/show_bug.cgi?id=228137
+            <rdar://problem/81197138>
+
+            Reviewed by Ryosuke Niwa.
+
+            Increase the precision of our high precision time (used by performance.now()) from
+            1ms to 20us when cross-origin isolated via COOP=same-origin + COEP=require-corp.
+            Precision remains the same (1ms) when not cross-origin isolated.
+
+            This aligns our behavior with Firefox.
+
+            Note that Chrome provides higher precision (100us in general and 5us when
+            cross-origin-isolated).
+
+            * dom/ScriptExecutionContext.cpp:
+            (WebCore::ScriptExecutionContext::setCrossOriginMode):
+            * page/Performance.cpp:
+            (WebCore::Performance::reduceTimeResolution):
+            (WebCore::Performance::allowHighPrecisionTime):
+            * page/Performance.h:
+
+2021-10-15  Russell Epstein  <repstein@apple.com>
+
</ins><span class="cx">         Cherry-pick r283572. rdar://problem/83953133
</span><span class="cx"> 
</span><span class="cx">     Web Inspector: Show color space for canvases in the Graphics tab on the overview cards
</span></span></pre></div>
<a id="branchessafari612branchSourceWebCoredomScriptExecutionContextcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/dom/ScriptExecutionContext.cpp (284279 => 284280)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/dom/ScriptExecutionContext.cpp 2021-10-15 22:37:24 UTC (rev 284279)
+++ branches/safari-612-branch/Source/WebCore/dom/ScriptExecutionContext.cpp    2021-10-15 22:38:53 UTC (rev 284280)
</span><span class="lines">@@ -47,6 +47,7 @@
</span><span class="cx"> #include "MessagePort.h"
</span><span class="cx"> #include "Navigator.h"
</span><span class="cx"> #include "Page.h"
</span><ins>+#include "Performance.h"
</ins><span class="cx"> #include "PublicURLManager.h"
</span><span class="cx"> #include "RejectedPromiseTracker.h"
</span><span class="cx"> #include "ResourceRequest.h"
</span><span class="lines">@@ -628,6 +629,8 @@
</span><span class="cx"> void ScriptExecutionContext::setCrossOriginMode(CrossOriginMode crossOriginMode)
</span><span class="cx"> {
</span><span class="cx">     globalCrossOriginMode = crossOriginMode;
</span><ins>+    if (crossOriginMode == CrossOriginMode::Isolated)
+        Performance::allowHighPrecisionTime();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> CrossOriginMode ScriptExecutionContext::crossOriginMode()
</span></span></pre></div>
<a id="branchessafari612branchSourceWebCorepagePerformancecpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/page/Performance.cpp (284279 => 284280)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/page/Performance.cpp   2021-10-15 22:37:24 UTC (rev 284279)
+++ branches/safari-612-branch/Source/WebCore/page/Performance.cpp      2021-10-15 22:38:53 UTC (rev 284280)
</span><span class="lines">@@ -58,6 +58,9 @@
</span><span class="cx"> 
</span><span class="cx"> WTF_MAKE_ISO_ALLOCATED_IMPL(Performance);
</span><span class="cx"> 
</span><ins>+constexpr Seconds highTimePrecision { 20_us };
+static Seconds timePrecision { 1_ms };
+
</ins><span class="cx"> Performance::Performance(ScriptExecutionContext* context, MonotonicTime timeOrigin)
</span><span class="cx">     : ContextDestructionObserver(context)
</span><span class="cx">     , m_resourceTimingBufferFullTimer(*this, &Performance::resourceTimingBufferFullTimerFired) // FIXME: Migrate this to the event loop as well. https://bugs.webkit.org/show_bug.cgi?id=229044
</span><span class="lines">@@ -92,11 +95,16 @@
</span><span class="cx"> 
</span><span class="cx"> Seconds Performance::reduceTimeResolution(Seconds seconds)
</span><span class="cx"> {
</span><del>-    double resolution = (1000_us).seconds();
</del><ins>+    double resolution = timePrecision.seconds();
</ins><span class="cx">     double reduced = std::floor(seconds.seconds() / resolution) * resolution;
</span><span class="cx">     return Seconds(reduced);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void Performance::allowHighPrecisionTime()
+{
+    timePrecision = highTimePrecision;
+}
+
</ins><span class="cx"> DOMHighResTimeStamp Performance::relativeTimeFromTimeOriginInReducedResolution(MonotonicTime timestamp) const
</span><span class="cx"> {
</span><span class="cx">     Seconds seconds = timestamp - m_timeOrigin;
</span></span></pre></div>
<a id="branchessafari612branchSourceWebCorepagePerformanceh"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/page/Performance.h (284279 => 284280)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/page/Performance.h     2021-10-15 22:37:24 UTC (rev 284279)
+++ branches/safari-612-branch/Source/WebCore/page/Performance.h        2021-10-15 22:38:53 UTC (rev 284280)
</span><span class="lines">@@ -106,6 +106,7 @@
</span><span class="cx">     void registerPerformanceObserver(PerformanceObserver&);
</span><span class="cx">     void unregisterPerformanceObserver(PerformanceObserver&);
</span><span class="cx"> 
</span><ins>+    static void allowHighPrecisionTime();
</ins><span class="cx">     static Seconds reduceTimeResolution(Seconds);
</span><span class="cx"> 
</span><span class="cx">     DOMHighResTimeStamp relativeTimeFromTimeOriginInReducedResolution(MonotonicTime) const;
</span></span></pre>
</div>
</div>

</body>
</html>