<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[283454] branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/283454">283454</a></dd>
<dt>Author</dt> <dd>repstein@apple.com</dd>
<dt>Date</dt> <dd>2021-10-02 15:53:56 -0700 (Sat, 02 Oct 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Revert "Apply patch. rdar://problem/83784775"

This reverts commit <a href="http://trac.webkit.org/projects/webkit/changeset/283426">r283426</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari612293branchSourceWebCorebindingsscriptsCodeGeneratorJSpm">branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#branchessafari612293branchSourceWebCorebindingsscriptstestJSJSTestObjcpp">branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#branchessafari612293branchSourceWebCorebindingsscriptstestTestObjidl">branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari612293branchSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (283453 => 283454)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm      2021-10-02 22:51:37 UTC (rev 283453)
+++ branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2021-10-02 22:53:56 UTC (rev 283454)
</span><span class="lines">@@ -2055,7 +2055,7 @@
</span><span class="cx">     push(@specials, "JSC::PropertyAttribute::DontEnum") if ($attribute->extendedAttributes->{NotEnumerable} || $isGlobalConstructor);
</span><span class="cx">     push(@specials, "JSC::PropertyAttribute::ReadOnly") if IsReadonly($attribute);
</span><span class="cx">     push(@specials, "JSC::PropertyAttribute::CustomAccessor") unless $isGlobalConstructor or IsJSBuiltin($interface, $attribute);
</span><del>-    push(@specials, "JSC::PropertyAttribute::DOMLegacyAccessor") if $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{SetterCallWith}, "LegacyActiveWindowForAccessor");
</del><ins>+    push(@specials, "JSC::PropertyAttribute::DOMLegacyAccessor") if $attribute->extendedAttributes->{LegacyActiveWindowForAccessor};
</ins><span class="cx">     push(@specials, "JSC::PropertyAttribute::DOMAttribute") if IsAcceleratedDOMAttribute($interface, $attribute);
</span><span class="cx">     push(@specials, "JSC::PropertyAttribute::DOMJITAttribute") if $attribute->extendedAttributes->{DOMJIT};
</span><span class="cx">     push(@specials, "JSC::PropertyAttribute::Accessor | JSC::PropertyAttribute::Builtin") if  IsJSBuiltin($interface, $attribute);
</span></span></pre></div>
<a id="branchessafari612293branchSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (283453 => 283454)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp   2021-10-02 22:51:37 UTC (rev 283453)
+++ branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp      2021-10-02 22:53:56 UTC (rev 283454)
</span><span class="lines">@@ -1847,8 +1847,6 @@
</span><span class="cx"> static JSC_DECLARE_CUSTOM_SETTER(setJSTestObj_double_leading_underscore_attribute);
</span><span class="cx"> static JSC_DECLARE_CUSTOM_GETTER(jsTestObj_trailing_underscore_attribute_);
</span><span class="cx"> static JSC_DECLARE_CUSTOM_SETTER(setJSTestObj_trailing_underscore_attribute_);
</span><del>-static JSC_DECLARE_CUSTOM_GETTER(jsTestObj_href);
-static JSC_DECLARE_CUSTOM_SETTER(setJSTestObj_href);
</del><span class="cx"> 
</span><span class="cx"> class JSTestObjPrototype final : public JSC::JSNonFinalObject {
</span><span class="cx"> public:
</span><span class="lines">@@ -2183,7 +2181,6 @@
</span><span class="cx">     { "leading_underscore_attribute", static_cast<unsigned>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute), NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObj_leading_underscore_attribute), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObj_leading_underscore_attribute) } },
</span><span class="cx">     { "_double_leading_underscore_attribute", static_cast<unsigned>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute), NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObj_double_leading_underscore_attribute), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObj_double_leading_underscore_attribute) } },
</span><span class="cx">     { "trailing_underscore_attribute_", static_cast<unsigned>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute), NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObj_trailing_underscore_attribute_), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObj_trailing_underscore_attribute_) } },
</span><del>-    { "href", static_cast<unsigned>(JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMLegacyAccessor | JSC::PropertyAttribute::DOMAttribute), NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObj_href), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestObj_href) } },
</del><span class="cx"> #if ENABLE(TEST_FEATURE)
</span><span class="cx">     { "enabledAtRuntimeOperation", static_cast<unsigned>(JSC::PropertyAttribute::Function), NoIntrinsic, { (intptr_t)static_cast<RawNativeFunction>(jsTestObjPrototypeFunction_enabledAtRuntimeOperation), (intptr_t) (1) } },
</span><span class="cx"> #else
</span><span class="lines">@@ -5329,37 +5326,6 @@
</span><span class="cx">     return IDLAttribute<JSTestObj>::set<setJSTestObj_trailing_underscore_attribute_Setter>(*lexicalGlobalObject, thisValue, encodedValue, attributeName);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-static inline JSValue jsTestObj_hrefGetter(JSGlobalObject& lexicalGlobalObject, JSTestObj& thisObject)
-{
-    auto& vm = JSC::getVM(&lexicalGlobalObject);
-    auto throwScope = DECLARE_THROW_SCOPE(vm);
-    auto& impl = thisObject.wrapped();
-    RELEASE_AND_RETURN(throwScope, (toJS<IDLUSVString>(lexicalGlobalObject, throwScope, impl.href())));
-}
-
-JSC_DEFINE_CUSTOM_GETTER(jsTestObj_href, (JSGlobalObject* lexicalGlobalObject, EncodedJSValue thisValue, PropertyName attributeName))
-{
-    return IDLAttribute<JSTestObj>::get<jsTestObj_hrefGetter, CastedThisErrorBehavior::Assert>(*lexicalGlobalObject, thisValue, attributeName);
-}
-
-static inline bool setJSTestObj_hrefSetter(JSGlobalObject& lexicalGlobalObject, JSTestObj& thisObject, JSValue value)
-{
-    auto& vm = JSC::getVM(&lexicalGlobalObject);
-    auto throwScope = DECLARE_THROW_SCOPE(vm);
-    auto& impl = thisObject.wrapped();
-    auto nativeValue = convert<IDLUSVString>(lexicalGlobalObject, value);
-    RETURN_IF_EXCEPTION(throwScope, false);
-    invokeFunctorPropagatingExceptionIfNecessary(lexicalGlobalObject, throwScope, [&] {
-        return impl.setHref(legacyActiveDOMWindowForAccessor(*jsCast<JSDOMGlobalObject*>(&lexicalGlobalObject)), firstDOMWindow(*jsCast<JSDOMGlobalObject*>(&lexicalGlobalObject)), WTFMove(nativeValue));
-    });
-    return true;
-}
-
-JSC_DEFINE_CUSTOM_SETTER(setJSTestObj_href, (JSGlobalObject* lexicalGlobalObject, EncodedJSValue thisValue, EncodedJSValue encodedValue, PropertyName attributeName))
-{
-    return IDLAttribute<JSTestObj>::set<setJSTestObj_hrefSetter>(*lexicalGlobalObject, thisValue, encodedValue, attributeName);
-}
-
</del><span class="cx"> #if ENABLE(TEST_FEATURE)
</span><span class="cx"> static inline JSC::EncodedJSValue jsTestObjPrototypeFunction_enabledAtRuntimeOperation1Body(JSC::JSGlobalObject* lexicalGlobalObject, JSC::CallFrame* callFrame, typename IDLOperation<JSTestObj>::ClassParameter castedThis)
</span><span class="cx"> {
</span></span></pre></div>
<a id="branchessafari612293branchSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/TestObj.idl (283453 => 283454)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/TestObj.idl        2021-10-02 22:51:37 UTC (rev 283453)
+++ branches/safari-612.2.9.3-branch/Source/WebCore/bindings/scripts/test/TestObj.idl   2021-10-02 22:53:56 UTC (rev 283454)
</span><span class="lines">@@ -455,8 +455,6 @@
</span><span class="cx">     boolean bigUint64(BigUint64Array destination);
</span><span class="cx">     boolean bigInt64AllowShared([AllowShared] BigInt64Array destination);
</span><span class="cx">     boolean bigUint64AllowShared([AllowShared] BigUint64Array destination);
</span><del>-
-    [SetterCallWith=LegacyActiveWindowForAccessor&FirstWindow] attribute USVString href;
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> // The following comments should not generate any code.
</span></span></pre>
</div>
</div>

</body>
</html>