<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[283342] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/283342">283342</a></dd>
<dt>Author</dt> <dd>wilander@apple.com</dd>
<dt>Date</dt> <dd>2021-09-30 15:42:17 -0700 (Thu, 30 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
https://bugs.webkit.org/show_bug.cgi?id=230914
<rdar://problem/83639923>

Reviewed by Brent Fulgham.

This patch changes Private Click Measurement's WebIDL attributes from
all lowercase to camelcase to match the spec and align with the
Attribution Reporting API proposal.

References
- Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
- Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor

Source/WebCore:

Existing tests updated.

* html/HTMLAnchorElement.idl:

LayoutTests:

* http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
* http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
* http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesreflectexpectedtxt">trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesreflecthtml">trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html</a></li>
<li><a href="#trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesvalidationhtml">trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementidl">trunk/Source/WebCore/html/HTMLAnchorElement.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/ChangeLog 2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-09-30  John Wilander  <wilander@apple.com>
+
+        PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+        https://bugs.webkit.org/show_bug.cgi?id=230914
+        <rdar://problem/83639923>
+
+        Reviewed by Brent Fulgham.
+
+        This patch changes Private Click Measurement's WebIDL attributes from
+        all lowercase to camelcase to match the spec and align with the
+        Attribution Reporting API proposal.
+
+        References
+        - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+        - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+        * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
+        * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
+        * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
+
</ins><span class="cx"> 2021-09-30  Ziran Sun  <zsun@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [css-grid]  Transfer sizes from the aspect-ratio while resolving min-length for auto repetitions
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesreflectexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt  2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt     2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -1,10 +1,10 @@
</span><del>-Test for the new private click measurement attributes on anchor tags.
</del><ins>+Test for private click measurement attributes on anchor tags.
</ins><span class="cx"> 
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-PASS anchorTag.attributionsourceid is 40
-PASS anchorTag.attributiondestination is "https://destination.example"
</del><ins>+PASS anchorTag.attributionSourceId is 40
+PASS anchorTag.attributionDestination is "https://destination.example"
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx"> 
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesreflecthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html  2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html     2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -7,11 +7,11 @@
</span><span class="cx"> <body>
</span><span class="cx"> <a id="testTag" href="http://localhost:8000" attributionsourceid=40 attributiondestination="https://destination.example"></a>
</span><span class="cx"> <script>
</span><del>-    description("Test for the new private click measurement attributes on anchor tags.");
</del><ins>+    description("Test for private click measurement attributes on anchor tags.");
</ins><span class="cx"> 
</span><span class="cx">     const anchorTag = document.getElementById("testTag");
</span><del>-    shouldBeEqualToNumber("anchorTag.attributionsourceid", 40);
-    shouldBeEqualToString("anchorTag.attributiondestination", "https://destination.example");
</del><ins>+    shouldBeEqualToNumber("anchorTag.attributionSourceId", 40);
+    shouldBeEqualToString("anchorTag.attributionDestination", "https://destination.example");
</ins><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsprivateClickMeasurementanchortagattributesvalidationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html       2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html  2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -25,9 +25,9 @@
</span><span class="cx">         anchorElement.id = elementID;
</span><span class="cx">         anchorElement.classList.add("wide-link");
</span><span class="cx">         if (sourceID !== null)
</span><del>-            anchorElement.attributionsourceid = sourceID;
</del><ins>+            anchorElement.attributionSourceId = sourceID;
</ins><span class="cx">         if (destination !== null)
</span><del>-            anchorElement.attributiondestination = destination;
</del><ins>+            anchorElement.attributionDestination = destination;
</ins><span class="cx">         anchorElement.href = "#";
</span><span class="cx">         anchorElement.innerText = "Link" + currentTest;
</span><span class="cx">         return anchorElement;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/Source/WebCore/ChangeLog      2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-09-30  John Wilander  <wilander@apple.com>
+
+        PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+        https://bugs.webkit.org/show_bug.cgi?id=230914
+        <rdar://problem/83639923>
+
+        Reviewed by Brent Fulgham.
+
+        This patch changes Private Click Measurement's WebIDL attributes from
+        all lowercase to camelcase to match the spec and align with the
+        Attribution Reporting API proposal.
+
+        References
+        - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+        - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+        Existing tests updated.
+
+        * html/HTMLAnchorElement.idl:
+
</ins><span class="cx"> 2021-09-30  Rob Buis  <rbuis@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Move canCompositeClipPath to RenderLayer
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.idl (283341 => 283342)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.idl  2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.idl     2021-09-30 22:42:17 UTC (rev 283342)
</span><span class="lines">@@ -21,9 +21,9 @@
</span><span class="cx"> [
</span><span class="cx">     Exposed=Window
</span><span class="cx"> ] interface HTMLAnchorElement : HTMLElement {
</span><del>-    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionsourceid;
-    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributiondestination;
-    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionsourcenonce;
</del><ins>+    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionSourceId;
+    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributionDestination;
+    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionSourceNonce;
</ins><span class="cx">     [CEReactions=NotNeeded, Reflect] attribute DOMString charset;
</span><span class="cx">     [CEReactions=NotNeeded, Reflect] attribute DOMString coords;
</span><span class="cx">     [CEReactions=NotNeeded, Conditional=DOWNLOAD_ATTRIBUTE, EnabledBySetting=DownloadAttribute, Reflect] attribute DOMString download;
</span></span></pre>
</div>
</div>

</body>
</html>