<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282944] branches/safari-612-branch/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282944">282944</a></dd>
<dt>Author</dt> <dd>repstein@apple.com</dd>
<dt>Date</dt> <dd>2021-09-22 22:14:32 -0700 (Wed, 22 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/282774">r282774</a>. rdar://problem/83429893

    [GPUP] Videos appear black but audio plays normally
    https://bugs.webkit.org/show_bug.cgi?id=230471
    <rdar://82121369>

    Reviewed by Youenn Fablet.

    For some videos, the media player (MediaPlayerPrivateAVFoundation) starts
    with the "MediaRenderingToContext" mode, and it switches to the "MediaRenderingToLayer"
    mode later. When the mode switch happens, we have to destroy the context
    video renderer before creating the video layer. Otherwise, we won't receive
    the notification regarding "readyForDisplay" key path, which drives the
    `firstVideoFrameAvailable` callback.

    `destroyContextVideoRenderer()` destroys the `m_videoOutput`, but it will
    be recreated by `createVideoLayer()`.

    Manually tested.

    * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
    (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282774 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari612branchSourceWebCoreChangeLog">branches/safari-612-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari612branchSourceWebCoreplatformgraphicsavfoundationMediaPlayerPrivateAVFoundationcpp">branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari612branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (282943 => 282944)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/ChangeLog      2021-09-23 05:14:29 UTC (rev 282943)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-09-23 05:14:32 UTC (rev 282944)
</span><span class="lines">@@ -1,5 +1,56 @@
</span><span class="cx"> 2021-09-22  Alan Coon  <alancoon@apple.com>
</span><span class="cx"> 
</span><ins>+        Cherry-pick r282774. rdar://problem/83429893
+
+    [GPUP] Videos appear black but audio plays normally
+    https://bugs.webkit.org/show_bug.cgi?id=230471
+    <rdar://82121369>
+    
+    Reviewed by Youenn Fablet.
+    
+    For some videos, the media player (MediaPlayerPrivateAVFoundation) starts
+    with the "MediaRenderingToContext" mode, and it switches to the "MediaRenderingToLayer"
+    mode later. When the mode switch happens, we have to destroy the context
+    video renderer before creating the video layer. Otherwise, we won't receive
+    the notification regarding "readyForDisplay" key path, which drives the
+    `firstVideoFrameAvailable` callback.
+    
+    `destroyContextVideoRenderer()` destroys the `m_videoOutput`, but it will
+    be recreated by `createVideoLayer()`.
+    
+    Manually tested.
+    
+    * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+    (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-09-20  Peng Liu  <peng.liu6@apple.com>
+
+            [GPUP] Videos appear black but audio plays normally
+            https://bugs.webkit.org/show_bug.cgi?id=230471
+            <rdar://82121369>
+
+            Reviewed by Youenn Fablet.
+
+            For some videos, the media player (MediaPlayerPrivateAVFoundation) starts
+            with the "MediaRenderingToContext" mode, and it switches to the "MediaRenderingToLayer"
+            mode later. When the mode switch happens, we have to destroy the context
+            video renderer before creating the video layer. Otherwise, we won't receive
+            the notification regarding "readyForDisplay" key path, which drives the
+            `firstVideoFrameAvailable` callback.
+
+            `destroyContextVideoRenderer()` destroys the `m_videoOutput`, but it will
+            be recreated by `createVideoLayer()`.
+
+            Manually tested.
+
+            * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+            (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering):
+
+2021-09-22  Alan Coon  <alancoon@apple.com>
+
</ins><span class="cx">         Cherry-pick r282707. rdar://problem/83429953
</span><span class="cx"> 
</span><span class="cx">     [JSC] Add fast property enumeration mode for JSON.stringify
</span></span></pre></div>
<a id="branchessafari612branchSourceWebCoreplatformgraphicsavfoundationMediaPlayerPrivateAVFoundationcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (282943 => 282944)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp      2021-09-23 05:14:29 UTC (rev 282943)
+++ branches/safari-612-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2021-09-23 05:14:32 UTC (rev 282944)
</span><span class="lines">@@ -136,6 +136,7 @@
</span><span class="cx">         break;
</span><span class="cx"> 
</span><span class="cx">     case MediaRenderingToLayer:
</span><ins>+        destroyContextVideoRenderer();
</ins><span class="cx">         createVideoLayer();
</span><span class="cx">         break;
</span><span class="cx">     }
</span></span></pre>
</div>
</div>

</body>
</html>