<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282848] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282848">282848</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2021-09-21 16:03:37 -0700 (Tue, 21 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Drop makeRefPtr() and use RefPtr { } directly instead
https://bugs.webkit.org/show_bug.cgi?id=230564

Reviewed by Alex Christensen.

Source/WebKit:

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists):
(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):
* NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::addConnection):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
* Platform/IPC/Connection.cpp:
(IPC::Connection::MessagesThrottler::scheduleMessagesDispatch):
* Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::parseByteSource):
* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewCreateNewPage):
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
(WebKit::WebAutomationSession::maximizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::hideWindowOfBrowsingContext):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runOpenPanel):
(WebKit::UIDelegate::UIClient::requestPointerLock):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::scheduleActivityStateUpdate):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(-[WKProcessPoolWeakObserver pool]):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
* UIProcess/WebContextMenuProxy.cpp:
(WebKit::WebContextMenuProxy::useContextMenuItems):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handlePreventableTouchEvent):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::runModalJavaScriptDialog):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
(WebKit::WebContextMenuProxyMac::insertOrUpdateQuickLookImageItem):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::waitForDidCreateImageBufferBackend):
(WebKit::RemoteRenderingBackendProxy::waitForDidFlush):
(WebKit::RemoteRenderingBackendProxy::findReusableDisplayListHandle):
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
(WebKit::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::networkStateChanged):
(WebKit::MediaPlayerPrivateRemote::setReadyState):
(WebKit::MediaPlayerPrivateRemote::readyStateChanged):
(WebKit::MediaPlayerPrivateRemote::volumeChanged):
(WebKit::MediaPlayerPrivateRemote::muteChanged):
(WebKit::MediaPlayerPrivateRemote::timeChanged):
(WebKit::MediaPlayerPrivateRemote::durationChanged):
(WebKit::MediaPlayerPrivateRemote::rateChanged):
(WebKit::MediaPlayerPrivateRemote::playbackStateChanged):
(WebKit::MediaPlayerPrivateRemote::engineFailedToLoad):
(WebKit::MediaPlayerPrivateRemote::characteristicChanged):
(WebKit::MediaPlayerPrivateRemote::sizeChanged):
(WebKit::MediaPlayerPrivateRemote::firstVideoFrameAvailable):
(WebKit::MediaPlayerPrivateRemote::renderingModeChanged):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::removeRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteTextTrack):
(WebKit::MediaPlayerPrivateRemote::removeRemoteTextTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):
(WebKit::MediaPlayerPrivateRemote::removeRemoteVideoTrack):
(WebKit::MediaPlayerPrivateRemote::currentPlaybackTargetIsWirelessChanged):
(WebKit::MediaPlayerPrivateRemote::mediaPlayerKeyNeeded):
(WebKit::MediaPlayerPrivateRemote::waitingForKeyChanged):
(WebKit::MediaPlayerPrivateRemote::initializationDataEncountered):
(WebKit::MediaPlayerPrivateRemote::resourceNotSupported):
(WebKit::MediaPlayerPrivateRemote::activeSourceBuffersChanged):
(WebKit::MediaPlayerPrivateRemote::getRawCookies const):
* WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::startRecording):
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage):
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didDestroyNotification):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches):
* WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCSemaphore::signal):
(WebKit::IPCTestingAPI::JSIPCSemaphore::waitFor):
(WebKit::IPCTestingAPI::JSSharedMemory::readBytes):
(WebKit::IPCTestingAPI::JSSharedMemory::writeBytes):
(WebKit::IPCTestingAPI::JSIPC::addMessageListener):
(WebKit::IPCTestingAPI::encodeRemoteRenderingBackendCreationParameters):
(WebKit::IPCTestingAPI::encodeSharedMemory):
(WebKit::IPCTestingAPI::encodeSemaphore):
(WebKit::IPCTestingAPI::encodeArgument):
(WebKit::IPCTestingAPI::JSIPC::sendMessage):
(WebKit::IPCTestingAPI::JSIPC::sendSyncMessage):
(WebKit::IPCTestingAPI::JSIPC::vmPageSize):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
* WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInFrameInScriptWorld):
(WebKit::WebPage::getContentsAsString):
(WebKit::WebPage::removeDataDetectedLinks):
(WebKit::WebPage::detectDataInAllFrames):
(WebKit::WebPage::startTextManipulations):
(WebKit::WebPage::completeTextManipulation):
(WebKit::WebPage::requestTextRecognition):
(WebKit::WebPage::updateWithTextRecognitionResult):
(WebKit::WebPage::createAppHighlightInSelectedRange):
(WebKit::WebPage::setAppHighlightsVisibility):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const):
(WebKit::insideImageOverlay):
(WebKit::expandForImageOverlay):
(WebKit::rangeForPointInRootViewCoordinates):
(WebKit::WebPage::rootViewBounds):
(WebKit::WebPage::absoluteInteractionBounds):
(WebKit::WebPage::rootViewInteractionBounds):
(WebKit::WebPage::requestEvasionRectsAboveSelection):
(WebKit::dataDetectorImageOverlayPositionInformation):
(WebKit::selectionPositionInformation):
(WebKit::populateCaretContext):
(WebKit::WebPage::positionInformation):
(WebKit::WebPage::performActionOnElement):
(WebKit::WebPage::shrinkToFitContent):
(WebKit::WebPage::updateVisibleContentRects):
(WebKit::WebPage::updateSelectionWithDelta):
(WebKit::WebPage::requestDocumentEditingContext):
(WebKit::WebPage::animationDidFinishForElement):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

Source/WebKitLegacy/mac:

* DOM/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::declareAndWriteDragImage):
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]):
(-[WebHTMLRepresentation controlsInForm:]):
* WebView/WebView.mm:
(-[WebView updateTextTouchBar]):

Source/WTF:

* wtf/RefPtr.h:

Tools:

* TestWebKitAPI/Tests/WTF/RunLoop.cpp:
(TestWebKitAPI::TEST):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfRefPtrh">trunk/Source/WTF/wtf/RefPtr.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitGPUProcessgraphicsRemoteRenderingBackendcpp">trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessIndexedDBWebIDBServercpp">trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp</a></li>
<li><a href="#trunkSourceWebKitNetworkProcesscocoaNetworkSessionCocoamm">trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm</a></li>
<li><a href="#trunkSourceWebKitPlatformIPCConnectioncpp">trunk/Source/WebKit/Platform/IPC/Connection.cpp</a></li>
<li><a href="#trunkSourceWebKitSharedWebHitTestResultDatacpp">trunk/Source/WebKit/Shared/WebHitTestResultData.cpp</a></li>
<li><a href="#trunkSourceWebKitSharedmacMediaFormatReaderMediaFormatReadercpp">trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPIglibWebKitWebViewcpp">trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessAutomationWebAutomationSessioncpp">trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessCocoaUIDelegatemm">trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessCocoaWebPageProxyCocoamm">trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessCocoaWebProcessPoolCocoamm">trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessNetworkNetworkProcessProxycpp">trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebContextMenuProxycpp">trunk/Source/WebKit/UIProcess/WebContextMenuProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxycpp">trunk/Source/WebKit/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebProcessPoolcpp">trunk/Source/WebKit/UIProcess/WebProcessPool.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessiosViewGestureControllerIOSmm">trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessmacWebContextMenuProxyMacmm">trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm</a></li>
<li><a href="#trunkSourceWebKitWebProcessGPUgraphicsRemoteRenderingBackendProxycpp">trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessGPUmediaMediaPlayerPrivateRemotecpp">trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessGPUwebrtcMediaRecorderPrivatecpp">trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessInjectedBundleDOMInjectedBundleRangeHandlecpp">trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessNetworkWebLoaderStrategycpp">trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessNotificationsWebNotificationManagercpp">trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebCoreSupportmacWebDragClientMacmm">trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageFindControllercpp">trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageIPCTestingAPIcpp">trunk/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageRemoteLayerTreeRemoteLayerTreeDrawingAreamm">trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageViewGestureGeometryCollectorcpp">trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageWebPagecpp">trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPagemacTiledCoreAnimationDrawingAreamm">trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPagemacWebPageMacmm">trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm</a></li>
<li><a href="#trunkSourceWebKitLegacymacChangeLog">trunk/Source/WebKitLegacy/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitLegacymacDOMDOMmm">trunk/Source/WebKitLegacy/mac/DOM/DOM.mm</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebCoreSupportWebContextMenuClientmm">trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebCoreSupportWebDragClientmm">trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebViewWebHTMLRepresentationmm">trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebViewWebViewmm">trunk/Source/WebKitLegacy/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFRunLoopcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WTF/ChangeLog  2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-09-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop makeRefPtr() and use RefPtr { } directly instead
+        https://bugs.webkit.org/show_bug.cgi?id=230564
+
+        Reviewed by Alex Christensen.
+
+        * wtf/RefPtr.h:
+
</ins><span class="cx"> 2021-09-21  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>
</span></span></pre></div>
<a id="trunkSourceWTFwtfRefPtrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/RefPtr.h (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/RefPtr.h    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WTF/wtf/RefPtr.h       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -253,16 +253,6 @@
</span><span class="cx">     return RefPtr<T, U, V>(p, RefPtr<T, U, V>::Adopt);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-template<typename T> inline RefPtr<T> makeRefPtr(T* pointer)
-{
-    return pointer;
-}
-
-template<typename T> inline RefPtr<T> makeRefPtr(T& reference)
-{
-    return &reference;
-}
-
</del><span class="cx"> template<typename ExpectedType, typename ArgType, typename PtrTraits, typename RefDerefTraits>
</span><span class="cx"> inline bool is(RefPtr<ArgType, PtrTraits, RefDerefTraits>& source)
</span><span class="cx"> {
</span><span class="lines">@@ -279,5 +269,4 @@
</span><span class="cx"> 
</span><span class="cx"> using WTF::RefPtr;
</span><span class="cx"> using WTF::adoptRef;
</span><del>-using WTF::makeRefPtr;
</del><span class="cx"> using WTF::static_pointer_cast;
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/ChangeLog       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1,3 +1,155 @@
</span><ins>+2021-09-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop makeRefPtr() and use RefPtr { } directly instead
+        https://bugs.webkit.org/show_bug.cgi?id=230564
+
+        Reviewed by Alex Christensen.
+
+        * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+        (WebKit::RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists):
+        (WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):
+        * NetworkProcess/IndexedDB/WebIDBServer.cpp:
+        (WebKit::WebIDBServer::addConnection):
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
+        * Platform/IPC/Connection.cpp:
+        (IPC::Connection::MessagesThrottler::scheduleMessagesDispatch):
+        * Shared/WebHitTestResultData.cpp:
+        (WebKit::WebHitTestResultData::WebHitTestResultData):
+        * Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
+        (WebKit::MediaFormatReader::parseByteSource):
+        * UIProcess/API/glib/WebKitWebView.cpp:
+        (webkitWebViewCreateNewPage):
+        * UIProcess/Automation/WebAutomationSession.cpp:
+        (WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
+        (WebKit::WebAutomationSession::maximizeWindowOfBrowsingContext):
+        (WebKit::WebAutomationSession::hideWindowOfBrowsingContext):
+        * UIProcess/Cocoa/UIDelegate.mm:
+        (WebKit::UIDelegate::UIClient::runOpenPanel):
+        (WebKit::UIDelegate::UIClient::requestPointerLock):
+        * UIProcess/Cocoa/WebPageProxyCocoa.mm:
+        (WebKit::WebPageProxy::scheduleActivityStateUpdate):
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (-[WKProcessPoolWeakObserver pool]):
+        * UIProcess/Network/NetworkProcessProxy.cpp:
+        (WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
+        * UIProcess/WebContextMenuProxy.cpp:
+        (WebKit::WebContextMenuProxy::useContextMenuItems):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::handlePreventableTouchEvent):
+        (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
+        (WebKit::WebPageProxy::runModalJavaScriptDialog):
+        (WebKit::WebPageProxy::runJavaScriptAlert):
+        (WebKit::WebPageProxy::runJavaScriptConfirm):
+        (WebKit::WebPageProxy::runJavaScriptPrompt):
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::processForNavigation):
+        * UIProcess/ios/ViewGestureControllerIOS.mm:
+        (WebKit::ViewGestureController::beginSwipeGesture):
+        * UIProcess/mac/WebContextMenuProxyMac.mm:
+        (WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
+        (WebKit::WebContextMenuProxyMac::insertOrUpdateQuickLookImageItem):
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+        (WebKit::RemoteRenderingBackendProxy::waitForDidCreateImageBufferBackend):
+        (WebKit::RemoteRenderingBackendProxy::waitForDidFlush):
+        (WebKit::RemoteRenderingBackendProxy::findReusableDisplayListHandle):
+        * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+        (WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
+        (WebKit::MediaPlayerPrivateRemote::load):
+        (WebKit::MediaPlayerPrivateRemote::networkStateChanged):
+        (WebKit::MediaPlayerPrivateRemote::setReadyState):
+        (WebKit::MediaPlayerPrivateRemote::readyStateChanged):
+        (WebKit::MediaPlayerPrivateRemote::volumeChanged):
+        (WebKit::MediaPlayerPrivateRemote::muteChanged):
+        (WebKit::MediaPlayerPrivateRemote::timeChanged):
+        (WebKit::MediaPlayerPrivateRemote::durationChanged):
+        (WebKit::MediaPlayerPrivateRemote::rateChanged):
+        (WebKit::MediaPlayerPrivateRemote::playbackStateChanged):
+        (WebKit::MediaPlayerPrivateRemote::engineFailedToLoad):
+        (WebKit::MediaPlayerPrivateRemote::characteristicChanged):
+        (WebKit::MediaPlayerPrivateRemote::sizeChanged):
+        (WebKit::MediaPlayerPrivateRemote::firstVideoFrameAvailable):
+        (WebKit::MediaPlayerPrivateRemote::renderingModeChanged):
+        (WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
+        (WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
+        (WebKit::MediaPlayerPrivateRemote::removeRemoteAudioTrack):
+        (WebKit::MediaPlayerPrivateRemote::addRemoteTextTrack):
+        (WebKit::MediaPlayerPrivateRemote::removeRemoteTextTrack):
+        (WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):
+        (WebKit::MediaPlayerPrivateRemote::removeRemoteVideoTrack):
+        (WebKit::MediaPlayerPrivateRemote::currentPlaybackTargetIsWirelessChanged):
+        (WebKit::MediaPlayerPrivateRemote::mediaPlayerKeyNeeded):
+        (WebKit::MediaPlayerPrivateRemote::waitingForKeyChanged):
+        (WebKit::MediaPlayerPrivateRemote::initializationDataEncountered):
+        (WebKit::MediaPlayerPrivateRemote::resourceNotSupported):
+        (WebKit::MediaPlayerPrivateRemote::activeSourceBuffersChanged):
+        (WebKit::MediaPlayerPrivateRemote::getRawCookies const):
+        * WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
+        (WebKit::MediaRecorderPrivate::startRecording):
+        * WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
+        (WebKit::InjectedBundleRangeHandle::renderedImage):
+        * WebProcess/Network/WebLoaderStrategy.cpp:
+        (WebKit::WebLoaderStrategy::scheduleLoad):
+        (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
+        * WebProcess/Notifications/WebNotificationManager.cpp:
+        (WebKit::WebNotificationManager::didDestroyNotification):
+        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
+        (WebKit::WebDragClient::declareAndWriteDragImage):
+        * WebProcess/WebPage/FindController.cpp:
+        (WebKit::FindController::findStringMatches):
+        * WebProcess/WebPage/IPCTestingAPI.cpp:
+        (WebKit::IPCTestingAPI::JSIPCSemaphore::signal):
+        (WebKit::IPCTestingAPI::JSIPCSemaphore::waitFor):
+        (WebKit::IPCTestingAPI::JSSharedMemory::readBytes):
+        (WebKit::IPCTestingAPI::JSSharedMemory::writeBytes):
+        (WebKit::IPCTestingAPI::JSIPC::addMessageListener):
+        (WebKit::IPCTestingAPI::encodeRemoteRenderingBackendCreationParameters):
+        (WebKit::IPCTestingAPI::encodeSharedMemory):
+        (WebKit::IPCTestingAPI::encodeSemaphore):
+        (WebKit::IPCTestingAPI::encodeArgument):
+        (WebKit::IPCTestingAPI::JSIPC::sendMessage):
+        (WebKit::IPCTestingAPI::JSIPC::sendSyncMessage):
+        (WebKit::IPCTestingAPI::JSIPC::vmPageSize):
+        * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+        (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+        * WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
+        (WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales):
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::runJavaScriptInFrameInScriptWorld):
+        (WebKit::WebPage::getContentsAsString):
+        (WebKit::WebPage::removeDataDetectedLinks):
+        (WebKit::WebPage::detectDataInAllFrames):
+        (WebKit::WebPage::startTextManipulations):
+        (WebKit::WebPage::completeTextManipulation):
+        (WebKit::WebPage::requestTextRecognition):
+        (WebKit::WebPage::updateWithTextRecognitionResult):
+        (WebKit::WebPage::createAppHighlightInSelectedRange):
+        (WebKit::WebPage::setAppHighlightsVisibility):
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::getPlatformEditorState const):
+        (WebKit::insideImageOverlay):
+        (WebKit::expandForImageOverlay):
+        (WebKit::rangeForPointInRootViewCoordinates):
+        (WebKit::WebPage::rootViewBounds):
+        (WebKit::WebPage::absoluteInteractionBounds):
+        (WebKit::WebPage::rootViewInteractionBounds):
+        (WebKit::WebPage::requestEvasionRectsAboveSelection):
+        (WebKit::dataDetectorImageOverlayPositionInformation):
+        (WebKit::selectionPositionInformation):
+        (WebKit::populateCaretContext):
+        (WebKit::WebPage::positionInformation):
+        (WebKit::WebPage::performActionOnElement):
+        (WebKit::WebPage::shrinkToFitContent):
+        (WebKit::WebPage::updateVisibleContentRects):
+        (WebKit::WebPage::updateSelectionWithDelta):
+        (WebKit::WebPage::requestDocumentEditingContext):
+        (WebKit::WebPage::animationDidFinishForElement):
+        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+        (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+        * WebProcess/WebPage/mac/WebPageMac.mm:
+        (WebKit::WebPage::performImmediateActionHitTestAtLocation):
+
</ins><span class="cx"> 2021-09-21  Megan Gardner  <megan_gardner@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Remove unused selection parameter.
</span></span></pre></div>
<a id="trunkSourceWebKitGPUProcessgraphicsRemoteRenderingBackendcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp       2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp  2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -236,8 +236,8 @@
</span><span class="cx"> 
</span><span class="cx"> RefPtr<ImageBuffer> RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists(ImageBuffer& initialDestination, size_t initialOffset, DisplayListReaderHandle& handle, GPUProcessWakeupReason reason)
</span><span class="cx"> {
</span><del>-    auto destination = makeRefPtr(initialDestination);
-    auto handleProtector = makeRef(handle);
</del><ins>+    RefPtr destination { &initialDestination };
+    Ref handleProtector { handle };
</ins><span class="cx"> 
</span><span class="cx">     auto offset = initialOffset;
</span><span class="cx">     size_t sizeToRead = 0;
</span><span class="lines">@@ -269,7 +269,7 @@
</span><span class="cx">         MESSAGE_CHECK_WITH_RETURN_VALUE(offset <= handle.sharedMemory().size(), nullptr, "Out-of-bounds offset into shared display list handle");
</span><span class="cx"> 
</span><span class="cx">         if (result.reasonForStopping == DisplayList::StopReplayReason::ChangeDestinationImageBuffer) {
</span><del>-            destination = makeRefPtr(m_remoteResourceCache.cachedImageBuffer(*result.nextDestinationImageBuffer));
</del><ins>+            destination = m_remoteResourceCache.cachedImageBuffer(*result.nextDestinationImageBuffer);
</ins><span class="cx">             if (!destination) {
</span><span class="cx">                 ASSERT(!m_pendingWakeupInfo);
</span><span class="cx">                 m_pendingWakeupInfo = {{
</span><span class="lines">@@ -311,7 +311,7 @@
</span><span class="cx">             auto newDestinationIdentifier = makeObjectIdentifier<RenderingResourceIdentifierType>(resumeReadingInfo->destination);
</span><span class="cx">             MESSAGE_CHECK_WITH_RETURN_VALUE(newDestinationIdentifier.isValid(), nullptr, "Invalid image buffer destination when resuming display list processing");
</span><span class="cx"> 
</span><del>-            destination = makeRefPtr(m_remoteResourceCache.cachedImageBuffer(newDestinationIdentifier));
</del><ins>+            destination = m_remoteResourceCache.cachedImageBuffer(newDestinationIdentifier);
</ins><span class="cx">             MESSAGE_CHECK_WITH_RETURN_VALUE(destination, nullptr, "Missing image buffer destination when resuming display list processing");
</span><span class="cx"> 
</span><span class="cx">             offset = resumeReadingInfo->offset;
</span><span class="lines">@@ -329,7 +329,7 @@
</span><span class="cx"> 
</span><span class="cx">     updateLastKnownState(RemoteRenderingBackendState::BeganReplayingDisplayList);
</span><span class="cx"> 
</span><del>-    auto destinationImageBuffer = makeRefPtr(m_remoteResourceCache.cachedImageBuffer(arguments.destinationImageBufferIdentifier));
</del><ins>+    RefPtr destinationImageBuffer = m_remoteResourceCache.cachedImageBuffer(arguments.destinationImageBufferIdentifier);
</ins><span class="cx">     MESSAGE_CHECK(destinationImageBuffer, "Missing destination image buffer");
</span><span class="cx"> 
</span><span class="cx">     auto initialHandle = m_sharedDisplayListHandles.get(arguments.itemBufferIdentifier);
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessIndexedDBWebIDBServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -399,9 +399,9 @@
</span><span class="cx"> {
</span><span class="cx">     ASSERT(RunLoop::isMain());
</span><span class="cx"> 
</span><del>-    postTask([this, protectedThis = Ref { *this }, protectedConnection = makeRefPtr(connection), processIdentifier] {
</del><ins>+    postTask([this, protectedThis = Ref { *this }, protectedConnection = Ref { connection }, processIdentifier] {
</ins><span class="cx">         auto[iter, isNewEntry] = m_connectionMap.ensure(protectedConnection->uniqueID(), [&] {
</span><del>-            return makeUnique<WebIDBConnectionToClient>(*protectedConnection, processIdentifier);
</del><ins>+            return makeUnique<WebIDBConnectionToClient>(protectedConnection.get(), processIdentifier);
</ins><span class="cx">         });
</span><span class="cx"> 
</span><span class="cx">         ASSERT_UNUSED(isNewEntry, isNewEntry);
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcesscocoaNetworkSessionCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -754,7 +754,7 @@
</span><span class="cx">                 networkDataTask->didNegotiateModernTLS(URL(URL(), makeString(String(protectionSpace.protocol), "://", String(protectionSpace.host), ':', protectionSpace.port)));
</span><span class="cx">             }
</span><span class="cx"> #if HAVE(CFNETWORK_NSURLSESSION_STRICTRUSTEVALUATE)
</span><del>-            auto decisionHandler = makeBlockPtr([weakSelf = WeakObjCPtr<WKNetworkSessionDelegate>(self), sessionCocoa = makeWeakPtr(sessionCocoa), completionHandler = makeBlockPtr(completionHandler), taskIdentifier, networkDataTask = makeRefPtr(networkDataTask), negotiatedLegacyTLS](NSURLAuthenticationChallenge *challenge, OSStatus trustResult) mutable {
</del><ins>+            auto decisionHandler = makeBlockPtr([weakSelf = WeakObjCPtr<WKNetworkSessionDelegate>(self), sessionCocoa = makeWeakPtr(sessionCocoa), completionHandler = makeBlockPtr(completionHandler), taskIdentifier, networkDataTask = RefPtr { networkDataTask }, negotiatedLegacyTLS](NSURLAuthenticationChallenge *challenge, OSStatus trustResult) mutable {
</ins><span class="cx">                 auto strongSelf = weakSelf.get();
</span><span class="cx">                 if (!strongSelf)
</span><span class="cx">                     return completionHandler(NSURLSessionAuthChallengeCancelAuthenticationChallenge, nil);
</span></span></pre></div>
<a id="trunkSourceWebKitPlatformIPCConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Platform/IPC/Connection.cpp  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1135,7 +1135,7 @@
</span><span class="cx">         m_dispatchMessagesTimer.startOneShot(0_s);
</span><span class="cx">         return;
</span><span class="cx">     }
</span><del>-    RunLoop::main().dispatch([this, protectedConnection = makeRefPtr(&m_connection)]() mutable {
</del><ins>+    RunLoop::main().dispatch([this, protectedConnection = RefPtr { &m_connection }]() mutable {
</ins><span class="cx">         (protectedConnection.get()->*m_dispatchMessages)();
</span><span class="cx">     });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitSharedWebHitTestResultDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/WebHitTestResultData.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/WebHitTestResultData.cpp      2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/Shared/WebHitTestResultData.cpp 2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx">         }
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    if (auto target = makeRefPtr(hitTestResult.innerNonSharedNode()); target && is<RenderImage>(target->renderer()))
</del><ins>+    if (auto target = RefPtr { hitTestResult.innerNonSharedNode() }; target && is<RenderImage>(target->renderer()))
</ins><span class="cx">         imageBitmap = createShareableBitmap(*downcast<RenderImage>(target->renderer()));
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitSharedmacMediaFormatReaderMediaFormatReadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp   2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp      2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if (!m_logger) {
</span><del>-        m_logger = makeRefPtr(Document::sharedLogger());
</del><ins>+        m_logger = &Document::sharedLogger();
</ins><span class="cx">         m_logIdentifier = nextLogIdentifier();
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPIglibWebKitWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -2473,7 +2473,7 @@
</span><span class="cx"> 
</span><span class="cx">     webkitWindowPropertiesUpdateFromWebWindowFeatures(newWebView->priv->windowProperties.get(), windowFeatures);
</span><span class="cx"> 
</span><del>-    return makeRefPtr(getPage(newWebView));
</del><ins>+    return &getPage(newWebView);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void webkitWebViewReadyToShowPage(WebKitWebView* webView)
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAutomationWebAutomationSessioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp        2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp   2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -415,7 +415,7 @@
</span><span class="cx">     if (!page)
</span><span class="cx">         ASYNC_FAIL_WITH_PREDEFINED_ERROR(WindowNotFound);
</span><span class="cx"> 
</span><del>-    exitFullscreenWindowForPage(*page, [this, protectedThis = Ref { *this }, callback = WTFMove(callback), page = makeRefPtr(page), width, height, x, y]() mutable {
</del><ins>+    exitFullscreenWindowForPage(*page, [this, protectedThis = Ref { *this }, callback = WTFMove(callback), page = RefPtr { page }, width, height, x, y]() mutable {
</ins><span class="cx">         auto& webPage = *page;
</span><span class="cx">         this->restoreWindowForPage(webPage, [callback = WTFMove(callback), page = WTFMove(page), width, height, x, y]() mutable {
</span><span class="cx">             auto& webPage = *page;
</span><span class="lines">@@ -563,7 +563,7 @@
</span><span class="cx">     if (!page)
</span><span class="cx">         ASYNC_FAIL_WITH_PREDEFINED_ERROR(WindowNotFound);
</span><span class="cx"> 
</span><del>-    exitFullscreenWindowForPage(*page, [this, protectedThis = Ref { *this }, callback = WTFMove(callback), page = makeRefPtr(page)]() mutable {
</del><ins>+    exitFullscreenWindowForPage(*page, [this, protectedThis = Ref { *this }, callback = WTFMove(callback), page = RefPtr { page }]() mutable {
</ins><span class="cx">         auto& webPage = *page;
</span><span class="cx">         restoreWindowForPage(webPage, [this, callback = WTFMove(callback), page = WTFMove(page)]() mutable {
</span><span class="cx">             maximizeWindowForPage(*page, [callback = WTFMove(callback)]() {
</span><span class="lines">@@ -579,7 +579,7 @@
</span><span class="cx">     if (!page)
</span><span class="cx">         ASYNC_FAIL_WITH_PREDEFINED_ERROR(WindowNotFound);
</span><span class="cx">     
</span><del>-    exitFullscreenWindowForPage(*page, [protectedThis = Ref { *this }, callback = WTFMove(callback), page = makeRefPtr(page)]() mutable {
</del><ins>+    exitFullscreenWindowForPage(*page, [protectedThis = Ref { *this }, callback = WTFMove(callback), page = RefPtr { page }]() mutable {
</ins><span class="cx">         protectedThis->hideWindowForPage(*page, [callback = WTFMove(callback)]() mutable {
</span><span class="cx">             callback->sendSuccess();
</span><span class="cx">         });
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessCocoaUIDelegatemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm        2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm   2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1029,7 +1029,7 @@
</span><span class="cx"> 
</span><span class="cx">     auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector(webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:));
</span><span class="cx"> 
</span><del>-    [delegate webView:m_uiDelegate->m_webView.get().get() runOpenPanelWithParameters:wrapper(*openPanelParameters) initiatedByFrame:wrapper(frame) completionHandler:makeBlockPtr([checker = WTFMove(checker), openPanelParameters = makeRef(*openPanelParameters), listener = makeRefPtr(listener)] (NSArray *URLs) mutable {
</del><ins>+    [delegate webView:m_uiDelegate->m_webView.get().get() runOpenPanelWithParameters:wrapper(*openPanelParameters) initiatedByFrame:wrapper(frame) completionHandler:makeBlockPtr([checker = WTFMove(checker), openPanelParameters = Ref { *openPanelParameters }, listener = RefPtr { listener }] (NSArray *URLs) mutable {
</ins><span class="cx">         if (checker->completionHandlerHasBeenCalled())
</span><span class="cx">             return;
</span><span class="cx">         checker->didCallCompletionHandler();
</span><span class="lines">@@ -1465,7 +1465,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector(_webViewDidRequestPointerLock:completionHandler:));
</span><del>-    [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewDidRequestPointerLock:m_uiDelegate->m_webView.get().get() completionHandler:makeBlockPtr([checker = WTFMove(checker), page = makeRefPtr(page)] (BOOL allow) {
</del><ins>+    [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewDidRequestPointerLock:m_uiDelegate->m_webView.get().get() completionHandler:makeBlockPtr([checker = WTFMove(checker), page = RefPtr { page }] (BOOL allow) {
</ins><span class="cx">         if (checker->completionHandlerHasBeenCalled())
</span><span class="cx">             return;
</span><span class="cx">         checker->didCallCompletionHandler();
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessCocoaWebPageProxyCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -534,7 +534,7 @@
</span><span class="cx">             // that may result in other frameworks trying to install commit handlers for the same phase, which is not allowed.
</span><span class="cx">             // So, dispatch_async here; we only care that the activity state change doesn't apply until after the active commit is complete.
</span><span class="cx">             WorkQueue::main().dispatch([weakThis] {
</span><del>-                auto protectedThis = makeRefPtr(weakThis.get());
</del><ins>+                RefPtr protectedThis { weakThis.get() };
</ins><span class="cx">                 if (!protectedThis)
</span><span class="cx">                     return;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessCocoaWebProcessPoolCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm       2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm  2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> @implementation WKProcessPoolWeakObserver (Direct)
</span><span class="cx"> - (RefPtr<WebKit::WebProcessPool>)pool
</span><span class="cx"> {
</span><del>-    return makeRefPtr(m_weakPtr.get());
</del><ins>+    return m_weakPtr.get();
</ins><span class="cx"> }
</span><span class="cx"> @end
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessNetworkNetworkProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -470,7 +470,7 @@
</span><span class="cx"> 
</span><span class="cx"> void NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses(WebCore::ProcessIdentifier processIdentifier)
</span><span class="cx"> {
</span><del>-    if (auto process = makeRefPtr(WebProcessProxy::processForIdentifier(processIdentifier))) {
</del><ins>+    if (RefPtr process = WebProcessProxy::processForIdentifier(processIdentifier)) {
</ins><span class="cx">         process->disableServiceWorkers();
</span><span class="cx">         process->requestTermination(ProcessTerminationReason::ExceededCPULimit);
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebContextMenuProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebContextMenuProxy.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebContextMenuProxy.cpp    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/WebContextMenuProxy.cpp       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> {
</span><span class="cx">     m_contextMenuListener = nullptr;
</span><span class="cx"> 
</span><del>-    auto page = makeRefPtr(this->page());
</del><ins>+    RefPtr page = this->page();
</ins><span class="cx">     if (!page)
</span><span class="cx">         return;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp   2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp      2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -3203,7 +3203,7 @@
</span><span class="cx">             ++m_handlingPreventableTouchEndCount;
</span><span class="cx"> 
</span><span class="cx">         sendWithAsyncReply(Messages::EventDispatcher::TouchEvent(m_webPageID, event), [this, weakThis = makeWeakPtr(*this), event] (bool handled) {
</span><del>-            auto protectedThis = makeRefPtr(weakThis.get());
</del><ins>+            RefPtr protectedThis { weakThis.get() };
</ins><span class="cx">             if (!protectedThis)
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><span class="lines">@@ -4634,7 +4634,7 @@
</span><span class="cx"> {
</span><span class="cx">     PageClientProtector protector(pageClient());
</span><span class="cx"> 
</span><del>-    auto frame = makeRefPtr(process->webFrame(frameID));
</del><ins>+    RefPtr frame = process->webFrame(frameID);
</ins><span class="cx">     MESSAGE_CHECK(process, frame);
</span><span class="cx">     MESSAGE_CHECK_URL(process, url);
</span><span class="cx"> 
</span><span class="lines">@@ -5420,7 +5420,7 @@
</span><span class="cx">     auto listener = makeRef(frame.setUpPolicyListenerProxy([this, protectedThis = Ref { *this }, frame = makeRef(frame), sender = WTFMove(sender), navigation, navigationAction, frameInfo, userDataObject = process->transformHandlesToObjects(userData.object()).get()] (PolicyAction policyAction, API::WebsitePolicies* policies, ProcessSwapRequestedByClient processSwapRequestedByClient, RefPtr<SafeBrowsingWarning>&& safeBrowsingWarning, std::optional<NavigatingToAppBoundDomain> isAppBoundDomain) mutable {
</span><span class="cx">         WEBPAGEPROXY_RELEASE_LOG(Loading, "decidePolicyForNavigationAction: listener called: frameID=%llu, navigationID=%llu, policyAction=%u, safeBrowsingWarning=%d, isAppBoundDomain=%d", frame->frameID().toUInt64(), navigation ? navigation->navigationID() : 0, (unsigned)policyAction, !!safeBrowsingWarning, !!isAppBoundDomain);
</span><span class="cx"> 
</span><del>-        auto completionHandler = [this, protectedThis, frame, sender = WTFMove(sender), navigation, navigationAction = WTFMove(navigationAction), processSwapRequestedByClient, policies = makeRefPtr(policies)] (PolicyAction policyAction) mutable {
</del><ins>+        auto completionHandler = [this, protectedThis, frame, sender = WTFMove(sender), navigation, navigationAction = WTFMove(navigationAction), processSwapRequestedByClient, policies = RefPtr { policies }] (PolicyAction policyAction) mutable {
</ins><span class="cx">             if (frame->isMainFrame()) {
</span><span class="cx">                 if (!policies) {
</span><span class="cx">                     if (auto* defaultPolicies = m_configuration->defaultWebsitePolicies())
</span><span class="lines">@@ -5921,13 +5921,13 @@
</span><span class="cx"> void WebPageProxy::runModalJavaScriptDialog(RefPtr<WebFrameProxy>&& frame, FrameInfoData&& frameInfo, const String& message, CompletionHandler<void(WebPageProxy&, WebFrameProxy* frame, FrameInfoData&& frameInfo, const String& message, CompletionHandler<void()>&&)>&& runDialogCallback)
</span><span class="cx"> {
</span><span class="cx">     pageClient().runModalJavaScriptDialog([weakThis = makeWeakPtr(*this), frameInfo = WTFMove(frameInfo), frame = WTFMove(frame), message, runDialogCallback = WTFMove(runDialogCallback)]() mutable {
</span><del>-        auto protectedThis = makeRefPtr(weakThis.get());
</del><ins>+        RefPtr protectedThis { weakThis.get() };
</ins><span class="cx">         if (!protectedThis)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="cx">         protectedThis->m_isRunningModalJavaScriptDialog = true;
</span><span class="cx">         runDialogCallback(*protectedThis, frame.get(), WTFMove(frameInfo), message, [weakThis = WTFMove(weakThis)]() mutable {
</span><del>-            if (auto protectedThis = makeRefPtr(weakThis.get()))
</del><ins>+            if (RefPtr protectedThis = weakThis.get())
</ins><span class="cx">                 protectedThis->m_isRunningModalJavaScriptDialog = false;
</span><span class="cx">         });
</span><span class="cx">     });
</span><span class="lines">@@ -5935,7 +5935,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebPageProxy::runJavaScriptAlert(FrameIdentifier frameID, FrameInfoData&& frameInfo, const String& message, Messages::WebPageProxy::RunJavaScriptAlert::DelayedReply&& reply)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(m_process->webFrame(frameID));
</del><ins>+    RefPtr frame = m_process->webFrame(frameID);
</ins><span class="cx">     MESSAGE_CHECK(m_process, frame);
</span><span class="cx"> 
</span><span class="cx">     exitFullscreenImmediately();
</span><span class="lines">@@ -5958,7 +5958,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebPageProxy::runJavaScriptConfirm(FrameIdentifier frameID, FrameInfoData&& frameInfo, const String& message, Messages::WebPageProxy::RunJavaScriptConfirm::DelayedReply&& reply)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(m_process->webFrame(frameID));
</del><ins>+    RefPtr frame = m_process->webFrame(frameID);
</ins><span class="cx">     MESSAGE_CHECK(m_process, frame);
</span><span class="cx"> 
</span><span class="cx">     exitFullscreenImmediately();
</span><span class="lines">@@ -5981,7 +5981,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebPageProxy::runJavaScriptPrompt(FrameIdentifier frameID, FrameInfoData&& frameInfo, const String& message, const String& defaultValue, Messages::WebPageProxy::RunJavaScriptPrompt::DelayedReply&& reply)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(m_process->webFrame(frameID));
</del><ins>+    RefPtr frame = m_process->webFrame(frameID);
</ins><span class="cx">     MESSAGE_CHECK(m_process, frame);
</span><span class="cx"> 
</span><span class="cx">     exitFullscreenImmediately();
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1805,7 +1805,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebProcessPool::processForNavigation(WebPageProxy& page, const API::Navigation& navigation, Ref<WebProcessProxy>&& sourceProcess, const URL& sourceURL, ProcessSwapRequestedByClient processSwapRequestedByClient, Ref<WebsiteDataStore>&& dataStore, CompletionHandler<void(Ref<WebProcessProxy>&&, SuspendedPageProxy*, const String&)>&& completionHandler)
</span><span class="cx"> {
</span><del>-    processForNavigationInternal(page, navigation, sourceProcess.copyRef(), sourceURL, processSwapRequestedByClient, WTFMove(dataStore), [this, page = makeRefPtr(page), navigation = makeRef(navigation), sourceProcess = sourceProcess.copyRef(), sourceURL, processSwapRequestedByClient, completionHandler = WTFMove(completionHandler)](Ref<WebProcessProxy>&& process, SuspendedPageProxy* suspendedPage, const String& reason) mutable {
</del><ins>+    processForNavigationInternal(page, navigation, sourceProcess.copyRef(), sourceURL, processSwapRequestedByClient, WTFMove(dataStore), [this, page = Ref { page }, navigation = makeRef(navigation), sourceProcess = sourceProcess.copyRef(), sourceURL, processSwapRequestedByClient, completionHandler = WTFMove(completionHandler)](Ref<WebProcessProxy>&& process, SuspendedPageProxy* suspendedPage, const String& reason) mutable {
</ins><span class="cx">         // We are process-swapping so automatic process prewarming would be beneficial if the client has not explicitly enabled / disabled it.
</span><span class="cx">         bool doingAnAutomaticProcessSwap = processSwapRequestedByClient == ProcessSwapRequestedByClient::No && process.ptr() != sourceProcess.ptr();
</span><span class="cx">         if (doingAnAutomaticProcessSwap && !configuration().wasAutomaticProcessWarmingSetByClient() && !configuration().clientWouldBenefitFromAutomaticProcessPrewarming()) {
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessiosViewGestureControllerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx">     m_webPageProxyForBackForwardListForCurrentSwipe = alternateBackForwardListSourcePage ? alternateBackForwardListSourcePage.get() : &m_webPageProxy;
</span><span class="cx"> 
</span><span class="cx">     auto& backForwardList = m_webPageProxyForBackForwardListForCurrentSwipe->backForwardList();
</span><del>-    auto targetItem = makeRefPtr(direction == SwipeDirection::Back ? backForwardList.backItem() : backForwardList.forwardItem());
</del><ins>+    RefPtr targetItem = direction == SwipeDirection::Back ? backForwardList.backItem() : backForwardList.forwardItem();
</ins><span class="cx">     if (!targetItem) {
</span><span class="cx">         RELEASE_LOG_ERROR(ViewGestures, "Failed to find %s item when beginning swipe.", direction == SwipeDirection::Back ? "back" : "forward");
</span><span class="cx">         didEndGesture();
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessmacWebContextMenuProxyMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm      2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -546,7 +546,7 @@
</span><span class="cx"> 
</span><span class="cx">         [menu setItemArray:[sparseMenuItems allObjects]];
</span><span class="cx"> 
</span><del>-        auto page = makeRefPtr(weakPage.get());
</del><ins>+        RefPtr page { weakPage.get() };
</ins><span class="cx">         if (page && imageBitmap) {
</span><span class="cx"> #if ENABLE(IMAGE_ANALYSIS)
</span><span class="cx">             protectedThis->insertOrUpdateQuickLookImageItem(imageURL, imageBitmap.releaseNonNull(), WTFMove(quickLookItemToInsertIfNeeded), shouldUpdateQuickLookItemTitle);
</span><span class="lines">@@ -575,7 +575,7 @@
</span><span class="cx">     auto page = makeRef(*this->page());
</span><span class="cx">     if (quickLookItemToInsertIfNeeded) {
</span><span class="cx">         page->computeHasImageAnalysisResults(imageURL, imageBitmap.get(), ImageAnalysisType::VisualSearch, [weakThis = makeWeakPtr(*this), quickLookItemToInsertIfNeeded = WTFMove(*quickLookItemToInsertIfNeeded)] (bool hasVisualSearchResults) mutable {
</span><del>-            if (auto protectedThis = makeRefPtr(weakThis.get()); protectedThis && hasVisualSearchResults) {
</del><ins>+            if (RefPtr protectedThis = weakThis.get(); protectedThis && hasVisualSearchResults) {
</ins><span class="cx">                 protectedThis->m_quickLookPreviewActivity = QuickLookPreviewActivity::VisualSearch;
</span><span class="cx">                 [protectedThis->m_menu addItem:NSMenuItem.separatorItem];
</span><span class="cx">                 [protectedThis->m_menu addItem:createMenuActionItem(quickLookItemToInsertIfNeeded).get()];
</span><span class="lines">@@ -586,11 +586,11 @@
</span><span class="cx"> 
</span><span class="cx">     if (shouldUpdateQuickLookItemTitle) {
</span><span class="cx">         page->computeHasImageAnalysisResults(imageURL, imageBitmap.get(), ImageAnalysisType::VisualSearch, [weakThis = makeWeakPtr(*this), weakPage = makeWeakPtr(page.get()), imageURL, imageBitmap = WTFMove(imageBitmap)] (bool hasVisualSearchResults) mutable {
</span><del>-            auto protectedThis = makeRefPtr(weakThis.get());
</del><ins>+            RefPtr protectedThis { weakThis.get() };
</ins><span class="cx">             if (!protectedThis)
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><del>-            auto page = makeRefPtr(weakPage.get());
</del><ins>+            RefPtr page { weakPage.get() };
</ins><span class="cx">             if (!page)
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><span class="lines">@@ -601,11 +601,11 @@
</span><span class="cx">             }
</span><span class="cx"> 
</span><span class="cx">             page->computeHasImageAnalysisResults(imageURL, imageBitmap.get(), ImageAnalysisType::Text, [weakThis = WTFMove(weakThis), weakPage] (bool hasText) mutable {
</span><del>-                auto protectedThis = makeRefPtr(weakThis.get());
</del><ins>+                RefPtr protectedThis { weakThis.get() };
</ins><span class="cx">                 if (!protectedThis)
</span><span class="cx">                     return;
</span><span class="cx"> 
</span><del>-                if (auto page = makeRefPtr(weakPage.get()); page && hasText)
</del><ins>+                if (RefPtr page = weakPage.get(); page && hasText)
</ins><span class="cx">                     protectedThis->updateQuickLookContextMenuItemTitle(contextMenuItemTagQuickLookImageForTextSelection());
</span><span class="cx">             });
</span><span class="cx">         });
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessGPUgraphicsRemoteRenderingBackendProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp      2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> 
</span><span class="cx"> RemoteRenderingBackendProxy::DidReceiveBackendCreationResult RemoteRenderingBackendProxy::waitForDidCreateImageBufferBackend()
</span><span class="cx"> {
</span><del>-    auto connection = makeRefPtr(messageSenderConnection());
</del><ins>+    RefPtr connection = messageSenderConnection();
</ins><span class="cx">     if (!connection->waitForAndDispatchImmediately<Messages::RemoteRenderingBackendProxy::DidCreateImageBufferBackend>(renderingBackendIdentifier(), 1_s, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives))
</span><span class="cx">         return DidReceiveBackendCreationResult::TimeoutOrIPCFailure;
</span><span class="cx">     return DidReceiveBackendCreationResult::ReceivedAnyResponse;
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> 
</span><span class="cx"> bool RemoteRenderingBackendProxy::waitForDidFlush()
</span><span class="cx"> {
</span><del>-    auto connection = makeRefPtr(messageSenderConnection());
</del><ins>+    RefPtr connection = messageSenderConnection();
</ins><span class="cx">     return connection->waitForAndDispatchImmediately<Messages::RemoteRenderingBackendProxy::DidFlush>(renderingBackendIdentifier(), 1_s, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -397,7 +397,7 @@
</span><span class="cx"> 
</span><span class="cx">     auto leastRecentlyUsedIdentifier = m_identifiersOfReusableHandles.first();
</span><span class="cx">     if (leastRecentlyUsedIdentifier != mostRecentlyUsedHandle->identifier()) {
</span><del>-        auto handle = makeRefPtr(m_sharedDisplayListHandles.get(leastRecentlyUsedIdentifier));
</del><ins>+        RefPtr handle = m_sharedDisplayListHandles.get(leastRecentlyUsedIdentifier);
</ins><span class="cx">         if (handle->moveWritableOffsetToStartIfPossible() && handle->availableCapacity() >= capacity)
</span><span class="cx">             return handle;
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessGPUmediaMediaPlayerPrivateRemotecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> 
</span><span class="cx"> void MediaPlayerPrivateRemote::prepareForPlayback(bool privateMode, MediaPlayer::Preload preload, bool preservesPitch, bool prepare)
</span><span class="cx"> {
</span><del>-    auto player = makeRefPtr(m_player.get());
</del><ins>+    RefPtr player = m_player.get();
</ins><span class="cx">     if (!player)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -154,7 +154,7 @@
</span><span class="cx">         if (!inlineLayerHostingContextId)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        auto player = makeRefPtr(m_player.get());
</del><ins>+        RefPtr player = m_player.get();
</ins><span class="cx">         if (!player)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx">         if (!createExtension()) {
</span><span class="cx">             WTFLogAlways("Unable to create sandbox extension handle for GPUProcess url.\n");
</span><span class="cx">             m_cachedState.networkState = MediaPlayer::NetworkState::FormatError;
</span><del>-            if (auto player = makeRefPtr(m_player.get()))
</del><ins>+            if (RefPtr player = m_player.get())
</ins><span class="cx">                 player->networkStateChanged();
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="lines">@@ -204,7 +204,7 @@
</span><span class="cx">         if (!weakThis)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        auto player = makeRefPtr(m_player.get());
</del><ins>+        RefPtr player = m_player.get();
</ins><span class="cx">         if (!player)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -337,7 +337,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::networkStateChanged(RemoteMediaPlayerState&& state)
</span><span class="cx"> {
</span><span class="cx">     updateCachedState(WTFMove(state));
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->networkStateChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -344,7 +344,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::setReadyState(MediaPlayer::ReadyState readyState)
</span><span class="cx"> {
</span><span class="cx">     m_cachedState.readyState = readyState;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->readyStateChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -351,7 +351,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::readyStateChanged(RemoteMediaPlayerState&& state)
</span><span class="cx"> {
</span><span class="cx">     updateCachedState(WTFMove(state));
</span><del>-    if (auto player = makeRefPtr(m_player.get())) {
</del><ins>+    if (RefPtr player = m_player.get()) {
</ins><span class="cx">         player->readyStateChanged();
</span><span class="cx">         bool renderingCanBeAccelerated = player->renderingCanBeAccelerated();
</span><span class="cx">         if (m_renderingCanBeAccelerated != renderingCanBeAccelerated)
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::volumeChanged(double volume)
</span><span class="cx"> {
</span><span class="cx">     m_volume = volume;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->volumeChanged(volume);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -369,7 +369,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::muteChanged(bool muted)
</span><span class="cx"> {
</span><span class="cx">     m_muted = muted;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->muteChanged(muted);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx"> {
</span><span class="cx">     m_seeking = false;
</span><span class="cx">     updateCachedState(WTFMove(state));
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->timeChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -384,7 +384,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::durationChanged(RemoteMediaPlayerState&& state)
</span><span class="cx"> {
</span><span class="cx">     updateCachedState(WTFMove(state));
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->durationChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -391,7 +391,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::rateChanged(double rate)
</span><span class="cx"> {
</span><span class="cx">     m_rate = rate;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->rateChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -400,7 +400,7 @@
</span><span class="cx">     m_cachedState.paused = paused;
</span><span class="cx">     m_cachedMediaTime = mediaTime;
</span><span class="cx">     m_cachedMediaTimeQueryTime = wallTime;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->playbackStateChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -407,7 +407,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::engineFailedToLoad(long platformErrorCode)
</span><span class="cx"> {
</span><span class="cx">     m_platformErrorCode = platformErrorCode;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->remoteEngineFailedToLoad();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -414,7 +414,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::characteristicChanged(RemoteMediaPlayerState&& state)
</span><span class="cx"> {
</span><span class="cx">     updateCachedState(WTFMove(state));
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->characteristicChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -421,7 +421,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::sizeChanged(WebCore::FloatSize naturalSize)
</span><span class="cx"> {
</span><span class="cx">     m_cachedState.naturalSize = naturalSize;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->sizeChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -435,7 +435,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::firstVideoFrameAvailable()
</span><span class="cx"> {
</span><span class="cx">     INFO_LOG(LOGIDENTIFIER);
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->firstVideoFrameAvailable();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -442,7 +442,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::renderingModeChanged()
</span><span class="cx"> {
</span><span class="cx">     INFO_LOG(LOGIDENTIFIER);
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->renderingModeChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -473,7 +473,7 @@
</span><span class="cx"> 
</span><span class="cx"> void MediaPlayerPrivateRemote::acceleratedRenderingStateChanged()
</span><span class="cx"> {
</span><del>-    if (auto player = makeRefPtr(m_player.get())) {
</del><ins>+    if (RefPtr player = m_player.get()) {
</ins><span class="cx">         m_renderingCanBeAccelerated = player->renderingCanBeAccelerated();
</span><span class="cx">         connection().send(Messages::RemoteMediaPlayerProxy::AcceleratedRenderingStateChanged(m_renderingCanBeAccelerated), m_id);
</span><span class="cx">     }
</span><span class="lines">@@ -573,7 +573,7 @@
</span><span class="cx">         return;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         m_player->addAudioTrack(addResult.iterator->value);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -582,7 +582,7 @@
</span><span class="cx">     ASSERT(m_audioTracks.contains(identifier));
</span><span class="cx"> 
</span><span class="cx">     if (auto* track = m_audioTracks.get(identifier)) {
</span><del>-        if (auto player = makeRefPtr(m_player.get()))
</del><ins>+        if (RefPtr player = m_player.get())
</ins><span class="cx">             player->removeAudioTrack(*track);
</span><span class="cx">         m_audioTracks.remove(identifier);
</span><span class="cx">     }
</span><span class="lines">@@ -611,7 +611,7 @@
</span><span class="cx">         return;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->addTextTrack(addResult.iterator->value);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -620,7 +620,7 @@
</span><span class="cx">     ASSERT(m_textTracks.contains(identifier));
</span><span class="cx"> 
</span><span class="cx">     if (auto* track = m_textTracks.get(identifier)) {
</span><del>-        if (auto player = makeRefPtr(m_player.get()))
</del><ins>+        if (RefPtr player = m_player.get())
</ins><span class="cx">             player->removeTextTrack(*track);
</span><span class="cx">         m_textTracks.remove(identifier);
</span><span class="cx">     }
</span><span class="lines">@@ -731,7 +731,7 @@
</span><span class="cx">         return;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->addVideoTrack(addResult.iterator->value);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -740,7 +740,7 @@
</span><span class="cx">     ASSERT(m_videoTracks.contains(identifier));
</span><span class="cx"> 
</span><span class="cx">     if (auto* track = m_videoTracks.get(identifier)) {
</span><del>-        if (auto player = makeRefPtr(m_player.get()))
</del><ins>+        if (RefPtr player = m_player.get())
</ins><span class="cx">             player->removeVideoTrack(*track);
</span><span class="cx">         m_videoTracks.remove(identifier);
</span><span class="cx">     }
</span><span class="lines">@@ -763,7 +763,7 @@
</span><span class="cx">             if (!weakThis)
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><del>-            auto player = makeRefPtr(m_player.get());
</del><ins>+            RefPtr player = m_player.get();
</ins><span class="cx">             if (!player)
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><span class="lines">@@ -779,7 +779,7 @@
</span><span class="cx">         if (!weakThis)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        auto player = makeRefPtr(m_player.get());
</del><ins>+        RefPtr player = m_player.get();
</ins><span class="cx">         if (!player)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -796,7 +796,7 @@
</span><span class="cx">         if (!weakThis)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        auto player = makeRefPtr(m_player.get());
</del><ins>+        RefPtr player = m_player.get();
</ins><span class="cx">         if (!player)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -1022,7 +1022,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::currentPlaybackTargetIsWirelessChanged(bool isCurrentPlaybackTargetWireless)
</span><span class="cx"> {
</span><span class="cx">     m_isCurrentPlaybackTargetWireless = isCurrentPlaybackTargetWireless;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->currentPlaybackTargetIsWirelessChanged(isCurrentPlaybackTargetWireless);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1156,7 +1156,7 @@
</span><span class="cx"> 
</span><span class="cx"> void MediaPlayerPrivateRemote::mediaPlayerKeyNeeded(IPC::DataReference&& message)
</span><span class="cx"> {
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->keyNeeded(Uint8Array::create(message.data(), message.size()).ptr());
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="lines">@@ -1183,7 +1183,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::waitingForKeyChanged(bool waitingForKey)
</span><span class="cx"> {
</span><span class="cx">     m_waitingForKey = waitingForKey;
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->waitingForKeyChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1190,7 +1190,7 @@
</span><span class="cx"> void MediaPlayerPrivateRemote::initializationDataEncountered(const String& initDataType, IPC::DataReference&& initData)
</span><span class="cx"> {
</span><span class="cx">     auto initDataBuffer = ArrayBuffer::create(initData.data(), initData.size());
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->initializationDataEncountered(initDataType, WTFMove(initDataBuffer));
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1381,13 +1381,13 @@
</span><span class="cx"> 
</span><span class="cx"> void MediaPlayerPrivateRemote::resourceNotSupported()
</span><span class="cx"> {
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->resourceNotSupported();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void MediaPlayerPrivateRemote::activeSourceBuffersChanged()
</span><span class="cx"> {
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->activeSourceBuffersChanged();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1394,7 +1394,7 @@
</span><span class="cx"> #if PLATFORM(IOS_FAMILY)
</span><span class="cx"> void MediaPlayerPrivateRemote::getRawCookies(const URL& url, WebCore::MediaPlayerClient::GetRawCookiesCallback&& completionHandler) const
</span><span class="cx"> {
</span><del>-    if (auto player = makeRefPtr(m_player.get()))
</del><ins>+    if (RefPtr player = m_player.get())
</ins><span class="cx">         player->getRawCookies(url, WTFMove(completionHandler));
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessGPUwebrtcMediaRecorderPrivatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp       2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp  2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx">     if (selectedTracks.audioTrack)
</span><span class="cx">         m_ringBuffer = makeUnique<CARingBuffer>(makeUniqueRef<SharedRingBufferStorage>(std::bind(&MediaRecorderPrivate::storageChanged, this, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3)));
</span><span class="cx"> 
</span><del>-    m_connection->sendWithAsyncReply(Messages::RemoteMediaRecorderManager::CreateRecorder { m_identifier, !!selectedTracks.audioTrack, !!selectedTracks.videoTrack, m_options }, [this, weakThis = makeWeakPtr(this), audioTrack = makeRefPtr(selectedTracks.audioTrack), videoTrack = makeRefPtr(selectedTracks.videoTrack), callback = WTFMove(callback)](auto&& exception, String&& mimeType, unsigned audioBitRate, unsigned videoBitRate) mutable {
</del><ins>+    m_connection->sendWithAsyncReply(Messages::RemoteMediaRecorderManager::CreateRecorder { m_identifier, !!selectedTracks.audioTrack, !!selectedTracks.videoTrack, m_options }, [this, weakThis = makeWeakPtr(this), audioTrack = RefPtr { selectedTracks.audioTrack }, videoTrack = RefPtr { selectedTracks.videoTrack }, callback = WTFMove(callback)](auto&& exception, String&& mimeType, unsigned audioBitRate, unsigned videoBitRate) mutable {
</ins><span class="cx">         if (!weakThis) {
</span><span class="cx">             callback(Exception { InvalidStateError }, 0, 0);
</span><span class="cx">             return;
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessInjectedBundleDOMInjectedBundleRangeHandlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -117,9 +117,9 @@
</span><span class="cx"> {
</span><span class="cx">     auto range = makeSimpleRange(m_range);
</span><span class="cx"> 
</span><del>-    auto document = makeRef(range.start.document());
</del><ins>+    Ref document = range.start.document();
</ins><span class="cx"> 
</span><del>-    auto frame = makeRefPtr(document->frame());
</del><ins>+    RefPtr frame = document->frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return nullptr;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessNetworkWebLoaderStrategycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp     2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp        2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -236,8 +236,8 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(SERVICE_WORKER)
</span><span class="cx">         if (!resourceLoader.options().serviceWorkerRegistrationIdentifier && InspectorInstrumentationWebKit::shouldInterceptRequest(resourceLoader.frame(), resourceLoader.request())) {
</span><del>-            InspectorInstrumentationWebKit::interceptRequest(resourceLoader, [this, protectedResourceLoader = makeRefPtr(&resourceLoader), trackingParameters, shouldClearReferrerOnHTTPSToHTTPRedirect, resource](const ResourceRequest& request) {
-                scheduleLoadFromNetworkProcess(*protectedResourceLoader, request, trackingParameters, shouldClearReferrerOnHTTPSToHTTPRedirect, maximumBufferingTime(resource));
</del><ins>+            InspectorInstrumentationWebKit::interceptRequest(resourceLoader, [this, protectedResourceLoader = Ref { resourceLoader }, trackingParameters, shouldClearReferrerOnHTTPSToHTTPRedirect, resource](const ResourceRequest& request) {
+                scheduleLoadFromNetworkProcess(protectedResourceLoader, request, trackingParameters, shouldClearReferrerOnHTTPSToHTTPRedirect, maximumBufferingTime(resource));
</ins><span class="cx">             });
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="lines">@@ -406,7 +406,7 @@
</span><span class="cx">     if (resourceLoader.options().mode == FetchOptions::Mode::Navigate) {
</span><span class="cx">         Vector<RefPtr<SecurityOrigin>> frameAncestorOrigins;
</span><span class="cx">         for (auto* frame = resourceLoader.frame()->tree().parent(); frame; frame = frame->tree().parent())
</span><del>-            frameAncestorOrigins.append(makeRefPtr(frame->document()->securityOrigin()));
</del><ins>+            frameAncestorOrigins.append(&frame->document()->securityOrigin());
</ins><span class="cx">         loadParameters.frameAncestorOrigins = WTFMove(frameAncestorOrigins);
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessNotificationsWebNotificationManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx"> void WebNotificationManager::didDestroyNotification(Notification* notification, WebPage* page)
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(NOTIFICATIONS)
</span><del>-    auto protectedNotification = makeRefPtr(notification);
</del><ins>+    RefPtr protectedNotification { notification };
</ins><span class="cx"> 
</span><span class="cx">     uint64_t notificationID = m_notificationMap.take(notification);
</span><span class="cx">     if (!notificationID)
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebCoreSupportmacWebDragClientMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -187,7 +187,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebDragClient::declareAndWriteDragImage(const String& pasteboardName, Element& element, const URL& url, const String& label, Frame*)
</span><span class="cx"> {
</span><del>-    if (auto frame = makeRefPtr(element.document().frame()))
</del><ins>+    if (RefPtr frame = element.document().frame())
</ins><span class="cx">         frame->editor().writeImageToPasteboard(*Pasteboard::createForDragAndDrop(PagePasteboardContext::create(frame->pageID())), element, url, label);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageFindControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp        2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/FindController.cpp   2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     bool found = !m_findMatches.isEmpty();
</span><del>-    m_webPage->drawingArea()->dispatchAfterEnsuringUpdatedScrollPosition([protectedWebPage = makeRefPtr(m_webPage), found, string, options, maxMatchCount] () {
</del><ins>+    m_webPage->drawingArea()->dispatchAfterEnsuringUpdatedScrollPosition([protectedWebPage = RefPtr { m_webPage }, found, string, options, maxMatchCount] () {
</ins><span class="cx">         protectedWebPage->findController().updateFindUIAfterPageScroll(found, string, options, maxMatchCount, DidWrap::No, FindUIOriginator::FindStringMatches);
</span><span class="cx">     });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageIPCTestingAPIcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -285,7 +285,7 @@
</span><span class="cx"> {
</span><span class="cx">     auto* globalObject = toJS(context);
</span><span class="cx">     JSC::JSLockHolder lock(globalObject->vm());
</span><del>-    auto jsIPCSemaphore = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPCSemaphore = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPCSemaphore) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -300,7 +300,7 @@
</span><span class="cx"> {
</span><span class="cx">     auto* globalObject = toJS(context);
</span><span class="cx">     JSC::JSLockHolder lock(globalObject->vm());
</span><del>-    auto jsIPCSemaphore = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPCSemaphore = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPCSemaphore) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -396,7 +396,7 @@
</span><span class="cx"> 
</span><span class="cx"> JSValueRef JSSharedMemory::readBytes(JSContextRef context, JSObjectRef, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
</span><span class="cx"> {
</span><del>-    auto jsSharedMemory = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsSharedMemory = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsSharedMemory) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -474,7 +474,7 @@
</span><span class="cx"> 
</span><span class="cx"> JSValueRef JSSharedMemory::writeBytes(JSContextRef context, JSObjectRef, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
</span><span class="cx"> {
</span><del>-    auto jsSharedMemory = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsSharedMemory = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsSharedMemory) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -622,7 +622,7 @@
</span><span class="cx"> {
</span><span class="cx">     auto* globalObject = toJS(context);
</span><span class="cx">     JSC::JSLockHolder lock(globalObject->vm());
</span><del>-    auto jsIPC = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPC = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPC) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return;
</span><span class="lines">@@ -764,7 +764,7 @@
</span><span class="cx">     auto jsSemaphore = jsObject->get(globalObject, JSC::Identifier::fromString(globalObject->vm(), "semaphore"_s));
</span><span class="cx">     if (scope.exception())
</span><span class="cx">         return false;
</span><del>-    auto semaphoreObject = makeRefPtr(JSIPCSemaphore::toWrapped(toRef(globalObject), toRef(jsSemaphore)));
</del><ins>+    RefPtr semaphoreObject = JSIPCSemaphore::toWrapped(toRef(globalObject), toRef(jsSemaphore));
</ins><span class="cx">     if (!semaphoreObject)
</span><span class="cx">         return false;
</span><span class="cx"> 
</span><span class="lines">@@ -789,7 +789,7 @@
</span><span class="cx">     auto jsSharedMemoryValue = jsObject->get(globalObject, JSC::Identifier::fromString(globalObject->vm(), "value"_s));
</span><span class="cx">     if (scope.exception())
</span><span class="cx">         return false;
</span><del>-    auto jsSharedMemory = makeRefPtr(JSSharedMemory::toWrapped(toRef(globalObject), toRef(jsSharedMemoryValue)));
</del><ins>+    RefPtr jsSharedMemory = JSSharedMemory::toWrapped(toRef(globalObject), toRef(jsSharedMemoryValue));
</ins><span class="cx">     if (!jsSharedMemory)
</span><span class="cx">         return false;
</span><span class="cx"> 
</span><span class="lines">@@ -823,7 +823,7 @@
</span><span class="cx"> 
</span><span class="cx"> static bool encodeSemaphore(IPC::Encoder& encoder, JSC::JSGlobalObject* globalObject, JSC::JSValue jsValue, JSC::CatchScope& scope)
</span><span class="cx"> {
</span><del>-    auto jsIPCSemaphore = makeRefPtr(JSIPCSemaphore::toWrapped(toRef(globalObject), toRef(jsValue)));
</del><ins>+    RefPtr jsIPCSemaphore = JSIPCSemaphore::toWrapped(toRef(globalObject), toRef(jsValue));
</ins><span class="cx">     if (!jsIPCSemaphore)
</span><span class="cx">         return false;
</span><span class="cx"> 
</span><span class="lines">@@ -962,7 +962,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if (type == "FrameInfoData") {
</span><del>-        auto webFrame = makeRefPtr(jsIPC.webFrame());
</del><ins>+        RefPtr webFrame = jsIPC.webFrame();
</ins><span class="cx">         if (!webFrame) {
</span><span class="cx">             *exception = createTypeError(context, "Failed to get the frame"_s);
</span><span class="cx">             return false;
</span><span class="lines">@@ -1114,7 +1114,7 @@
</span><span class="cx"> {
</span><span class="cx">     auto* globalObject = toJS(context);
</span><span class="cx">     JSC::JSLockHolder lock(globalObject->vm());
</span><del>-    auto jsIPC = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPC = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPC) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -1196,7 +1196,7 @@
</span><span class="cx"> {
</span><span class="cx">     auto* globalObject = toJS(context);
</span><span class="cx">     JSC::JSLockHolder lock(globalObject->vm());
</span><del>-    auto jsIPC = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPC = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPC) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span><span class="lines">@@ -1281,7 +1281,7 @@
</span><span class="cx"> 
</span><span class="cx"> JSValueRef JSIPC::vmPageSize(JSContextRef context, JSObjectRef thisObject, JSStringRef, JSValueRef* exception)
</span><span class="cx"> {
</span><del>-    auto jsIPC = makeRefPtr(toWrapped(context, thisObject));
</del><ins>+    RefPtr jsIPC = toWrapped(context, thisObject);
</ins><span class="cx">     if (!jsIPC) {
</span><span class="cx">         *exception = createTypeError(context, "Wrong type"_s);
</span><span class="cx">         return JSValueMakeUndefined(context);
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageRemoteLayerTreeRemoteLayerTreeDrawingAreamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm     2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm        2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -288,7 +288,7 @@
</span><span class="cx">     if (m_webPage.firstFlushAfterCommit())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
</del><ins>+    [CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
</ins><span class="cx">         if (Page* corePage = retainedPage->corePage()) {
</span><span class="cx">             if (Frame* coreFrame = retainedPage->mainFrame())
</span><span class="cx">                 corePage->inspectorController().willComposite(*coreFrame);
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx">         }
</span><span class="cx">     } forPhase:kCATransactionPhasePreCommit];
</span><span class="cx">     
</span><del>-    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
</del><ins>+    [CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
</ins><span class="cx">         if (Page* corePage = retainedPage->corePage()) {
</span><span class="cx">             if (Frame* coreFrame = retainedPage->mainFrame())
</span><span class="cx">                 corePage->inspectorController().didComposite(*coreFrame);
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageViewGestureGeometryCollectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -150,7 +150,7 @@
</span><span class="cx">     if (m_cachedTextLegibilityScales)
</span><span class="cx">         return m_cachedTextLegibilityScales;
</span><span class="cx"> 
</span><del>-    auto document = makeRefPtr(m_webPage.mainFrame()->document());
</del><ins>+    RefPtr document = m_webPage.mainFrame()->document();
</ins><span class="cx">     if (!document)
</span><span class="cx">         return std::nullopt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp       2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp  2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -3758,7 +3758,7 @@
</span><span class="cx"> void WebPage::runJavaScriptInFrameInScriptWorld(RunJavaScriptParameters&& parameters, std::optional<WebCore::FrameIdentifier> frameID, const std::pair<ContentWorldIdentifier, String>& worldData, CompletionHandler<void(const IPC::DataReference&, const std::optional<WebCore::ExceptionDetails>&)>&& completionHandler)
</span><span class="cx"> {
</span><span class="cx">     WEBPAGE_RELEASE_LOG(Process, "runJavaScriptInFrameInScriptWorld: frameID=%" PRIu64, frameID.value_or(WebCore::FrameIdentifier { }).toUInt64());
</span><del>-    auto webFrame = makeRefPtr(frameID ? WebProcess::singleton().webFrame(*frameID) : &mainWebFrame());
</del><ins>+    RefPtr webFrame = frameID ? WebProcess::singleton().webFrame(*frameID) : &mainWebFrame();
</ins><span class="cx"> 
</span><span class="cx">     if (auto* newWorld = m_userContentController->addContentWorld(worldData)) {
</span><span class="cx">         auto& coreWorld = newWorld->coreWorld();
</span><span class="lines">@@ -3783,7 +3783,7 @@
</span><span class="cx">         break;
</span><span class="cx">     case ContentAsStringIncludesChildFrames::Yes:
</span><span class="cx">         StringBuilder builder;
</span><del>-        for (auto frame = makeRefPtr(m_mainFrame->coreFrame()); frame; frame = frame->tree().traverseNextRendered()) {
</del><ins>+        for (RefPtr frame = m_mainFrame->coreFrame(); frame; frame = frame->tree().traverseNextRendered()) {
</ins><span class="cx">             if (auto webFrame = WebFrame::fromCoreFrame(*frame))
</span><span class="cx">                 builder.append(builder.isEmpty() ? "" : "\n\n", webFrame->contentsAsString());
</span><span class="cx">         }
</span><span class="lines">@@ -4070,8 +4070,8 @@
</span><span class="cx"> 
</span><span class="cx"> void WebPage::removeDataDetectedLinks(CompletionHandler<void(const DataDetectionResult&)>&& completionHandler)
</span><span class="cx"> {
</span><del>-    for (auto frame = makeRefPtr(&m_page->mainFrame()); frame; frame = frame->tree().traverseNext()) {
-        auto document = makeRefPtr(frame->document());
</del><ins>+    for (RefPtr frame = &m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+        RefPtr document = frame->document();
</ins><span class="cx">         if (!document)
</span><span class="cx">             continue;
</span><span class="cx"> 
</span><span class="lines">@@ -4089,8 +4089,8 @@
</span><span class="cx"> void WebPage::detectDataInAllFrames(OptionSet<WebCore::DataDetectorType> dataDetectorTypes, CompletionHandler<void(const DataDetectionResult&)>&& completionHandler)
</span><span class="cx"> {
</span><span class="cx">     DataDetectionResult mainFrameResult;
</span><del>-    for (auto frame = makeRefPtr(&m_page->mainFrame()); frame; frame = frame->tree().traverseNext()) {
-        auto document = makeRefPtr(frame->document());
</del><ins>+    for (RefPtr frame = &m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+        RefPtr document = frame->document();
</ins><span class="cx">         if (!document)
</span><span class="cx">             continue;
</span><span class="cx">         auto results = retainPtr(DataDetection::detectContentInRange(makeRangeSelectingNodeContents(*document), dataDetectorTypes, m_dataDetectionContext.get()));
</span><span class="lines">@@ -7297,7 +7297,7 @@
</span><span class="cx">     if (!m_page)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto mainDocument = makeRefPtr(m_page->mainFrame().document());
</del><ins>+    RefPtr mainDocument = m_page->mainFrame().document();
</ins><span class="cx">     if (!mainDocument)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -7327,7 +7327,7 @@
</span><span class="cx">         return;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    auto mainDocument = makeRefPtr(m_page->mainFrame().document());
</del><ins>+    RefPtr mainDocument = m_page->mainFrame().document();
</ins><span class="cx">     if (!mainDocument) {
</span><span class="cx">         completionHandler(true, { });
</span><span class="cx">         return;
</span><span class="lines">@@ -7470,7 +7470,7 @@
</span><span class="cx">         if (completion) {
</span><span class="cx">             RefPtr<Element> imageOverlayHost;
</span><span class="cx">             if (htmlElement->hasImageOverlay())
</span><del>-                imageOverlayHost = makeRefPtr(element);
</del><ins>+                imageOverlayHost = &element;
</ins><span class="cx">             completion(WTFMove(imageOverlayHost));
</span><span class="cx">         }
</span><span class="cx">         return;
</span><span class="lines">@@ -7517,7 +7517,7 @@
</span><span class="cx">     auto cachedImage = renderImage.cachedImage();
</span><span class="cx">     auto imageURL = cachedImage ? element.document().completeURL(cachedImage->url().string()) : URL { };
</span><span class="cx">     sendWithAsyncReply(Messages::WebPageProxy::RequestTextRecognition(WTFMove(imageURL), WTFMove(bitmapHandle)), [webPage = makeWeakPtr(*this), weakElement = makeWeakPtr(element)] (auto&& result) {
</span><del>-        auto protectedPage = makeRefPtr(webPage.get());
</del><ins>+        RefPtr protectedPage { webPage.get() };
</ins><span class="cx">         if (!protectedPage)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -7531,7 +7531,7 @@
</span><span class="cx">             return true;
</span><span class="cx">         });
</span><span class="cx"> 
</span><del>-        auto protectedElement = makeRefPtr(weakElement.get());
</del><ins>+        RefPtr protectedElement { weakElement.get() };
</ins><span class="cx">         if (!protectedElement)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="lines">@@ -7545,7 +7545,7 @@
</span><span class="cx">         if (matchIndex == notFound)
</span><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        auto imageOverlayHost = htmlElement.hasImageOverlay() ? makeRefPtr(htmlElement) : nullptr;
</del><ins>+        RefPtr imageOverlayHost = htmlElement.hasImageOverlay() ? &htmlElement : nullptr;
</ins><span class="cx">         for (auto& completionHandler : protectedPage->m_elementsPendingTextRecognition[matchIndex].second)
</span><span class="cx">             completionHandler(imageOverlayHost.copyRef());
</span><span class="cx"> 
</span><span class="lines">@@ -7568,7 +7568,7 @@
</span><span class="cx">         HitTestRequest::Type::AllowVisibleChildFrameContentOnly,
</span><span class="cx">     });
</span><span class="cx"> 
</span><del>-    auto nodeAtLocation = makeRefPtr(hitTestResult.innerNonSharedNode());
</del><ins>+    RefPtr nodeAtLocation = hitTestResult.innerNonSharedNode();
</ins><span class="cx">     auto updateResult = ([&] {
</span><span class="cx">         if (!nodeAtLocation || nodeAtLocation->shadowHost() != elementToUpdate || !HTMLElement::isInsideImageOverlay(*nodeAtLocation))
</span><span class="cx">             return TextRecognitionUpdateResult::NoText;
</span><span class="lines">@@ -7657,7 +7657,7 @@
</span><span class="cx"> 
</span><span class="cx">     RefPtr document = CheckedRef(m_page->focusController())->focusedOrMainFrame().document();
</span><span class="cx"> 
</span><del>-    auto frame = makeRefPtr(document->frame());
</del><ins>+    RefPtr frame = document->frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return false;
</span><span class="cx"> 
</span><span class="lines">@@ -7690,7 +7690,7 @@
</span><span class="cx"> {
</span><span class="cx">     m_appHighlightsVisible = appHighlightVisibility;
</span><span class="cx">     for (RefPtr<Frame> frame = m_mainFrame->coreFrame(); frame; frame = frame->tree().traverseNextRendered()) {
</span><del>-        if (auto document = makeRefPtr(frame->document()))
</del><ins>+        if (RefPtr document = frame->document())
</ins><span class="cx">             document->appHighlightRegister().setHighlightVisibility(appHighlightVisibility);
</span><span class="cx">     }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -343,7 +343,7 @@
</span><span class="cx">                 postLayoutData.caretColor = CaretBase::computeCaretColor(editableRoot->renderer()->style(), editableRoot.get());
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        if (auto editableRootOrFormControl = makeRefPtr(enclosingTextFormControl(selection.start()) ?: selection.rootEditableElement())) {
</del><ins>+        if (RefPtr editableRootOrFormControl = enclosingTextFormControl(selection.start()) ?: selection.rootEditableElement()) {
</ins><span class="cx">             postLayoutData.selectionClipRect = rootViewInteractionBounds(*editableRootOrFormControl);
</span><span class="cx">             postLayoutData.editableRootIsTransparentOrFullyClipped = result.isContentEditable && isTransparentOrFullyClipped(*editableRootOrFormControl);
</span><span class="cx">         }
</span><span class="lines">@@ -1345,7 +1345,7 @@
</span><span class="cx"> 
</span><span class="cx"> static bool insideImageOverlay(const VisiblePosition& position)
</span><span class="cx"> {
</span><del>-    auto container = makeRefPtr(position.deepEquivalent().containerNode());
</del><ins>+    RefPtr container = position.deepEquivalent().containerNode();
</ins><span class="cx">     return container && HTMLElement::isInsideImageOverlay(*container);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1355,7 +1355,7 @@
</span><span class="cx">     VisiblePosition expandedEnd(makeContainerOffsetPosition(&range.endContainer(), range.endOffset()));
</span><span class="cx"> 
</span><span class="cx">     for (auto start = expandedStart; insideImageOverlay(start); start = start.previous()) {
</span><del>-        if (auto container = makeRefPtr(start.deepEquivalent().containerNode()); is<Text>(container)) {
</del><ins>+        if (RefPtr container = start.deepEquivalent().containerNode(); is<Text>(container)) {
</ins><span class="cx">             expandedStart = firstPositionInNode(container.get()).downstream();
</span><span class="cx">             break;
</span><span class="cx">         }
</span><span class="lines">@@ -1362,7 +1362,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     for (auto end = expandedEnd; insideImageOverlay(end); end = end.next()) {
</span><del>-        if (auto container = makeRefPtr(end.deepEquivalent().containerNode()); is<Text>(container)) {
</del><ins>+        if (RefPtr container = end.deepEquivalent().containerNode(); is<Text>(container)) {
</ins><span class="cx">             expandedEnd = lastPositionInNode(container.get()).upstream();
</span><span class="cx">             break;
</span><span class="cx">         }
</span><span class="lines">@@ -1540,7 +1540,7 @@
</span><span class="cx">         HitTestRequest::Type::AllowVisibleChildFrameContentOnly,
</span><span class="cx">     });
</span><span class="cx"> 
</span><del>-    auto targetNode = makeRefPtr(hitTest.targetNode());
</del><ins>+    RefPtr targetNode = hitTest.targetNode();
</ins><span class="cx">     if (targetNode && !HTMLElement::shouldExtendSelectionToTargetNode(*targetNode, existingSelection))
</span><span class="cx">         return std::nullopt;
</span><span class="cx"> 
</span><span class="lines">@@ -1555,7 +1555,7 @@
</span><span class="cx">     if (baseIsStart) {
</span><span class="cx">         if (result <= selectionStart)
</span><span class="cx">             result = selectionStart.next();
</span><del>-        else if (auto containerNode = makeRefPtr(selectionStart.deepEquivalent().containerNode()); containerNode && targetNode && &containerNode->treeScope() != &targetNode->treeScope())
</del><ins>+        else if (RefPtr containerNode = selectionStart.deepEquivalent().containerNode(); containerNode && targetNode && &containerNode->treeScope() != &targetNode->treeScope())
</ins><span class="cx">             result = VisibleSelection::adjustPositionForEnd(result.deepEquivalent(), containerNode.get());
</span><span class="cx"> 
</span><span class="cx">         range = makeSimpleRange(selectionStart, result);
</span><span class="lines">@@ -1562,7 +1562,7 @@
</span><span class="cx">     } else {
</span><span class="cx">         if (selectionEnd <= result)
</span><span class="cx">             result = selectionEnd.previous();
</span><del>-        else if (auto containerNode = makeRefPtr(selectionEnd.deepEquivalent().containerNode()); containerNode && targetNode && &containerNode->treeScope() != &targetNode->treeScope())
</del><ins>+        else if (RefPtr containerNode = selectionEnd.deepEquivalent().containerNode(); containerNode && targetNode && &containerNode->treeScope() != &targetNode->treeScope())
</ins><span class="cx">             result = VisibleSelection::adjustPositionForStart(result.deepEquivalent(), containerNode.get());
</span><span class="cx"> 
</span><span class="cx">         range = makeSimpleRange(result, selectionEnd);
</span><span class="lines">@@ -1630,11 +1630,11 @@
</span><span class="cx"> 
</span><span class="cx"> IntRect WebPage::rootViewBounds(const Node& node)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(node.document().frame());
</del><ins>+    RefPtr frame = node.document().frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><del>-    auto view = makeRefPtr(frame->view());
</del><ins>+    RefPtr view = frame->view();
</ins><span class="cx">     if (!view)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><span class="lines">@@ -1647,11 +1647,11 @@
</span><span class="cx"> 
</span><span class="cx"> IntRect WebPage::absoluteInteractionBounds(const Node& node)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(node.document().frame());
</del><ins>+    RefPtr frame = node.document().frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><del>-    auto view = makeRefPtr(frame->view());
</del><ins>+    RefPtr view = frame->view();
</ins><span class="cx">     if (!view)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><span class="lines">@@ -1682,11 +1682,11 @@
</span><span class="cx"> 
</span><span class="cx"> IntRect WebPage::rootViewInteractionBounds(const Node& node)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(node.document().frame());
</del><ins>+    RefPtr frame = node.document().frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><del>-    auto view = makeRefPtr(frame->view());
</del><ins>+    RefPtr view = frame->view();
</ins><span class="cx">     if (!view)
</span><span class="cx">         return { };
</span><span class="cx"> 
</span><span class="lines">@@ -1894,7 +1894,7 @@
</span><span class="cx"> void WebPage::requestEvasionRectsAboveSelection(CompletionHandler<void(const Vector<FloatRect>&)>&& reply)
</span><span class="cx"> {
</span><span class="cx">     Ref frame = CheckedRef(m_page->focusController())->focusedOrMainFrame();
</span><del>-    auto frameView = makeRefPtr(frame->view());
</del><ins>+    RefPtr frameView = frame->view();
</ins><span class="cx">     if (!frameView) {
</span><span class="cx">         reply({ });
</span><span class="cx">         return;
</span><span class="lines">@@ -1973,7 +1973,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     for (auto& node : hitTestedNodes) {
</span><del>-        auto frameView = makeRefPtr(node->document().view());
</del><ins>+        RefPtr frameView = node->document().view();
</ins><span class="cx">         auto* renderer = node->renderer();
</span><span class="cx">         if (!renderer || !frameView)
</span><span class="cx">             continue;
</span><span class="lines">@@ -2717,7 +2717,7 @@
</span><span class="cx"> 
</span><span class="cx"> static void dataDetectorImageOverlayPositionInformation(const HTMLElement& overlayHost, const InteractionInformationRequest& request, InteractionInformationAtPosition& info)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(overlayHost.document().frame());
</del><ins>+    RefPtr frame = overlayHost.document().frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -2891,7 +2891,7 @@
</span><span class="cx">         if (info.isSelectable && !hitNode->isTextNode())
</span><span class="cx">             info.isSelectable = !isAssistableElement(*downcast<Element>(hitNode)) && !rectIsTooBigForSelection(info.bounds, *result.innerNodeFrame());
</span><span class="cx">     }
</span><del>-    for (auto currentNode = makeRefPtr(hitNode); currentNode; currentNode = currentNode->parentOrShadowHostNode()) {
</del><ins>+    for (RefPtr currentNode = hitNode; currentNode; currentNode = currentNode->parentOrShadowHostNode()) {
</ins><span class="cx">         auto* renderer = currentNode->renderer();
</span><span class="cx">         if (!renderer)
</span><span class="cx">             continue;
</span><span class="lines">@@ -2957,11 +2957,11 @@
</span><span class="cx"> 
</span><span class="cx"> static void populateCaretContext(const HitTestResult& hitTestResult, const InteractionInformationRequest& request, InteractionInformationAtPosition& info)
</span><span class="cx"> {
</span><del>-    auto frame = makeRefPtr(hitTestResult.innerNodeFrame());
</del><ins>+    RefPtr frame = hitTestResult.innerNodeFrame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto view = makeRefPtr(frame->view());
</del><ins>+    RefPtr view = frame->view();
</ins><span class="cx">     if (!view)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -3054,7 +3054,7 @@
</span><span class="cx">     if (m_focusedElement)
</span><span class="cx">         focusedElementPositionInformation(*this, *m_focusedElement, request, info);
</span><span class="cx"> 
</span><del>-    auto hitTestNode = makeRefPtr(hitTestResult.innerNonSharedNode());
</del><ins>+    RefPtr hitTestNode = hitTestResult.innerNonSharedNode();
</ins><span class="cx">     if (is<Element>(nodeRespondingToClickEvents)) {
</span><span class="cx">         auto& element = downcast<Element>(*nodeRespondingToClickEvents);
</span><span class="cx">         elementPositionInformation(*this, element, request, hitTestNode.get(), info);
</span><span class="lines">@@ -3114,7 +3114,7 @@
</span><span class="cx">         if (is<RenderImage>(*element.renderer())) {
</span><span class="cx">             URL urlToCopy;
</span><span class="cx">             String titleToCopy;
</span><del>-            if (auto linkElement = makeRefPtr(containingLinkAnchorElement(element))) {
</del><ins>+            if (RefPtr linkElement = containingLinkAnchorElement(element)) {
</ins><span class="cx">                 if (auto url = linkElement->href(); !url.isEmpty() && !url.protocolIsJavaScript()) {
</span><span class="cx">                     urlToCopy = url;
</span><span class="cx">                     titleToCopy = linkElement->attributeWithoutSynchronization(HTMLNames::titleAttr);
</span><span class="lines">@@ -3717,12 +3717,12 @@
</span><span class="cx">     if (m_viewportConfiguration.canIgnoreScalingConstraints())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto mainFrame = makeRefPtr(m_mainFrame->coreFrame());
</del><ins>+    RefPtr mainFrame = m_mainFrame->coreFrame();
</ins><span class="cx">     if (!mainFrame)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto view = makeRefPtr(mainFrame->view());
-    auto mainDocument = makeRefPtr(mainFrame->document());
</del><ins>+    RefPtr view = mainFrame->view();
+    RefPtr mainDocument = mainFrame->document();
</ins><span class="cx">     if (!view || !mainDocument)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -4044,7 +4044,7 @@
</span><span class="cx">         viewportConfigurationChanged();
</span><span class="cx"> 
</span><span class="cx">     double minimumEffectiveDeviceWidthWhenIgnoringScalingConstraints = ([&] {
</span><del>-        auto document = makeRefPtr(frame.document());
</del><ins>+        RefPtr document = frame.document();
</ins><span class="cx">         if (!document)
</span><span class="cx">             return 0;
</span><span class="cx"> 
</span><span class="lines">@@ -4287,7 +4287,7 @@
</span><span class="cx"> void WebPage::updateSelectionWithDelta(int64_t locationDelta, int64_t lengthDelta, CompletionHandler<void()>&& completionHandler)
</span><span class="cx"> {
</span><span class="cx">     Ref frame = CheckedRef(m_page->focusController())->focusedOrMainFrame();
</span><del>-    auto root = makeRefPtr(frame->selection().rootEditableElementOrDocumentElement());
</del><ins>+    RefPtr root = frame->selection().rootEditableElementOrDocumentElement();
</ins><span class="cx">     auto selectionRange = frame->selection().selection().toNormalizedRange();
</span><span class="cx">     if (!root || !selectionRange) {
</span><span class="cx">         completionHandler();
</span><span class="lines">@@ -4369,7 +4369,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     Ref frame = CheckedRef(m_page->focusController())->focusedOrMainFrame();
</span><del>-    makeRefPtr(frame->document())->updateLayoutIgnorePendingStylesheets();
</del><ins>+    RefPtr { frame->document() }->updateLayoutIgnorePendingStylesheets();
</ins><span class="cx"> 
</span><span class="cx">     VisibleSelection selection = frame->selection().selection();
</span><span class="cx"> 
</span><span class="lines">@@ -4635,11 +4635,11 @@
</span><span class="cx">         return true;
</span><span class="cx">     };
</span><span class="cx"> 
</span><del>-    auto startContainer = makeRefPtr(selection.start().containerNode());
</del><ins>+    RefPtr startContainer = selection.start().containerNode();
</ins><span class="cx">     if (scheduleEditorStateUpdateForStartOrEndContainerNodeIfNeeded(startContainer.get()))
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    auto endContainer = makeRefPtr(selection.end().containerNode());
</del><ins>+    RefPtr endContainer = selection.end().containerNode();
</ins><span class="cx">     if (startContainer != endContainer)
</span><span class="cx">         scheduleEditorStateUpdateForStartOrEndContainerNodeIfNeeded(endContainer.get());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPagemacTiledCoreAnimationDrawingAreamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm      2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -413,7 +413,7 @@
</span><span class="cx">     if (m_webPage.firstFlushAfterCommit())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
</del><ins>+    [CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
</ins><span class="cx">         if (Page* corePage = retainedPage->corePage()) {
</span><span class="cx">             if (Frame* coreFrame = retainedPage->mainFrame())
</span><span class="cx">                 corePage->inspectorController().willComposite(*coreFrame);
</span><span class="lines">@@ -420,7 +420,7 @@
</span><span class="cx">         }
</span><span class="cx">     } forPhase:kCATransactionPhasePreCommit];
</span><span class="cx"> 
</span><del>-    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
</del><ins>+    [CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
</ins><span class="cx">         if (Page* corePage = retainedPage->corePage()) {
</span><span class="cx">             if (Frame* coreFrame = retainedPage->mainFrame())
</span><span class="cx">                 corePage->inspectorController().didComposite(*coreFrame);
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPagemacWebPageMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -891,7 +891,7 @@
</span><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     URL absoluteLinkURL = hitTestResult.absoluteLinkURL();
</span><del>-    if (auto urlElement = makeRefPtr(hitTestResult.URLElement()); !absoluteLinkURL.isEmpty() && urlElement) {
</del><ins>+    if (auto urlElement = RefPtr { hitTestResult.URLElement() }; !absoluteLinkURL.isEmpty() && urlElement) {
</ins><span class="cx">         auto elementRange = makeRangeSelectingNodeContents(*urlElement);
</span><span class="cx">         immediateActionResult.linkTextIndicator = TextIndicator::createWithRange(elementRange, indicatorOptions(elementRange), TextIndicatorPresentationTransition::FadeIn);
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/ChangeLog  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2021-09-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop makeRefPtr() and use RefPtr { } directly instead
+        https://bugs.webkit.org/show_bug.cgi?id=230564
+
+        Reviewed by Alex Christensen.
+
+        * DOM/DOM.mm:
+        (-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
+        * WebCoreSupport/WebContextMenuClient.mm:
+        (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
+        * WebCoreSupport/WebDragClient.mm:
+        (WebDragClient::declareAndWriteDragImage):
+        * WebView/WebHTMLRepresentation.mm:
+        (-[WebHTMLRepresentation elementWithName:inForm:]):
+        (-[WebHTMLRepresentation controlsInForm:]):
+        * WebView/WebView.mm:
+        (-[WebView updateTextTouchBar]):
+
</ins><span class="cx"> 2021-09-21  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacDOMDOMmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/DOM/DOM.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/DOM/DOM.mm 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/DOM/DOM.mm    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -584,7 +584,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> {
</span><span class="cx">     auto range = makeSimpleRange(*core(self));
</span><del>-    auto frame = makeRefPtr(range.start.document().frame());
</del><ins>+    RefPtr frame = range.start.document().frame();
</ins><span class="cx">     if (!frame)
</span><span class="cx">         return nil;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebCoreSupportWebContextMenuClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm     2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm        2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -198,11 +198,11 @@
</span><span class="cx">     if (!page)
</span><span class="cx">         return nil;
</span><span class="cx"> 
</span><del>-    auto node = makeRefPtr(page->contextMenuController().context().hitTestResult().innerNode());
</del><ins>+    RefPtr node = page->contextMenuController().context().hitTestResult().innerNode();
</ins><span class="cx">     if (!node)
</span><span class="cx">         return nil;
</span><span class="cx"> 
</span><del>-    auto frameView = makeRefPtr(node->document().view());
</del><ins>+    RefPtr frameView = node->document().view();
</ins><span class="cx">     if (!frameView) {
</span><span class="cx">         // This method shouldn't be called in cases where the controlled node isn't in a rendered view.
</span><span class="cx">         ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebCoreSupportWebDragClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -271,7 +271,7 @@
</span><span class="cx"> 
</span><span class="cx"> void WebDragClient::declareAndWriteDragImage(const String& pasteboardName, Element& element, const URL& url, const String& label, Frame*)
</span><span class="cx"> {
</span><del>-    if (auto frame = makeRefPtr(element.document().frame()))
</del><ins>+    if (RefPtr frame = element.document().frame())
</ins><span class="cx">         frame->editor().writeImageToPasteboard(*Pasteboard::createForDragAndDrop(PagePasteboardContext::create(frame->pageID())), element, url, label);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebViewWebHTMLRepresentationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm   2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm      2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -290,8 +290,8 @@
</span><span class="cx">     ScriptDisallowedScope::InMainThread scriptDisallowedScope;
</span><span class="cx">     AtomString targetName = name;
</span><span class="cx">     for (auto& weakElement : formElement->unsafeAssociatedElements()) {
</span><del>-        auto element = makeRefPtr(weakElement.get());
-        if (element->asFormAssociatedElement()->name() == targetName)
</del><ins>+        RefPtr element { weakElement.get() };
+        if (element && element->asFormAssociatedElement()->name() == targetName)
</ins><span class="cx">             return kit(element.get());
</span><span class="cx">     }
</span><span class="cx">     return nil;
</span><span class="lines">@@ -337,8 +337,8 @@
</span><span class="cx"> 
</span><span class="cx">     ScriptDisallowedScope::InMainThread scriptDisallowedScope;
</span><span class="cx">     auto result = createNSArray(formElement->unsafeAssociatedElements(), [] (auto& weakElement) -> DOMElement * {
</span><del>-        auto coreElement = makeRefPtr(weakElement.get());
-        if (!coreElement->asFormAssociatedElement()->isEnumeratable()) // Skip option elements, other duds
</del><ins>+        RefPtr coreElement { weakElement.get() };
+        if (!coreElement || !coreElement->asFormAssociatedElement()->isEnumeratable()) // Skip option elements, other duds
</ins><span class="cx">             return nil;
</span><span class="cx">         return kit(coreElement.get());
</span><span class="cx">     });
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm    2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -9510,7 +9510,7 @@
</span><span class="cx"> 
</span><span class="cx">                 [_private->_textTouchBarItemController setCurrentTextAlignment:nsTextAlignmentFromRenderStyle(style)];
</span><span class="cx"> 
</span><del>-                auto enclosingListElement = makeRefPtr(enclosingList(selection.start().deprecatedNode()));
</del><ins>+                RefPtr enclosingListElement = enclosingList(selection.start().deprecatedNode());
</ins><span class="cx">                 if (enclosingListElement) {
</span><span class="cx">                     if (is<HTMLUListElement>(*enclosingListElement))
</span><span class="cx">                         [[_private->_textTouchBarItemController webTextListTouchBarViewController] setCurrentListType:WebListType::Unordered];
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Tools/ChangeLog       2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2021-09-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop makeRefPtr() and use RefPtr { } directly instead
+        https://bugs.webkit.org/show_bug.cgi?id=230564
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
+        (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2021-09-21  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFRunLoopcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp (282847 => 282848)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp  2021-09-21 23:02:16 UTC (rev 282847)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp     2021-09-21 23:03:37 UTC (rev 282848)
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx">     RefPtr<RunLoop> runLoop;
</span><span class="cx"> 
</span><span class="cx">     Thread::create("RunLoopThreadTerminationSelfReferenceCleanup", [&] {
</span><del>-        runLoop = makeRefPtr(RunLoop::current());
</del><ins>+        runLoop = &RunLoop::current();
</ins><span class="cx"> 
</span><span class="cx">         // This stores a RunLoop reference in the dispatch queue that will not be released
</span><span class="cx">         // via the usual dispatch, but should still be released upon thread termination.
</span></span></pre>
</div>
</div>

</body>
</html>