<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282703] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282703">282703</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2021-09-17 16:08:52 -0700 (Fri, 17 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>WebKit::WebProcessPool should use a weak observer with CFNotificationCenter
<https://webkit.org/b/230227>
<rdar://problem/83067708>

Reviewed by Darin Adler.

Source/WebKit:

To fix the bug, implement an Objective-C class named
WKProcessPoolWeakObserver which contains an instance variable
holding a WeakPtr<WebProcessPool>, and tell CFNotificationCenter
to hold a weak reference to WKProcessPoolWeakObserver.

Since WKProcessPoolWeakObserver is self-contained within the
source file, it uses the NS_DIRECT_MEMBERS attribute since it
does not require the overhead of dynamic Objective-C method
dispatch.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(-[WKProcessPoolWeakObserver initWithWeakPtr:]): Add.
(-[WKProcessPoolWeakObserver pool]): Add.
- Implement WKProcessPoolWeakObserver class.
- Note that init methods can never be marked as NS_DIRECT, and
  @property statements can't use NS_DIRECT in their declaration,
  so the @property is declared in a category which uses
  NS_DIRECT_MEMBERS.
(WebKit::extractWebProcessPool): Add.
- Static helper method for extracting RefPtr<WebProcessPool>
  from type-punned WKProcessPoolWeakObserver.
(WebKit::WebProcessPool::backlightLevelDidChangeCallback):
(WebKit::WebProcessPool::accessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::colorPreferencesDidChangeCallback):
(WebKit::WebProcessPool::remoteWebInspectorEnabledCallback):
- Clean up function parameter list.
- Use extractWebProcessPool() helper method to get a
  RefPtr<WebProcessPool> from `observer`.
(WebKit::WebProcessPool::addCFNotificationObserver): Add.
(WebKit::WebProcessPool::removeCFNotificationObserver): Add.
- Private helper methods to reduce duplicate code.
- Use m_weakObserver for CFNotificationCenter observer and
  include _CFNotificationObserverIsObjC to fix the bug.
(WebKit::WebProcessPool::registerNotificationObservers):
- Make use of new addCFNotificationObserver() helper method.
- Fixes use of static_cast<CFStringRef> to make code ready for
  ARC by using a __bridge cast or removing the static_cast when
  CFSTR() is used.
(WebKit::WebProcessPool::unregisterNotificationObservers):
- Make use of new removeCFNotificationObserver() helper method.

* UIProcess/WebProcessPool.h:
- Add m_weakObserver instance variable to hold the
  WKProcessPoolWeakObserver object.
(WebKit::WebProcessPool::addCFNotificationObserver): Add.
(WebKit::WebProcessPool::removeCFNotificationObserver): Add.
- Add declarations for new helper methods.
(WebKit::WebProcessPool::backlightLevelDidChangeCallback):
(WebKit::WebProcessPool::accessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
(WebKit::WebProcessPool::colorPreferencesDidChangeCallback):
(WebKit::WebProcessPool::remoteWebInspectorEnabledCallback):
- Clean up function parameter list.

Source/WTF:

Tests (API):
    TestWTF.TypeCastsNS.checked_ns_cast
    TestWTF.TypeCastsNS.dynamic_ns_cast
    TestWTF.TypeCastsNS.dynamic_ns_cast_RetainPtr

* WTF.xcodeproj/project.pbxproj:
* wtf/PlatformMac.cmake:
- Add new header files to the project.

* wtf/cocoa/TypeCastsNS.h: Add.
(WTF::checked_ns_cast):
(WTF::dynamic_ns_cast):
- Add casts for NS objects similar to TypeCastsCF.h.

* wtf/PlatformHave.h:
(HAVE_NS_DIRECT_SUPPORT): Add.
- Note that clang for macOS 11 Big Sur claims to know about the
  attributes, but will fail to compile if they are actually
  used.

* wtf/spi/cocoa/NSObjCRuntimeSPI.h: Add.
(NS_DIRECT):
(NS_DIRECT_MEMBERS):
- Define compiler attributes for direct dispatch of Objective-C
  methods.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Add TypeCastsNS.mm to the project.
* TestWebKitAPI/Tests/WTF/cocoa/TypeCastsNS.mm: Add.
(TestWebKitAPI::TEST): Add tests for <wtf/TypeCastsNS.h>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (282702 => 282703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-09-17 23:02:17 UTC (rev 282702)
+++ trunk/Source/WTF/ChangeLog  2021-09-17 23:08:52 UTC (rev 282703)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2021-09-16  David Kilzer  <ddkilzer@apple.com>
+
+        WebKit::WebProcessPool should use a weak observer with CFNotificationCenter
+        <https://webkit.org/b/230227>
+        <rdar://problem/83067708>
+
+        Reviewed by Darin Adler.
+
+        Tests (API):
+            TestWTF.TypeCastsNS.checked_ns_cast
+            TestWTF.TypeCastsNS.dynamic_ns_cast
+            TestWTF.TypeCastsNS.dynamic_ns_cast_RetainPtr
+
+        * WTF.xcodeproj/project.pbxproj:
+        * wtf/PlatformMac.cmake:
+        - Add new header files to the project.
+
+        * wtf/cocoa/TypeCastsNS.h: Add.
+        (WTF::checked_ns_cast):
+        (WTF::dynamic_ns_cast):
+        - Add casts for NS objects similar to TypeCastsCF.h.
+
+        * wtf/PlatformHave.h:
+        (HAVE_NS_DIRECT_SUPPORT): Add.
+        - Note that clang for macOS 11 Big Sur claims to know about the
+          attributes, but will fail to compile if they are actually
+          used.
+
+        * wtf/spi/cocoa/NSObjCRuntimeSPI.h: Add.
+        (NS_DIRECT):
+        (NS_DIRECT_MEMBERS):
+        - Define compiler attributes for direct dispatch of Objective-C
+          methods.
+
</ins><span class="cx"> 2021-09-17  Tim Horton  <timothy_horton@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Enable UseCGDisplayListsForDOMRendering by default where it is available
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (282702 => 282703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-09-17 23:02:17 UTC (rev 282702)
+++ trunk/Source/WebKit/ChangeLog       2021-09-17 23:08:52 UTC (rev 282703)
</span><span class="lines">@@ -1,3 +1,66 @@
</span><ins>+2021-09-16  David Kilzer  <ddkilzer@apple.com>
+
+        WebKit::WebProcessPool should use a weak observer with CFNotificationCenter
+        <https://webkit.org/b/230227>
+        <rdar://problem/83067708>
+
+        Reviewed by Darin Adler.
+
+        To fix the bug, implement an Objective-C class named
+        WKProcessPoolWeakObserver which contains an instance variable
+        holding a WeakPtr<WebProcessPool>, and tell CFNotificationCenter
+        to hold a weak reference to WKProcessPoolWeakObserver.
+
+        Since WKProcessPoolWeakObserver is self-contained within the
+        source file, it uses the NS_DIRECT_MEMBERS attribute since it
+        does not require the overhead of dynamic Objective-C method
+        dispatch.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (-[WKProcessPoolWeakObserver initWithWeakPtr:]): Add.
+        (-[WKProcessPoolWeakObserver pool]): Add.
+        - Implement WKProcessPoolWeakObserver class.
+        - Note that init methods can never be marked as NS_DIRECT, and
+          @property statements can't use NS_DIRECT in their declaration,
+          so the @property is declared in a category which uses
+          NS_DIRECT_MEMBERS.
+        (WebKit::extractWebProcessPool): Add.
+        - Static helper method for extracting RefPtr<WebProcessPool>
+          from type-punned WKProcessPoolWeakObserver.
+        (WebKit::WebProcessPool::backlightLevelDidChangeCallback):
+        (WebKit::WebProcessPool::accessibilityPreferencesChangedCallback):
+        (WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+        (WebKit::WebProcessPool::colorPreferencesDidChangeCallback):
+        (WebKit::WebProcessPool::remoteWebInspectorEnabledCallback):
+        - Clean up function parameter list.
+        - Use extractWebProcessPool() helper method to get a
+          RefPtr<WebProcessPool> from `observer`.
+        (WebKit::WebProcessPool::addCFNotificationObserver): Add.
+        (WebKit::WebProcessPool::removeCFNotificationObserver): Add.
+        - Private helper methods to reduce duplicate code.
+        - Use m_weakObserver for CFNotificationCenter observer and
+          include _CFNotificationObserverIsObjC to fix the bug.
+        (WebKit::WebProcessPool::registerNotificationObservers):
+        - Make use of new addCFNotificationObserver() helper method.
+        - Fixes use of static_cast<CFStringRef> to make code ready for
+          ARC by using a __bridge cast or removing the static_cast when
+          CFSTR() is used.
+        (WebKit::WebProcessPool::unregisterNotificationObservers):
+        - Make use of new removeCFNotificationObserver() helper method.
+
+        * UIProcess/WebProcessPool.h:
+        - Add m_weakObserver instance variable to hold the
+          WKProcessPoolWeakObserver object.
+        (WebKit::WebProcessPool::addCFNotificationObserver): Add.
+        (WebKit::WebProcessPool::removeCFNotificationObserver): Add.
+        - Add declarations for new helper methods.
+        (WebKit::WebProcessPool::backlightLevelDidChangeCallback):
+        (WebKit::WebProcessPool::accessibilityPreferencesChangedCallback):
+        (WebKit::WebProcessPool::mediaAccessibilityPreferencesChangedCallback):
+        (WebKit::WebProcessPool::colorPreferencesDidChangeCallback):
+        (WebKit::WebProcessPool::remoteWebInspectorEnabledCallback):
+        - Clean up function parameter list.
+
</ins><span class="cx"> 2021-09-17  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed build fix.
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (282702 => 282703)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-09-17 23:02:17 UTC (rev 282702)
+++ trunk/Tools/ChangeLog       2021-09-17 23:08:52 UTC (rev 282703)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2021-09-16  David Kilzer  <ddkilzer@apple.com>
+
+        WebKit::WebProcessPool should use a weak observer with CFNotificationCenter
+        <https://webkit.org/b/230227>
+        <rdar://problem/83067708>
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        - Add TypeCastsNS.mm to the project.
+        * TestWebKitAPI/Tests/WTF/cocoa/TypeCastsNS.mm: Add.
+        (TestWebKitAPI::TEST): Add tests for <wtf/TypeCastsNS.h>.
+
</ins><span class="cx"> 2021-09-17  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION: [ iOS ] 5 TestWebKitAPI.WebpagePreferences.* api tests are flaky timing out
</span></span></pre>
</div>
</div>

</body>
</html>