<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282469] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282469">282469</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-09-15 13:18:25 -0700 (Wed, 15 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Avoid GCC warnings introduced in <a href="http://trac.webkit.org/projects/webkit/changeset/282125">r282125</a>
https://bugs.webkit.org/show_bug.cgi?id=230154

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2021-09-15
Reviewed by Fujii Hironori.

Yusuke suggested casting to UChar to avoid -Wswitch-out-of-range. This works!

Also, avoid -Wredundant-move by removing one unnecessary WTFMove.

* runtime/ISO8601.cpp:
(JSC::ISO8601::parseTimeZoneBracketedAnnotation):
(JSC::ISO8601::canBeTimeZone):
(JSC::ISO8601::parseTimeZone):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeISO8601cpp">trunk/Source/JavaScriptCore/runtime/ISO8601.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (282468 => 282469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2021-09-15 20:17:05 UTC (rev 282468)
+++ trunk/Source/JavaScriptCore/ChangeLog       2021-09-15 20:18:25 UTC (rev 282469)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2021-09-15  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Avoid GCC warnings introduced in r282125
+        https://bugs.webkit.org/show_bug.cgi?id=230154
+
+        Reviewed by Fujii Hironori.
+
+        Yusuke suggested casting to UChar to avoid -Wswitch-out-of-range. This works!
+
+        Also, avoid -Wredundant-move by removing one unnecessary WTFMove.
+
+        * runtime/ISO8601.cpp:
+        (JSC::ISO8601::parseTimeZoneBracketedAnnotation):
+        (JSC::ISO8601::canBeTimeZone):
+        (JSC::ISO8601::parseTimeZone):
+
</ins><span class="cx"> 2021-09-15  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [JSC] Optimize leaf object creation in JSON.parse
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeISO8601cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ISO8601.cpp (282468 => 282469)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ISO8601.cpp  2021-09-15 20:17:05 UTC (rev 282468)
+++ trunk/Source/JavaScriptCore/runtime/ISO8601.cpp     2021-09-15 20:18:25 UTC (rev 282469)
</span><span class="lines">@@ -448,7 +448,7 @@
</span><span class="cx">         return std::nullopt;
</span><span class="cx">     buffer.advance();
</span><span class="cx"> 
</span><del>-    switch (*buffer) {
</del><ins>+    switch (static_cast<UChar>(*buffer)) {
</ins><span class="cx">     case '+':
</span><span class="cx">     case '-':
</span><span class="cx">     case minusSign: {
</span><span class="lines">@@ -576,7 +576,7 @@
</span><span class="cx">         if (*buffer != ']')
</span><span class="cx">             return std::nullopt;
</span><span class="cx">         buffer.advance();
</span><del>-        return WTFMove(result);
</del><ins>+        return result;
</ins><span class="cx">     }
</span><span class="cx">     }
</span><span class="cx"> }
</span><span class="lines">@@ -584,7 +584,7 @@
</span><span class="cx"> template<typename CharacterType>
</span><span class="cx"> static bool canBeTimeZone(const StringParsingBuffer<CharacterType>& buffer, CharacterType character)
</span><span class="cx"> {
</span><del>-    switch (character) {
</del><ins>+    switch (static_cast<UChar>(character)) {
</ins><span class="cx">     // UTCDesignator
</span><span class="cx">     // https://tc39.es/proposal-temporal/#prod-UTCDesignator
</span><span class="cx">     case 'z':
</span><span class="lines">@@ -615,7 +615,7 @@
</span><span class="cx"> {
</span><span class="cx">     if (buffer.atEnd())
</span><span class="cx">         return std::nullopt;
</span><del>-    switch (*buffer) {
</del><ins>+    switch (static_cast<UChar>(*buffer)) {
</ins><span class="cx">     // UTCDesignator
</span><span class="cx">     // https://tc39.es/proposal-temporal/#prod-UTCDesignator
</span><span class="cx">     case 'z':
</span></span></pre>
</div>
</div>

</body>
</html>