<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282314] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282314">282314</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2021-09-11 17:32:08 -0700 (Sat, 11 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove support for -[WKWebView _needsSiteSpecificViewportQuirks]
https://bugs.webkit.org/show_bug.cgi?id=230193

Reviewed by Tim Horton.

This SPI is no longer needed; for the brief moment it existed, it was only used to allow Safari's lowered bar
(which previously overlapped page content) to additionally apply obscured bottom insets on a handful of
webpages.

This method has no internal clients (including Safari).

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _needsSiteSpecificViewportQuirks]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessTermination):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/WebPage.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPICocoaWKWebViewmm">trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPICocoaWKWebViewPrivateh">trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxycpp">trunk/Source/WebKit/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxyh">trunk/Source/WebKit/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxymessagesin">trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageWebPagecpp">trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageWebPageh">trunk/Source/WebKit/WebProcess/WebPage/WebPage.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/ChangeLog       2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2021-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Remove support for -[WKWebView _needsSiteSpecificViewportQuirks]
+        https://bugs.webkit.org/show_bug.cgi?id=230193
+
+        Reviewed by Tim Horton.
+
+        This SPI is no longer needed; for the brief moment it existed, it was only used to allow Safari's lowered bar
+        (which previously overlapped page content) to additionally apply obscured bottom insets on a handful of
+        webpages.
+
+        This method has no internal clients (including Safari).
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _needsSiteSpecificViewportQuirks]): Deleted.
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::resetStateAfterProcessTermination):
+        * UIProcess/WebPageProxy.h:
+        * UIProcess/WebPageProxy.messages.in:
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::didCommitLoad):
+        * WebProcess/WebPage/WebPage.h:
+
</ins><span class="cx"> 2021-09-11  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         CFNotificationCenterAddObserver() should use weak observers
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPICocoaWKWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm     2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm        2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -2527,11 +2527,6 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-- (BOOL)_needsSiteSpecificViewportQuirks
-{
-    return _page && _page->needsSiteSpecificViewportQuirks();
-}
-
</del><span class="cx"> - (pid_t)_webProcessIdentifier
</span><span class="cx"> {
</span><span class="cx">     if (![self _isValid])
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPICocoaWKWebViewPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h       2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h  2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -412,8 +412,6 @@
</span><span class="cx"> - (void)_suspendPage:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macos(12.0), ios(15.0));
</span><span class="cx"> - (void)_resumePage:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macos(12.0), ios(15.0));
</span><span class="cx"> 
</span><del>-@property (nonatomic, readonly) BOOL _needsSiteSpecificViewportQuirks WK_API_AVAILABLE(macos(12.0), ios(15.0));
-
</del><span class="cx"> @end
</span><span class="cx"> 
</span><span class="cx"> #if TARGET_OS_IPHONE
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp   2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp      2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -7730,8 +7730,6 @@
</span><span class="cx">         if (auto* automationSession = process().processPool().automationSession())
</span><span class="cx">             automationSession->terminate();
</span><span class="cx">     }
</span><del>-
-    m_needsSiteSpecificViewportQuirks = true;
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void WebPageProxy::provisionalProcessDidTerminate()
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.h     2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h        2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -1971,9 +1971,6 @@
</span><span class="cx">     WKQuickLookPreviewController *quickLookPreviewController() const { return m_quickLookPreviewController.get(); }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    bool needsSiteSpecificViewportQuirks() const { return m_needsSiteSpecificViewportQuirks; }
-    void setNeedsSiteSpecificViewportQuirks(bool value) { m_needsSiteSpecificViewportQuirks = value; }
-
</del><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx">     bool isQuarantinedAndNotUserApproved(const String&);
</span><span class="cx"> #endif
</span><span class="lines">@@ -3100,8 +3097,6 @@
</span><span class="cx">     RetainPtr<WKQuickLookPreviewController> m_quickLookPreviewController;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    bool m_needsSiteSpecificViewportQuirks { true };
-
</del><span class="cx">     WindowKind m_windowKind { WindowKind::Unparented };
</span><span class="cx"> };
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxymessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in   2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in      2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -414,8 +414,6 @@
</span><span class="cx">     ShowDataDetectorsUIForPositionInformation(struct WebKit::InteractionInformationAtPosition information)
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    SetNeedsSiteSpecificViewportQuirks(bool value)
-
</del><span class="cx">     DidChangeInspectorFrontendCount(uint64_t count)
</span><span class="cx"> 
</span><span class="cx">     CreateInspectorTarget(String targetId, enum:uint8_t Inspector::InspectorTargetType type)
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp       2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp  2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -6321,12 +6321,6 @@
</span><span class="cx">     if (!frame->isMainFrame())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    bool needsSiteSpecificViewportQuirks = frame->coreFrame()->settings().needsSiteSpecificQuirks();
-    if (m_needsSiteSpecificViewportQuirks != needsSiteSpecificViewportQuirks) {
-        m_needsSiteSpecificViewportQuirks = needsSiteSpecificViewportQuirks;
-        send(Messages::WebPageProxy::SetNeedsSiteSpecificViewportQuirks(needsSiteSpecificViewportQuirks));
-    }
-
</del><span class="cx">     if (m_drawingArea)
</span><span class="cx">         m_drawingArea->sendEnterAcceleratedCompositingModeIfNeeded();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageWebPageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (282313 => 282314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2021-09-11 19:24:11 UTC (rev 282313)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h    2021-09-12 00:32:08 UTC (rev 282314)
</span><span class="lines">@@ -2376,8 +2376,6 @@
</span><span class="cx"> #if ENABLE(APP_HIGHLIGHTS)
</span><span class="cx">     WebCore::HighlightVisibility m_appHighlightsVisible { WebCore::HighlightVisibility::Hidden };
</span><span class="cx"> #endif
</span><del>-
-    bool m_needsSiteSpecificViewportQuirks { true };
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> #if !PLATFORM(IOS_FAMILY)
</span></span></pre>
</div>
</div>

</body>
</html>