<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282133] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282133">282133</a></dd>
<dt>Author</dt> <dd>ntim@apple.com</dd>
<dt>Date</dt> <dd>2021-09-08 00:48:29 -0700 (Wed, 08 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Support animations on ::backdrop
https://bugs.webkit.org/show_bug.cgi?id=229042

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html: Added.
* web-platform-tests/css/css-pseudo/backdrop-animate-002.html: Added.
* web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt: Added.
* web-platform-tests/css/css-pseudo/backdrop-animate.html: Added.

Source/WebCore:

* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):

LayoutTests:

* TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorestyleStyleTreeResolvercpp">trunk/Source/WebCore/style/StyleTreeResolver.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimate002expectedhtml">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimate002html">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimateexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimatehtml">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (282132 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-09-08 07:39:41 UTC (rev 282132)
+++ trunk/LayoutTests/ChangeLog 2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-09-08  Tim Nguyen  <ntim@apple.com>
+
+        Support animations on ::backdrop
+        https://bugs.webkit.org/show_bug.cgi?id=229042
+
+        Reviewed by Antoine Quint.
+
+        * TestExpectations:
+
</ins><span class="cx"> 2021-09-08  Kimmo Kinnunen  <kkinnunen@apple.com>
</span><span class="cx"> 
</span><span class="cx">         webgl/2.0.y/deqp/functional/gles3/rbostatequery.html fails on Metal
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (282132 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations       2021-09-08 07:39:41 UTC (rev 282132)
+++ trunk/LayoutTests/TestExpectations  2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -5066,3 +5066,4 @@
</span><span class="cx"> webkit.org/b/229727 imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-var.html [ Skip ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/229975 fast/text/FontFaceSet-status-after-style-update.html [ Failure Pass ]
</span><ins>+webkit.org/b/230008 imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html [ ImageOnlyFailure ]
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282132 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-08 07:39:41 UTC (rev 282132)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2021-09-08  Tim Nguyen  <ntim@apple.com>
+
+        Support animations on ::backdrop
+        https://bugs.webkit.org/show_bug.cgi?id=229042
+
+        Reviewed by Antoine Quint.
+
+        * web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html: Added.
+        * web-platform-tests/css/css-pseudo/backdrop-animate-002.html: Added.
+        * web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt: Added.
+        * web-platform-tests/css/css-pseudo/backdrop-animate.html: Added.
+
</ins><span class="cx"> 2021-09-07  Sihui Liu  <sihui_liu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add basic support for Storage API
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimate002expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html (0 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html                              (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002-expected.html 2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<!DOCTYPE html>
+<meta charset="utf-8">
+<dialog id="target">Dialog contents</dialog>
+<style>
+#target::backdrop {
+  opacity: 0.1;
+  background-color: green;
+}
+</style>
+<script>
+const target = document.getElementById("target");
+target.showModal();
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimate002html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html (0 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html                               (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html  2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Test: A Web Animations on ::backdrop</title>
+<link rel="help" href="https://fullscreen.spec.whatwg.org/#::backdrop-pseudo-element">
+<link rel="match" href="backdrop-animate-002-ref.html">
+<dialog id="target">Dialog contents</dialog>
+<script>
+const target = document.getElementById("target");
+target.showModal();
+target.animate({
+  opacity: [0.1, 0.1],
+  backgroundColor: ["green", "green"]
+}, {
+  pseudoElement: "::backdrop",
+  duration: Infinity
+});
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimateexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt (0 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt                           (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-expected.txt      2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+
+PASS 'backgroundColor' animation
+Dialog contents
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspseudobackdropanimatehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate.html (0 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate.html                           (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate.html      2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -0,0 +1,29 @@
</span><ins>+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Pseudo-Elements Test: ::backdrop & web animations</title>
+<link rel="help" href="https://fullscreen.spec.whatwg.org/#::backdrop-pseudo-element">
+<link rel="help" href="https://drafts.csswg.org/web-animations-1/">
+<meta name="assert" content="This test checks that ::backdrop can be animated with Web Animations." />
+<div id="log"></div>
+<dialog id="target">Dialog contents</dialog>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+const target = document.getElementById("target");
+target.showModal();
+
+test(function() {
+  const options = {
+    pseudoElement: "::backdrop",
+    duration: 2,
+    delay: -1,
+  };
+  const cs = getComputedStyle(target, "::backdrop");
+  const anim = target.animate([
+    {backgroundColor: "rgb(0, 100, 200)"},
+    {backgroundColor: "rgb(200, 0, 100)"},
+  ], options);
+  this.add_cleanup(() => anim.cancel());
+  assert_equals(cs.backgroundColor, "rgb(100, 50, 150)", "background-color");
+}, "'backgroundColor' animation");
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (282132 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-09-08 07:39:41 UTC (rev 282132)
+++ trunk/Source/WebCore/ChangeLog      2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-09-08  Tim Nguyen  <ntim@apple.com>
+
+        Support animations on ::backdrop
+        https://bugs.webkit.org/show_bug.cgi?id=229042
+
+        Reviewed by Antoine Quint.
+
+        * style/StyleTreeResolver.cpp:
+        (WebCore::Style::TreeResolver::resolveElement):
+        (WebCore::Style::TreeResolver::resolvePseudoStyle):
+
</ins><span class="cx"> 2021-09-08  Kimmo Kinnunen  <kkinnunen@apple.com>
</span><span class="cx"> 
</span><span class="cx">         webgl/2.0.y/deqp/functional/gles3/rbostatequery.html fails on Metal
</span></span></pre></div>
<a id="trunkSourceWebCorestyleStyleTreeResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (282132 => 282133)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/StyleTreeResolver.cpp 2021-09-08 07:39:41 UTC (rev 282132)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp    2021-09-08 07:48:29 UTC (rev 282133)
</span><span class="lines">@@ -259,6 +259,8 @@
</span><span class="cx">         pseudoUpdates.set(PseudoId::Before, WTFMove(*beforeElementUpdate));
</span><span class="cx">     if (auto afterElementUpdate = resolvePseudoStyle(element, update, PseudoId::After))
</span><span class="cx">         pseudoUpdates.set(PseudoId::After, WTFMove(*afterElementUpdate));
</span><ins>+    if (auto backdropElementUpdate = resolvePseudoStyle(element, update, PseudoId::Backdrop))
+        pseudoUpdates.set(PseudoId::Backdrop, WTFMove(*backdropElementUpdate));
</ins><span class="cx"> 
</span><span class="cx"> #if ENABLE(TOUCH_ACTION_REGIONS)
</span><span class="cx">     // FIXME: Track this exactly.
</span><span class="lines">@@ -275,8 +277,8 @@
</span><span class="cx"> 
</span><span class="cx"> std::optional<ElementUpdate> TreeResolver::resolvePseudoStyle(Element& element, const ElementUpdate& elementUpdate, PseudoId pseudoId)
</span><span class="cx"> {
</span><del>-    ASSERT(pseudoId != PseudoId::Backdrop, "This method does not handle ::backdrop currently");
-
</del><ins>+    if (pseudoId == PseudoId::Backdrop && !element.isInTopLayer())
+        return { };
</ins><span class="cx">     if (pseudoId == PseudoId::Marker && elementUpdate.style->display() != DisplayType::ListItem)
</span><span class="cx">         return { };
</span><span class="cx">     if (elementUpdate.style->display() == DisplayType::None)
</span></span></pre>
</div>
</div>

</body>
</html>