<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[282137] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/282137">282137</a></dd>
<dt>Author</dt> <dd>jya@apple.com</dd>
<dt>Date</dt> <dd>2021-09-08 04:01:18 -0700 (Wed, 08 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Safari TP 131 audio canPlayType() reports false negatives
https://bugs.webkit.org/show_bug.cgi?id=229799
rdar://problem/82776747

Reviewed by Youenn Fablet.

Source/WebCore:

webaudio now supports the same webm content as the video and audio element,
making this workaround no longer necessary.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType const): Remove work around
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webMParserEnabled const): Remove now unused method.

Source/WebKit:

* Shared/WebPreferencesDefaultValues.cpp:
* Shared/WebPreferencesDefaultValues.h: Remove no longer used method.

Source/WebKitLegacy/mac:

* WebView/WebPreferencesDefaultValues.h:
* WebView/WebPreferencesDefaultValues.mm: Remove no longer used method.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml: Remove preference.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml">trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepageRuntimeEnabledFeaturesh">trunk/Source/WebCore/page/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitSharedWebPreferencesDefaultValuescpp">trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp</a></li>
<li><a href="#trunkSourceWebKitSharedWebPreferencesDefaultValuesh">trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h</a></li>
<li><a href="#trunkSourceWebKitLegacymacChangeLog">trunk/Source/WebKitLegacy/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebViewWebPreferencesDefaultValuesh">trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h</a></li>
<li><a href="#trunkSourceWebKitLegacymacWebViewWebPreferencesDefaultValuesmm">trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WTF/ChangeLog  2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2021-09-08  Jean-Yves Avenard  <jya@apple.com>
+
+        Safari TP 131 audio canPlayType() reports false negatives
+        https://bugs.webkit.org/show_bug.cgi?id=229799
+        rdar://problem/82776747
+
+        Reviewed by Youenn Fablet.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml: Remove preference.
+
</ins><span class="cx"> 2021-09-07  Sihui Liu  <sihui_liu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add basic support for Storage API
</span></span></pre></div>
<a id="trunkSourceWTFScriptsPreferencesWebPreferencesExperimentalyaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml     2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml        2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1366,18 +1366,6 @@
</span><span class="cx">     WebKit:
</span><span class="cx">       default: WebKit::defaultWebMParserEnabled()
</span><span class="cx"> 
</span><del>-WebMWebAudioEnabled:
-  type: bool
-  webcoreBinding: RuntimeEnabledFeatures
-  humanReadableName: "WebM Web Audio"
-  humanReadableDescription: "Enable WebM Web Audio"
-  condition: ENABLE(MEDIA_SOURCE)
-  defaultValue:
-    WebKitLegacy:
-      default: WebKit::defaultWebMWebAudioEnabled()
-    WebKit:
-      default: WebKit::defaultWebMWebAudioEnabled()
-
</del><span class="cx"> # FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
</span><span class="cx"> WebRTCH264LowLatencyEncoderEnabled:
</span><span class="cx">   type: bool
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/ChangeLog      2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2021-09-08  Jean-Yves Avenard  <jya@apple.com>
+
+        Safari TP 131 audio canPlayType() reports false negatives
+        https://bugs.webkit.org/show_bug.cgi?id=229799
+        rdar://problem/82776747
+
+        Reviewed by Youenn Fablet.
+
+        webaudio now supports the same webm content as the video and audio element,
+        making this workaround no longer necessary.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::canPlayType const): Remove work around
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::webMParserEnabled const): Remove now unused method.
+
</ins><span class="cx"> 2021-09-08  Kimmo Kinnunen  <kkinnunen@apple.com>
</span><span class="cx"> 
</span><span class="cx">         webgl/2.0.y/deqp/functional/gles3/negativeshaderapi.html fails on Metal
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp   2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp      2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1061,15 +1061,6 @@
</span><span class="cx">     return m_networkState;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-static inline bool webMWebAudioEnabled()
-{
-#if ENABLE(MEDIA_SOURCE)
-    return RuntimeEnabledFeatures::sharedFeatures().webMWebAudioEnabled();
-#else
-    return false;
-#endif
-}
-
</del><span class="cx"> String HTMLMediaElement::canPlayType(const String& mimeType) const
</span><span class="cx"> {
</span><span class="cx">     MediaEngineSupportParameters parameters;
</span><span class="lines">@@ -1079,14 +1070,6 @@
</span><span class="cx">     MediaPlayer::SupportsType support = MediaPlayer::supportsType(parameters);
</span><span class="cx">     String canPlay;
</span><span class="cx"> 
</span><del>-#if PLATFORM(COCOA)
-    // Temporarily work around bug 226922. For now claim that the opus and vorbis codecs aren't supported
-    // so that sites relying on this test to determine if webaudio use of opus or vorbis won't error.
-    auto codecs = contentType.codecs();
-    if (support == MediaPlayer::SupportsType::IsSupported && ((codecs.contains("opus") || codecs.contains("vorbis")) && !webMWebAudioEnabled()))
-        support = MediaPlayer::SupportsType::IsNotSupported;
-#endif
-
</del><span class="cx">     // 4.8.10.3
</span><span class="cx">     switch (support)
</span><span class="cx">     {
</span></span></pre></div>
<a id="trunkSourceWebCorepageRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h       2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h  2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -235,8 +235,6 @@
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><span class="cx">     void setWebMParserEnabled(bool isEnabled) { m_webMParserEnabled = isEnabled; }
</span><span class="cx">     bool webMParserEnabled() const { return m_webMParserEnabled; }
</span><del>-    void setWebMWebAudioEnabled(bool isEnabled) { m_webMWebAudioEnabled = isEnabled; }
-    bool webMWebAudioEnabled() const { return m_webMWebAudioEnabled; }
</del><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> #if HAVE(CELESTIAL)
</span><span class="lines">@@ -377,7 +375,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><span class="cx">     bool m_webMParserEnabled { false };
</span><del>-    bool m_webMWebAudioEnabled { false };
</del><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> #if HAVE(CELESTIAL)
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/ChangeLog       2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-09-08  Jean-Yves Avenard  <jya@apple.com>
+
+        Safari TP 131 audio canPlayType() reports false negatives
+        https://bugs.webkit.org/show_bug.cgi?id=229799
+        rdar://problem/82776747
+
+        Reviewed by Youenn Fablet.
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        * Shared/WebPreferencesDefaultValues.h: Remove no longer used method.
+
</ins><span class="cx"> 2021-09-07  Sihui Liu  <sihui_liu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add basic support for Storage API
</span></span></pre></div>
<a id="trunkSourceWebKitSharedWebPreferencesDefaultValuescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp       2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp  2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -314,11 +314,6 @@
</span><span class="cx">     return isFeatureFlagEnabled("webm_parser", true);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool defaultWebMWebAudioEnabled()
-{
-    return isFeatureFlagEnabled("webm_webaudio", false);
-}
-
</del><span class="cx"> #endif // ENABLE(MEDIA_SOURCE)
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(MEDIA_SESSION_COORDINATOR)
</span></span></pre></div>
<a id="trunkSourceWebKitSharedWebPreferencesDefaultValuesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h    2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -103,7 +103,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><span class="cx"> bool defaultWebMParserEnabled();
</span><del>-bool defaultWebMWebAudioEnabled();
</del><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(MEDIA_SESSION_COORDINATOR)
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/ChangeLog  2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog     2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-09-08  Jean-Yves Avenard  <jya@apple.com>
+
+        Safari TP 131 audio canPlayType() reports false negatives
+        https://bugs.webkit.org/show_bug.cgi?id=229799
+        rdar://problem/82776747
+
+        Reviewed by Youenn Fablet.
+
+        * WebView/WebPreferencesDefaultValues.h:
+        * WebView/WebPreferencesDefaultValues.mm: Remove no longer used method.
+
</ins><span class="cx"> 2021-09-07  Sihui Liu  <sihui_liu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add basic support for Storage API
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebViewWebPreferencesDefaultValuesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h      2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -83,7 +83,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><span class="cx"> bool defaultWebMParserEnabled();
</span><del>-bool defaultWebMWebAudioEnabled();
</del><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(VP9)
</span></span></pre></div>
<a id="trunkSourceWebKitLegacymacWebViewWebPreferencesDefaultValuesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (282136 => 282137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm     2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm        2021-09-08 11:01:18 UTC (rev 282137)
</span><span class="lines">@@ -282,11 +282,6 @@
</span><span class="cx">     return isFeatureFlagEnabled("webm_parser", true);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool defaultWebMWebAudioEnabled()
-{
-    return isFeatureFlagEnabled("webm_webaudio", false);
-}
-
</del><span class="cx"> #endif // ENABLE(MEDIA_SOURCE)
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(VP9)
</span></span></pre>
</div>
</div>

</body>
</html>