<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281856] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281856">281856</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-09-01 10:16:48 -0700 (Wed, 01 Sep 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[RunBindingsTests] Invoke with Python 3
https://bugs.webkit.org/show_bug.cgi?id=229724

Patch by Kevin Neal <kevin_neal@apple.com> on 2021-09-01
Reviewed by Darin Adler.

* CISupport/build-webkit-org/steps.py:
(RunBindingsTests):
* CISupport/ews-build/steps.py:
(RunBindingsTests):
* CISupport/ews-build/steps_unittest.py:
* Scripts/run-bindings-tests:
(main): Deleted.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsCISupportbuildwebkitorgstepspy">trunk/Tools/CISupport/build-webkit-org/steps.py</a></li>
<li><a href="#trunkToolsCISupportbuildwebkitorgsteps_unittestpy">trunk/Tools/CISupport/build-webkit-org/steps_unittest.py</a></li>
<li><a href="#trunkToolsCISupportewsbuildstepspy">trunk/Tools/CISupport/ews-build/steps.py</a></li>
<li><a href="#trunkToolsCISupportewsbuildsteps_unittestpy">trunk/Tools/CISupport/ews-build/steps_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunbindingstests">trunk/Tools/Scripts/run-bindings-tests</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsCISupportbuildwebkitorgstepspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/build-webkit-org/steps.py  2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py     2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -863,7 +863,7 @@
</span><span class="cx">     name = "bindings-generation-tests"
</span><span class="cx">     description = ["bindings-tests running"]
</span><span class="cx">     descriptionDone = ["bindings-tests"]
</span><del>-    command = ["python", "./Tools/Scripts/run-bindings-tests"]
</del><ins>+    command = ["python3", "./Tools/Scripts/run-bindings-tests"]
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> class RunBuiltinsTests(shell.Test):
</span></span></pre></div>
<a id="trunkToolsCISupportbuildwebkitorgsteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/build-webkit-org/steps_unittest.py (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/build-webkit-org/steps_unittest.py 2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/CISupport/build-webkit-org/steps_unittest.py    2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -201,7 +201,7 @@
</span><span class="cx">                 workdir='wkdir',
</span><span class="cx">                 timeout=1200,
</span><span class="cx">                 logEnviron=True,
</span><del>-                command=['python', './Tools/Scripts/run-bindings-tests'],
</del><ins>+                command=['python3', './Tools/Scripts/run-bindings-tests'],
</ins><span class="cx">             ) + 0,
</span><span class="cx">         )
</span><span class="cx">         self.expectOutcome(result=SUCCESS, state_string='bindings-tests')
</span><span class="lines">@@ -214,7 +214,7 @@
</span><span class="cx">                 workdir='wkdir',
</span><span class="cx">                 timeout=1200,
</span><span class="cx">                 logEnviron=True,
</span><del>-                command=['python', './Tools/Scripts/run-bindings-tests'],
</del><ins>+                command=['python3', './Tools/Scripts/run-bindings-tests'],
</ins><span class="cx">             ) + 2
</span><span class="cx">             + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp'),
</span><span class="cx">         )
</span></span></pre></div>
<a id="trunkToolsCISupportewsbuildstepspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/ews-build/steps.py (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/ews-build/steps.py 2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/CISupport/ews-build/steps.py    2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -1234,7 +1234,7 @@
</span><span class="cx">     flunkOnFailure = True
</span><span class="cx">     jsonFileName = 'bindings_test_results.json'
</span><span class="cx">     logfiles = {'json': jsonFileName}
</span><del>-    command = ['python', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(jsonFileName)]
</del><ins>+    command = ['python3', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(jsonFileName)]
</ins><span class="cx"> 
</span><span class="cx">     def __init__(self, **kwargs):
</span><span class="cx">         super(RunBindingsTests, self).__init__(timeout=5 * 60, logEnviron=False, **kwargs)
</span></span></pre></div>
<a id="trunkToolsCISupportewsbuildsteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/ews-build/steps_unittest.py        2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py   2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -374,7 +374,7 @@
</span><span class="cx">             ExpectShell(workdir='wkdir',
</span><span class="cx">                         timeout=300,
</span><span class="cx">                         logEnviron=False,
</span><del>-                        command=['python', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
</del><ins>+                        command=['python3', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
</ins><span class="cx">                         logfiles={'json': self.jsonFileName},
</span><span class="cx">                         )
</span><span class="cx">             + 0,
</span><span class="lines">@@ -388,7 +388,7 @@
</span><span class="cx">             ExpectShell(workdir='wkdir',
</span><span class="cx">                         timeout=300,
</span><span class="cx">                         logEnviron=False,
</span><del>-                        command=['python', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
</del><ins>+                        command=['python3', 'Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
</ins><span class="cx">                         logfiles={'json': self.jsonFileName},
</span><span class="cx">                         )
</span><span class="cx">             + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/ChangeLog       2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2021-09-01  Kevin Neal  <kevin_neal@apple.com>
+
+        [RunBindingsTests] Invoke with Python 3
+        https://bugs.webkit.org/show_bug.cgi?id=229724
+
+        Reviewed by Darin Adler.
+
+        * CISupport/build-webkit-org/steps.py:
+        (RunBindingsTests):
+        * CISupport/ews-build/steps.py:
+        (RunBindingsTests):
+        * CISupport/ews-build/steps_unittest.py:
+        * Scripts/run-bindings-tests:
+        (main): Deleted.
+
</ins><span class="cx"> 2021-09-01  Jonathan Bedard  <jbedard@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [contributors.json] Relocation (Part 1)
</span></span></pre></div>
<a id="trunkToolsScriptsrunbindingstests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-bindings-tests (281855 => 281856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-bindings-tests   2021-09-01 17:00:26 UTC (rev 281855)
+++ trunk/Tools/Scripts/run-bindings-tests      2021-09-01 17:16:48 UTC (rev 281856)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-#!/usr/bin/env python
</del><ins>+#!/usr/bin/env python3
</ins><span class="cx"> # Copyright (C) 2010 Google Inc.  All rights reserved.
</span><span class="cx"> #
</span><span class="cx"> # Redistribution and use in source and binary forms, with or without
</span></span></pre>
</div>
</div>

</body>
</html>