<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281658] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281658">281658</a></dd>
<dt>Author</dt> <dd>pangle@apple.com</dd>
<dt>Date</dt> <dd>2021-08-26 14:59:19 -0700 (Thu, 26 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
https://bugs.webkit.org/show_bug.cgi?id=229459

Reviewed by Devin Rousso.

Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
also delay the echo server's response further.

* http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
* platform/mac/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestswebsockettestshybiinspectorechodelayed_wshpy">trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py</a></li>
<li><a href="#trunkLayoutTestshttptestswebsockettestshybiinspectorsendandrecievedebuggerhtml">trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (281657 => 281658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/ChangeLog 2021-08-26 21:59:19 UTC (rev 281658)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2021-08-26  Patrick Angle  <pangle@apple.com>
+
+        [ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
+        https://bugs.webkit.org/show_bug.cgi?id=229459
+
+        Reviewed by Devin Rousso.
+
+        Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
+        also delay the echo server's response further.
+
+        * http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:
+        (web_socket_transfer_data):
+        * http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
+        * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2021-08-26  Robert Jenner  <Jenner@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [ Catalina+ wk1 ] css2.1/20110323/replaced-intrinsic-003.htm is a flaky text failure
</span></span></pre></div>
<a id="trunkLayoutTestshttptestswebsockettestshybiinspectorechodelayed_wshpy"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py (281657 => 281658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py  2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py     2021-08-26 21:59:19 UTC (rev 281658)
</span><span class="lines">@@ -9,5 +9,5 @@
</span><span class="cx"> def web_socket_transfer_data(request):
</span><span class="cx">     # Echo message back
</span><span class="cx">     message = msgutil.receive_message(request)
</span><del>-    sleep(0.1)
</del><ins>+    sleep(0.25)
</ins><span class="cx">     msgutil.send_message(request, message)
</span></span></pre></div>
<a id="trunkLayoutTestshttptestswebsockettestshybiinspectorsendandrecievedebuggerhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html (281657 => 281658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html       2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html  2021-08-26 21:59:19 UTC (rev 281658)
</span><span class="lines">@@ -50,12 +50,12 @@
</span><span class="cx">                         InspectorTest.log("Pausing script execution with `debugger` statement.");
</span><span class="cx">                         InspectorTest.evaluateInPage(`debugger`);
</span><span class="cx"> 
</span><del>-                        // The WebSocket echos with a 100ms delay, so wait a bit longer than that before resuming to
</del><ins>+                        // The WebSocket echos with a 250ms delay, so wait a bit longer than that before resuming to
</ins><span class="cx">                         // ensure we receive the message while still paused.
</span><span class="cx">                         setTimeout(() => {
</span><span class="cx">                          InspectorTest.log("Resuming script execution.")
</span><span class="cx">                          WI.debuggerManager.resume().catch(reject);
</span><del>-                        }, 200);
</del><ins>+                        }, 500);
</ins><span class="cx">                     } else if (frameAddedCount === 2) {
</span><span class="cx"> 
</span><span class="cx">                         InspectorTest.expectEqual(frame.data, "Hello World! Привет Мир!", "Frame data should be 'Hello World! Привет Мир!'");
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (281657 => 281658)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations  2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/platform/mac/TestExpectations     2021-08-26 21:59:19 UTC (rev 281658)
</span><span class="lines">@@ -656,8 +656,6 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/89153 http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
</span><span class="cx"> 
</span><del>-webkit.org/b/229459 [ Debug ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html [ Pass Failure Timeout ]
-
</del><span class="cx"> # <rdar://problem/16696298>
</span><span class="cx"> webkit.org/b/131886 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/131886 fast/canvas/webgl/webgl-compressed-texture-size-limit.html [ Pass Failure Timeout ]
</span></span></pre>
</div>
</div>

</body>
</html>