<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281524] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281524">281524</a></dd>
<dt>Author</dt> <dd>akeerthi@apple.com</dd>
<dt>Date</dt> <dd>2021-08-24 16:12:08 -0700 (Tue, 24 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/276598">r276598</a>): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=229471
rdar://80390931

Reviewed by Wenson Hsieh.

* fast/forms/ios/accessory-bar-navigation.html:

<a href="http://trac.webkit.org/projects/webkit/changeset/276598">r276598</a> updated this test so that the second input is positioned out of
the viewport on larger devices. However, the change (increasing the margin)
also lead to the first input being positioned out of the viewport on
smaller devices. Consequently, the test times out when run on an iPhone SE
as it is unable to tap on the first input.

To fix, the original margin for the first input is restored, ensuring it is
positioned within the viewport, and can be tapped. Then, a separate margin
is applied to the second input, ensuring it remains positioned outside the
viewport, and the test can verify accessory bar navigation with an
element outside the viewport.

* platform/ios-wk2/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastformsiosaccessorybarnavigationhtml">trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html</a></li>
<li><a href="#trunkLayoutTestsplatformioswk2TestExpectations">trunk/LayoutTests/platform/ios-wk2/TestExpectations</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (281523 => 281524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/ChangeLog 2021-08-24 23:12:08 UTC (rev 281524)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2021-08-24  Aditya Keerthi  <akeerthi@apple.com>
+
+        REGRESSION (r276598): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout
+        https://bugs.webkit.org/show_bug.cgi?id=229471
+        rdar://80390931
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/forms/ios/accessory-bar-navigation.html:
+
+        r276598 updated this test so that the second input is positioned out of
+        the viewport on larger devices. However, the change (increasing the margin)
+        also lead to the first input being positioned out of the viewport on
+        smaller devices. Consequently, the test times out when run on an iPhone SE
+        as it is unable to tap on the first input.
+
+        To fix, the original margin for the first input is restored, ensuring it is
+        positioned within the viewport, and can be tapped. Then, a separate margin
+        is applied to the second input, ensuring it remains positioned outside the
+        viewport, and the test can verify accessory bar navigation with an
+        element outside the viewport.
+
+        * platform/ios-wk2/TestExpectations:
+
</ins><span class="cx"> 2021-08-24  Eric Hutchison  <ehutchison@apple.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION (r281182?): 4 Media tests flakily timing out.
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsiosaccessorybarnavigationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html (281523 => 281524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html   2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/fast/forms/ios/accessory-bar-navigation.html      2021-08-24 23:12:08 UTC (rev 281524)
</span><span class="lines">@@ -6,8 +6,11 @@
</span><span class="cx">     <style>
</span><span class="cx">         input[type="text"] {
</span><span class="cx">             display: block;
</span><del>-            margin: 800px 20px;
</del><ins>+            margin: 400px 20px;
</ins><span class="cx">         }
</span><ins>+        #input2 {
+            margin-top: 800px;
+        }
</ins><span class="cx">         button {
</span><span class="cx">             display: block;
</span><span class="cx">         }
</span></span></pre></div>
<a id="trunkLayoutTestsplatformioswk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281523 => 281524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-wk2/TestExpectations      2021-08-24 23:04:18 UTC (rev 281523)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-24 23:12:08 UTC (rev 281524)
</span><span class="lines">@@ -2019,8 +2019,6 @@
</span><span class="cx"> 
</span><span class="cx"> #rdar://80391927 ([ iOS ] fast/forms/ios/ipad/open-picker-using-keyboard.html is a flaky timeout) fast/forms/ios/ipad/open-picker-using-keyboard.html [ Pass Timeout ]
</span><span class="cx"> 
</span><del>-#rdar://80390931 (REGRESSION (r271861): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout) fast/forms/ios/accessory-bar-navigation.html [ Timeout ] 
-
</del><span class="cx"> webkit.org/b/168961 fast/events/wheelevent-in-frame.html [ Pass Timeout ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/168961 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
</span></span></pre>
</div>
</div>

</body>
</html>