<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281369] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281369">281369</a></dd>
<dt>Author</dt> <dd>ysuzuki@apple.com</dd>
<dt>Date</dt> <dd>2021-08-21 05:10:09 -0700 (Sat, 21 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[JSC] Enable Array#findLast method
https://bugs.webkit.org/show_bug.cgi?id=229355

Reviewed by Saam Barati.

JSTests:

* stress/unscopables.js:

Source/JavaScriptCore:

This patch enables Array#findLast and Array#findLastIndex methods.

* runtime/ArrayPrototype.cpp: Order of unscopables is alphabet ordering (https://tc39.es/ecma262/#sec-array.prototype-@@unscopables)
(JSC::ArrayPrototype::finishCreation):
* runtime/OptionsList.h:

LayoutTests:

* inspector/model/remote-object-get-properties-expected.txt:
* js/Object-getOwnPropertyNames-expected.txt:
* js/array-unscopables-properties-expected.txt:
* js/script-tests/Object-getOwnPropertyNames.js:
* js/script-tests/array-unscopables-properties.js:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTestsstressunscopablesjs">trunk/JSTests/stress/unscopables.js</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt">trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsObjectgetOwnPropertyNamesexpectedtxt">trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsarrayunscopablespropertiesexpectedtxt">trunk/LayoutTests/js/array-unscopables-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsObjectgetOwnPropertyNamesjs">trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsarrayunscopablespropertiesjs">trunk/LayoutTests/js/script-tests/array-unscopables-properties.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeArrayPrototypecpp">trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsListh">trunk/Source/JavaScriptCore/runtime/OptionsList.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog  2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/JSTests/ChangeLog     2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2021-08-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Enable Array#findLast method
+        https://bugs.webkit.org/show_bug.cgi?id=229355
+
+        Reviewed by Saam Barati.
+
+        * stress/unscopables.js:
+
</ins><span class="cx"> 2021-08-17  Mikhail R. Gadelha  <mikhail@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed. Skip failing MIPS tests
</span></span></pre></div>
<a id="trunkJSTestsstressunscopablesjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/stress/unscopables.js (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/stress/unscopables.js      2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/JSTests/stress/unscopables.js 2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx"> 
</span><span class="cx">     test(typeof unscopables, "object");
</span><span class="cx">     test(unscopables.__proto__, undefined);
</span><del>-    test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,flat,flatMap,includes,keys,values");
</del><ins>+    test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,findLast,findLastIndex,flat,flatMap,includes,keys,values");
</ins><span class="cx"> }());
</span><span class="cx"> 
</span><span class="cx"> (function () {
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/ChangeLog 2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2021-08-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Enable Array#findLast method
+        https://bugs.webkit.org/show_bug.cgi?id=229355
+
+        Reviewed by Saam Barati.
+
+        * inspector/model/remote-object-get-properties-expected.txt:
+        * js/Object-getOwnPropertyNames-expected.txt:
+        * js/array-unscopables-properties-expected.txt:
+        * js/script-tests/Object-getOwnPropertyNames.js:
+        * js/script-tests/array-unscopables-properties.js:
+
</ins><span class="cx"> 2021-08-21  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Prevent AudioSession category from moving out of PlayAndRecord too quickly
</span></span></pre></div>
<a id="trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt      2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -82,7 +82,9 @@
</span><span class="cx">     keys
</span><span class="cx">     entries
</span><span class="cx">     find
</span><ins>+    findLast
</ins><span class="cx">     findIndex
</span><ins>+    findLastIndex
</ins><span class="cx">     includes
</span><span class="cx">     copyWithin
</span><span class="cx">     at
</span><span class="lines">@@ -136,7 +138,9 @@
</span><span class="cx">     keys
</span><span class="cx">     entries
</span><span class="cx">     find
</span><ins>+    findLast
</ins><span class="cx">     findIndex
</span><ins>+    findLastIndex
</ins><span class="cx">     includes
</span><span class="cx">     copyWithin
</span><span class="cx">     at
</span><span class="lines">@@ -175,7 +179,9 @@
</span><span class="cx">     keys
</span><span class="cx">     entries
</span><span class="cx">     find
</span><ins>+    findLast
</ins><span class="cx">     findIndex
</span><ins>+    findLastIndex
</ins><span class="cx">     includes
</span><span class="cx">     copyWithin
</span><span class="cx">     at
</span><span class="lines">@@ -214,7 +220,9 @@
</span><span class="cx">     keys
</span><span class="cx">     entries
</span><span class="cx">     find
</span><ins>+    findLast
</ins><span class="cx">     findIndex
</span><ins>+    findLastIndex
</ins><span class="cx">     includes
</span><span class="cx">     copyWithin
</span><span class="cx">     at
</span></span></pre></div>
<a id="trunkLayoutTestsjsObjectgetOwnPropertyNamesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt     2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt        2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> PASS getSortedOwnPropertyNames(Function) is ['length', 'name', 'prototype']
</span><span class="cx"> PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
</span><span class="cx"> PASS getSortedOwnPropertyNames(Array) is ['from', 'isArray', 'length', 'name', 'of', 'prototype']
</span><del>-PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
</del><ins>+PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
</ins><span class="cx"> PASS getSortedOwnPropertyNames(String) is ['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
</span><span class="cx"> PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']
</span><span class="cx"> PASS getSortedOwnPropertyNames(Boolean) is ['length', 'name', 'prototype']
</span></span></pre></div>
<a id="trunkLayoutTestsjsarrayunscopablespropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/array-unscopables-properties-expected.txt (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/array-unscopables-properties-expected.txt   2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/js/array-unscopables-properties-expected.txt      2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -34,6 +34,14 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").writable is true
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").enumerable is true
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findIndex").configurable is true
</span><ins>+PASS Array.prototype[Symbol.unscopables]["findLast"] is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLast").writable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLast").enumerable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLast").configurable is true
+PASS Array.prototype[Symbol.unscopables]["findLastIndex"] is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLastIndex").writable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLastIndex").enumerable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "findLastIndex").configurable is true
</ins><span class="cx"> PASS Array.prototype[Symbol.unscopables]["flat"] is true
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flat").writable is true
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flat").enumerable is true
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsObjectgetOwnPropertyNamesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js  2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js     2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">     "Function": "['length', 'name', 'prototype']",
</span><span class="cx">     "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']",
</span><span class="cx">     "Array": "['from', 'isArray', 'length', 'name', 'of', 'prototype']",
</span><del>-    "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
</del><ins>+    "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
</ins><span class="cx">     "String": "['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']",
</span><span class="cx">     "String.prototype": "['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']",
</span><span class="cx">     "Boolean": "['length', 'name', 'prototype']",
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsarrayunscopablespropertiesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/array-unscopables-properties.js (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/array-unscopables-properties.js        2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/LayoutTests/js/script-tests/array-unscopables-properties.js   2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -13,6 +13,8 @@
</span><span class="cx">     "fill",
</span><span class="cx">     "find",
</span><span class="cx">     "findIndex",
</span><ins>+    "findLast",
+    "findLastIndex",
</ins><span class="cx">     "flat",
</span><span class="cx">     "flatMap",
</span><span class="cx">     "includes",
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/Source/JavaScriptCore/ChangeLog       2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2021-08-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Enable Array#findLast method
+        https://bugs.webkit.org/show_bug.cgi?id=229355
+
+        Reviewed by Saam Barati.
+
+        This patch enables Array#findLast and Array#findLastIndex methods.
+
+        * runtime/ArrayPrototype.cpp: Order of unscopables is alphabet ordering (https://tc39.es/ecma262/#sec-array.prototype-@@unscopables)
+        (JSC::ArrayPrototype::finishCreation):
+        * runtime/OptionsList.h:
+
</ins><span class="cx"> 2021-08-20  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [JSC] Simplify moveIntsToDouble
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeArrayPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp   2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp      2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -127,11 +127,14 @@
</span><span class="cx">     JSObject* unscopables = constructEmptyObject(vm, globalObject->nullPrototypeObjectStructure());
</span><span class="cx">     unscopables->convertToDictionary(vm);
</span><span class="cx">     const Identifier* const unscopableNames[] = {
</span><ins>+        Options::useAtMethod() ? &vm.propertyNames->builtinNames().atPublicName() : nullptr,
</ins><span class="cx">         &vm.propertyNames->builtinNames().copyWithinPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().entriesPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().fillPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().findPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().findIndexPublicName(),
</span><ins>+        Options::useArrayFindLastMethod() ? &vm.propertyNames->builtinNames().findLastPublicName() : nullptr,
+        Options::useArrayFindLastMethod() ? &vm.propertyNames->builtinNames().findLastIndexPublicName() : nullptr,
</ins><span class="cx">         &vm.propertyNames->builtinNames().flatPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().flatMapPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().includesPublicName(),
</span><span class="lines">@@ -138,14 +141,10 @@
</span><span class="cx">         &vm.propertyNames->builtinNames().keysPublicName(),
</span><span class="cx">         &vm.propertyNames->builtinNames().valuesPublicName()
</span><span class="cx">     };
</span><del>-    if (Options::useArrayFindLastMethod()) {
-        unscopables->putDirect(vm, vm.propertyNames->builtinNames().findLastPublicName(), jsBoolean(true));
-        unscopables->putDirect(vm, vm.propertyNames->builtinNames().findLastIndexPublicName(), jsBoolean(true));
</del><ins>+    for (const auto* unscopableName : unscopableNames) {
+        if (unscopableName)
+            unscopables->putDirect(vm, *unscopableName, jsBoolean(true));
</ins><span class="cx">     }
</span><del>-    if (Options::useAtMethod())
-        unscopables->putDirect(vm, vm.propertyNames->builtinNames().atPublicName(), jsBoolean(true));
-    for (const auto* unscopableName : unscopableNames)
-        unscopables->putDirect(vm, *unscopableName, jsBoolean(true));
</del><span class="cx">     putDirectWithoutTransition(vm, vm.propertyNames->unscopablesSymbol, unscopables, PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/OptionsList.h (281368 => 281369)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/OptionsList.h        2021-08-21 07:56:13 UTC (rev 281368)
+++ trunk/Source/JavaScriptCore/runtime/OptionsList.h   2021-08-21 12:10:09 UTC (rev 281369)
</span><span class="lines">@@ -553,7 +553,7 @@
</span><span class="cx">     v(Bool, useDataICInOptimizingJIT, false, Normal, nullptr) \
</span><span class="cx">     v(Bool, useDataICSharing, false, Normal, nullptr) \
</span><span class="cx">     v(Bool, useTemporal, false, Normal, "Expose the Temporal object.") \
</span><del>-    v(Bool, useArrayFindLastMethod, false, Normal, "Expose the findLast() and findLastIndex() methods on Array and %TypedArray%.") \
</del><ins>+    v(Bool, useArrayFindLastMethod, true, Normal, "Expose the findLast() and findLastIndex() methods on Array and %TypedArray%.") \
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> enum OptionEquivalence {
</span></span></pre>
</div>
</div>

</body>
</html>