<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281226] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281226">281226</a></dd>
<dt>Author</dt> <dd>youenn@apple.com</dd>
<dt>Date</dt> <dd>2021-08-19 01:22:22 -0700 (Thu, 19 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>RTCRtpTransceiver does not need an ice transport
https://bugs.webkit.org/show_bug.cgi?id=229186

Reviewed by Eric Carlson.

No change of behavior, we are removing a member from RTCRtpTransceiver which is unused.
We are also updating RTCIceTransport as it does not need to have virtual methods yet.

* Modules/mediastream/RTCIceTransport.cpp:
(WebCore::RTCIceTransport::~RTCIceTransport):
* Modules/mediastream/RTCIceTransport.h:
* Modules/mediastream/RTCIceTransport.idl:
* Modules/mediastream/RTCRtpTransceiver.cpp:
(WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
* Modules/mediastream/RTCRtpTransceiver.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportcpp">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransporth">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceTransportidl">trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCRtpTransceivercpp">trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCRtpTransceiverh">trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/ChangeLog      2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2021-08-19  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><ins>+        RTCRtpTransceiver does not need an ice transport
+        https://bugs.webkit.org/show_bug.cgi?id=229186
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior, we are removing a member from RTCRtpTransceiver which is unused.
+        We are also updating RTCIceTransport as it does not need to have virtual methods yet.
+
+        * Modules/mediastream/RTCIceTransport.cpp:
+        (WebCore::RTCIceTransport::~RTCIceTransport):
+        * Modules/mediastream/RTCIceTransport.h:
+        * Modules/mediastream/RTCIceTransport.idl:
+        * Modules/mediastream/RTCRtpTransceiver.cpp:
+        (WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
+        * Modules/mediastream/RTCRtpTransceiver.h:
+
+2021-08-19  Youenn Fablet  <youenn@apple.com>
+
</ins><span class="cx">         Add support for RTCDtlsTransport
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=229133
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCIceTransportcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp     2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp        2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -34,6 +34,10 @@
</span><span class="cx"> 
</span><span class="cx"> WTF_MAKE_ISO_ALLOCATED_IMPL(RTCIceTransport);
</span><span class="cx"> 
</span><ins>+RTCIceTransport::~RTCIceTransport()
+{
+}
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx"> 
</span><span class="cx"> #endif // ENABLE(WEB_RTC)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCIceTransporth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h       2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h  2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-class RTCIceTransport final : public RefCounted<RTCIceTransport>, public ScriptWrappable {
</del><ins>+class RTCIceTransport : public RefCounted<RTCIceTransport>, public ScriptWrappable {
</ins><span class="cx">     WTF_MAKE_ISO_ALLOCATED(RTCIceTransport);
</span><span class="cx"> public:
</span><span class="cx">     static Ref<RTCIceTransport> create()
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     {
</span><span class="cx">         return adoptRef(*new RTCIceTransport());
</span><span class="cx">     }
</span><del>-    virtual ~RTCIceTransport() = default;
</del><ins>+    ~RTCIceTransport();
</ins><span class="cx"> 
</span><span class="cx">     RTCIceTransportState state() const { return m_transportState; }
</span><span class="cx">     void setState(RTCIceTransportState state) { m_transportState = state; }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCIceTransportidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl     2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl        2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -29,7 +29,8 @@
</span><span class="cx"> [
</span><span class="cx">     Conditional=WEB_RTC,
</span><span class="cx">     EnabledBySetting=PeerConnection,
</span><del>-    Exposed=Window
</del><ins>+    Exposed=Window,
+    SkipVTableValidation
</ins><span class="cx"> ] interface RTCIceTransport {
</span><span class="cx">     // FIXME 169662: missing readonly attribute RTCIceRole role;
</span><span class="cx">     // FIXME 169662: missing readonly attribute RTCIceComponent component;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCRtpTransceivercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp   2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp      2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -46,7 +46,6 @@
</span><span class="cx">     : m_direction(RTCRtpTransceiverDirection::Sendrecv)
</span><span class="cx">     , m_sender(WTFMove(sender))
</span><span class="cx">     , m_receiver(WTFMove(receiver))
</span><del>-    , m_iceTransport(RTCIceTransport::create())
</del><span class="cx">     , m_backend(WTFMove(backend))
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCRtpTransceiverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h (281225 => 281226)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h     2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h        2021-08-19 08:22:22 UTC (rev 281226)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(WEB_RTC)
</span><span class="cx"> 
</span><del>-#include "RTCIceTransport.h"
</del><span class="cx"> #include "RTCRtpReceiver.h"
</span><span class="cx"> #include "RTCRtpSender.h"
</span><span class="cx"> #include "RTCRtpTransceiverBackend.h"
</span><span class="lines">@@ -70,11 +69,6 @@
</span><span class="cx">     ExceptionOr<void> stop();
</span><span class="cx">     ExceptionOr<void> setCodecPreferences(const Vector<RTCRtpCodecCapability>&);
</span><span class="cx"> 
</span><del>-    // FIXME: Temporary solution to keep track of ICE states for this transceiver. Later, each
-    // sender and receiver will have up to two DTLS transports, which in turn will have an ICE
-    // transport each.
-    RTCIceTransport& iceTransport() { return m_iceTransport.get(); }
-
</del><span class="cx">     RTCRtpTransceiverBackend* backend() { return m_backend.get(); }
</span><span class="cx">     void setConnection(RTCPeerConnection&);
</span><span class="cx"> 
</span><span class="lines">@@ -88,7 +82,6 @@
</span><span class="cx"> 
</span><span class="cx">     bool m_stopped { false };
</span><span class="cx"> 
</span><del>-    Ref<RTCIceTransport> m_iceTransport;
</del><span class="cx">     std::unique_ptr<RTCRtpTransceiverBackend> m_backend;
</span><span class="cx">     WeakPtr<RTCPeerConnection> m_connection;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>