<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281284] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281284">281284</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2021-08-19 17:12:09 -0700 (Thu, 19 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Implement Crypto.randomUUID()
https://bugs.webkit.org/show_bug.cgi?id=229240

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

* web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
* web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:

Source/WebCore:

Implement Crypto.randomUUID():
- https://wicg.github.io/uuid/#extensions-to-the-crypto-interface

Chrome already implements this and Firefox seems to be working on it
(https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).

No new tests, rebaselined existing tests.

* page/Crypto.cpp:
(WebCore::Crypto::randomUUID const):
* page/Crypto.h:
* page/Crypto.idl:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsWebCryptoAPIrandomUUIDhttpsanyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsWebCryptoAPIrandomUUIDhttpsanyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageCryptocpp">trunk/Source/WebCore/page/Crypto.cpp</a></li>
<li><a href="#trunkSourceWebCorepageCryptoh">trunk/Source/WebCore/page/Crypto.h</a></li>
<li><a href="#trunkSourceWebCorepageCryptoidl">trunk/Source/WebCore/page/Crypto.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2021-08-19  Chris Dumez  <cdumez@apple.com>
+
+        Implement Crypto.randomUUID()
+        https://bugs.webkit.org/show_bug.cgi?id=229240
+
+        Reviewed by Geoff Garen.
+
+        Rebaseline WPT tests that are now passing.
+
+        * web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
+        * web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:
+
</ins><span class="cx"> 2021-08-19  Zalan Bujtas  <zalan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [LFC][IFC] Add support for overflow-wrap: anywhere
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsWebCryptoAPIrandomUUIDhttpsanyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt 2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt    2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> 
</span><del>-FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
</del><ins>+PASS namespace format
+PASS version set
+PASS variant set
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsWebCryptoAPIrandomUUIDhttpsanyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt  2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt     2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> 
</span><del>-FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
</del><ins>+PASS namespace format
+PASS version set
+PASS variant set
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/Source/WebCore/ChangeLog      2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2021-08-19  Chris Dumez  <cdumez@apple.com>
+
+        Implement Crypto.randomUUID()
+        https://bugs.webkit.org/show_bug.cgi?id=229240
+
+        Reviewed by Geoff Garen.
+
+        Implement Crypto.randomUUID():
+        - https://wicg.github.io/uuid/#extensions-to-the-crypto-interface
+
+        Chrome already implements this and Firefox seems to be working on it
+        (https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).
+
+        No new tests, rebaselined existing tests.
+
+        * page/Crypto.cpp:
+        (WebCore::Crypto::randomUUID const):
+        * page/Crypto.h:
+        * page/Crypto.idl:
+
</ins><span class="cx"> 2021-08-19  Simon Fraser  <simon.fraser@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Remove unused RenderLayerCompositor member variable
</span></span></pre></div>
<a id="trunkSourceWebCorepageCryptocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Crypto.cpp (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Crypto.cpp     2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/Source/WebCore/page/Crypto.cpp        2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> #include "SubtleCrypto.h"
</span><span class="cx"> #include <JavaScriptCore/ArrayBufferView.h>
</span><span class="cx"> #include <wtf/CryptographicallyRandomNumber.h>
</span><ins>+#include <wtf/UUID.h>
</ins><span class="cx"> 
</span><span class="cx"> #if OS(DARWIN)
</span><span class="cx"> #include <CommonCrypto/CommonCryptor.h>
</span><span class="lines">@@ -68,6 +69,11 @@
</span><span class="cx">     return { };
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+String Crypto::randomUUID() const
+{
+    return createCanonicalUUIDString();
+}
+
</ins><span class="cx"> #if ENABLE(WEB_CRYPTO)
</span><span class="cx"> 
</span><span class="cx"> SubtleCrypto& Crypto::subtle()
</span></span></pre></div>
<a id="trunkSourceWebCorepageCryptoh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Crypto.h (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Crypto.h       2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/Source/WebCore/page/Crypto.h  2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -46,6 +46,7 @@
</span><span class="cx">     virtual ~Crypto();
</span><span class="cx"> 
</span><span class="cx">     ExceptionOr<void> getRandomValues(JSC::ArrayBufferView&);
</span><ins>+    String randomUUID() const;
</ins><span class="cx"> 
</span><span class="cx"> #if ENABLE(WEB_CRYPTO)
</span><span class="cx">     SubtleCrypto& subtle();
</span></span></pre></div>
<a id="trunkSourceWebCorepageCryptoidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Crypto.idl (281283 => 281284)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Crypto.idl     2021-08-19 23:58:26 UTC (rev 281283)
+++ trunk/Source/WebCore/page/Crypto.idl        2021-08-20 00:12:09 UTC (rev 281284)
</span><span class="lines">@@ -33,4 +33,5 @@
</span><span class="cx"> ] interface Crypto {
</span><span class="cx">     [Conditional=WEB_CRYPTO, SecureContext] readonly attribute SubtleCrypto subtle;
</span><span class="cx">     ArrayBufferView getRandomValues([ReturnValue] ArrayBufferView array);
</span><ins>+    [SecureContext] DOMString randomUUID();
</ins><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>