<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281230] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281230">281230</a></dd>
<dt>Author</dt> <dd>ntim@apple.com</dd>
<dt>Date</dt> <dd>2021-08-19 02:15:03 -0700 (Thu, 19 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Port HTMLDetailsElement to use modern event handling code
https://bugs.webkit.org/show_bug.cgi?id=228863

Reviewed by Antti Koivisto.

No behaviour change, follows: https://html.spec.whatwg.org/#details-notification-task-steps

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::parseAttribute):
(WebCore::HTMLDetailsElement::toggleOpen):
(WebCore::detailToggleEventSender): Deleted.
(WebCore::HTMLDetailsElement::~HTMLDetailsElement): Deleted.
(WebCore::HTMLDetailsElement::dispatchPendingEvent): Deleted.
* html/HTMLDetailsElement.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDetailsElementcpp">trunk/Source/WebCore/html/HTMLDetailsElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDetailsElementh">trunk/Source/WebCore/html/HTMLDetailsElement.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (281229 => 281230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-08-19 09:02:02 UTC (rev 281229)
+++ trunk/Source/WebCore/ChangeLog      2021-08-19 09:15:03 UTC (rev 281230)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2021-08-19  Tim Nguyen  <ntim@apple.com>
</span><span class="cx"> 
</span><ins>+        Port HTMLDetailsElement to use modern event handling code
+        https://bugs.webkit.org/show_bug.cgi?id=228863
+
+        Reviewed by Antti Koivisto.
+
+        No behaviour change, follows: https://html.spec.whatwg.org/#details-notification-task-steps
+
+        * html/HTMLDetailsElement.cpp:
+        (WebCore::HTMLDetailsElement::parseAttribute):
+        (WebCore::HTMLDetailsElement::toggleOpen):
+        (WebCore::detailToggleEventSender): Deleted.
+        (WebCore::HTMLDetailsElement::~HTMLDetailsElement): Deleted.
+        (WebCore::HTMLDetailsElement::dispatchPendingEvent): Deleted.
+        * html/HTMLDetailsElement.h:
+
+2021-08-19  Tim Nguyen  <ntim@apple.com>
+
</ins><span class="cx">         Implement ::backdrop pseudo element
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=227801
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDetailsElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (281229 => 281230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2021-08-19 09:02:02 UTC (rev 281229)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp    2021-08-19 09:15:03 UTC (rev 281230)
</span><span class="lines">@@ -24,8 +24,8 @@
</span><span class="cx"> 
</span><span class="cx"> #include "AXObjectCache.h"
</span><span class="cx"> #include "ElementIterator.h"
</span><ins>+#include "EventLoop.h"
</ins><span class="cx"> #include "EventNames.h"
</span><del>-#include "EventSender.h"
</del><span class="cx"> #include "HTMLSlotElement.h"
</span><span class="cx"> #include "HTMLSummaryElement.h"
</span><span class="cx"> #include "LocalizedStrings.h"
</span><span class="lines">@@ -43,12 +43,6 @@
</span><span class="cx"> 
</span><span class="cx"> using namespace HTMLNames;
</span><span class="cx"> 
</span><del>-static DetailEventSender& detailToggleEventSender()
-{
-    static NeverDestroyed<DetailEventSender> sharedToggleEventSender(eventNames().toggleEvent);
-    return sharedToggleEventSender;
-}
-
</del><span class="cx"> static const AtomString& summarySlotName()
</span><span class="cx"> {
</span><span class="cx">     static MainThreadNeverDestroyed<const AtomString> summarySlot("summarySlot");
</span><span class="lines">@@ -98,11 +92,6 @@
</span><span class="cx">     ASSERT(hasTagName(detailsTag));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-HTMLDetailsElement::~HTMLDetailsElement()
-{
-    detailToggleEventSender().cancelEvent(*this);
-}
-
</del><span class="cx"> RenderPtr<RenderElement> HTMLDetailsElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
</span><span class="cx"> {
</span><span class="cx">     return createRenderer<RenderBlockFlow>(*this, WTFMove(style));
</span><span class="lines">@@ -139,12 +128,6 @@
</span><span class="cx">     return slot == m_summarySlot;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void HTMLDetailsElement::dispatchPendingEvent(DetailEventSender* eventSender)
-{
-    ASSERT_UNUSED(eventSender, eventSender == &detailToggleEventSender());
-    dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
-}
-
</del><span class="cx"> void HTMLDetailsElement::parseAttribute(const QualifiedName& name, const AtomString& value)
</span><span class="cx"> {
</span><span class="cx">     if (name == openAttr) {
</span><span class="lines">@@ -158,9 +141,15 @@
</span><span class="cx">             else
</span><span class="cx">                 root->removeChild(*m_defaultSlot);
</span><span class="cx"> 
</span><del>-            // https://html.spec.whatwg.org/#details-notification-task-steps.
-            detailToggleEventSender().cancelEvent(*this);
-            detailToggleEventSender().dispatchEventSoon(*this);
</del><ins>+            // https://html.spec.whatwg.org/#details-notification-task-steps
+            if (m_isToggleEventTaskQueued)
+                return;
+
+            document().eventLoop().queueTask(TaskSource::DOMManipulation, [protectedThis = GCReachableRef { *this }] {
+                protectedThis->dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
+                protectedThis->m_isToggleEventTaskQueued = false;
+            });
+            m_isToggleEventTaskQueued = true;
</ins><span class="cx">         }
</span><span class="cx">     } else
</span><span class="cx">         HTMLElement::parseAttribute(name, value);
</span><span class="lines">@@ -169,7 +158,7 @@
</span><span class="cx"> 
</span><span class="cx"> void HTMLDetailsElement::toggleOpen()
</span><span class="cx"> {
</span><del>-    setAttributeWithoutSynchronization(openAttr, m_isOpen ? nullAtom() : emptyAtom());
</del><ins>+    setBooleanAttribute(openAttr, !m_isOpen);
</ins><span class="cx"> 
</span><span class="cx">     // We need to post to the document because toggling this element will delete it.
</span><span class="cx">     if (AXObjectCache* cache = document().existingAXObjectCache())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDetailsElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDetailsElement.h (281229 => 281230)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDetailsElement.h   2021-08-19 09:02:02 UTC (rev 281229)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.h      2021-08-19 09:15:03 UTC (rev 281230)
</span><span class="lines">@@ -27,14 +27,10 @@
</span><span class="cx"> 
</span><span class="cx"> class HTMLSlotElement;
</span><span class="cx"> 
</span><del>-template<typename T> class EventSender;
-using DetailEventSender = EventSender<HTMLDetailsElement>;
-
</del><span class="cx"> class HTMLDetailsElement final : public HTMLElement {
</span><span class="cx">     WTF_MAKE_ISO_ALLOCATED(HTMLDetailsElement);
</span><span class="cx"> public:
</span><span class="cx">     static Ref<HTMLDetailsElement> create(const QualifiedName& tagName, Document&);
</span><del>-    ~HTMLDetailsElement();
</del><span class="cx"> 
</span><span class="cx">     void toggleOpen();
</span><span class="cx"> 
</span><span class="lines">@@ -41,8 +37,6 @@
</span><span class="cx">     bool isOpen() const { return m_isOpen; }
</span><span class="cx">     bool isActiveSummary(const HTMLSummaryElement&) const;
</span><span class="cx"> 
</span><del>-    void dispatchPendingEvent(DetailEventSender*);
-    
</del><span class="cx"> private:
</span><span class="cx">     HTMLDetailsElement(const QualifiedName&, Document&);
</span><span class="cx"> 
</span><span class="lines">@@ -57,6 +51,7 @@
</span><span class="cx">     HTMLSlotElement* m_summarySlot { nullptr };
</span><span class="cx">     HTMLSummaryElement* m_defaultSummary { nullptr };
</span><span class="cx">     RefPtr<HTMLSlotElement> m_defaultSlot;
</span><ins>+    bool m_isToggleEventTaskQueued { false };
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre>
</div>
</div>

</body>
</html>