<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[281178] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/281178">281178</a></dd>
<dt>Author</dt> <dd>sbarati@apple.com</dd>
<dt>Date</dt> <dd>2021-08-17 19:27:03 -0700 (Tue, 17 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add an option for canonicalizePrePostIncrements
https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
https://bugs.webkit.org/show_bug.cgi?id=228538

* b3/B3Generate.cpp:
(JSC::B3::generateToAir):
* b3/testb3_3.cpp:
(addShrTests):
* runtime/OptionsList.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3B3Generatecpp">trunk/Source/JavaScriptCore/b3/B3Generate.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3testb3_3cpp">trunk/Source/JavaScriptCore/b3/testb3_3.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsListh">trunk/Source/JavaScriptCore/runtime/OptionsList.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (281177 => 281178)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2021-08-18 02:20:25 UTC (rev 281177)
+++ trunk/Source/JavaScriptCore/ChangeLog       2021-08-18 02:27:03 UTC (rev 281178)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2021-08-17  Saam Barati  <sbarati@apple.com>
+
+        Add an option for canonicalizePrePostIncrements
+        https://bugs.webkit.org/show_bug.cgi?id=229211
+        <rdar://problem/82050126>
+
+        Reviewed by Mark Lam.
+
+        The current phase has bugs. Let's disable it for now until the bugs
+        are fixed. See discussion about the bugs I spotted in:
+        https://bugs.webkit.org/show_bug.cgi?id=228538
+
+        * b3/B3Generate.cpp:
+        (JSC::B3::generateToAir):
+        * b3/testb3_3.cpp:
+        (addShrTests):
+        * runtime/OptionsList.h:
+
</ins><span class="cx"> 2021-08-16  Mark Lam  <mark.lam@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Ensure that unused LLInt opcodes are not inadvertently used.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3B3Generatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/B3Generate.cpp (281177 => 281178)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/B3Generate.cpp    2021-08-18 02:20:25 UTC (rev 281177)
+++ trunk/Source/JavaScriptCore/b3/B3Generate.cpp       2021-08-18 02:27:03 UTC (rev 281178)
</span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx">     lowerMacrosAfterOptimizations(procedure);
</span><span class="cx">     legalizeMemoryOffsets(procedure);
</span><span class="cx">     moveConstants(procedure);
</span><del>-    if (procedure.optLevel() >= 2)
</del><ins>+    if (Options::useB3CanonicalizePrePostIncrements() && procedure.optLevel() >= 2)
</ins><span class="cx">         canonicalizePrePostIncrements(procedure);
</span><span class="cx">     eliminateDeadCode(procedure);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3testb3_3cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/testb3_3.cpp (281177 => 281178)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/testb3_3.cpp      2021-08-18 02:20:25 UTC (rev 281177)
+++ trunk/Source/JavaScriptCore/b3/testb3_3.cpp 2021-08-18 02:27:03 UTC (rev 281178)
</span><span class="lines">@@ -4097,15 +4097,17 @@
</span><span class="cx">     RUN(testZShrArgImm32(0xffffffff, 1));
</span><span class="cx">     RUN(testZShrArgImm32(0xffffffff, 63));
</span><span class="cx"> 
</span><del>-    RUN(testLoadPreIndex32());
-    RUN(testLoadPreIndex64());
-    RUN(testLoadPostIndex32());
-    RUN(testLoadPostIndex64());
</del><ins>+    if (Options::useB3CanonicalizePrePostIncrements()) {
+        RUN(testLoadPreIndex32());
+        RUN(testLoadPreIndex64());
+        RUN(testLoadPostIndex32());
+        RUN(testLoadPostIndex64());
</ins><span class="cx"> 
</span><del>-    RUN(testStorePreIndex32());
-    RUN(testStorePreIndex64());
-    RUN(testStorePostIndex32());
-    RUN(testStorePostIndex64());
</del><ins>+        RUN(testStorePreIndex32());
+        RUN(testStorePreIndex64());
+        RUN(testStorePostIndex32());
+        RUN(testStorePostIndex64());
+    }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> #endif // ENABLE(B3_JIT)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/OptionsList.h (281177 => 281178)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/OptionsList.h        2021-08-18 02:20:25 UTC (rev 281177)
+++ trunk/Source/JavaScriptCore/runtime/OptionsList.h   2021-08-18 02:27:03 UTC (rev 281178)
</span><span class="lines">@@ -437,6 +437,7 @@
</span><span class="cx">     v(Unsigned, maxB3TailDupBlockSize, 3, Normal, nullptr) \
</span><span class="cx">     v(Unsigned, maxB3TailDupBlockSuccessors, 3, Normal, nullptr) \
</span><span class="cx">     v(Bool, useB3HoistLoopInvariantValues, false, Normal, nullptr) \
</span><ins>+    v(Bool, useB3CanonicalizePrePostIncrements, false, Normal, nullptr) \
</ins><span class="cx">     \
</span><span class="cx">     v(Bool, useDollarVM, false, Restricted, "installs the $vm debugging tool in global objects") \
</span><span class="cx">     v(OptionString, functionOverrides, nullptr, Restricted, "file with debugging overrides for function bodies") \
</span></span></pre>
</div>
</div>

</body>
</html>