<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[280933] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/280933">280933</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2021-08-11 15:21:57 -0700 (Wed, 11 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre><a rel="opener noopener" target="_blank"> should create a window without opener
https://bugs.webkit.org/show_bug.cgi?id=229011

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

* web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt:
* web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt:

Source/WebCore:

<a rel="opener noopener" target="_blank"> should create a window without opener, as per:
- https://html.spec.whatwg.org/#get-an-element's-noopener (noopener is checked *before* opener).

Firefox and Chrome match the specification.

No new tests, rebaselined existing tests.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticslinkslinkscreatedbyaandareaelementstarget_blank_implicit_noopenerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticslinkslinkscreatedbyaandareaelementstarget_blank_implicit_noopener_baseexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280932 => 280933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-11 22:18:38 UTC (rev 280932)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-08-11 22:21:57 UTC (rev 280933)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2021-08-11  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        <a rel="opener noopener" target="_blank"> should create a window without opener
+        https://bugs.webkit.org/show_bug.cgi?id=229011
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline WPT tests that are now passing.
+
+        * web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt:
+        * web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt:
+
+2021-08-11  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         Stop evaluating <script>s moved between Documents during fetching
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=202714
</span><span class="cx">         <rdar://problem/56208425>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticslinkslinkscreatedbyaandareaelementstarget_blank_implicit_noopenerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt (280932 => 280933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt  2021-08-11 22:18:38 UTC (rev 280932)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener-expected.txt     2021-08-11 22:21:57 UTC (rev 280933)
</span><span class="lines">@@ -3,14 +3,14 @@
</span><span class="cx"> PASS Anchor element with target=_blank with rel=noopener
</span><span class="cx"> PASS Anchor element with target=_blank with rel=opener
</span><span class="cx"> PASS Anchor element with target=_blank with implicit rel=noopener
</span><del>-FAIL Anchor element with target=_blank with rel=opener+noopener assert_equals: expected false but got true
-FAIL Anchor element with target=_blank with rel=noopener+opener assert_equals: expected false but got true
</del><ins>+PASS Anchor element with target=_blank with rel=opener+noopener
+PASS Anchor element with target=_blank with rel=noopener+opener
</ins><span class="cx"> PASS Anchor element with target=_blank with rel=noreferrer
</span><del>-FAIL Anchor element with target=_blank with rel=opener+noreferrer assert_equals: expected false but got true
-FAIL Anchor element with target=_blank with rel=noopener+opener+noreferrer assert_equals: expected false but got true
</del><ins>+PASS Anchor element with target=_blank with rel=opener+noreferrer
+PASS Anchor element with target=_blank with rel=noopener+opener+noreferrer
</ins><span class="cx"> PASS Area element with target=_blank with rel=noopener
</span><span class="cx"> PASS Area element with target=_blank with rel=opener
</span><span class="cx"> PASS Area element with target=_blank with implicit rel=noopener
</span><del>-FAIL Area element with target=_blank with rel=opener+noopener assert_equals: expected false but got true
-FAIL Area element with target=_blank with rel=noopener+opener assert_equals: expected false but got true
</del><ins>+PASS Area element with target=_blank with rel=opener+noopener
+PASS Area element with target=_blank with rel=noopener+opener
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticslinkslinkscreatedbyaandareaelementstarget_blank_implicit_noopener_baseexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt (280932 => 280933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt     2021-08-11 22:18:38 UTC (rev 280932)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base-expected.txt        2021-08-11 22:21:57 UTC (rev 280933)
</span><span class="lines">@@ -3,14 +3,14 @@
</span><span class="cx"> PASS Anchor element with base target=_blank with rel=noopener
</span><span class="cx"> PASS Anchor element with base target=_blank with rel=opener
</span><span class="cx"> PASS Anchor element with base target=_blank with implicit rel=noopener
</span><del>-FAIL Anchor element with base target=_blank with rel=opener+noopener assert_equals: expected false but got true
-FAIL Anchor element with base target=_blank with rel=noopener+opener assert_equals: expected false but got true
</del><ins>+PASS Anchor element with base target=_blank with rel=opener+noopener
+PASS Anchor element with base target=_blank with rel=noopener+opener
</ins><span class="cx"> PASS Anchor element with base target=_blank with rel=noreferrer
</span><del>-FAIL Anchor element with base target=_blank with rel=opener+noreferrer assert_equals: expected false but got true
-FAIL Anchor element with base target=_blank with rel=noopener+opener+noreferrer assert_equals: expected false but got true
</del><ins>+PASS Anchor element with base target=_blank with rel=opener+noreferrer
+PASS Anchor element with base target=_blank with rel=noopener+opener+noreferrer
</ins><span class="cx"> PASS Area element with base target=_blank with rel=noopener
</span><span class="cx"> PASS Area element with base target=_blank with rel=opener
</span><span class="cx"> PASS Area element with base target=_blank with implicit rel=noopener
</span><del>-FAIL Area element with base target=_blank with rel=opener+noopener assert_equals: expected false but got true
-FAIL Area element with base target=_blank with rel=noopener+opener assert_equals: expected false but got true
</del><ins>+PASS Area element with base target=_blank with rel=opener+noopener
+PASS Area element with base target=_blank with rel=noopener+opener
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (280932 => 280933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-08-11 22:18:38 UTC (rev 280932)
+++ trunk/Source/WebCore/ChangeLog      2021-08-11 22:21:57 UTC (rev 280933)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2021-08-11  Chris Dumez  <cdumez@apple.com>
+
+        <a rel="opener noopener" target="_blank"> should create a window without opener
+        https://bugs.webkit.org/show_bug.cgi?id=229011
+
+        Reviewed by Alex Christensen.
+
+        <a rel="opener noopener" target="_blank"> should create a window without opener, as per:
+        - https://html.spec.whatwg.org/#get-an-element's-noopener (noopener is checked *before* opener).
+
+        Firefox and Chrome match the specification.
+
+        No new tests, rebaselined existing tests.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::handleClick):
+
</ins><span class="cx"> 2021-08-11  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION (r278392) performance.measure should never throw an InvalidAccessError for fetchStart
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (280932 => 280933)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp  2021-08-11 22:18:38 UTC (rev 280932)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp     2021-08-11 22:21:57 UTC (rev 280933)
</span><span class="lines">@@ -517,10 +517,8 @@
</span><span class="cx">     auto referrerPolicy = hasRel(Relation::NoReferrer) ? ReferrerPolicy::NoReferrer : this->referrerPolicy();
</span><span class="cx"> 
</span><span class="cx">     auto effectiveTarget = this->effectiveTarget();
</span><del>-    std::optional<NewFrameOpenerPolicy> newFrameOpenerPolicy;
-    if (hasRel(Relation::Opener))
-        newFrameOpenerPolicy = NewFrameOpenerPolicy::Allow;
-    else if (hasRel(Relation::NoOpener) || (document().settings().blankAnchorTargetImpliesNoOpenerEnabled() && equalIgnoringASCIICase(effectiveTarget, "_blank")))
</del><ins>+    NewFrameOpenerPolicy newFrameOpenerPolicy = NewFrameOpenerPolicy::Allow;
+    if (hasRel(Relation::NoOpener) || hasRel(Relation::NoReferrer) || (!hasRel(Relation::Opener) && document().settings().blankAnchorTargetImpliesNoOpenerEnabled() && equalIgnoringASCIICase(effectiveTarget, "_blank")))
</ins><span class="cx">         newFrameOpenerPolicy = NewFrameOpenerPolicy::Suppress;
</span><span class="cx"> 
</span><span class="cx">     auto privateClickMeasurement = parsePrivateClickMeasurement();
</span></span></pre>
</div>
</div>

</body>
</html>