<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[280829] releases/WebKitGTK/webkit-2.32/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/280829">280829</a></dd>
<dt>Author</dt> <dd>aperez@igalia.com</dd>
<dt>Date</dt> <dd>2021-08-10 02:19:23 -0700 (Tue, 10 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/273935">r273935</a> - "precustomized" state of custom elements can become HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=221652

Reviewed by Darin Adler.

The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on
!isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element.

This is problematic after <a href="http://trac.webkit.org/projects/webkit/changeset/266269">r266269</a> since that change re-purposes CustomElementState::Failed
on a custom element as "precustomized" state instead of introducing another enum value in
CustomElementState as RareDataBitFields has no more bits available.

This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that
to check whether JSHTMLUnknownElement should be created for a given element or not. Note that
HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking
a virtual function proved to incur too much runtime cost.

* dom/Node.h:
(WebCore::Node::isUnknownElement const): Added.
(WebCore::Node::isHTMLUnknownElement const): Added.
(WebCore::Node::isSVGUnknownElement const): Added.
(WebCore::Node::isMathMLUnknownElement const): Added.
(WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement.
* dom/make_names.pl:
(printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement
returns true instead of isCustomElementUpgradeCandidate returning false.
* html/HTMLElement.h:
(WebCore::HTMLElement::isHTMLUnknownElement const): Deleted.
* html/HTMLUnknownElement.h:
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument.
* mathml/MathMLElement.h:
* mathml/MathMLUnknownElement.h:
(WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement.
* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement): Added ConstructionType as an argument.
* svg/SVGElement.h:
* svg/SVGUnknownElement.h:
(WebCore::SVGUnknownElement::SVGUnknownElement): Set NodeFlag::IsUnknownElement.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoredomNodeh">releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Node.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoredommake_namespl">releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/make_names.pl</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCorehtmlHTMLElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCorehtmlHTMLUnknownElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLUnknownElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLElementcpp">releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLUnknownElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLUnknownElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoresvgSVGElementcpp">releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoresvgSVGElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoresvgSVGUnknownElementh">releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGUnknownElement.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit232SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog  2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog     2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -1,3 +1,45 @@
</span><ins>+2021-03-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        "precustomized" state of custom elements can become HTMLUnknownElement
+        https://bugs.webkit.org/show_bug.cgi?id=221652
+
+        Reviewed by Darin Adler.
+
+        The bug was caused by createJSHTMLWrapper in JSHTMLElementWrapperFactory.cpp relying on
+        !isCustomElementUpgradeCandidate() to create HTMLUnknownElement as JS wrapper of the element.
+
+        This is problematic after r266269 since that change re-purposes CustomElementState::Failed
+        on a custom element as "precustomized" state instead of introducing another enum value in
+        CustomElementState as RareDataBitFields has no more bits available.
+
+        This patch fixes the problem by introducing a new NodeFlag::IsUnknownElement and using that
+        to check whether JSHTMLUnknownElement should be created for a given element or not. Note that
+        HTMLElement had a virtual function, isHTMLUnknownElement, to check this condition but invoking
+        a virtual function proved to incur too much runtime cost.
+
+        * dom/Node.h:
+        (WebCore::Node::isUnknownElement const): Added.
+        (WebCore::Node::isHTMLUnknownElement const): Added.
+        (WebCore::Node::isSVGUnknownElement const): Added.
+        (WebCore::Node::isMathMLUnknownElement const): Added.
+        (WebCore::Node::NodeFlag): Added NodeFlag::IsUnknownElement.
+        * dom/make_names.pl:
+        (printWrapperFactoryCppFile): Treat the element as HTMLUnknownElement only if isUnknownElement
+        returns true instead of isCustomElementUpgradeCandidate returning false.
+        * html/HTMLElement.h:
+        (WebCore::HTMLElement::isHTMLUnknownElement const): Deleted.
+        * html/HTMLUnknownElement.h:
+        * mathml/MathMLElement.cpp:
+        (WebCore::MathMLElement::MathMLElement): Added ConstructionType as an argument.
+        * mathml/MathMLElement.h:
+        * mathml/MathMLUnknownElement.h:
+        (WebCore::MathMLUnknownElement::MathMLUnknownElement): Set NodeFlag::IsUnknownElement.
+        * svg/SVGElement.cpp:
+        (WebCore::SVGElement::SVGElement): Added ConstructionType as an argument.
+        * svg/SVGElement.h:
+        * svg/SVGUnknownElement.h:
+        (WebCore::SVGUnknownElement::SVGUnknownElement): Set NodeFlag::IsUnknownElement.
+
</ins><span class="cx"> 2021-03-01  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Protect AudioWorkletGlobalScope::registerProcessor() against re-entry
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Node.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Node.h 2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Node.h    2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -193,6 +193,11 @@
</span><span class="cx">     bool isSVGElement() const { return hasNodeFlag(NodeFlag::IsSVGElement); }
</span><span class="cx">     bool isMathMLElement() const { return hasNodeFlag(NodeFlag::IsMathMLElement); }
</span><span class="cx"> 
</span><ins>+    bool isUnknownElement() const { return hasNodeFlag(NodeFlag::IsUnknownElement); }
+    bool isHTMLUnknownElement() const { return isHTMLElement() && isUnknownElement(); }
+    bool isSVGUnknownElement() const { return isSVGElement() && isUnknownElement(); }
+    bool isMathMLUnknownElement() const { return isMathMLElement() && isUnknownElement(); }
+
</ins><span class="cx">     bool isPseudoElement() const { return pseudoId() != PseudoId::None; }
</span><span class="cx">     bool isBeforePseudoElement() const { return pseudoId() == PseudoId::Before; }
</span><span class="cx">     bool isAfterPseudoElement() const { return pseudoId() == PseudoId::After; }
</span><span class="lines">@@ -535,8 +540,8 @@
</span><span class="cx">         IsShadowRoot = 1 << 9,
</span><span class="cx">         IsConnected = 1 << 10,
</span><span class="cx">         IsInShadowTree = 1 << 11,
</span><del>-        HasEventTargetData = 1 << 12,
-        // UnusedFlag = 1 << 13,
</del><ins>+        IsUnknownElement = 1 << 12,
+        HasEventTargetData = 1 << 13,
</ins><span class="cx"> 
</span><span class="cx">         // These bits are used by derived classes, pulled up here so they can
</span><span class="cx">         // be stored in the same memory word as the Node bits above.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoredommake_namespl"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/make_names.pl (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/make_names.pl  2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/make_names.pl     2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -1277,12 +1277,19 @@
</span><span class="cx"> 
</span><span class="cx">     if ($parameters{customElementInterfaceName}) {
</span><span class="cx">         print F <<END
</span><del>-    if (element->isCustomElementUpgradeCandidate())
</del><ins>+    if (!element->isUnknownElement())
</ins><span class="cx">         return createWrapper<$parameters{customElementInterfaceName}>(globalObject, WTFMove(element));
</span><span class="cx"> END
</span><span class="cx"> ;
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    if ("$parameters{namespace}Element" eq $parameters{fallbackJSInterfaceName}) {
+        print F <<END
+    ASSERT(element->is$parameters{fallbackJSInterfaceName}());
+END
+;
+    }
+
</ins><span class="cx">     print F <<END
</span><span class="cx">     return createWrapper<$parameters{fallbackJSInterfaceName}>(globalObject, WTFMove(element));
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCorehtmlHTMLElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLElement.h 2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLElement.h    2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -86,7 +86,6 @@
</span><span class="cx">     bool hasDirectionAuto() const;
</span><span class="cx">     TextDirection directionalityIfhasDirAutoAttribute(bool& isAuto) const;
</span><span class="cx"> 
</span><del>-    virtual bool isHTMLUnknownElement() const { return false; }
</del><span class="cx">     virtual bool isTextControlInnerTextElement() const { return false; }
</span><span class="cx"> 
</span><span class="cx">     bool willRespondToMouseMoveEvents() override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCorehtmlHTMLUnknownElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLUnknownElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLUnknownElement.h  2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLUnknownElement.h     2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -43,11 +43,9 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     HTMLUnknownElement(const QualifiedName& tagName, Document& document)
</span><del>-        : HTMLElement(tagName, document, CreateHTMLElement)
</del><ins>+        : HTMLElement(tagName, document, CreateHTMLElement | NodeFlag::IsUnknownElement)
</ins><span class="cx">     {
</span><span class="cx">     }
</span><del>-
-    bool isHTMLUnknownElement() const final { return true; }
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.cpp (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.cpp   2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.cpp      2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -50,8 +50,8 @@
</span><span class="cx"> 
</span><span class="cx"> using namespace MathMLNames;
</span><span class="cx"> 
</span><del>-MathMLElement::MathMLElement(const QualifiedName& tagName, Document& document)
-    : StyledElement(tagName, document, CreateMathMLElement)
</del><ins>+MathMLElement::MathMLElement(const QualifiedName& tagName, Document& document, ConstructionType constructionType)
+    : StyledElement(tagName, document, constructionType)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.h     2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLElement.h        2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx">     virtual void updateSelectedChild() { }
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><del>-    MathMLElement(const QualifiedName& tagName, Document&);
</del><ins>+    MathMLElement(const QualifiedName& tagName, Document&, ConstructionType = CreateMathMLElement);
</ins><span class="cx"> 
</span><span class="cx">     void parseAttribute(const QualifiedName&, const AtomString&) override;
</span><span class="cx">     bool childShouldCreateRenderer(const Node&) const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoremathmlMathMLUnknownElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLUnknownElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLUnknownElement.h      2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/mathml/MathMLUnknownElement.h 2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     MathMLUnknownElement(const QualifiedName& tagName, Document& document)
</span><del>-        : MathMLElement(tagName, document)
</del><ins>+        : MathMLElement(tagName, document, CreateMathMLElement | NodeFlag::IsUnknownElement)
</ins><span class="cx">     {
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoresvgSVGElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp 2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp    2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -155,8 +155,8 @@
</span><span class="cx">     return map;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-SVGElement::SVGElement(const QualifiedName& tagName, Document& document)
-    : StyledElement(tagName, document, CreateSVGElement)
</del><ins>+SVGElement::SVGElement(const QualifiedName& tagName, Document& document, ConstructionType constructionType)
+    : StyledElement(tagName, document, constructionType)
</ins><span class="cx">     , m_propertyAnimatorFactory(makeUnique<SVGPropertyAnimatorFactory>())
</span><span class="cx"> {
</span><span class="cx">     static std::once_flag onceFlag;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoresvgSVGElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.h   2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.h      2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx">     SVGAnimatedString& classNameAnimated() { return m_className; }
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><del>-    SVGElement(const QualifiedName&, Document&);
</del><ins>+    SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElement);
</ins><span class="cx">     virtual ~SVGElement();
</span><span class="cx"> 
</span><span class="cx">     bool rendererIsNeeded(const RenderStyle&) override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCoresvgSVGUnknownElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGUnknownElement.h (280828 => 280829)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGUnknownElement.h    2021-08-10 08:57:20 UTC (rev 280828)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGUnknownElement.h       2021-08-10 09:19:23 UTC (rev 280829)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     SVGUnknownElement(const QualifiedName& tagName, Document& document)
</span><del>-        : SVGElement(tagName, document)
</del><ins>+        : SVGElement(tagName, document, CreateSVGElement | NodeFlag::IsUnknownElement)
</ins><span class="cx">     {
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>