<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[280861] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/280861">280861</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2021-08-10 13:49:44 -0700 (Tue, 10 Aug 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Deploy some more smart pointers in DOMWindow.cpp
https://bugs.webkit.org/show_bug.cgi?id=228883

Reviewed by Darin Adler.

A follow up to <a href="http://trac.webkit.org/projects/webkit/changeset/279661">r279661</a>. Deploy even more smart pointers.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::failedToRegisterDeviceMotionEventListener):
(WebCore::DOMWindow::dispatchEvent):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (280860 => 280861)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-08-10 19:50:47 UTC (rev 280860)
+++ trunk/Source/WebCore/ChangeLog      2021-08-10 20:49:44 UTC (rev 280861)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2021-08-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Deploy some more smart pointers in DOMWindow.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=228883
+
+        Reviewed by Darin Adler.
+
+        A follow up to r279661. Deploy even more smart pointers.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
+        (WebCore::DOMWindow::failedToRegisterDeviceMotionEventListener):
+        (WebCore::DOMWindow::dispatchEvent):
+
</ins><span class="cx"> 2021-08-10  Antti Koivisto  <antti@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Remove some dead code from LegacyInlineFlowBox::nodeAtPoint
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (280860 => 280861)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp  2021-08-10 19:50:47 UTC (rev 280860)
+++ trunk/Source/WebCore/page/DOMWindow.cpp     2021-08-10 20:49:44 UTC (rev 280861)
</span><span class="lines">@@ -248,7 +248,7 @@
</span><span class="cx">         if (!set.contains(window.ptr()))
</span><span class="cx">             continue;
</span><span class="cx"> 
</span><del>-        Frame* frame = window->frame();
</del><ins>+        RefPtr frame = window->frame();
</ins><span class="cx">         if (!frame)
</span><span class="cx">             continue;
</span><span class="cx"> 
</span><span class="lines">@@ -2154,7 +2154,7 @@
</span><span class="cx">     if (RegistrableDomain::uncheckedCreateFromRegistrableDomainString("chase.com"_s).matches(document()->url())) {
</span><span class="cx">         // Fire a fake DeviceMotionEvent with acceleration data to unblock the site's login flow.
</span><span class="cx">         document()->postTask([](auto& context) {
</span><del>-            if (auto* window = downcast<Document>(context).domWindow()) {
</del><ins>+            if (RefPtr window = downcast<Document>(context).domWindow()) {
</ins><span class="cx">                 auto acceleration = DeviceMotionData::Acceleration::create();
</span><span class="cx">                 window->dispatchEvent(DeviceMotionEvent::create(eventNames().devicemotionEvent, DeviceMotionData::create(acceleration.copyRef(), acceleration.copyRef(), DeviceMotionData::RotationRate::create(), std::nullopt).ptr()));
</span><span class="cx">             }
</span><span class="lines">@@ -2311,13 +2311,13 @@
</span><span class="cx">     event.setEventPhase(Event::AT_TARGET);
</span><span class="cx">     event.resetBeforeDispatch();
</span><span class="cx"> 
</span><del>-    Frame* protectedFrame = nullptr;
</del><ins>+    RefPtr<Frame> protectedFrame;
</ins><span class="cx">     bool hasListenersForEvent = false;
</span><span class="cx">     if (UNLIKELY(InspectorInstrumentation::hasFrontends())) {
</span><span class="cx">         protectedFrame = frame();
</span><span class="cx">         hasListenersForEvent = hasEventListeners(event.type());
</span><span class="cx">         if (hasListenersForEvent)
</span><del>-            InspectorInstrumentation::willDispatchEventOnWindow(protectedFrame, event, *this);
</del><ins>+            InspectorInstrumentation::willDispatchEventOnWindow(protectedFrame.get(), event, *this);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     // FIXME: We should use EventDispatcher everywhere.
</span><span class="lines">@@ -2325,7 +2325,7 @@
</span><span class="cx">     fireEventListeners(event, EventInvokePhase::Bubbling);
</span><span class="cx"> 
</span><span class="cx">     if (hasListenersForEvent)
</span><del>-        InspectorInstrumentation::didDispatchEventOnWindow(protectedFrame, event);
</del><ins>+        InspectorInstrumentation::didDispatchEventOnWindow(protectedFrame.get(), event);
</ins><span class="cx"> 
</span><span class="cx">     event.resetAfterDispatch();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>