<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[280439] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/280439">280439</a></dd>
<dt>Author</dt> <dd>peng.liu6@apple.com</dd>
<dt>Date</dt> <dd>2021-07-29 12:04:52 -0700 (Thu, 29 Jul 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Catalina][GPUP] Some API tests fail after GPU Process features are enabled
https://bugs.webkit.org/show_bug.cgi?id=228589

Reviewed by Aakash Jain.

Disable a few API tests while the investigation is ongoing.

* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
* TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
(TEST_F):
* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitGetUserMediamm">trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitCocoaAudioBufferSizemm">trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitCocoaNowPlayingmm">trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitCocoaPreferredAudioBufferSizemm">trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (280438 => 280439)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/ChangeLog       2021-07-29 19:04:52 UTC (rev 280439)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2021-07-29  Peng Liu  <peng.liu6@apple.com>
+
+        [Catalina][GPUP] Some API tests fail after GPU Process features are enabled
+        https://bugs.webkit.org/show_bug.cgi?id=228589
+
+        Reviewed by Aakash Jain.
+
+        Disable a few API tests while the investigation is ongoing.
+
+        * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
+        (TEST_F):
+        * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
+        (TEST_F):
+
</ins><span class="cx"> 2021-07-29  Aakash Jain  <aakash_jain@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Send email notification when VerifyGitHubIntegrity step fails
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitGetUserMediamm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (280438 => 280439)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm   2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm      2021-07-29 19:04:52 UTC (rev 280439)
</span><span class="lines">@@ -648,7 +648,7 @@
</span><span class="cx">     EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST(WebKit2, CrashGPUProcessAfterApplyingConstraints)
</del><ins>+TEST(WebKit2, DISABLED_CrashGPUProcessAfterApplyingConstraints)
</ins><span class="cx"> {
</span><span class="cx">     auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
</span><span class="cx">     auto preferences = [configuration preferences];
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitCocoaAudioBufferSizemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm (280438 => 280439)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm   2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm      2021-07-29 19:04:52 UTC (rev 280439)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx">     return 0;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST(WebKit, AudioBufferSize)
</del><ins>+TEST(WebKit, DISABLED_AudioBufferSize)
</ins><span class="cx"> {
</span><span class="cx">     auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
</span><span class="cx">     auto context = adoptWK(TestWebKitAPI::Util::createContextForInjectedBundleTest("InternalsInjectedBundleTest"));
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitCocoaNowPlayingmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm (280438 => 280439)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm        2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm   2021-07-29 19:04:52 UTC (rev 280439)
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx">     HashMap<CFNotificationName, NotificationCallback> _callbacks;
</span><span class="cx"> };
</span><span class="cx"> 
</span><del>-TEST_F(NowPlayingTest, AudioElement)
</del><ins>+TEST_F(NowPlayingTest, DISABLED_AudioElement)
</ins><span class="cx"> {
</span><span class="cx">     executeAndWaitForWebViewToBecomeNowPlaying([&] {
</span><span class="cx">         executeAndWaitForPlaying([&] {
</span><span class="lines">@@ -214,7 +214,7 @@
</span><span class="cx">     });
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(NowPlayingTest, VideoElementWithAudio)
</del><ins>+TEST_F(NowPlayingTest, DISABLED_VideoElementWithAudio)
</ins><span class="cx"> {
</span><span class="cx">     executeAndWaitForWebViewToBecomeNowPlaying([&] {
</span><span class="cx">         executeAndWaitForPlaying([&] {
</span><span class="lines">@@ -246,7 +246,7 @@
</span><span class="cx">     ASSERT_NE(webViewPid(), getNowPlayingClientPid());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(NowPlayingTest, VideoElementWithMutedAudioUnmutedWithUserGesture)
</del><ins>+TEST_F(NowPlayingTest, DISABLED_VideoElementWithMutedAudioUnmutedWithUserGesture)
</ins><span class="cx"> {
</span><span class="cx">     executeAndWaitForPlaying([&] {
</span><span class="cx">         loadPage("now-playing");
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitCocoaPreferredAudioBufferSizemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm (280438 => 280439)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm  2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm     2021-07-29 19:04:52 UTC (rev 280439)
</span><span class="lines">@@ -79,32 +79,32 @@
</span><span class="cx">     EXPECT_EQ(512, preferredAudioBufferSize());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, AudioElement)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_AudioElement)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"audio-only", 4096);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, WebAudio)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_WebAudio)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"web-audio-only", 128);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, VideoOnly)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_VideoOnly)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"video-without-audio", 4096);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, VideoWithAudio)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudio)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"video-with-audio", 4096);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, AudioWithWebAudio)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_AudioWithWebAudio)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"audio-with-web-audio", 128);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TEST_F(PreferredAudioBufferSize, VideoWithAudioAndWebAudio)
</del><ins>+TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudioAndWebAudio)
</ins><span class="cx"> {
</span><span class="cx">     runPlayingTestWithPageNamed(@"video-with-audio-and-web-audio", 128);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>