<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[280133] releases/WebKitGTK/webkit-2.32/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/280133">280133</a></dd>
<dt>Author</dt> <dd>aperez@igalia.com</dd>
<dt>Date</dt> <dd>2021-07-21 07:44:41 -0700 (Wed, 21 Jul 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/274025">r274025</a> - CanvasRenderingContext2DBase::canDrawTextWithParams() needs to resolve styles before using the drawingContext
https://bugs.webkit.org/show_bug.cgi?id=221257
<rdar://problem/73878095>

Reviewed by Ryosuke Niwa.

Simply call fontProxy() (which internally resolves styles) before calling drawingContext().

Test: fast/text/canvas-synchronous-events.html

* html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::canDrawTextWithParams):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit232SourceWebCorehtmlcanvasCanvasRenderingContext2DBasecpp">releases/WebKitGTK/webkit-2.32/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit232SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (280132 => 280133)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog  2021-07-21 14:44:35 UTC (rev 280132)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog     2021-07-21 14:44:41 UTC (rev 280133)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2021-03-05  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        CanvasRenderingContext2DBase::canDrawTextWithParams() needs to resolve styles before using the drawingContext
+        https://bugs.webkit.org/show_bug.cgi?id=221257
+        <rdar://problem/73878095>
+
+        Reviewed by Ryosuke Niwa.
+
+        Simply call fontProxy() (which internally resolves styles) before calling drawingContext().
+
+        Test: fast/text/canvas-synchronous-events.html
+
+        * html/canvas/CanvasRenderingContext2DBase.cpp:
+        (WebCore::CanvasRenderingContext2DBase::canDrawTextWithParams):
+
</ins><span class="cx"> 2021-03-12  Rob Buis  <rbuis@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Cancel image loader events after first dispatch
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit232SourceWebCorehtmlcanvasCanvasRenderingContext2DBasecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (280132 => 280133)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.32/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp       2021-07-21 14:44:35 UTC (rev 280132)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp  2021-07-21 14:44:41 UTC (rev 280133)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2004-2017 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2004-2021 Apple Inc. All rights reserved.
</ins><span class="cx">  * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
</span><span class="cx">  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
</span><span class="cx">  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
</span><span class="lines">@@ -61,6 +61,7 @@
</span><span class="cx"> #include "RenderImage.h"
</span><span class="cx"> #include "RenderLayer.h"
</span><span class="cx"> #include "RenderTheme.h"
</span><ins>+#include "ScriptDisallowedScope.h"
</ins><span class="cx"> #include "SecurityOrigin.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "StrokeStyleApplier.h"
</span><span class="lines">@@ -2438,11 +2439,14 @@
</span><span class="cx"> 
</span><span class="cx"> bool CanvasRenderingContext2DBase::canDrawTextWithParams(float x, float y, bool fill, Optional<float> maxWidth)
</span><span class="cx"> {
</span><ins>+    if (!fontProxy()->realized())
+        return false;
+
+    ScriptDisallowedScope::InMainThread scriptDisallowedScope;
+
</ins><span class="cx">     auto* c = drawingContext();
</span><span class="cx">     if (!c)
</span><span class="cx">         return false;
</span><del>-    if (!this->fontProxy()->realized())
-        return false;
</del><span class="cx">     if (!state().hasInvertibleTransform)
</span><span class="cx">         return false;
</span><span class="cx">     if (!std::isfinite(x) | !std::isfinite(y))
</span></span></pre>
</div>
</div>

</body>
</html>