<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[279659] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/279659">279659</a></dd>
<dt>Author</dt> <dd>akeerthi@apple.com</dd>
<dt>Date</dt> <dd>2021-07-07 12:46:08 -0700 (Wed, 07 Jul 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
https://bugs.webkit.org/show_bug.cgi?id=227043
<rdar://problem/79629354>

Reviewed by Wenson Hsieh.

Source/WebCore:

In iOS 15, submit buttons have a different appearance from standard
buttons, matching UIKit's "preferred" button style.

Previously, all buttons had the same styling, which meant that
input[type="submit"] and button[type="submit"] had the same
appearance by default. The changes made for iOS 15 were applied to
input[type="submit"], but not button[type="submit"], leading to
inconsistent styling.

Test: fast/forms/ios/form-control-refresh/button/button-type-submit.html

* css/html.css:

Ensure the different style applied to input[type="submit"] also applies
to button[type="submit"].

Additionally, apply the new style to button[type="menu"]. This type is
unsupported, but should have the same appearance as a submit button,
according to the button-type-menu-historical.html web platform test.

LayoutTests:

Added a reference test to verify that input[type="submit"] and
button[type="submit"] have the same appearance.

* fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html: Added.
* fast/forms/ios/form-control-refresh/button/button-type-submit.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecsshtmlcss">trunk/Source/WebCore/css/html.css</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/</li>
<li><a href="#trunkLayoutTestsfastformsiosformcontrolrefreshbuttonbuttontypesubmitexpectedhtml">trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastformsiosformcontrolrefreshbuttonbuttontypesubmithtml">trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (279658 => 279659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-07-07 19:43:49 UTC (rev 279658)
+++ trunk/LayoutTests/ChangeLog 2021-07-07 19:46:08 UTC (rev 279659)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2021-07-07  Aditya Keerthi  <akeerthi@apple.com>
+
+        [iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
+        https://bugs.webkit.org/show_bug.cgi?id=227043
+        <rdar://problem/79629354>
+
+        Reviewed by Wenson Hsieh.
+
+        Added a reference test to verify that input[type="submit"] and
+        button[type="submit"] have the same appearance.
+
+        * fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html: Added.
+        * fast/forms/ios/form-control-refresh/button/button-type-submit.html: Added.
+
</ins><span class="cx"> 2021-07-07  Commit Queue  <commit-queue@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, reverting r279271.
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsiosformcontrolrefreshbuttonbuttontypesubmitexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html (0 => 279659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html                            (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html       2021-07-07 19:46:08 UTC (rev 279659)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ IOSFormControlRefreshEnabled=true ] -->
+<html>
+<head>
+<meta name="viewport" content="width=device-width, initial-scale=1">
+</head>
+<body>
+<input type="submit" value="Submit">
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformsiosformcontrolrefreshbuttonbuttontypesubmithtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html (0 => 279659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html                             (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html        2021-07-07 19:46:08 UTC (rev 279659)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ IOSFormControlRefreshEnabled=true ] -->
+<html>
+<head>
+<meta name="viewport" content="width=device-width, initial-scale=1">
+</head>
+<body>
+<button type="submit">Submit</button>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (279658 => 279659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-07-07 19:43:49 UTC (rev 279658)
+++ trunk/Source/WebCore/ChangeLog      2021-07-07 19:46:08 UTC (rev 279659)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2021-07-07  Aditya Keerthi  <akeerthi@apple.com>
+
+        [iOS] Inconsistent styling for input[type="submit"] and button[type="submit"]
+        https://bugs.webkit.org/show_bug.cgi?id=227043
+        <rdar://problem/79629354>
+
+        Reviewed by Wenson Hsieh.
+
+        In iOS 15, submit buttons have a different appearance from standard
+        buttons, matching UIKit's "preferred" button style.
+
+        Previously, all buttons had the same styling, which meant that
+        input[type="submit"] and button[type="submit"] had the same
+        appearance by default. The changes made for iOS 15 were applied to
+        input[type="submit"], but not button[type="submit"], leading to
+        inconsistent styling.
+
+        Test: fast/forms/ios/form-control-refresh/button/button-type-submit.html
+
+        * css/html.css:
+
+        Ensure the different style applied to input[type="submit"] also applies
+        to button[type="submit"].
+
+        Additionally, apply the new style to button[type="menu"]. This type is
+        unsupported, but should have the same appearance as a submit button,
+        according to the button-type-menu-historical.html web platform test.
+
</ins><span class="cx"> 2021-07-07  Fujii Hironori  <Hironori.Fujii@sony.com>
</span><span class="cx"> 
</span><span class="cx">         [Cairo] Merge PlatformContextCairo into GraphicsContextCairo
</span></span></pre></div>
<a id="trunkSourceWebCorecsshtmlcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/html.css (279658 => 279659)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/html.css        2021-07-07 19:43:49 UTC (rev 279658)
+++ trunk/Source/WebCore/css/html.css   2021-07-07 19:46:08 UTC (rev 279659)
</span><span class="lines">@@ -852,7 +852,9 @@
</span><span class="cx"> 
</span><span class="cx"> #if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY
</span><span class="cx"> 
</span><del>-input[type="submit"], input[type="submit"]:active {
</del><ins>+input[type="submit"], input[type="submit"]:active,
+button[type="submit"], button[type="submit"]:active,
+button[type="menu"], button[type="menu"]:active {
</ins><span class="cx">     background-color: -apple-system-blue;
</span><span class="cx">     color: white;
</span><span class="cx">     font-weight: bold;
</span></span></pre>
</div>
</div>

</body>
</html>