<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[278849] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/278849">278849</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-06-14 14:36:12 -0700 (Mon, 14 Jun 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Pass PAL::SessionID by value instead of reference
https://bugs.webkit.org/show_bug.cgi?id=226983

Patch by Alex Christensen <achristensen@webkit.org> on 2021-06-14
Reviewed by Geoffrey Garen.

Source/WebCore:

It's a wrapper around an integer which will pass in a register.
There's no reason to pass a pointer to it.

* loader/CrossOriginAccessControl.cpp:
(WebCore::validatePreflightResponse):
* loader/CrossOriginAccessControl.h:
* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
* loader/CrossOriginPreflightResultCache.h:
* loader/EmptyClients.cpp:
* loader/cache/CachedApplicationManifest.cpp:
(WebCore::CachedApplicationManifest::CachedApplicationManifest):
* loader/cache/CachedApplicationManifest.h:
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument):
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::CachedSVGFont):
* loader/cache/CachedSVGFont.h:
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
* loader/cache/CachedScript.h:
* loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::CachedTextTrack):
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
* loader/cache/CachedXSLStyleSheet.h:
* page/DatabaseProvider.h:
* platform/WebCoreCrossThreadCopier.cpp:
(WTF::PAL::SessionID>::copy):
* platform/WebCoreCrossThreadCopier.h:
* storage/StorageNamespaceProvider.cpp:
(WebCore::StorageNamespaceProvider::setSessionIDForTesting):
* storage/StorageNamespaceProvider.h:

Source/WebKit:

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::newTestingSession):
(WebKit::NetworkProcess::ensureSession):
(WebKit::NetworkProcess::storageSession const):
(WebKit::NetworkProcess::findCacheEngine):
(WebKit::NetworkProcess::ensureCacheEngine):
(WebKit::NetworkProcess::removeCacheEngine):
(WebKit::NetworkProcess::flushCookies):
(WebKit::NetworkProcess::platformFlushCookies):
(WebKit::NetworkProcess::addWebPageNetworkParameters):
(WebKit::NetworkProcess::removeWebPageNetworkParameters):
(WebKit::NetworkProcess::countNonDefaultSessionSets):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/NetworkStorageSessionProvider.h:
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
* NetworkProcess/cache/NetworkCache.h:
(WebKit::NetworkCache::Cache::sessionID const):
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::flushCookies):
(WebKit::NetworkProcess::platformFlushCookies):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::flushCookies):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebProcessPool.h:
* WebProcess/Databases/WebDatabaseProvider.cpp:
(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
* WebProcess/Databases/WebDatabaseProvider.h:

Source/WebKitLegacy:

* Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::idbConnectionToServerForSession):
* Storage/WebDatabaseProvider.h:
* WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::storageSession):
(NetworkStorageSessionMap::ensureSession):
(NetworkStorageSessionMap::destroySession):
* WebCoreSupport/NetworkStorageSessionMap.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderCrossOriginAccessControlcpp">trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderCrossOriginAccessControlh">trunk/Source/WebCore/loader/CrossOriginAccessControl.h</a></li>
<li><a href="#trunkSourceWebCoreloaderCrossOriginPreflightResultCachecpp">trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderCrossOriginPreflightResultCacheh">trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h</a></li>
<li><a href="#trunkSourceWebCoreloaderEmptyClientscpp">trunk/Source/WebCore/loader/EmptyClients.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedApplicationManifestcpp">trunk/Source/WebCore/loader/cache/CachedApplicationManifest.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedApplicationManifesth">trunk/Source/WebCore/loader/cache/CachedApplicationManifest.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedCSSStyleSheetcpp">trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedCSSStyleSheeth">trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedFontcpp">trunk/Source/WebCore/loader/cache/CachedFont.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedFonth">trunk/Source/WebCore/loader/cache/CachedFont.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedImagecpp">trunk/Source/WebCore/loader/cache/CachedImage.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedImageh">trunk/Source/WebCore/loader/cache/CachedImage.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedRawResourcecpp">trunk/Source/WebCore/loader/cache/CachedRawResource.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedRawResourceh">trunk/Source/WebCore/loader/cache/CachedRawResource.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourcecpp">trunk/Source/WebCore/loader/cache/CachedResource.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourceh">trunk/Source/WebCore/loader/cache/CachedResource.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourceLoadercpp">trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedResourceLoaderh">trunk/Source/WebCore/loader/cache/CachedResourceLoader.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedSVGDocumentcpp">trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedSVGDocumenth">trunk/Source/WebCore/loader/cache/CachedSVGDocument.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedSVGFontcpp">trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedSVGFonth">trunk/Source/WebCore/loader/cache/CachedSVGFont.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedScriptcpp">trunk/Source/WebCore/loader/cache/CachedScript.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedScripth">trunk/Source/WebCore/loader/cache/CachedScript.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedTextTrackcpp">trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedTextTrackh">trunk/Source/WebCore/loader/cache/CachedTextTrack.h</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedXSLStyleSheetcpp">trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCoreloadercacheCachedXSLStyleSheeth">trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h</a></li>
<li><a href="#trunkSourceWebCorepageDatabaseProviderh">trunk/Source/WebCore/page/DatabaseProvider.h</a></li>
<li><a href="#trunkSourceWebCoreplatformWebCoreCrossThreadCopiercpp">trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformWebCoreCrossThreadCopierh">trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.h</a></li>
<li><a href="#trunkSourceWebCorestorageStorageNamespaceProvidercpp">trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp</a></li>
<li><a href="#trunkSourceWebCorestorageStorageNamespaceProviderh">trunk/Source/WebCore/storage/StorageNamespaceProvider.h</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessNetworkProcesscpp">trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessNetworkProcessh">trunk/Source/WebKit/NetworkProcess/NetworkProcess.h</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessNetworkResourceLoadercpp">trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessNetworkResourceLoaderh">trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h</a></li>
<li><a href="#trunkSourceWebKitNetworkProcessNetworkStorageSessionProviderh">trunk/Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h</a></li>
<li><a href="#trunkSourceWebKitNetworkProcesscacheNetworkCachecpp">trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp</a></li>
<li><a href="#trunkSourceWebKitNetworkProcesscacheNetworkCacheh">trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h</a></li>
<li><a href="#trunkSourceWebKitNetworkProcesscocoaNetworkProcessCocoamm">trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm</a></li>
<li><a href="#trunkSourceWebKitNetworkProcesscocoaNetworkSessionCocoamm">trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessNetworkNetworkProcessProxycpp">trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessNetworkNetworkProcessProxyh">trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebProcessPoolh">trunk/Source/WebKit/UIProcess/WebProcessPool.h</a></li>
<li><a href="#trunkSourceWebKitWebProcessDatabasesWebDatabaseProvidercpp">trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcessDatabasesWebDatabaseProviderh">trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h</a></li>
<li><a href="#trunkSourceWebKitLegacyChangeLog">trunk/Source/WebKitLegacy/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitLegacyStorageWebDatabaseProvidercpp">trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp</a></li>
<li><a href="#trunkSourceWebKitLegacyStorageWebDatabaseProviderh">trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.h</a></li>
<li><a href="#trunkSourceWebKitLegacyWebCoreSupportNetworkStorageSessionMapcpp">trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp</a></li>
<li><a href="#trunkSourceWebKitLegacyWebCoreSupportNetworkStorageSessionMaph">trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/ChangeLog      2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1,3 +1,66 @@
</span><ins>+2021-06-14  Alex Christensen  <achristensen@webkit.org>
+
+        Pass PAL::SessionID by value instead of reference
+        https://bugs.webkit.org/show_bug.cgi?id=226983
+
+        Reviewed by Geoffrey Garen.
+
+        It's a wrapper around an integer which will pass in a register.
+        There's no reason to pass a pointer to it.
+
+        * loader/CrossOriginAccessControl.cpp:
+        (WebCore::validatePreflightResponse):
+        * loader/CrossOriginAccessControl.h:
+        * loader/CrossOriginPreflightResultCache.cpp:
+        (WebCore::CrossOriginPreflightResultCache::appendEntry):
+        (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
+        * loader/CrossOriginPreflightResultCache.h:
+        * loader/EmptyClients.cpp:
+        * loader/cache/CachedApplicationManifest.cpp:
+        (WebCore::CachedApplicationManifest::CachedApplicationManifest):
+        * loader/cache/CachedApplicationManifest.h:
+        * loader/cache/CachedCSSStyleSheet.cpp:
+        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
+        * loader/cache/CachedCSSStyleSheet.h:
+        * loader/cache/CachedFont.cpp:
+        (WebCore::CachedFont::CachedFont):
+        * loader/cache/CachedFont.h:
+        * loader/cache/CachedImage.cpp:
+        (WebCore::CachedImage::CachedImage):
+        * loader/cache/CachedImage.h:
+        * loader/cache/CachedRawResource.cpp:
+        (WebCore::CachedRawResource::CachedRawResource):
+        * loader/cache/CachedRawResource.h:
+        * loader/cache/CachedResource.cpp:
+        (WebCore::CachedResource::CachedResource):
+        * loader/cache/CachedResource.h:
+        * loader/cache/CachedResourceLoader.cpp:
+        (WebCore::createResource):
+        (WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
+        * loader/cache/CachedResourceLoader.h:
+        * loader/cache/CachedSVGDocument.cpp:
+        (WebCore::CachedSVGDocument::CachedSVGDocument):
+        * loader/cache/CachedSVGDocument.h:
+        * loader/cache/CachedSVGFont.cpp:
+        (WebCore::CachedSVGFont::CachedSVGFont):
+        * loader/cache/CachedSVGFont.h:
+        * loader/cache/CachedScript.cpp:
+        (WebCore::CachedScript::CachedScript):
+        * loader/cache/CachedScript.h:
+        * loader/cache/CachedTextTrack.cpp:
+        (WebCore::CachedTextTrack::CachedTextTrack):
+        * loader/cache/CachedTextTrack.h:
+        * loader/cache/CachedXSLStyleSheet.cpp:
+        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
+        * loader/cache/CachedXSLStyleSheet.h:
+        * page/DatabaseProvider.h:
+        * platform/WebCoreCrossThreadCopier.cpp:
+        (WTF::PAL::SessionID>::copy):
+        * platform/WebCoreCrossThreadCopier.h:
+        * storage/StorageNamespaceProvider.cpp:
+        (WebCore::StorageNamespaceProvider::setSessionIDForTesting):
+        * storage/StorageNamespaceProvider.h:
+
</ins><span class="cx"> 2021-06-14  Patrick Angle  <pangle@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: CSS variables not handled as case sensitive
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderCrossOriginAccessControlcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx">     return { };
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-Expected<void, String> validatePreflightResponse(const PAL::SessionID& sessionID, const ResourceRequest& request, const ResourceResponse& response, StoredCredentialsPolicy storedCredentialsPolicy, const SecurityOrigin& securityOrigin, const CrossOriginAccessControlCheckDisabler* checkDisabler)
</del><ins>+Expected<void, String> validatePreflightResponse(PAL::SessionID sessionID, const ResourceRequest& request, const ResourceResponse& response, StoredCredentialsPolicy storedCredentialsPolicy, const SecurityOrigin& securityOrigin, const CrossOriginAccessControlCheckDisabler* checkDisabler)
</ins><span class="cx"> {
</span><span class="cx">     if (!response.isSuccessful())
</span><span class="cx">         return makeUnexpected("Preflight response is not successful"_s);
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderCrossOriginAccessControlh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/CrossOriginAccessControl.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/CrossOriginAccessControl.h   2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/CrossOriginAccessControl.h      2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> WEBCORE_EXPORT Expected<void, String> passesAccessControlCheck(const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
</span><del>-WEBCORE_EXPORT Expected<void, String> validatePreflightResponse(const PAL::SessionID&, const ResourceRequest&, const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
</del><ins>+WEBCORE_EXPORT Expected<void, String> validatePreflightResponse(PAL::SessionID, const ResourceRequest&, const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
</ins><span class="cx"> 
</span><span class="cx"> WEBCORE_EXPORT std::optional<ResourceError> validateCrossOriginResourcePolicy(const SecurityOrigin&, const URL&, const ResourceResponse&);
</span><span class="cx"> std::optional<ResourceError> validateRangeRequestedFlag(const ResourceRequest&, const ResourceResponse&);
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderCrossOriginPreflightResultCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -121,13 +121,13 @@
</span><span class="cx">     return cache;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void CrossOriginPreflightResultCache::appendEntry(const PAL::SessionID& sessionID, const String& origin, const URL& url, std::unique_ptr<CrossOriginPreflightResultCacheItem> preflightResult)
</del><ins>+void CrossOriginPreflightResultCache::appendEntry(PAL::SessionID sessionID, const String& origin, const URL& url, std::unique_ptr<CrossOriginPreflightResultCacheItem> preflightResult)
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(isMainThread());
</span><span class="cx">     m_preflightHashMap.set(std::make_tuple(sessionID, origin, url), WTFMove(preflightResult));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool CrossOriginPreflightResultCache::canSkipPreflight(const PAL::SessionID& sessionID, const String& origin, const URL& url, StoredCredentialsPolicy storedCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders)
</del><ins>+bool CrossOriginPreflightResultCache::canSkipPreflight(PAL::SessionID sessionID, const String& origin, const URL& url, StoredCredentialsPolicy storedCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders)
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(isMainThread());
</span><span class="cx">     auto it = m_preflightHashMap.find(std::make_tuple(sessionID, origin, url));
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderCrossOriginPreflightResultCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -67,8 +67,8 @@
</span><span class="cx">     WTF_MAKE_NONCOPYABLE(CrossOriginPreflightResultCache); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx">     WEBCORE_EXPORT static CrossOriginPreflightResultCache& singleton();
</span><del>-    WEBCORE_EXPORT void appendEntry(const PAL::SessionID&, const String& origin, const URL&, std::unique_ptr<CrossOriginPreflightResultCacheItem>);
-    WEBCORE_EXPORT bool canSkipPreflight(const PAL::SessionID&, const String& origin, const URL&, StoredCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders);
</del><ins>+    WEBCORE_EXPORT void appendEntry(PAL::SessionID, const String& origin, const URL&, std::unique_ptr<CrossOriginPreflightResultCacheItem>);
+    WEBCORE_EXPORT bool canSkipPreflight(PAL::SessionID, const String& origin, const URL&, StoredCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders);
</ins><span class="cx">     WEBCORE_EXPORT void clear();
</span><span class="cx"> 
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderEmptyClientscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/EmptyClients.cpp     2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp        2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -202,7 +202,7 @@
</span><span class="cx">         ~EmptyIDBConnectionToServerDeletegate() { }
</span><span class="cx">     };
</span><span class="cx"> 
</span><del>-    IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) final
</del><ins>+    IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) final
</ins><span class="cx">     {
</span><span class="cx">         static NeverDestroyed<EmptyIDBConnectionToServerDeletegate> emptyDelegate;
</span><span class="cx">         static auto& emptyConnection = IDBClient::IDBConnectionToServer::create(emptyDelegate.get()).leakRef();
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedApplicationManifestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedApplicationManifest.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedApplicationManifest.cpp  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedApplicationManifest.cpp     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedApplicationManifest::CachedApplicationManifest(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedApplicationManifest::CachedApplicationManifest(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::ApplicationManifest, sessionID, cookieJar)
</span><span class="cx">     , m_decoder(TextResourceDecoder::create("application/manifest+json", UTF8Encoding()))
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedApplicationManifesth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedApplicationManifest.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedApplicationManifest.h    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedApplicationManifest.h       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedApplicationManifest final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedApplicationManifest(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedApplicationManifest(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
</ins><span class="cx"> 
</span><span class="cx">     std::optional<struct ApplicationManifest> process(const URL& manifestURL, const URL& documentURL, Document* = nullptr);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedCSSStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedCSSStyleSheet::CachedCSSStyleSheet(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedCSSStyleSheet::CachedCSSStyleSheet(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::CSSStyleSheet, sessionID, cookieJar)
</span><span class="cx">     , m_decoder(TextResourceDecoder::create("text/css", request.charset()))
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedCSSStyleSheeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedCSSStyleSheet final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedCSSStyleSheet(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedCSSStyleSheet(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
</ins><span class="cx">     virtual ~CachedCSSStyleSheet();
</span><span class="cx"> 
</span><span class="cx">     enum class MIMETypeCheckHint { Strict, Lax };
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedFontcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedFont.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedFont.cpp 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedFont.cpp    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedFont::CachedFont(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, Type type)
</del><ins>+CachedFont::CachedFont(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, Type type)
</ins><span class="cx">     : CachedResource(WTFMove(request), type, sessionID, cookieJar)
</span><span class="cx">     , m_loadInitiated(false)
</span><span class="cx">     , m_hasCreatedFontDataWrappingResource(false)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedFonth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedFont.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedFont.h   2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedFont.h      2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "CachedResourceClient.h"
</span><span class="cx"> #include "Font.h"
</span><span class="cx"> #include "TextFlags.h"
</span><ins>+#include <pal/SessionID.h>
</ins><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="lines">@@ -45,7 +46,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedFont : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedFont(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, Type = Type::FontResource);
</del><ins>+    CachedFont(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, Type = Type::FontResource);
</ins><span class="cx">     virtual ~CachedFont();
</span><span class="cx"> 
</span><span class="cx">     void beginLoadIfNeeded(CachedResourceLoader&);
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedImage.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedImage::CachedImage(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedImage::CachedImage(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::ImageResource, sessionID, cookieJar)
</span><span class="cx">     , m_updateImageDataCount(0)
</span><span class="cx">     , m_isManuallyCached(false)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx">     setStatus(Unknown);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-CachedImage::CachedImage(Image* image, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedImage::CachedImage(Image* image, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(URL(), Type::ImageResource, sessionID, cookieJar)
</span><span class="cx">     , m_image(image)
</span><span class="cx">     , m_updateImageDataCount(0)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-CachedImage::CachedImage(const URL& url, Image* image, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const String& domainForCachePartition)
</del><ins>+CachedImage::CachedImage(const URL& url, Image* image, PAL::SessionID sessionID, const CookieJar* cookieJar, const String& domainForCachePartition)
</ins><span class="cx">     : CachedResource(url, Type::ImageResource, sessionID, cookieJar)
</span><span class="cx">     , m_image(image)
</span><span class="cx">     , m_updateImageDataCount(0)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedImageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedImage.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -47,10 +47,10 @@
</span><span class="cx">     friend class MemoryCache;
</span><span class="cx"> 
</span><span class="cx"> public:
</span><del>-    CachedImage(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
-    CachedImage(Image*, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedImage(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
+    CachedImage(Image*, PAL::SessionID, const CookieJar*);
</ins><span class="cx">     // Constructor to use for manually cached images.
</span><del>-    CachedImage(const URL&, Image*, const PAL::SessionID&, const CookieJar*, const String& domainForCachePartition);
</del><ins>+    CachedImage(const URL&, Image*, PAL::SessionID, const CookieJar*, const String& domainForCachePartition);
</ins><span class="cx">     virtual ~CachedImage();
</span><span class="cx"> 
</span><span class="cx">     WEBCORE_EXPORT Image* image(); // Returns the nullImage() if the image is not available yet.
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedRawResourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedRawResource.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedRawResource.cpp  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedRawResource.cpp     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedRawResource::CachedRawResource(CachedResourceRequest&& request, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedRawResource::CachedRawResource(CachedResourceRequest&& request, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), type, sessionID, cookieJar)
</span><span class="cx">     , m_identifier(0)
</span><span class="cx">     , m_allowEncodedDataReplacement(true)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedRawResourceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedRawResource.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedRawResource.h    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedRawResource.h       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedRawResource final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedRawResource(CachedResourceRequest&&, Type, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedRawResource(CachedResourceRequest&&, Type, PAL::SessionID, const CookieJar*);
</ins><span class="cx"> 
</span><span class="cx">     void setDefersLoading(bool);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResource.cpp     2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp        2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> 
</span><span class="cx"> DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedResourceLeakCounter, ("CachedResource"));
</span><span class="cx"> 
</span><del>-CachedResource::CachedResource(CachedResourceRequest&& request, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedResource::CachedResource(CachedResourceRequest&& request, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : m_options(request.options())
</span><span class="cx">     , m_resourceRequest(request.releaseResourceRequest())
</span><span class="cx">     , m_decodedDataDeletionTimer(*this, &CachedResource::destroyDecodedData, deadDecodedDataDeletionIntervalForResourceType(type))
</span><span class="lines">@@ -121,7 +121,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> // FIXME: For this constructor, we should probably mandate that the URL has no fragment identifier.
</span><del>-CachedResource::CachedResource(const URL& url, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedResource::CachedResource(const URL& url, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : m_resourceRequest(url)
</span><span class="cx">     , m_decodedDataDeletionTimer(*this, &CachedResource::destroyDecodedData, deadDecodedDataDeletionIntervalForResourceType(type))
</span><span class="cx">     , m_sessionID(sessionID)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResource.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResource.h       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedResource.h  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx">     static constexpr unsigned bitWidthOfStatus = 3;
</span><span class="cx">     static_assert(static_cast<unsigned>(DecodeError) <= ((1ULL << bitWidthOfStatus) - 1));
</span><span class="cx"> 
</span><del>-    CachedResource(CachedResourceRequest&&, Type, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedResource(CachedResourceRequest&&, Type, PAL::SessionID, const CookieJar*);
</ins><span class="cx">     virtual ~CachedResource();
</span><span class="cx"> 
</span><span class="cx">     virtual void load(CachedResourceLoader&);
</span><span class="lines">@@ -296,7 +296,7 @@
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><span class="cx">     // CachedResource constructor that may be used when the CachedResource can already be filled with response data.
</span><del>-    CachedResource(const URL&, Type, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedResource(const URL&, Type, PAL::SessionID, const CookieJar*);
</ins><span class="cx"> 
</span><span class="cx">     void setEncodedSize(unsigned);
</span><span class="cx">     void setDecodedSize(unsigned);
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx">     return makeUnexpected(cachedResource.error());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-static CachedResourceHandle<CachedResource> createResource(CachedResource::Type type, CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
</del><ins>+static CachedResourceHandle<CachedResource> createResource(CachedResource::Type type, CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
</ins><span class="cx"> {
</span><span class="cx">     switch (type) {
</span><span class="cx">     case CachedResource::Type::ImageResource:
</span><span class="lines">@@ -744,7 +744,7 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-CachedResourceHandle<CachedResource> CachedResourceLoader::updateCachedResourceWithCurrentRequest(const CachedResource& resource, CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar& cookieJar, const Settings& settings)
</del><ins>+CachedResourceHandle<CachedResource> CachedResourceLoader::updateCachedResourceWithCurrentRequest(const CachedResource& resource, CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar& cookieJar, const Settings& settings)
</ins><span class="cx"> {
</span><span class="cx">     if (!isResourceSuitableForDirectReuse(resource, request)) {
</span><span class="cx">         request.setCachingPolicy(CachingPolicy::DisallowCaching);
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedResourceLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.h    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx">     RevalidationPolicy determineRevalidationPolicy(CachedResource::Type, CachedResourceRequest&, CachedResource* existingResource, ForPreload, ImageLoading) const;
</span><span class="cx"> 
</span><span class="cx">     bool shouldUpdateCachedResourceWithCurrentRequest(const CachedResource&, const CachedResourceRequest&);
</span><del>-    CachedResourceHandle<CachedResource> updateCachedResourceWithCurrentRequest(const CachedResource&, CachedResourceRequest&&, const PAL::SessionID&, const CookieJar&, const Settings&);
</del><ins>+    CachedResourceHandle<CachedResource> updateCachedResourceWithCurrentRequest(const CachedResource&, CachedResourceRequest&&, PAL::SessionID, const CookieJar&, const Settings&);
</ins><span class="cx"> 
</span><span class="cx">     bool shouldContinueAfterNotifyingLoadedFromMemoryCache(const CachedResourceRequest&, CachedResource&, ResourceError&);
</span><span class="cx">     bool checkInsecureContent(CachedResource::Type, const URL&) const;
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedSVGDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedSVGDocument::CachedSVGDocument(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
</del><ins>+CachedSVGDocument::CachedSVGDocument(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::SVGDocumentResource, sessionID, cookieJar)
</span><span class="cx">     , m_decoder(TextResourceDecoder::create("application/xml"))
</span><span class="cx">     , m_settings(settings)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedSVGDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedSVGDocument.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedSVGDocument.h    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedSVGDocument.h       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedSVGDocument final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    explicit CachedSVGDocument(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, const Settings&);
</del><ins>+    explicit CachedSVGDocument(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, const Settings&);
</ins><span class="cx">     explicit CachedSVGDocument(CachedResourceRequest&&, CachedSVGDocument&);
</span><span class="cx">     virtual ~CachedSVGDocument();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedSVGFontcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedSVGFont::CachedSVGFont(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
</del><ins>+CachedSVGFont::CachedSVGFont(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
</ins><span class="cx">     : CachedFont(WTFMove(request), sessionID, cookieJar, Type::SVGFontResource)
</span><span class="cx">     , m_externalSVGFontElement(nullptr)
</span><span class="cx">     , m_settings(settings)
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedSVGFonth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedSVGFont.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedSVGFont.h        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedSVGFont.h   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedSVGFont final : public CachedFont {
</span><span class="cx"> public:
</span><del>-    CachedSVGFont(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, const Settings&);
</del><ins>+    CachedSVGFont(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, const Settings&);
</ins><span class="cx">     CachedSVGFont(CachedResourceRequest&&, CachedSVGFont&);
</span><span class="cx"> 
</span><span class="cx">     bool ensureCustomFontData(const AtomString& remoteURI) override;
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedScriptcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedScript.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedScript.cpp       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedScript.cpp  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedScript::CachedScript(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedScript::CachedScript(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::Script, sessionID, cookieJar)
</span><span class="cx">     , m_decoder(TextResourceDecoder::create("text/javascript"_s, request.charset()))
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedScripth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedScript.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedScript.h 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedScript.h    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedScript final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedScript(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedScript(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
</ins><span class="cx">     virtual ~CachedScript();
</span><span class="cx"> 
</span><span class="cx">     StringView script();
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedTextTrackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-CachedTextTrack::CachedTextTrack(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedTextTrack::CachedTextTrack(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::TextTrackResource, sessionID, cookieJar)
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedTextTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedTextTrack.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedTextTrack.h      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedTextTrack.h 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedTextTrack final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedTextTrack(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedTextTrack(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     bool mayTryReplaceEncodedData() const override { return true; }
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedXSLStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(XSLT)
</span><span class="cx"> 
</span><del>-CachedXSLStyleSheet::CachedXSLStyleSheet(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
</del><ins>+CachedXSLStyleSheet::CachedXSLStyleSheet(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
</ins><span class="cx">     : CachedResource(WTFMove(request), Type::XSLStyleSheet, sessionID, cookieJar)
</span><span class="cx">     , m_decoder(TextResourceDecoder::create("text/xsl"))
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreloadercacheCachedXSLStyleSheeth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> 
</span><span class="cx"> class CachedXSLStyleSheet final : public CachedResource {
</span><span class="cx"> public:
</span><del>-    CachedXSLStyleSheet(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
</del><ins>+    CachedXSLStyleSheet(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
</ins><span class="cx">     virtual ~CachedXSLStyleSheet();
</span><span class="cx"> 
</span><span class="cx">     const String& sheet() const { return m_sheet; }
</span></span></pre></div>
<a id="trunkSourceWebCorepageDatabaseProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DatabaseProvider.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DatabaseProvider.h     2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/page/DatabaseProvider.h        2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> class WEBCORE_EXPORT DatabaseProvider : public RefCounted<DatabaseProvider> {
</span><span class="cx"> public:
</span><span class="cx">     virtual ~DatabaseProvider();
</span><del>-    virtual IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) = 0;
</del><ins>+    virtual IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) = 0;
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformWebCoreCrossThreadCopiercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.cpp       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.cpp  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WTF {
</span><span class="cx"> 
</span><del>-CrossThreadCopierBase<false, false, PAL::SessionID>::Type CrossThreadCopierBase<false, false, PAL::SessionID>::copy(const PAL::SessionID& sessionID)
</del><ins>+CrossThreadCopierBase<false, false, PAL::SessionID>::Type CrossThreadCopierBase<false, false, PAL::SessionID>::copy(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     return sessionID;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformWebCoreCrossThreadCopierh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.h 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.h    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> 
</span><span class="cx"> template<> struct CrossThreadCopierBase<false, false, PAL::SessionID> {
</span><span class="cx">     typedef PAL::SessionID Type;
</span><del>-    static Type copy(const PAL::SessionID&);
</del><ins>+    static Type copy(PAL::SessionID);
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> template<> struct CrossThreadCopierBase<false, false, WebCore::ThreadSafeDataBuffer> {
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageNamespaceProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx">     return *slot;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void StorageNamespaceProvider::setSessionIDForTesting(const PAL::SessionID& newSessionID)
</del><ins>+void StorageNamespaceProvider::setSessionIDForTesting(PAL::SessionID newSessionID)
</ins><span class="cx"> {
</span><span class="cx">     if (m_localStorageNamespace && newSessionID != m_localStorageNamespace->sessionID())
</span><span class="cx">         m_localStorageNamespace->setSessionIDForTesting(newSessionID);
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageNamespaceProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageNamespaceProvider.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageNamespaceProvider.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebCore/storage/StorageNamespaceProvider.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> 
</span><span class="cx">     Ref<StorageArea> localStorageArea(Document&);
</span><span class="cx"> 
</span><del>-    WEBCORE_EXPORT void setSessionIDForTesting(const PAL::SessionID&);
</del><ins>+    WEBCORE_EXPORT void setSessionIDForTesting(PAL::SessionID);
</ins><span class="cx"> 
</span><span class="cx"> protected:
</span><span class="cx">     StorageNamespace* optionalLocalStorageNamespace() { return m_localStorageNamespace.get(); }
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/ChangeLog       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2021-06-14  Alex Christensen  <achristensen@webkit.org>
+
+        Pass PAL::SessionID by value instead of reference
+        https://bugs.webkit.org/show_bug.cgi?id=226983
+
+        Reviewed by Geoffrey Garen.
+
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::newTestingSession):
+        (WebKit::NetworkProcess::ensureSession):
+        (WebKit::NetworkProcess::storageSession const):
+        (WebKit::NetworkProcess::findCacheEngine):
+        (WebKit::NetworkProcess::ensureCacheEngine):
+        (WebKit::NetworkProcess::removeCacheEngine):
+        (WebKit::NetworkProcess::flushCookies):
+        (WebKit::NetworkProcess::platformFlushCookies):
+        (WebKit::NetworkProcess::addWebPageNetworkParameters):
+        (WebKit::NetworkProcess::removeWebPageNetworkParameters):
+        (WebKit::NetworkProcess::countNonDefaultSessionSets):
+        * NetworkProcess/NetworkProcess.h:
+        * NetworkProcess/NetworkResourceLoader.cpp:
+        (WebKit::NetworkResourceLoader::shouldLogCookieInformation):
+        * NetworkProcess/NetworkResourceLoader.h:
+        * NetworkProcess/NetworkStorageSessionProvider.h:
+        * NetworkProcess/cache/NetworkCache.cpp:
+        (WebKit::NetworkCache::makeUseDecision):
+        * NetworkProcess/cache/NetworkCache.h:
+        (WebKit::NetworkCache::Cache::sessionID const):
+        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+        (WebKit::NetworkProcess::flushCookies):
+        (WebKit::NetworkProcess::platformFlushCookies):
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::configurationForSessionID):
+        * UIProcess/Network/NetworkProcessProxy.cpp:
+        (WebKit::NetworkProcessProxy::flushCookies):
+        * UIProcess/Network/NetworkProcessProxy.h:
+        * UIProcess/WebProcessPool.h:
+        * WebProcess/Databases/WebDatabaseProvider.cpp:
+        (WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
+        * WebProcess/Databases/WebDatabaseProvider.h:
+
</ins><span class="cx"> 2021-06-14  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Accessing navigator.mediaDevices.enumerateDevices after granting permission
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessNetworkProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -451,7 +451,7 @@
</span><span class="cx">         functor(*session);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::newTestingSession(const PAL::SessionID& sessionID)
</del><ins>+std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::newTestingSession(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(COCOA)
</span><span class="cx">     // Session name should be short enough for shared memory region name to be under the limit, otherwise sandbox rules won't work (see <rdar://problem/13642852>).
</span><span class="lines">@@ -469,9 +469,9 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> #if PLATFORM(COCOA)
</span><del>-void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase, RetainPtr<CFHTTPCookieStorageRef>&& cookieStorage)
</del><ins>+void NetworkProcess::ensureSession(PAL::SessionID sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase, RetainPtr<CFHTTPCookieStorageRef>&& cookieStorage)
</ins><span class="cx"> #else
</span><del>-void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase)
</del><ins>+void NetworkProcess::ensureSession(PAL::SessionID sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase)
</ins><span class="cx"> #endif
</span><span class="cx"> {
</span><span class="cx">     auto addResult = m_networkStorageSessions.add(sessionID, nullptr);
</span><span class="lines">@@ -509,7 +509,7 @@
</span><span class="cx">         connection->cookieAcceptPolicyChanged(newPolicy);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-WebCore::NetworkStorageSession* NetworkProcess::storageSession(const PAL::SessionID& sessionID) const
</del><ins>+WebCore::NetworkStorageSession* NetworkProcess::storageSession(PAL::SessionID sessionID) const
</ins><span class="cx"> {
</span><span class="cx">     return m_networkStorageSessions.get(sessionID);
</span><span class="cx"> }
</span><span class="lines">@@ -2073,17 +2073,17 @@
</span><span class="cx"> }
</span><span class="cx"> #endif // ENABLE(RESOURCE_LOAD_STATISTICS)
</span><span class="cx"> 
</span><del>-CacheStorage::Engine* NetworkProcess::findCacheEngine(const PAL::SessionID& sessionID)
</del><ins>+CacheStorage::Engine* NetworkProcess::findCacheEngine(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     return m_cacheEngines.get(sessionID);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-CacheStorage::Engine& NetworkProcess::ensureCacheEngine(const PAL::SessionID& sessionID, Function<Ref<CacheStorage::Engine>()>&& functor)
</del><ins>+CacheStorage::Engine& NetworkProcess::ensureCacheEngine(PAL::SessionID sessionID, Function<Ref<CacheStorage::Engine>()>&& functor)
</ins><span class="cx"> {
</span><span class="cx">     return m_cacheEngines.ensure(sessionID, WTFMove(functor)).iterator->value;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::removeCacheEngine(const PAL::SessionID& sessionID)
</del><ins>+void NetworkProcess::removeCacheEngine(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     m_cacheEngines.remove(sessionID);
</span><span class="cx"> }
</span><span class="lines">@@ -2528,12 +2528,12 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::flushCookies(const PAL::SessionID&, CompletionHandler<void()>&& completionHandler)
</del><ins>+void NetworkProcess::flushCookies(PAL::SessionID, CompletionHandler<void()>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     completionHandler();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::platformFlushCookies(const PAL::SessionID&, CompletionHandler<void()>&& completionHandler)
</del><ins>+void NetworkProcess::platformFlushCookies(PAL::SessionID, CompletionHandler<void()>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     completionHandler();
</span><span class="cx"> }
</span><span class="lines">@@ -2794,7 +2794,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-void NetworkProcess::addWebPageNetworkParameters(const PAL::SessionID& sessionID, WebPageProxyIdentifier pageID, WebPageNetworkParameters&& parameters)
</del><ins>+void NetworkProcess::addWebPageNetworkParameters(PAL::SessionID sessionID, WebPageProxyIdentifier pageID, WebPageNetworkParameters&& parameters)
</ins><span class="cx"> {
</span><span class="cx">     auto session = networkSession(sessionID);
</span><span class="cx">     if (!session)
</span><span class="lines">@@ -2803,7 +2803,7 @@
</span><span class="cx">     session->addWebPageNetworkParameters(pageID, WTFMove(parameters));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::removeWebPageNetworkParameters(const PAL::SessionID& sessionID, WebPageProxyIdentifier pageID)
</del><ins>+void NetworkProcess::removeWebPageNetworkParameters(PAL::SessionID sessionID, WebPageProxyIdentifier pageID)
</ins><span class="cx"> {
</span><span class="cx">     auto session = networkSession(sessionID);
</span><span class="cx">     if (!session)
</span><span class="lines">@@ -2812,7 +2812,7 @@
</span><span class="cx">     session->removeWebPageNetworkParameters(pageID);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::countNonDefaultSessionSets(const PAL::SessionID& sessionID, CompletionHandler<void(size_t)>&& completionHandler)
</del><ins>+void NetworkProcess::countNonDefaultSessionSets(PAL::SessionID sessionID, CompletionHandler<void(size_t)>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     auto session = networkSession(sessionID);
</span><span class="cx">     if (!session)
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessNetworkProcessh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -173,12 +173,12 @@
</span><span class="cx">     void forEachNetworkSession(const Function<void(NetworkSession&)>&);
</span><span class="cx"> 
</span><span class="cx">     void forEachNetworkStorageSession(const Function<void(WebCore::NetworkStorageSession&)>&);
</span><del>-    WebCore::NetworkStorageSession* storageSession(const PAL::SessionID&) const;
-    std::unique_ptr<WebCore::NetworkStorageSession> newTestingSession(const PAL::SessionID&);
</del><ins>+    WebCore::NetworkStorageSession* storageSession(PAL::SessionID) const;
+    std::unique_ptr<WebCore::NetworkStorageSession> newTestingSession(PAL::SessionID);
</ins><span class="cx"> #if PLATFORM(COCOA)
</span><del>-    void ensureSession(const PAL::SessionID&, bool shouldUseTestingNetworkSession, const String& identifier, RetainPtr<CFHTTPCookieStorageRef>&&);
</del><ins>+    void ensureSession(PAL::SessionID, bool shouldUseTestingNetworkSession, const String& identifier, RetainPtr<CFHTTPCookieStorageRef>&&);
</ins><span class="cx"> #else
</span><del>-    void ensureSession(const PAL::SessionID&, bool shouldUseTestingNetworkSession, const String& identifier);
</del><ins>+    void ensureSession(PAL::SessionID, bool shouldUseTestingNetworkSession, const String& identifier);
</ins><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     void processWillSuspendImminentlyForTestingSync(CompletionHandler<void()>&&);
</span><span class="lines">@@ -329,9 +329,9 @@
</span><span class="cx">     void ref() const override { ThreadSafeRefCounted<NetworkProcess>::ref(); }
</span><span class="cx">     void deref() const override { ThreadSafeRefCounted<NetworkProcess>::deref(); }
</span><span class="cx"> 
</span><del>-    CacheStorage::Engine* findCacheEngine(const PAL::SessionID&);
-    CacheStorage::Engine& ensureCacheEngine(const PAL::SessionID&, Function<Ref<CacheStorage::Engine>()>&&);
-    void removeCacheEngine(const PAL::SessionID&);
</del><ins>+    CacheStorage::Engine* findCacheEngine(PAL::SessionID);
+    CacheStorage::Engine& ensureCacheEngine(PAL::SessionID, Function<Ref<CacheStorage::Engine>()>&&);
+    void removeCacheEngine(PAL::SessionID);
</ins><span class="cx">     void requestStorageSpace(PAL::SessionID, const WebCore::ClientOrigin&, uint64_t quota, uint64_t currentSize, uint64_t spaceRequired, CompletionHandler<void(std::optional<uint64_t>)>&&);
</span><span class="cx"> 
</span><span class="cx">     void storePrivateClickMeasurement(PAL::SessionID, WebCore::PrivateClickMeasurement&&);
</span><span class="lines">@@ -451,11 +451,11 @@
</span><span class="cx">     void allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo&, const String& host);
</span><span class="cx">     void setAllowsAnySSLCertificateForWebSocket(bool, CompletionHandler<void()>&&);
</span><span class="cx">     
</span><del>-    void flushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
</del><ins>+    void flushCookies(PAL::SessionID, CompletionHandler<void()>&&);
</ins><span class="cx"> 
</span><del>-    void addWebPageNetworkParameters(const PAL::SessionID&, WebPageProxyIdentifier, WebPageNetworkParameters&&);
-    void removeWebPageNetworkParameters(const PAL::SessionID&, WebPageProxyIdentifier);
-    void countNonDefaultSessionSets(const PAL::SessionID&, CompletionHandler<void(size_t)>&&);
</del><ins>+    void addWebPageNetworkParameters(PAL::SessionID, WebPageProxyIdentifier, WebPageNetworkParameters&&);
+    void removeWebPageNetworkParameters(PAL::SessionID, WebPageProxyIdentifier);
+    void countNonDefaultSessionSets(PAL::SessionID, CompletionHandler<void(size_t)>&&);
</ins><span class="cx"> 
</span><span class="cx"> #if USE(SOUP)
</span><span class="cx">     void setIgnoreTLSErrors(PAL::SessionID, bool);
</span><span class="lines">@@ -472,7 +472,7 @@
</span><span class="cx">     static void setSharedHTTPCookieStorage(const Vector<uint8_t>& identifier);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    void platformFlushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
</del><ins>+    void platformFlushCookies(PAL::SessionID, CompletionHandler<void()>&&);
</ins><span class="cx">     
</span><span class="cx">     void registerURLSchemeAsSecure(const String&) const;
</span><span class="cx">     void registerURLSchemeAsBypassingContentSecurityPolicy(const String&) const;
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessNetworkResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp     2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp        2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1284,7 +1284,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED
</span><del>-bool NetworkResourceLoader::shouldLogCookieInformation(NetworkConnectionToWebProcess& connection, const PAL::SessionID& sessionID)
</del><ins>+bool NetworkResourceLoader::shouldLogCookieInformation(NetworkConnectionToWebProcess& connection, PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     if (auto* session = connection.networkProcess().networkSession(sessionID))
</span><span class="cx">         return session->shouldLogCookieInformation();
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessNetworkResourceLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx">     bool isAlwaysOnLoggingAllowed() const;
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED
</span><del>-    static bool shouldLogCookieInformation(NetworkConnectionToWebProcess&, const PAL::SessionID&);
</del><ins>+    static bool shouldLogCookieInformation(NetworkConnectionToWebProcess&, PAL::SessionID);
</ins><span class="cx">     static void logCookieInformation(NetworkConnectionToWebProcess&, const String& label, const void* loggedObject, const WebCore::NetworkStorageSession&, const URL& firstParty, const WebCore::SameSiteInfo&, const URL&, const String& referrer, std::optional<WebCore::FrameIdentifier>, std::optional<WebCore::PageIdentifier>, std::optional<uint64_t> identifier);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcessNetworkStorageSessionProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h       2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h  2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -35,10 +35,10 @@
</span><span class="cx"> 
</span><span class="cx"> class NetworkStorageSessionProvider final : public WebCore::StorageSessionProvider {
</span><span class="cx"> public:
</span><del>-    static Ref<NetworkStorageSessionProvider> create(NetworkProcess& networkProcess, const PAL::SessionID& sessionID) { return adoptRef(*new NetworkStorageSessionProvider(networkProcess, sessionID)); }
</del><ins>+    static Ref<NetworkStorageSessionProvider> create(NetworkProcess& networkProcess, PAL::SessionID sessionID) { return adoptRef(*new NetworkStorageSessionProvider(networkProcess, sessionID)); }
</ins><span class="cx">     
</span><span class="cx"> private:
</span><del>-    NetworkStorageSessionProvider(NetworkProcess& networkProcess, const PAL::SessionID& sessionID)
</del><ins>+    NetworkStorageSessionProvider(NetworkProcess& networkProcess, PAL::SessionID sessionID)
</ins><span class="cx">         : m_networkProcess(makeWeakPtr(networkProcess))
</span><span class="cx">         , m_sessionID(sessionID) { }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcesscacheNetworkCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx">     return responseNeedsRevalidation(networkSession, response, timestamp, requestDirectives.maxStale);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-static UseDecision makeUseDecision(NetworkProcess& networkProcess, const PAL::SessionID& sessionID, const Entry& entry, const WebCore::ResourceRequest& request)
</del><ins>+static UseDecision makeUseDecision(NetworkProcess& networkProcess, PAL::SessionID sessionID, const Entry& entry, const WebCore::ResourceRequest& request)
</ins><span class="cx"> {
</span><span class="cx">     // The request is conditional so we force revalidation from the network. We merely check the disk cache
</span><span class="cx">     // so we can update the cache entry.
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcesscacheNetworkCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx">     void browsingContextRemoved(WebPageProxyIdentifier, WebCore::PageIdentifier, WebCore::FrameIdentifier);
</span><span class="cx"> 
</span><span class="cx">     NetworkProcess& networkProcess() { return m_networkProcess.get(); }
</span><del>-    const PAL::SessionID& sessionID() const { return m_sessionID; }
</del><ins>+    PAL::SessionID sessionID() const { return m_sessionID; }
</ins><span class="cx">     const String& storageDirectory() const { return m_storageDirectory; }
</span><span class="cx"> 
</span><span class="cx">     ~Cache();
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcesscocoaNetworkProcessCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-void NetworkProcess::flushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
</del><ins>+void NetworkProcess::flushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     platformFlushCookies(sessionID, WTFMove(completionHandler));
</span><span class="cx"> }
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx">     }).get()];
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcess::platformFlushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
</del><ins>+void NetworkProcess::platformFlushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
</span><span class="cx">     if (auto* networkStorageSession = storageSession(sessionID))
</span></span></pre></div>
<a id="trunkSourceWebKitNetworkProcesscocoaNetworkSessionCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1062,7 +1062,7 @@
</span><span class="cx"> static bool sessionsCreated = false;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session, bool isFullWebBrowser)
</del><ins>+static NSURLSessionConfiguration *configurationForSessionID(PAL::SessionID session, bool isFullWebBrowser)
</ins><span class="cx"> {
</span><span class="cx"> #if HAVE(LOGGING_PRIVACY_LEVEL)
</span><span class="cx">     auto loggingPrivacyLevel = nw_context_privacy_level_sensitive;
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessNetworkNetworkProcessProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1262,7 +1262,7 @@
</span><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkProcessProxy::flushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
</del><ins>+void NetworkProcessProxy::flushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
</ins><span class="cx"> {
</span><span class="cx">     sendWithAsyncReply(Messages::NetworkProcess::FlushCookies(sessionID), WTFMove(completionHandler));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessNetworkNetworkProcessProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -210,7 +210,7 @@
</span><span class="cx"> 
</span><span class="cx">     void setIsHoldingLockedFiles(bool);
</span><span class="cx"> 
</span><del>-    void flushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
</del><ins>+    void flushCookies(PAL::SessionID, CompletionHandler<void()>&&);
</ins><span class="cx"> 
</span><span class="cx">     void testProcessIncomingSyncMessagesWhenWaitingForSyncReply(WebPageProxyIdentifier, Messages::NetworkProcessProxy::TestProcessIncomingSyncMessagesWhenWaitingForSyncReplyDelayedReply&&);
</span><span class="cx">     void terminateUnresponsiveServiceWorkerProcesses(WebCore::ProcessIdentifier);
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebProcessPoolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebProcessPool.h   2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h      2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -299,7 +299,7 @@
</span><span class="cx">     };
</span><span class="cx">     static Statistics& statistics();    
</span><span class="cx"> 
</span><del>-    void clearCachedCredentials(const PAL::SessionID&);
</del><ins>+    void clearCachedCredentials(PAL::SessionID);
</ins><span class="cx">     void terminateNetworkProcess();
</span><span class="cx">     void terminateAllWebContentProcesses();
</span><span class="cx">     void sendNetworkProcessPrepareToSuspendForTesting(CompletionHandler<void()>&&);
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessDatabasesWebDatabaseProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp 2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp    2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -66,7 +66,7 @@
</span><span class="cx">     databaseProviders().remove(m_identifier);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(const PAL::SessionID&)
</del><ins>+WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(PAL::SessionID)
</ins><span class="cx"> {
</span><span class="cx">     return WebProcess::singleton().ensureNetworkProcessConnection().idbConnectionToServer().coreConnectionToServer();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessDatabasesWebDatabaseProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h   2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h      2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx">     static Ref<WebDatabaseProvider> getOrCreate(uint64_t identifier);
</span><span class="cx">     virtual ~WebDatabaseProvider();
</span><span class="cx"> 
</span><del>-    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) final;
</del><ins>+    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) final;
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     explicit WebDatabaseProvider(uint64_t identifier);
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/ChangeLog (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/ChangeLog      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKitLegacy/ChangeLog 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2021-06-14  Alex Christensen  <achristensen@webkit.org>
+
+        Pass PAL::SessionID by value instead of reference
+        https://bugs.webkit.org/show_bug.cgi?id=226983
+
+        Reviewed by Geoffrey Garen.
+
+        * Storage/WebDatabaseProvider.cpp:
+        (WebDatabaseProvider::idbConnectionToServerForSession):
+        * Storage/WebDatabaseProvider.h:
+        * WebCoreSupport/NetworkStorageSessionMap.cpp:
+        (NetworkStorageSessionMap::storageSession):
+        (NetworkStorageSessionMap::ensureSession):
+        (NetworkStorageSessionMap::destroySession):
+        * WebCoreSupport/NetworkStorageSessionMap.h:
+
</ins><span class="cx"> 2021-06-10  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Move Timing-Allow-Origin checks to the network process
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyStorageWebDatabaseProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp        2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp   2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(const PAL::SessionID& sessionID)
</del><ins>+WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     return m_idbServerMap.ensure(sessionID, [&sessionID] {
</span><span class="cx">         return sessionID.isEphemeral() ? InProcessIDBServer::create(sessionID) : InProcessIDBServer::create(sessionID, indexedDatabaseDirectoryPath());
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyStorageWebDatabaseProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.h  2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.h     2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx">     static WebDatabaseProvider& singleton();
</span><span class="cx">     virtual ~WebDatabaseProvider();
</span><span class="cx"> 
</span><del>-    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) override;
</del><ins>+    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) override;
</ins><span class="cx"> 
</span><span class="cx">     void deleteAllDatabases();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyWebCoreSupportNetworkStorageSessionMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp    2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp       2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">     return map;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-WebCore::NetworkStorageSession* NetworkStorageSessionMap::storageSession(const PAL::SessionID& sessionID)
</del><ins>+WebCore::NetworkStorageSession* NetworkStorageSessionMap::storageSession(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     if (sessionID == PAL::SessionID::defaultSessionID())
</span><span class="cx">         return &defaultStorageSession();
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
</del><ins>+void NetworkStorageSessionMap::ensureSession(PAL::SessionID sessionID, const String& identifierBase)
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(COCOA) || USE(CFURLCONNECTION)
</span><span class="cx">     auto addResult = globalSessionMap().add(sessionID, nullptr);
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void NetworkStorageSessionMap::destroySession(const PAL::SessionID& sessionID)
</del><ins>+void NetworkStorageSessionMap::destroySession(PAL::SessionID sessionID)
</ins><span class="cx"> {
</span><span class="cx">     globalSessionMap().remove(sessionID);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyWebCoreSupportNetworkStorageSessionMaph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.h (278848 => 278849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.h      2021-06-14 20:01:30 UTC (rev 278848)
+++ trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.h 2021-06-14 21:36:12 UTC (rev 278849)
</span><span class="lines">@@ -37,9 +37,9 @@
</span><span class="cx"> 
</span><span class="cx"> class NetworkStorageSessionMap {
</span><span class="cx"> public:
</span><del>-    static WebCore::NetworkStorageSession* storageSession(const PAL::SessionID&);
</del><ins>+    static WebCore::NetworkStorageSession* storageSession(PAL::SessionID);
</ins><span class="cx">     static WebCore::NetworkStorageSession& defaultStorageSession();
</span><span class="cx">     static void switchToNewTestingSession();
</span><del>-    static void ensureSession(const PAL::SessionID&, const String& identifierBase = String());
-    static void destroySession(const PAL::SessionID&);
</del><ins>+    static void ensureSession(PAL::SessionID, const String& identifierBase = String());
+    static void destroySession(PAL::SessionID);
</ins><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>