<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[278520] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/278520">278520</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2021-06-04 21:39:39 -0700 (Fri, 04 Jun 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Worker.constructor throws an exception when the url param is an empty string
https://bugs.webkit.org/show_bug.cgi?id=226637

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

* web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt:

Source/WebCore:

Stop throwing an exception if the Worker constructor gets called with an empty string.
Instead treat it as a relative URL, like Chrome and Firefox do.

No new tests, updated existing ones.

* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Update existing tests to reflect behavior change.

* fast/workers/worker-constructor-expected.txt:
* fast/workers/worker-constructor.html:
* http/tests/workers/worker-invalid-url-expected.txt:
* http/tests/workers/worker-invalid-url.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastworkersworkerconstructorexpectedtxt">trunk/LayoutTests/fast/workers/worker-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastworkersworkerconstructorhtml">trunk/LayoutTests/fast/workers/worker-constructor.html</a></li>
<li><a href="#trunkLayoutTestshttptestsworkersworkerinvalidurlexpectedtxt">trunk/LayoutTests/http/tests/workers/worker-invalid-url-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsworkersworkerinvalidurlhtml">trunk/LayoutTests/http/tests/workers/worker-invalid-url.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsworkersconstructorsWorkerWorkerconstructorexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreworkersAbstractWorkercpp">trunk/Source/WebCore/workers/AbstractWorker.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/ChangeLog 2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2021-06-04  Chris Dumez  <cdumez@apple.com>
+
+        Worker.constructor throws an exception when the url param is an empty string
+        https://bugs.webkit.org/show_bug.cgi?id=226637
+
+        Reviewed by Darin Adler.
+
+        Update existing tests to reflect behavior change.
+
+        * fast/workers/worker-constructor-expected.txt:
+        * fast/workers/worker-constructor.html:
+        * http/tests/workers/worker-invalid-url-expected.txt:
+        * http/tests/workers/worker-invalid-url.html:
+
</ins><span class="cx"> 2021-06-04  Diego Pino Garcia  <dpino@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GLIB][GTK] Unreviewed test gardening. Remove flaky tests that have been constantly passing for the last 4000 revisions.
</span></span></pre></div>
<a id="trunkLayoutTestsfastworkersworkerconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/workers/worker-constructor-expected.txt (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/worker-constructor-expected.txt   2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/fast/workers/worker-constructor-expected.txt      2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,9 +1,10 @@
</span><ins>+CONSOLE MESSAGE: SyntaxError: Unexpected token '<'
</ins><span class="cx"> Test Worker constructor functionality. Should print a series of PASS messages, followed with DONE.
</span><span class="cx"> 
</span><span class="cx"> PASS: toString exception propagated correctly.
</span><span class="cx"> PASS: trying to create workers recursively resulted in an exception (RangeError: Maximum call stack size exceeded.)
</span><span class="cx"> PASS: invoking Worker constructor without arguments resulted in an exception (TypeError: Not enough arguments)
</span><del>-PASS: invoking Worker constructor with empty script URL resulted in an exception (SyntaxError: The string did not match the expected pattern.)
</del><ins>+PASS: onerror invoked for an empty script URL.
</ins><span class="cx"> PASS: invoking Worker constructor with invalid script URL resulted in an exception (SyntaxError: The string did not match the expected pattern.)
</span><span class="cx"> PASS: onerror invoked for a script that could not be loaded.
</span><span class="cx"> PASS: Successfully created worker.
</span></span></pre></div>
<a id="trunkLayoutTestsfastworkersworkerconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/workers/worker-constructor.html (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/workers/worker-constructor.html   2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/fast/workers/worker-constructor.html      2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -72,11 +72,11 @@
</span><span class="cx">     try {
</span><span class="cx">         var worker = new Worker("");
</span><span class="cx">         worker.onerror = function() {
</span><del>-            log("FAIL: onerror invoked for an empty script URL.");
</del><ins>+            log("PASS: onerror invoked for an empty script URL.");
</ins><span class="cx">             runNextTest();
</span><span class="cx">         }
</span><span class="cx">     } catch (ex) {
</span><del>-        log("PASS: invoking Worker constructor with empty script URL resulted in an exception (" + ex + ")");
</del><ins>+        log("FAIL: invoking Worker constructor with empty script URL resulted in an exception (" + ex + ")");
</ins><span class="cx">         runNextTest();
</span><span class="cx">     }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsworkersworkerinvalidurlexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/workers/worker-invalid-url-expected.txt (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/workers/worker-invalid-url-expected.txt     2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/http/tests/workers/worker-invalid-url-expected.txt        2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,5 +1,4 @@
</span><del>-Test worker invalid url exceptions. Should print two "PASS" statements.
</del><ins>+Test worker invalid url exceptions. Should print one "PASS" statement.
</ins><span class="cx"> 
</span><span class="cx"> PASS: Got security error.
</span><del>-PASS: Got syntax error.
</del><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsworkersworkerinvalidurlhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/workers/worker-invalid-url.html (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/workers/worker-invalid-url.html     2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/http/tests/workers/worker-invalid-url.html        2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> <html>
</span><span class="cx"> <body>
</span><del>-<p>Test worker invalid url exceptions. Should print two "PASS" statements.</p>
</del><ins>+<p>Test worker invalid url exceptions. Should print one "PASS" statement.</p>
</ins><span class="cx"> <div id=result></div>
</span><span class="cx"> <script>
</span><span class="cx"> if (window.testRunner)
</span><span class="lines">@@ -20,16 +20,6 @@
</span><span class="cx">     else
</span><span class="cx">         log("FAIL: Got error code " + error.code + ". Expected error code 18.");
</span><span class="cx"> }
</span><del>-
-try {
-    new Worker("");
-    log("FAIL: No exception throw when accessing an invalid url.");
-} catch (error) {
-    if (error.code == 12)
-        log("PASS: Got syntax error.");
-    else
-        log("FAIL: Got error code " + error.code + ". Expected error code 12.");
-}
</del><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-06-04  Chris Dumez  <cdumez@apple.com>
+
+        Worker.constructor throws an exception when the url param is an empty string
+        https://bugs.webkit.org/show_bug.cgi?id=226637
+
+        Reviewed by Darin Adler.
+
+        Rebaseline WPT test now that it is passing.
+
+        * web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt:
+
</ins><span class="cx"> 2021-06-04  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Implement off-by-default experimental feature for PerformanceResourceTiming.transferSize, encodedBodySize, and decodedBodySize
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsworkersconstructorsWorkerWorkerconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt    2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/Worker-constructor-expected.txt       2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> PASS Test toString propagation exception.
</span><span class="cx"> PASS Test recursive Worker creation.
</span><span class="cx"> PASS Test worker creation with no arguments
</span><del>-FAIL Test Worker creation with empty script URL. The string did not match the expected pattern.
</del><ins>+PASS Test Worker creation with empty script URL.
</ins><span class="cx"> PASS Test invalid script URL.
</span><span class="cx"> PASS Test not existent script URL.
</span><span class="cx"> PASS Test the Worker object defines postMessage() and addEventListener().
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/Source/WebCore/ChangeLog      2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2021-06-04  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        Worker.constructor throws an exception when the url param is an empty string
+        https://bugs.webkit.org/show_bug.cgi?id=226637
+
+        Reviewed by Darin Adler.
+
+        Stop throwing an exception if the Worker constructor gets called with an empty string.
+        Instead treat it as a relative URL, like Chrome and Firefox do.
+
+        No new tests, updated existing ones.
+
+        * workers/AbstractWorker.cpp:
+        (WebCore::AbstractWorker::resolveURL):
+
+2021-06-04  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         Unreviewed Windows build fix after r278516.
</span><span class="cx"> 
</span><span class="cx">         * platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersAbstractWorkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/AbstractWorker.cpp (278519 => 278520)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/AbstractWorker.cpp  2021-06-05 02:21:10 UTC (rev 278519)
+++ trunk/Source/WebCore/workers/AbstractWorker.cpp     2021-06-05 04:39:39 UTC (rev 278520)
</span><span class="lines">@@ -42,9 +42,6 @@
</span><span class="cx"> 
</span><span class="cx"> ExceptionOr<URL> AbstractWorker::resolveURL(const String& url, bool shouldBypassMainWorldContentSecurityPolicy)
</span><span class="cx"> {
</span><del>-    if (url.isEmpty())
-        return Exception { SyntaxError };
-
</del><span class="cx">     auto& context = *scriptExecutionContext();
</span><span class="cx"> 
</span><span class="cx">     // FIXME: This should use the dynamic global scope (bug #27887).
</span></span></pre>
</div>
</div>

</body>
</html>