<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[278428] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/278428">278428</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2021-06-03 16:37:25 -0700 (Thu, 03 Jun 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (Safari 14): Menu items jump around on codelearn.cat
https://bugs.webkit.org/show_bug.cgi?id=226608
<rdar://78636003>

Reviewed by Alan Bujtas.

Source/WebCore:

This site changes overflow style dynamically on a stacking-context layer which
has an existing child compositing layer, and the layer has an offset from its
renderer due to the box-shadow.

When this happens, we need to ensure the child layers get a geometry update,
because the newly created clipping layer changes the offset for the child layers.

Test: compositing/overflow/overflow-change-reposition-descendants.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterLayout):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerStyleChanged):

LayoutTests:

* compositing/overflow/overflow-change-reposition-descendants-expected.html: Added.
* compositing/overflow/overflow-change-reposition-descendants.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingoverflowoverflowchangerepositiondescendantsexpectedhtml">trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositingoverflowoverflowchangerepositiondescendantshtml">trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (278427 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-06-03 23:21:19 UTC (rev 278427)
+++ trunk/LayoutTests/ChangeLog 2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-06-03  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (Safari 14): Menu items jump around on codelearn.cat
+        https://bugs.webkit.org/show_bug.cgi?id=226608
+        <rdar://78636003>
+
+        Reviewed by Alan Bujtas.
+
+        * compositing/overflow/overflow-change-reposition-descendants-expected.html: Added.
+        * compositing/overflow/overflow-change-reposition-descendants.html: Added.
+
</ins><span class="cx"> 2021-06-03  Amir Mark Jr  <amir_mark@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [MacOS] animations/leak-document-with-css-animation.html is a flaky failure
</span></span></pre></div>
<a id="trunkLayoutTestscompositingoverflowoverflowchangerepositiondescendantsexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants-expected.html (0 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants-expected.html                              (rev 0)
+++ trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants-expected.html 2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+    .container {
+        border: 1px solid black;
+        margin: 30px;
+        padding: 50px;
+        width: 300px;
+        height: 300px;
+        overflow: visible;
+        box-shadow: black 0px 0px 20px;
+        transform: translateZ(0px);
+        box-sizing: border-box;
+        overflow: hidden;
+    }
+    
+    .child {
+        width: 200px;
+        height: 200px;
+        background-color: green;
+        transform: translateZ(0);
+    }
+    </style>
+</head>
+<body>
+    <p>The green box should remain centered in the container</p>
+    <div class="container">
+        <div class="child">&nbsp;</div>
+    </div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestscompositingoverflowoverflowchangerepositiondescendantshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants.html (0 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants.html                               (rev 0)
+++ trunk/LayoutTests/compositing/overflow/overflow-change-reposition-descendants.html  2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -0,0 +1,44 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+    .container {
+        border: 1px solid black;
+        margin: 30px;
+        padding: 50px;
+        width: 300px;
+        height: 300px;
+        overflow: visible;
+        box-shadow: black 0px 0px 20px;
+        transform: translateZ(0px);
+        box-sizing: border-box;
+    }
+
+    .child {
+        width: 200px;
+        height: 200px;
+        background-color: green;
+        transform: translateZ(0);
+    }
+    </style>
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
+        window.addEventListener('load', () => {
+            requestAnimationFrame(() => {
+                document.querySelector(".container").style.overflow = "hidden";
+
+                if (window.testRunner)
+                    testRunner.notifyDone();
+            });
+        }, false);
+    </script>
+</head>
+<body>
+    <p>The green box should remain centered in the container</p>
+    <div class="container">
+        <div class="child">&nbsp;</div>
+    </div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (278427 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-06-03 23:21:19 UTC (rev 278427)
+++ trunk/Source/WebCore/ChangeLog      2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2021-06-03  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (Safari 14): Menu items jump around on codelearn.cat
+        https://bugs.webkit.org/show_bug.cgi?id=226608
+        <rdar://78636003>
+
+        Reviewed by Alan Bujtas.
+
+        This site changes overflow style dynamically on a stacking-context layer which
+        has an existing child compositing layer, and the layer has an offset from its
+        renderer due to the box-shadow.
+
+        When this happens, we need to ensure the child layers get a geometry update,
+        because the newly created clipping layer changes the offset for the child layers.
+
+        Test: compositing/overflow/overflow-change-reposition-descendants.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateAfterLayout):
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::layerStyleChanged):
+
</ins><span class="cx"> 2021-06-03  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Drop generic GenericTaskQueue<T> and DeferrableTask<T> now that they are unused
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (278427 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp    2021-06-03 23:21:19 UTC (rev 278427)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp       2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -916,7 +916,7 @@
</span><span class="cx">     RELEASE_ASSERT_WITH_MESSAGE(&m_owningLayer, "RenderLayerBacking::updateAfterLayout(): m_owningLayer is null (55699292)");
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    LOG(Compositing, "RenderLayerBacking %p updateAfterLayout (layer %p)", this, &m_owningLayer);
</del><ins>+    LOG_WITH_STREAM(Compositing, stream << "RenderLayerBacking::updateAfterLayout (layer " << &m_owningLayer << " needsClippingUpdate " << needsClippingUpdate << " needsFullRepaint " << needsFullRepaint);
</ins><span class="cx"> 
</span><span class="cx">     // This is the main trigger for layout changing layer geometry, but we have to do the work again in updateBackingAndHierarchy()
</span><span class="cx">     // when we know the final compositing hierarchy. We can't just set dirty bits from RenderLayer::setSize() because that doesn't
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (278427 => 278428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2021-06-03 23:21:19 UTC (rev 278427)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp    2021-06-03 23:37:25 UTC (rev 278428)
</span><span class="lines">@@ -1644,6 +1644,7 @@
</span><span class="cx">                 if (layer.isStackingContext()) {
</span><span class="cx">                     layer.setNeedsPostLayoutCompositingUpdate(); // Layer needs to become composited if it has composited descendants.
</span><span class="cx">                     layer.setNeedsCompositingConfigurationUpdate(); // If already composited, layer needs to create/destroy clipping layer.
</span><ins>+                    layer.setChildrenNeedCompositingGeometryUpdate(); // Clipping layers on this layer affect descendant layer geometry.
</ins><span class="cx">                 } else {
</span><span class="cx">                     // Descendant (in containing block order) compositing layers need to re-evaluate their clipping,
</span><span class="cx">                     // but they might be siblings in z-order so go up to our stacking context.
</span></span></pre>
</div>
</div>

</body>
</html>