<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[278194] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/278194">278194</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2021-05-28 04:35:54 -0700 (Fri, 28 May 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>Webkit doesn't calculate padding-top/-bottom in % correctly when parent has padding
https://bugs.webkit.org/show_bug.cgi?id=221202

Patch by Rob Buis <rbuis@igalia.com> on 2021-05-28
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Add test for this.

* web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt: Added.
* web-platform-tests/css/css-position/position-absolute-padding-percentage.html: Added.

Source/WebCore:

Absolute positioned elements should resolve %-ge padding against containing block padding-edge:
https://drafts.csswg.org/css-position-3/#absolute-positioning-containing-block

Test: imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContent const):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspositionpositionabsolutepaddingpercentageexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestscsscsspositionpositionabsolutepaddingpercentagehtml">trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (278193 => 278194)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-05-28 08:59:20 UTC (rev 278193)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2021-05-28 11:35:54 UTC (rev 278194)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2021-05-28  Rob Buis  <rbuis@igalia.com>
+
+        Webkit doesn't calculate padding-top/-bottom in % correctly when parent has padding
+        https://bugs.webkit.org/show_bug.cgi?id=221202
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Add test for this.
+
+        * web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt: Added.
+        * web-platform-tests/css/css-position/position-absolute-padding-percentage.html: Added.
+
</ins><span class="cx"> 2021-05-28  Martin Robinson  <mrobinson@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         More readily layout when scroll-snap properties change
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspositionpositionabsolutepaddingpercentageexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt (0 => 278194)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt                             (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage-expected.txt        2021-05-28 11:35:54 UTC (rev 278194)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+
+PASS absolute positioned element should resolve padding left+right against container padding-box width
+PASS absolute positioned element should resolve padding top+bottom against container padding-box width
+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestscsscsspositionpositionabsolutepaddingpercentagehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html (0 => 278194)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html                             (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html        2021-05-28 11:35:54 UTC (rev 278194)
</span><span class="lines">@@ -0,0 +1,59 @@
</span><ins>+<!DOCTYPE html>
+<title>CSS Position Absolute: css-position-3</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<link rel="help" href="https://drafts.csswg.org/css-position-3/#absolute-positioning-containing-block">
+<link rel="help" href="https://drafts.csswg.org/css-box-4/#padding-physical">
+<meta name="assert" content="abspos resolves padding %-ge sizes correctly.">
+<style>
+#outer-horizontal-padding {
+    position: relative;
+    padding: 10px;
+    width: 30px;
+    height: 80px;
+    background: green;
+}
+#inner-horizontal-padding {
+    position: absolute;
+    left: 50px;
+    height: 100px;
+    top: 0px;
+    padding-left: 50%;
+    padding-right: 50%;
+    background: green;
+}
+#outer-vertical-padding {
+    position: relative;
+    padding: 10px;
+    width: 30px;
+    height: 80px;
+    background: green;
+}
+#inner-vertical-padding {
+    position: absolute;
+    left: 50px;
+    width: 50px;
+    top: 0px;
+    padding-top: 100%;
+    padding-bottom: 100%;
+    background: green;
+}
+</style>
+<div id="outer-horizontal-padding">
+  <div id="inner-horizontal-padding"></div>
+</div>
+<div id="outer-vertical-padding">
+  <div id="inner-vertical-padding"></div>
+</div>
+<script>
+document.body.offsetTop;
+test(() => {
+  let target = document.querySelector("#inner-horizontal-padding");
+  assert_equals(target.offsetWidth, 50);
+}, 'absolute positioned element should resolve padding left+right against container padding-box width' );
+
+test(() => {
+  let target = document.querySelector("#inner-vertical-padding");
+  assert_equals(target.offsetHeight, 100);
+}, 'absolute positioned element should resolve padding top+bottom against container padding-box width' );
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (278193 => 278194)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-05-28 08:59:20 UTC (rev 278193)
+++ trunk/Source/WebCore/ChangeLog      2021-05-28 11:35:54 UTC (rev 278194)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2021-05-28  Rob Buis  <rbuis@igalia.com>
+
+        Webkit doesn't calculate padding-top/-bottom in % correctly when parent has padding
+        https://bugs.webkit.org/show_bug.cgi?id=221202
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Absolute positioned elements should resolve %-ge padding against containing block padding-edge:
+        https://drafts.csswg.org/css-position-3/#absolute-positioning-containing-block
+
+        Test: imported/w3c/web-platform-tests/css/css-position/position-absolute-padding-percentage.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::containingBlockLogicalWidthForContent const):
+
</ins><span class="cx"> 2021-05-28  Martin Robinson  <mrobinson@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         More readily layout when scroll-snap properties change
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (278193 => 278194)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp     2021-05-28 08:59:20 UTC (rev 278193)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp        2021-05-28 11:35:54 UTC (rev 278194)
</span><span class="lines">@@ -2045,8 +2045,11 @@
</span><span class="cx">     if (hasOverridingContainingBlockContentLogicalWidth())
</span><span class="cx">         return overridingContainingBlockContentLogicalWidth().value_or(0_lu);
</span><span class="cx"> 
</span><del>-    if (RenderBlock* cb = containingBlock())
</del><ins>+    if (RenderBlock* cb = containingBlock()) {
+        if (isOutOfFlowPositioned())
+            return cb->clientLogicalWidth();
</ins><span class="cx">         return cb->availableLogicalWidth();
</span><ins>+    }
</ins><span class="cx">     return 0_lu;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>