<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[277780] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/277780">277780</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2021-05-20 06:31:05 -0700 (Thu, 20 May 2021)</dd>
</dl>

<h3>Log Message</h3>
<pre>[LFC][TFC] Available space distribution should account for the top and bottom table spacing
https://bugs.webkit.org/show_bug.cgi?id=226003

Reviewed by Antti Koivisto.

Source/WebCore:

The available space for the table content is the table width/height minus the left-right/top-bottom spacing, minus
the additional spacing between the rows/columns.

Tests: fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html
       fast/layoutformattingcontext/table-simple-row-height.html

* layout/formattingContexts/table/TableLayout.cpp:
(WebCore::Layout::distributeAvailableSpace):

LayoutTests:

* TestExpectations: rendering code disagrees here.
* fast/layoutformattingcontext/table-simple-row-height-expected.html: Added.
* fast/layoutformattingcontext/table-simple-row-height.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorelayoutformattingContextstableTableLayoutcpp">trunk/Source/WebCore/layout/formattingContexts/table/TableLayout.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastlayoutformattingcontexttablesimplerowheightexpectedhtml">trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastlayoutformattingcontexttablesimplerowheighthtml">trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (277779 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2021-05-20 13:24:18 UTC (rev 277779)
+++ trunk/LayoutTests/ChangeLog 2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2021-05-20  Alan Bujtas  <zalan@apple.com>
+
+        [LFC][TFC] Available space distribution should account for the top and bottom table spacing
+        https://bugs.webkit.org/show_bug.cgi?id=226003
+
+        Reviewed by Antti Koivisto.
+
+        * TestExpectations: rendering code disagrees here.
+        * fast/layoutformattingcontext/table-simple-row-height-expected.html: Added.
+        * fast/layoutformattingcontext/table-simple-row-height.html: Added.
+
</ins><span class="cx"> 2021-05-20  Aditya Keerthi  <akeerthi@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Value of a color input does not update visually when using setAttribute
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (277779 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations       2021-05-20 13:24:18 UTC (rev 277779)
+++ trunk/LayoutTests/TestExpectations  2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -4873,6 +4873,8 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/225247 [ Debug ] fast/multicol/span/float-becomes-spanner-crash.html [ Skip ]
</span><span class="cx"> 
</span><ins>+webkit.org/b/226002 fast/layoutformattingcontext/table-simple-row-height.html [ Skip ]
+
</ins><span class="cx"> # This webstorage test has crashed since it was imported.
</span><span class="cx"> imported/w3c/web-platform-tests/webstorage/storage_session_setitem_quotaexceedederr.window.html [ Skip ]
</span><span class="cx"> # This webstorage test has timed out since it was imported.
</span></span></pre></div>
<a id="trunkLayoutTestsfastlayoutformattingcontexttablesimplerowheightexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height-expected.html (0 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height-expected.html                             (rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height-expected.html        2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -0,0 +1,8 @@
</span><ins>+<style>
+div {
+  height: 200px; 
+  width: 100px; 
+  background-color: green;
+}
+</style>
+<div></div>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastlayoutformattingcontexttablesimplerowheighthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height.html (0 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height.html                              (rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/table-simple-row-height.html 2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+<style>
+table {
+  height: 100px; 
+  width: 100px; 
+  background-color: green;
+}
+</style>
+<table><tr><td height=1px></td></tr></table>
+<table><tr><td></td></tr></table>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (277779 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2021-05-20 13:24:18 UTC (rev 277779)
+++ trunk/Source/WebCore/ChangeLog      2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2021-05-20  Alan Bujtas  <zalan@apple.com>
+
+        [LFC][TFC] Available space distribution should account for the top and bottom table spacing
+        https://bugs.webkit.org/show_bug.cgi?id=226003
+
+        Reviewed by Antti Koivisto.
+
+        The available space for the table content is the table width/height minus the left-right/top-bottom spacing, minus
+        the additional spacing between the rows/columns.
+
+        Tests: fast/inline/vertical-top-on-subpixel-makes-inline-box-overflow.html
+               fast/layoutformattingcontext/table-simple-row-height.html
+
+        * layout/formattingContexts/table/TableLayout.cpp:
+        (WebCore::Layout::distributeAvailableSpace):
+
</ins><span class="cx"> 2021-05-20  Aditya Keerthi  <akeerthi@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Value of a color input does not update visually when using setAttribute
</span></span></pre></div>
<a id="trunkSourceWebCorelayoutformattingContextstableTableLayoutcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/layout/formattingContexts/table/TableLayout.cpp (277779 => 277780)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/layout/formattingContexts/table/TableLayout.cpp     2021-05-20 13:24:18 UTC (rev 277779)
+++ trunk/Source/WebCore/layout/formattingContexts/table/TableLayout.cpp        2021-05-20 13:31:05 UTC (rev 277780)
</span><span class="lines">@@ -219,7 +219,10 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     Vector<LayoutUnit> distributedSpaces(resolvedItems.size());
</span><del>-    float spaceToDistribute = availableSpace - adjustabledSpace.value - ((resolvedItems.size() + 1) * SpanType::spacing(grid));
</del><ins>+    float spaceToDistribute = availableSpace;
+    // Top and bottom spacing are fixed.
+    spaceToDistribute -= 2 * SpanType::spacing(grid);
+    spaceToDistribute -= adjustabledSpace.value + ((resolvedItems.size() - 1) * SpanType::spacing(grid));
</ins><span class="cx">     // Essentially the remaining space to distribute should never be negative. LayoutUnit::epsilon() is required to compensate for LayoutUnit's low precision.
</span><span class="cx">     ASSERT(spaceToDistribute >= -LayoutUnit::epsilon() * resolvedItems.size());
</span><span class="cx">     // Distribute the extra space based on the resolved spaces.
</span></span></pre>
</div>
</div>

</body>
</html>