<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[270097] releases/WebKitGTK/webkit-2.30</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/270097">270097</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2020-11-20 02:40:16 -0800 (Fri, 20 Nov 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/269599">r269599</a> - [TextureMapper] backdrop-filter should use the identity transform to render the root layer
https://bugs.webkit.org/show_bug.cgi?id=218699

Reviewed by Don Olmstead.

Source/WebCore:

Even thouth CSS reflections mirror the content, backdrop-filter in
the reflection doesn't. It sees through the background.
css3/filters/backdrop/backdrop-filter-with-reflection.html is the
test case.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
Removed TextureMapperPaintOptions::isReplica.

LayoutTests:

* platform/glib/TestExpectations: Unmarked
css3/filters/backdrop/{backdrop-filter-with-reflection-add-backdrop.html,
backdrop-filter-with-reflection-value-change.html,backdrop-filter-with-reflection.html}</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit230LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.30/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit230LayoutTestsplatformglibTestExpectations">releases/WebKitGTK/webkit-2.30/LayoutTests/platform/glib/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit230SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit230SourceWebCoreplatformgraphicstexmapTextureMapperLayercpp">releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit230LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.30/LayoutTests/ChangeLog (270096 => 270097)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.30/LayoutTests/ChangeLog     2020-11-20 10:39:57 UTC (rev 270096)
+++ releases/WebKitGTK/webkit-2.30/LayoutTests/ChangeLog        2020-11-20 10:40:16 UTC (rev 270097)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
</span><span class="cx"> 
</span><ins>+        [TextureMapper] backdrop-filter should use the identity transform to render the root layer
+        https://bugs.webkit.org/show_bug.cgi?id=218699
+
+        Reviewed by Don Olmstead.
+
+        * platform/glib/TestExpectations: Unmarked
+        css3/filters/backdrop/{backdrop-filter-with-reflection-add-backdrop.html,
+        backdrop-filter-with-reflection-value-change.html,backdrop-filter-with-reflection.html}
+
+2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
</ins><span class="cx">         [TextureMapper] The top and left sides of drop-shadow are clipped
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=218647
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit230LayoutTestsplatformglibTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.30/LayoutTests/platform/glib/TestExpectations (270096 => 270097)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.30/LayoutTests/platform/glib/TestExpectations        2020-11-20 10:39:57 UTC (rev 270096)
+++ releases/WebKitGTK/webkit-2.30/LayoutTests/platform/glib/TestExpectations   2020-11-20 10:40:16 UTC (rev 270097)
</span><span class="lines">@@ -175,9 +175,6 @@
</span><span class="cx"> webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-border-radius-value-change.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-border-radius.html [ ImageOnlyFailure ]
</span><del>-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html [ ImageOnlyFailure ]
-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html [ ImageOnlyFailure ]
-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/169988 css3/filters/backdrop/effect-hw.html [ ImageOnlyFailure ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/214682 imported/w3c/web-platform-tests/css/cssom/stylesheet-same-origin.sub.html [ Pass Failure ]
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit230SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog (270096 => 270097)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog  2020-11-20 10:39:57 UTC (rev 270096)
+++ releases/WebKitGTK/webkit-2.30/Source/WebCore/ChangeLog     2020-11-20 10:40:16 UTC (rev 270097)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
</span><span class="cx"> 
</span><ins>+        [TextureMapper] backdrop-filter should use the identity transform to render the root layer
+        https://bugs.webkit.org/show_bug.cgi?id=218699
+
+        Reviewed by Don Olmstead.
+
+        Even thouth CSS reflections mirror the content, backdrop-filter in
+        the reflection doesn't. It sees through the background.
+        css3/filters/backdrop/backdrop-filter-with-reflection.html is the
+        test case.
+
+        * platform/graphics/texmap/TextureMapperLayer.cpp:
+        (WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
+        (WebCore::TextureMapperLayer::paintIntoSurface):
+        (WebCore::TextureMapperLayer::paintWithIntermediateSurface):
+        Removed TextureMapperPaintOptions::isReplica.
+
+2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
</ins><span class="cx">         [TextureMapper] The top and left sides of drop-shadow are clipped
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=218647
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit230SourceWebCoreplatformgraphicstexmapTextureMapperLayercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (270096 => 270097)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp    2020-11-20 10:39:57 UTC (rev 270096)
+++ releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp       2020-11-20 10:40:16 UTC (rev 270097)
</span><span class="lines">@@ -39,7 +39,6 @@
</span><span class="cx">     float opacity { 1 };
</span><span class="cx">     IntSize offset;
</span><span class="cx">     TextureMapperLayer* backdropLayer { nullptr };
</span><del>-    bool isReplica { false };
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> TextureMapperLayer::TextureMapperLayer() = default;
</span><span class="lines">@@ -291,10 +290,7 @@
</span><span class="cx"> {
</span><span class="cx">     if (m_state.replicaLayer) {
</span><span class="cx">         TextureMapperPaintOptions replicaOptions(options);
</span><del>-        replicaOptions.isReplica = true;
-        replicaOptions.transform
-            .multiply(m_state.replicaLayer->m_layerTransforms.combined)
-            .multiply(m_layerTransforms.combined.inverse().valueOr(TransformationMatrix()));
</del><ins>+        replicaOptions.transform.multiply(replicaTransform());
</ins><span class="cx">         paintSelfAndChildren(replicaOptions);
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="lines">@@ -429,6 +425,7 @@
</span><span class="cx">     options.textureMapper.bindSurface(options.surface.get());
</span><span class="cx">     if (m_isBackdrop) {
</span><span class="cx">         TextureMapperPaintOptions paintOptions(options);
</span><ins>+        paintOptions.transform = TransformationMatrix();
</ins><span class="cx">         paintOptions.backdropLayer = this;
</span><span class="cx">         rootLayer().paintSelfAndChildren(paintOptions);
</span><span class="cx">     } else
</span><span class="lines">@@ -454,18 +451,13 @@
</span><span class="cx">     paintOptions.offset = -toIntSize(rect.location());
</span><span class="cx">     paintOptions.opacity = 1;
</span><span class="cx">     if (m_state.replicaLayer) {
</span><del>-        paintOptions.isReplica = true;
</del><span class="cx">         paintOptions.transform.multiply(replicaTransform());
</span><span class="cx">         paintIntoSurface(paintOptions);
</span><del>-        paintOptions.isReplica = false;
</del><span class="cx">         paintOptions.transform = options.transform;
</span><span class="cx">         if (m_state.replicaLayer->m_state.maskLayer)
</span><span class="cx">             m_state.replicaLayer->m_state.maskLayer->applyMask(paintOptions);
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    if (m_isBackdrop && m_effectTarget->m_state.replicaLayer && options.isReplica)
-        paintOptions.transform = m_effectTarget->replicaTransform();
-
</del><span class="cx">     paintIntoSurface(paintOptions);
</span><span class="cx"> 
</span><span class="cx">     commitSurface(options, *paintOptions.surface, rect, options.opacity);
</span></span></pre>
</div>
</div>

</body>
</html>