<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[269928] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/269928">269928</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2020-11-17 15:30:08 -0800 (Tue, 17 Nov 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[macOS] Stop using RunLoopType=_WebKit starting in Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219052
<rdar://problem/61742969>

Reviewed by Geoffrey Garen.

Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
to be NSRunLoop.

After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
still working as expected.

* Configurations/WebContentService.xcconfig:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitConfigurationsWebContentServicexcconfig">trunk/Source/WebKit/Configurations/WebContentService.xcconfig</a></li>
<li><a href="#trunkSourceWebKitWebProcessEntryPointCocoaXPCServiceWebContentServiceInfoOSXplist">trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (269927 => 269928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/ChangeLog       2020-11-17 23:30:08 UTC (rev 269928)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2020-11-17  Chris Dumez  <cdumez@apple.com>
+
+        [macOS] Stop using RunLoopType=_WebKit starting in Big Sur
+        https://bugs.webkit.org/show_bug.cgi?id=219052
+        <rdar://problem/61742969>
+
+        Reviewed by Geoffrey Garen.
+
+        Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
+        scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
+        to be NSRunLoop.
+
+        After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
+        still working as expected.
+
+        * Configurations/WebContentService.xcconfig:
+        * WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
+
</ins><span class="cx"> 2020-11-17  Per Arne Vollan  <pvollan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [macOS] Issue sandbox extension to trust service if Media in the GPU process is not enabled
</span></span></pre></div>
<a id="trunkSourceWebKitConfigurationsWebContentServicexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Configurations/WebContentService.xcconfig (269927 => 269928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Configurations/WebContentService.xcconfig    2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/Configurations/WebContentService.xcconfig       2020-11-17 23:30:08 UTC (rev 269928)
</span><span class="lines">@@ -47,9 +47,9 @@
</span><span class="cx"> WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_NO = $(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG);
</span><span class="cx"> WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_YES = $(USE_STAGING_INSTALL_PATH);
</span><span class="cx"> 
</span><del>-RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1014));
-RUNLOOP_TYPE_MACOS_BEFORE_1014 = _NSApplicationMain;
-RUNLOOP_TYPE_MACOS_SINCE_1014 = _WebKit;
</del><ins>+RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1016));
+RUNLOOP_TYPE_MACOS_BEFORE_1016 = _WebKit;
+RUNLOOP_TYPE_MACOS_SINCE_1016 = NSRunLoop;
</ins><span class="cx"> 
</span><span class="cx"> ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
</span><span class="cx"> ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessEntryPointCocoaXPCServiceWebContentServiceInfoOSXplist"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist (269927 => 269928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist      2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist 2020-11-17 23:30:08 UTC (rev 269928)
</span><span class="lines">@@ -46,6 +46,8 @@
</span><span class="cx">          <string>Application</string>
</span><span class="cx">          <key>RunLoopType</key>
</span><span class="cx">          <string>${RUNLOOP_TYPE}</string>
</span><ins>+                <key>_ProcessType</key>
+                <string>App</string>
</ins><span class="cx">           <key>_MultipleInstances</key>
</span><span class="cx">          <true/>
</span><span class="cx">          <key>_HighBitsASLR</key>
</span></span></pre>
</div>
</div>

</body>
</html>