<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[269945] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/269945">269945</a></dd>
<dt>Author</dt> <dd>dpino@igalia.com</dd>
<dt>Date</dt> <dd>2020-11-17 22:37:17 -0800 (Tue, 17 Nov 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
https://bugs.webkit.org/show_bug.cgi?id=213016

Reviewed by Carlos Alberto Lopez Perez.

Add a new post-commit bot to test WebKitGTK using GTK4 library.

The bot builds WebKitGTK and runs the following test suites: layout-test, api-test
and webdriver-test.

* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories.py:
(BuildAndTestAllButJSCFactory):
(BuildAndTestAllButJSCFactory.getProduct):
(BuildAndTestAllButJSCFactory.__init__):
* CISupport/build-webkit-org/steps_unittest.py:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsCISupportbuildwebkitorgconfigjson">trunk/Tools/CISupport/build-webkit-org/config.json</a></li>
<li><a href="#trunkToolsCISupportbuildwebkitorgfactoriespy">trunk/Tools/CISupport/build-webkit-org/factories.py</a></li>
<li><a href="#trunkToolsCISupportbuildwebkitorgsteps_unittestpy">trunk/Tools/CISupport/build-webkit-org/steps_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsCISupportbuildwebkitorgconfigjson"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/build-webkit-org/config.json (269944 => 269945)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/build-webkit-org/config.json       2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/config.json  2020-11-18 06:37:17 UTC (rev 269945)
</span><span class="lines">@@ -101,6 +101,7 @@
</span><span class="cx">                     { "name": "gtk-linux-bot-15", "platform": "gtk" },
</span><span class="cx">                     { "name": "gtk-linux-bot-16", "platform": "gtk" },
</span><span class="cx">                     { "name": "gtk-linux-bot-17", "platform": "gtk" },
</span><ins>+                    { "name": "gtk-linux-bot-18", "platform": "gtk" },
</ins><span class="cx"> 
</span><span class="cx">                     { "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
</span><span class="cx">                     { "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
</span><span class="lines">@@ -408,6 +409,11 @@
</span><span class="cx">                       "workernames": ["gtk-linux-bot-17"]
</span><span class="cx">                     },
</span><span class="cx">                     {
</span><ins>+                      "name": "GTK-Linux-64-bit-Release-GTK4-Tests", "factory": "BuildAndTestAllButJSCFactory", "builddir": "gtk-linux-64-release-gtk4",
+                      "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+                      "workernames": ["gtk-linux-bot-18"]
+                    },
+                    {
</ins><span class="cx">                       "name": "WinCairo-64-bit-WKL-Release-Build", "factory": "BuildFactory", "builddir": "wincairo-wkl-release",
</span><span class="cx">                       "platform": "wincairo", "configuration": "release", "architectures": ["x86_64"],
</span><span class="cx">                       "triggers": ["wincairo-wkl-release-tests", "wincairo-jsc-release-tests"],
</span></span></pre></div>
<a id="trunkToolsCISupportbuildwebkitorgfactoriespy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/build-webkit-org/factories.py (269944 => 269945)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/build-webkit-org/factories.py      2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/factories.py 2020-11-18 06:37:17 UTC (rev 269945)
</span><span class="lines">@@ -174,6 +174,14 @@
</span><span class="cx">     JSCTestClass = None
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+class BuildAndTestAllButJSCFactory(BuildAndTestFactory):
+    JSCTestClass = None
+
+    def __init__(self, platform, configuration, architectures, triggers=None, additionalArguments=None, device_model=None, **kwargs):
+        BuildAndTestFactory.__init__(self, platform, configuration, architectures, additionalArguments, device_model, **kwargs)
+        self.addStep(RunWebDriverTests())
+
+
</ins><span class="cx"> class BuildAndGenerateJSCBundleFactory(BuildFactory):
</span><span class="cx">     ShouldRunJSCBundleStep = True
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsCISupportbuildwebkitorgsteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/CISupport/build-webkit-org/steps_unittest.py (269944 => 269945)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/CISupport/build-webkit-org/steps_unittest.py 2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/steps_unittest.py    2020-11-18 06:37:17 UTC (rev 269945)
</span><span class="lines">@@ -583,6 +583,7 @@
</span><span class="cx">     'GTK-Linux-64-bit-Release-Wayland-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'extract-test-results', 'API-tests', 'webdriver-test'],
</span><span class="cx">     'GTK-Linux-64-bit-Release-Ubuntu-LTS-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
</span><span class="cx">     'GTK-Linux-64-bit-Release-Debian-Stable-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
</span><ins>+    'GTK-Linux-64-bit-Release-GTK4-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'extract-test-results', 'API-tests', 'webdriver-test'],
</ins><span class="cx"> 
</span><span class="cx">     'PlayStation-Debug-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
</span><span class="cx">     'PlayStation-Release-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (269944 => 269945)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/ChangeLog       2020-11-18 06:37:17 UTC (rev 269945)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2020-11-17  Diego Pino Garcia  <dpino@igalia.com>
+
+        [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
+        https://bugs.webkit.org/show_bug.cgi?id=213016
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        Add a new post-commit bot to test WebKitGTK using GTK4 library.
+
+        The bot builds WebKitGTK and runs the following test suites: layout-test, api-test
+        and webdriver-test.
+
+        * CISupport/build-webkit-org/config.json:
+        * CISupport/build-webkit-org/factories.py:
+        (BuildAndTestAllButJSCFactory):
+        (BuildAndTestAllButJSCFactory.getProduct):
+        (BuildAndTestAllButJSCFactory.__init__):
+        * CISupport/build-webkit-org/steps_unittest.py:
+
</ins><span class="cx"> 2020-11-17  Matt Lewis  <jlewis3@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Big Sur testers fail to find proper archives due to architecture keys.
</span></span></pre>
</div>
</div>

</body>
</html>