<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[269792] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/269792">269792</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2020-11-13 14:13:02 -0800 (Fri, 13 Nov 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[macOS] Issue sandbox extension to the WebContent process for com.apple.lskdd
https://bugs.webkit.org/show_bug.cgi?id=218920
<rdar://problem/69168801>

Reviewed by Geoffrey Garen.

This is a Media related service, and a sandbox extension should be issued to the WebContent process based on GPU runtime settings.

No new tests, covered by existing tests.

* UIProcess/WebPageProxy.cpp:
(WebKit::mediaRelatedMachServices):
* WebProcess/com.apple.WebProcess.sb.in:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxycpp">trunk/Source/WebKit/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitWebProcesscomappleWebProcesssbin">trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (269791 => 269792)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2020-11-13 21:49:52 UTC (rev 269791)
+++ trunk/Source/WebKit/ChangeLog       2020-11-13 22:13:02 UTC (rev 269792)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2020-11-13  Per Arne Vollan  <pvollan@apple.com>
+
+        [macOS] Issue sandbox extension to the WebContent process for com.apple.lskdd
+        https://bugs.webkit.org/show_bug.cgi?id=218920
+        <rdar://problem/69168801>
+
+        Reviewed by Geoffrey Garen.
+
+        This is a Media related service, and a sandbox extension should be issued to the WebContent process based on GPU runtime settings.
+
+        No new tests, covered by existing tests.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::mediaRelatedMachServices):
+        * WebProcess/com.apple.WebProcess.sb.in:
+
</ins><span class="cx"> 2020-11-13  Claudio Saavedra  <csaavedra@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Non-unified build fixes.
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (269791 => 269792)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp   2020-11-13 21:49:52 UTC (rev 269791)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp      2020-11-13 22:13:02 UTC (rev 269792)
</span><span class="lines">@@ -7749,7 +7749,7 @@
</span><span class="cx"> #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
</span><span class="cx">         "com.apple.coremedia.endpointstream.xpc"_s, "com.apple.coremedia.endpointplaybacksession.xpc"_s,
</span><span class="cx">         "com.apple.coremedia.endpointremotecontrolsession.xpc"_s, "com.apple.coremedia.videodecoder"_s,
</span><del>-        "com.apple.coremedia.videoencoder"_s, "com.apple.BluetoothServices"_s
</del><ins>+        "com.apple.coremedia.videoencoder"_s, "com.apple.lskdd"_s, "com.apple.BluetoothServices"_s
</ins><span class="cx"> #endif
</span><span class="cx">     });
</span><span class="cx">     return services;
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcesscomappleWebProcesssbin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (269791 => 269792)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in        2020-11-13 21:49:52 UTC (rev 269791)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in   2020-11-13 22:13:02 UTC (rev 269792)
</span><span class="lines">@@ -955,7 +955,6 @@
</span><span class="cx">     (global-name "com.apple.audio.SystemSoundServer-OSX")
</span><span class="cx">     (global-name "com.apple.audio.audiohald")
</span><span class="cx">     (global-name "com.apple.fonts")
</span><del>-    (global-name "com.apple.lskdd") ;; <rdar://problem/49123855>
</del><span class="cx">     (global-name "com.apple.PowerManagement.control")
</span><span class="cx"> )
</span><span class="cx"> 
</span><span class="lines">@@ -1233,7 +1232,7 @@
</span><span class="cx">             ;;; FIXME(207716): The following should be removed when the GPU process is complete
</span><span class="cx">             "com.apple.audio.AudioComponentRegistrar" "com.apple.coremedia.endpoint.xpc" "com.apple.coremedia.endpointstream.xpc"
</span><span class="cx">             "com.apple.coremedia.endpointplaybacksession.xpc" "com.apple.coremedia.endpointremotecontrolsession.xpc" "com.apple.coremedia.routediscoverer.xpc"
</span><del>-            "com.apple.coremedia.routingcontext.xpc" "com.apple.coremedia.volumecontroller.xpc" "com.apple.mediaremoted.xpc"
</del><ins>+            "com.apple.coremedia.routingcontext.xpc" "com.apple.coremedia.volumecontroller.xpc" "com.apple.lskdd" "com.apple.mediaremoted.xpc"
</ins><span class="cx">             ;;; FIXME(207716): End services to remove.
</span><span class="cx">         )
</span><span class="cx">     )
</span></span></pre>
</div>
</div>

</body>
</html>