<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[269430] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/269430">269430</a></dd>
<dt>Author</dt> <dd>lmoura@igalia.com</dd>
<dt>Date</dt> <dd>2020-11-05 07:02:39 -0800 (Thu, 05 Nov 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[GTK] Test /webkit/WebKitWebsiteData/configuration is flaky
https://bugs.webkit.org/show_bug.cgi?id=205441

Reviewed by Carlos Garcia Campos.

Checking the last 200 runs of gtk-release in the bots, the original
error from the report does not appear, but other flakies happened
related to checking if some directories were created (namely
indexeddb, service-workers and dom-cache). As they are created
asynchronously or lazily (i.e. requiring some operation to happen).
This could be seen in the WPE bots, not covered by the original
expectation, and also reproduced locally by running the test case
alone.

This commit adds some steps/wait time before each of these to make
sure the directories are created properly.

* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration): Add required steps before checking
directories
* TestWebKitAPI/glib/TestExpectations.json: Remove expectation</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitGLibTestWebsiteDatacpp">trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp</a></li>
<li><a href="#trunkToolsTestWebKitAPIglibTestExpectationsjson">trunk/Tools/TestWebKitAPI/glib/TestExpectations.json</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (269429 => 269430)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2020-11-05 14:44:28 UTC (rev 269429)
+++ trunk/Tools/ChangeLog       2020-11-05 15:02:39 UTC (rev 269430)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2020-11-05  Lauro Moura  <lmoura@igalia.com>
+
+        [GTK] Test /webkit/WebKitWebsiteData/configuration is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=205441
+
+        Reviewed by Carlos Garcia Campos.
+
+        Checking the last 200 runs of gtk-release in the bots, the original
+        error from the report does not appear, but other flakies happened
+        related to checking if some directories were created (namely
+        indexeddb, service-workers and dom-cache). As they are created
+        asynchronously or lazily (i.e. requiring some operation to happen).
+        This could be seen in the WPE bots, not covered by the original
+        expectation, and also reproduced locally by running the test case
+        alone.
+
+        This commit adds some steps/wait time before each of these to make
+        sure the directories are created properly.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+        (testWebsiteDataConfiguration): Add required steps before checking
+        directories
+        * TestWebKitAPI/glib/TestExpectations.json: Remove expectation
+
</ins><span class="cx"> 2020-11-05  Angelos Oikonomopoulos  <angelos@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Test that skip_validation is effective
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitGLibTestWebsiteDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (269429 => 269430)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp   2020-11-05 14:44:28 UTC (rev 269429)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp      2020-11-05 15:02:39 UTC (rev 269430)
</span><span class="lines">@@ -166,6 +166,7 @@
</span><span class="cx">     test->waitUntilLoadFinished();
</span><span class="cx">     test->runJavaScriptAndWaitUntilFinished("window.indexedDB.open('TestDatabase');", nullptr);
</span><span class="cx">     GUniquePtr<char> indexedDBDirectory(g_build_filename(Test::dataDirectory(), "indexeddb", nullptr));
</span><ins>+    test->waitUntilFileChanged(indexedDBDirectory.get(), G_FILE_MONITOR_EVENT_CREATED);
</ins><span class="cx">     g_assert_cmpstr(indexedDBDirectory.get(), ==, webkit_website_data_manager_get_indexeddb_directory(test->m_manager));
</span><span class="cx">     g_assert_true(g_file_test(indexedDBDirectory.get(), G_FILE_TEST_IS_DIR));
</span><span class="cx"> 
</span><span class="lines">@@ -190,11 +191,15 @@
</span><span class="cx">     GUniquePtr<char> itpDirectory(g_build_filename(Test::dataDirectory(), "itp", nullptr));
</span><span class="cx">     g_assert_cmpstr(itpDirectory.get(), ==, webkit_website_data_manager_get_itp_directory(test->m_manager));
</span><span class="cx"> 
</span><ins>+    test->runJavaScriptAndWaitUntilFinished("navigator.serviceWorker.register('./some-dummy.js');", nullptr);
</ins><span class="cx">     GUniquePtr<char> swRegistrationsDirectory(g_build_filename(Test::dataDirectory(), "serviceworkers", nullptr));
</span><ins>+    test->waitUntilFileChanged(swRegistrationsDirectory.get(), G_FILE_MONITOR_EVENT_CREATED);
</ins><span class="cx">     g_assert_cmpstr(swRegistrationsDirectory.get(), ==, webkit_website_data_manager_get_service_worker_registrations_directory(test->m_manager));
</span><span class="cx">     g_assert_true(g_file_test(swRegistrationsDirectory.get(), G_FILE_TEST_IS_DIR));
</span><span class="cx"> 
</span><ins>+    test->runJavaScriptAndWaitUntilFinished("caches.open('my-cache');", nullptr);
</ins><span class="cx">     GUniquePtr<char> domCacheDirectory(g_build_filename(Test::dataDirectory(), "dom-cache", nullptr));
</span><ins>+    test->waitUntilFileChanged(domCacheDirectory.get(), G_FILE_MONITOR_EVENT_CREATED);
</ins><span class="cx">     g_assert_cmpstr(domCacheDirectory.get(), ==, webkit_website_data_manager_get_dom_cache_directory(test->m_manager));
</span><span class="cx">     g_assert_true(g_file_test(domCacheDirectory.get(), G_FILE_TEST_IS_DIR));
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPIglibTestExpectationsjson"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (269429 => 269430)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json     2020-11-05 14:44:28 UTC (rev 269429)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json        2020-11-05 15:02:39 UTC (rev 269430)
</span><span class="lines">@@ -66,9 +66,6 @@
</span><span class="cx">             "/webkit/WebKitWebsiteData/storage": {
</span><span class="cx">                 "expected": { "wpe": {"status": ["PASS", "FAIL"]}}
</span><span class="cx">             },
</span><del>-            "/webkit/WebKitWebsiteData/configuration": {
-                "expected": {"gtk": {"status": ["PASS", "FAIL"], "bug": "webkit.org/b/205441"}}
-            },
</del><span class="cx">             "/webkit/WebKitWebsiteData/dom-cache": {
</span><span class="cx">                 "expected": {
</span><span class="cx">                     "gtk": {"status": ["PASS", "FAIL"], "bug": "webkit.org/b/213785"},
</span></span></pre>
</div>
</div>

</body>
</html>