<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[266227] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/266227">266227</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2020-08-27 02:56:07 -0700 (Thu, 27 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[GTK] Include the run loop source name in frame rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=215847

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Include the given name in rendering frame record data.

* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRenderingFrameData):
* inspector/TimelineRecordFactory.h:
* inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):

Source/WebInspectorUI:

Show the frame name if present in timeline panel.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype._processRecord):
* UserInterface/Models/RenderingFrameTimelineRecord.js:
(WI.RenderingFrameTimelineRecord):
(WI.RenderingFrameTimelineRecord.prototype.get name):
* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView.displayNameForRecord):

Source/WTF:

Pass the run loop source name to the observer.

* wtf/RunLoop.h:
* wtf/glib/RunLoopGLib.cpp:
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::notify):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfRunLooph">trunk/Source/WTF/wtf/RunLoop.h</a></li>
<li><a href="#trunkSourceWTFwtfglibRunLoopGLibcpp">trunk/Source/WTF/wtf/glib/RunLoopGLib.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorTimelineRecordFactorycpp">trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorTimelineRecordFactoryh">trunk/Source/WebCore/inspector/TimelineRecordFactory.h</a></li>
<li><a href="#trunkSourceWebCoreinspectoragentsInspectorTimelineAgentcpp">trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsRenderingFrameTimelineRecordjs">trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineTabContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WTF/ChangeLog  2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2020-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Include the run loop source name in frame rendering timeline
+        https://bugs.webkit.org/show_bug.cgi?id=215847
+
+        Reviewed by Adrian Perez de Castro.
+
+        Pass the run loop source name to the observer.
+
+        * wtf/RunLoop.h:
+        * wtf/glib/RunLoopGLib.cpp:
+        (WTF::RunLoop::RunLoop):
+        (WTF::RunLoop::notify):
+
</ins><span class="cx"> 2020-08-26  Alexey Shvayka  <shvaikalesh@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
</span></span></pre></div>
<a id="trunkSourceWTFwtfRunLooph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/RunLoop.h (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/RunLoop.h   2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WTF/wtf/RunLoop.h      2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> #if USE(GLIB_EVENT_LOOP)
</span><span class="cx">     WTF_EXPORT_PRIVATE GMainContext* mainContext() const { return m_mainContext.get(); }
</span><span class="cx">     enum class Event { WillDispatch, DidDispatch };
</span><del>-    using Observer = WTF::Observer<void(Event)>;
</del><ins>+    using Observer = WTF::Observer<void(Event, const String&)>;
</ins><span class="cx">     WTF_EXPORT_PRIVATE void observe(const Observer&);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="lines">@@ -226,7 +226,7 @@
</span><span class="cx">     RetainPtr<CFRunLoopRef> m_runLoop;
</span><span class="cx">     RetainPtr<CFRunLoopSourceRef> m_runLoopSource;
</span><span class="cx"> #elif USE(GLIB_EVENT_LOOP)
</span><del>-    void notify(Event);
</del><ins>+    void notify(Event, const char*);
</ins><span class="cx"> 
</span><span class="cx">     static GSourceFuncs s_runLoopSourceFunctions;
</span><span class="cx">     GRefPtr<GMainContext> m_mainContext;
</span></span></pre></div>
<a id="trunkSourceWTFwtfglibRunLoopGLibcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/glib/RunLoopGLib.cpp (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/glib/RunLoopGLib.cpp        2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WTF/wtf/glib/RunLoopGLib.cpp   2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -47,10 +47,11 @@
</span><span class="cx">         if (g_source_get_ready_time(source) == -1)
</span><span class="cx">             return G_SOURCE_CONTINUE;
</span><span class="cx">         g_source_set_ready_time(source, -1);
</span><ins>+        const char* name = g_source_get_name(source);
</ins><span class="cx">         auto& runLoopSource = *reinterpret_cast<RunLoopSource*>(source);
</span><del>-        runLoopSource.runLoop->notify(RunLoop::Event::WillDispatch);
</del><ins>+        runLoopSource.runLoop->notify(RunLoop::Event::WillDispatch, name);
</ins><span class="cx">         auto returnValue = callback(userData);
</span><del>-        runLoopSource.runLoop->notify(RunLoop::Event::DidDispatch);
</del><ins>+        runLoopSource.runLoop->notify(RunLoop::Event::DidDispatch, name);
</ins><span class="cx">         return returnValue;
</span><span class="cx">     },
</span><span class="cx">     nullptr, // finalize
</span><span class="lines">@@ -146,13 +147,13 @@
</span><span class="cx">     m_observers.add(observer);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void RunLoop::notify(RunLoop::Event event)
</del><ins>+void RunLoop::notify(RunLoop::Event event, const char* name)
</ins><span class="cx"> {
</span><span class="cx">     if (m_observers.computesEmpty())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><del>-    m_observers.forEach([event](auto& observer) {
-        observer(event);
</del><ins>+    m_observers.forEach([event, name = String::fromUTF8(name)](auto& observer) {
+        observer(event, name);
</ins><span class="cx">     });
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebCore/ChangeLog      2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2020-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Include the run loop source name in frame rendering timeline
+        https://bugs.webkit.org/show_bug.cgi?id=215847
+
+        Reviewed by Adrian Perez de Castro.
+
+        Include the given name in rendering frame record data.
+
+        * inspector/TimelineRecordFactory.cpp:
+        (WebCore::TimelineRecordFactory::createRenderingFrameData):
+        * inspector/TimelineRecordFactory.h:
+        * inspector/agents/InspectorTimelineAgent.cpp:
+        (WebCore::InspectorTimelineAgent::internalStart):
+
</ins><span class="cx"> 2020-08-27  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorTimelineRecordFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp 2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp    2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -56,6 +56,13 @@
</span><span class="cx">     return record;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+Ref<JSON::Object> TimelineRecordFactory::createRenderingFrameData(const String& name)
+{
+    Ref<JSON::Object> data = JSON::Object::create();
+    data->setString("name"_s, name);
+    return data;
+}
+
</ins><span class="cx"> Ref<JSON::Object> TimelineRecordFactory::createFunctionCallData(const String& scriptName, int scriptLine, int scriptColumn)
</span><span class="cx"> {
</span><span class="cx">     Ref<JSON::Object> data = JSON::Object::create();
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorTimelineRecordFactoryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.h (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/TimelineRecordFactory.h   2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebCore/inspector/TimelineRecordFactory.h      2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -46,6 +46,7 @@
</span><span class="cx"> public:
</span><span class="cx">     static Ref<JSON::Object> createGenericRecord(double startTime, int maxCallStackDepth);
</span><span class="cx"> 
</span><ins>+    static Ref<JSON::Object> createRenderingFrameData(const String& name);
</ins><span class="cx">     static Ref<JSON::Object> createFunctionCallData(const String& scriptName, int scriptLine, int scriptColumn);
</span><span class="cx">     static Ref<JSON::Object> createConsoleProfileData(const String& title);
</span><span class="cx">     static Ref<JSON::Object> createProbeSampleData(JSC::BreakpointActionID, unsigned sampleId);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectoragentsInspectorTimelineAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp 2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp    2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -227,13 +227,13 @@
</span><span class="cx"> 
</span><span class="cx">     m_runLoopNestingLevel = 1;
</span><span class="cx"> #elif USE(GLIB_EVENT_LOOP)
</span><del>-    m_runLoopObserver = makeUnique<RunLoop::Observer>([this](RunLoop::Event event) {
</del><ins>+    m_runLoopObserver = makeUnique<RunLoop::Observer>([this](RunLoop::Event event, const String& name) {
</ins><span class="cx">         if (!m_tracking || m_environment.debugger().isPaused())
</span><span class="cx">             return;
</span><span class="cx"> 
</span><span class="cx">         switch (event) {
</span><span class="cx">         case RunLoop::Event::WillDispatch:
</span><del>-            pushCurrentRecord(JSON::Object::create(), TimelineRecordType::RenderingFrame, false, nullptr);
</del><ins>+            pushCurrentRecord(TimelineRecordFactory::createRenderingFrameData(name), TimelineRecordType::RenderingFrame, false, nullptr);
</ins><span class="cx">             break;
</span><span class="cx">         case RunLoop::Event::DidDispatch:
</span><span class="cx">             didCompleteCurrentRecord(TimelineRecordType::RenderingFrame);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebInspectorUI/ChangeLog       2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2020-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Include the run loop source name in frame rendering timeline
+        https://bugs.webkit.org/show_bug.cgi?id=215847
+
+        Reviewed by Adrian Perez de Castro.
+
+        Show the frame name if present in timeline panel.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Controllers/TimelineManager.js:
+        (WI.TimelineManager.prototype._processRecord):
+        * UserInterface/Models/RenderingFrameTimelineRecord.js:
+        (WI.RenderingFrameTimelineRecord):
+        (WI.RenderingFrameTimelineRecord.prototype.get name):
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WI.TimelineTabContentView.displayNameForRecord):
+
</ins><span class="cx"> 2020-08-26  Brian Burg  <bburg@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js   2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js      2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -602,6 +602,7 @@
</span><span class="cx"> localizedStrings["Fragment"] = "Fragment";
</span><span class="cx"> localizedStrings["Fragment Shader"] = "Fragment Shader";
</span><span class="cx"> localizedStrings["Frame %d"] = "Frame %d";
</span><ins>+localizedStrings["Frame %d \u2014 %s"] = "Frame %d \u2014 %s";
</ins><span class="cx"> localizedStrings["Frame URL"] = "Frame URL";
</span><span class="cx"> localizedStrings["Frames"] = "Frames";
</span><span class="cx"> localizedStrings["Frames %d \u2013 %d"] = "Frames %d \u2013 %d";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersTimelineManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js    2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -854,7 +854,7 @@
</span><span class="cx">             if (!recordPayload.children || !recordPayload.children.length)
</span><span class="cx">                 return null;
</span><span class="cx"> 
</span><del>-            return new WI.RenderingFrameTimelineRecord(startTime, endTime);
</del><ins>+            return new WI.RenderingFrameTimelineRecord(startTime, endTime, recordPayload.data.name);
</ins><span class="cx"> 
</span><span class="cx">         case InspectorBackend.Enum.Timeline.EventType.EvaluateScript:
</span><span class="cx">             if (!sourceCodeLocation) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsRenderingFrameTimelineRecordjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js 2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js    2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -25,10 +25,11 @@
</span><span class="cx"> 
</span><span class="cx"> WI.RenderingFrameTimelineRecord = class RenderingFrameTimelineRecord extends WI.TimelineRecord
</span><span class="cx"> {
</span><del>-    constructor(startTime, endTime)
</del><ins>+    constructor(startTime, endTime, name)
</ins><span class="cx">     {
</span><span class="cx">         super(WI.TimelineRecord.Type.RenderingFrame, startTime, endTime);
</span><span class="cx"> 
</span><ins>+        this._name = name || "";
</ins><span class="cx">         this._durationByTaskType = new Map;
</span><span class="cx">         this._frameIndex = -1;
</span><span class="cx">     }
</span><span class="lines">@@ -102,6 +103,11 @@
</span><span class="cx">         return this._frameIndex + 1;
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    get name()
+    {
+        return this._name;
+    }
+
</ins><span class="cx">     setupFrameIndex()
</span><span class="cx">     {
</span><span class="cx">         console.assert(this._frameIndex === -1, "Frame index should only be set once.");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineTabContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (266226 => 266227)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js        2020-08-27 08:25:23 UTC (rev 266226)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js   2020-08-27 09:56:07 UTC (rev 266227)
</span><span class="lines">@@ -288,6 +288,8 @@
</span><span class="cx">         case WI.TimelineRecord.Type.Script:
</span><span class="cx">             return WI.ScriptTimelineRecord.EventType.displayName(timelineRecord.eventType, timelineRecord.details, includeDetailsInMainTitle);
</span><span class="cx">         case WI.TimelineRecord.Type.RenderingFrame:
</span><ins>+            if (timelineRecord.name)
+                return WI.UIString("Frame %d \u2014 %s").format(timelineRecord.frameNumber, timelineRecord.name);
</ins><span class="cx">             return WI.UIString("Frame %d").format(timelineRecord.frameNumber);
</span><span class="cx">         case WI.TimelineRecord.Type.HeapAllocations:
</span><span class="cx">             if (timelineRecord.heapSnapshot.imported)
</span></span></pre>
</div>
</div>

</body>
</html>