<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265831] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265831">265831</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2020-08-18 13:58:32 -0700 (Tue, 18 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/262381">r262381</a>): replaceChildren should not use DeferChildrenChanged::No
https://bugs.webkit.org/show_bug.cgi?id=215600

Reviewed by Antti Koivisto.

It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
Use DeferChildrenChanged::Yes instead.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
people don't start using this function incorrectly in the future.
(WebCore::ContainerNode::replaceChildren): Fixed the bug.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodecpp">trunk/Source/WebCore/dom/ContainerNode.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265830 => 265831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-18 20:46:29 UTC (rev 265830)
+++ trunk/Source/WebCore/ChangeLog      2020-08-18 20:58:32 UTC (rev 265831)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2020-08-17  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r262381): replaceChildren should not use DeferChildrenChanged::No
+        https://bugs.webkit.org/show_bug.cgi?id=215600
+
+        Reviewed by Antti Koivisto.
+
+        It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
+        Use DeferChildrenChanged::Yes instead.
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
+        people don't start using this function incorrectly in the future.
+        (WebCore::ContainerNode::replaceChildren): Fixed the bug.
+
</ins><span class="cx"> 2020-08-18  Simon Fraser  <simon.fraser@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Turn off wheel event regions until we need them
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (265830 => 265831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.cpp       2020-08-18 20:46:29 UTC (rev 265830)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp  2020-08-18 20:58:32 UTC (rev 265831)
</span><span class="lines">@@ -633,8 +633,10 @@
</span><span class="cx"> void ContainerNode::replaceAllChildren(Ref<Node>&& node)
</span><span class="cx"> {
</span><span class="cx">     // This function assumes the input node is not a DocumentFragment and is parentless to decrease complexity.
</span><ins>+    // This function must be called on a new node that has not yet been exposed to script due to the use of DeferChildrenChanged::Yes.
</ins><span class="cx">     ASSERT(!is<DocumentFragment>(node));
</span><span class="cx">     ASSERT(!node->parentNode());
</span><ins>+    RELEASE_ASSERT(!node->wrapper() && node->refCount() == 1);
</ins><span class="cx"> 
</span><span class="cx">     if (!hasChildNodes()) {
</span><span class="cx">         // appendChildWithoutPreInsertionValidityCheck() can only throw when node has a parent and we already asserted it doesn't.
</span><span class="lines">@@ -972,7 +974,7 @@
</span><span class="cx">     // step 3
</span><span class="cx">     Ref<ContainerNode> protectedThis(*this);
</span><span class="cx">     ChildListMutationScope mutation(*this);
</span><del>-    removeAllChildrenWithScriptAssertion(ChildChangeSource::API, DeferChildrenChanged::Yes);
</del><ins>+    removeAllChildrenWithScriptAssertion(ChildChangeSource::API, DeferChildrenChanged::No);
</ins><span class="cx"> 
</span><span class="cx">     auto insertResult = appendChildWithoutPreInsertionValidityCheck(*node);
</span><span class="cx">     if (insertResult.hasException())
</span></span></pre>
</div>
</div>

</body>
</html>