<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265836] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265836">265836</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2020-08-18 15:51:17 -0700 (Tue, 18 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215624

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

* web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
If the context is an OfflineAudioContext, then it should pause processing until the script has finished
execution. This aligns our behavior with Blink and helps us pass more WPT tests.

No new tests, rebaselined existing test.

* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebaudiotheaudioapithescriptprocessornodeinterfacesimpleinputoutputexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioScriptProcessorNodecpp">trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (265835 => 265836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-18 22:18:20 UTC (rev 265835)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2020-08-18 22:51:17 UTC (rev 265836)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2020-08-18  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215624
+
+        Reviewed by Eric Carlson.
+
+        Rebaseline WPT test that is now passing.
+
+        * web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
+
+2020-08-18  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         WaveShaperNode.curve setter should create a copy of the input array
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=215615
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebaudiotheaudioapithescriptprocessornodeinterfacesimpleinputoutputexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt (265835 => 265836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt      2020-08-18 22:18:20 UTC (rev 265835)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt 2020-08-18 22:51:17 UTC (rev 265836)
</span><span class="lines">@@ -4,25 +4,8 @@
</span><span class="cx"> PASS Audit report 
</span><span class="cx"> PASS > [test] ScriptProcessor with stopped input source 
</span><span class="cx"> PASS   ScriptProcessor output[0:1023] contains only the constant 0. 
</span><del>-FAIL X ScriptProcessor output[1024:1151] does not equal [1,1.0575640201568604,1.11493718624115,1.171929121017456,1.2283508777618408,1.28401517868042,1.3387378454208374,1.3923369646072388,1.4446349143981934,1.4954586029052734,1.544638752937317,1.5920131206512451,1.6374237537384033,1.6807206869125366,1.7217600345611572,1.7604058980941772...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
-       Index   Actual                  Expected                AbsError                RelError                Test threshold
-       [0]     0.0000000000000000e+0   1.0000000000000000e+0   1.0000000000000000e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       [1]     0.0000000000000000e+0   1.0575640201568604e+0   1.0575640201568604e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       [2]     0.0000000000000000e+0   1.1149371862411499e+0   1.1149371862411499e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       [3]     0.0000000000000000e+0   1.1719291210174561e+0   1.1719291210174561e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       [4]     0.0000000000000000e+0   1.2283508777618408e+0   1.2283508777618408e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       ...and 123 more errors.
-       Max AbsError of 1.9998764991760254e+0 at index of 27.
-       [27]    0.0000000000000000e+0   1.9998764991760254e+0   1.9998764991760254e+0   1.0000000000000000e+0   0.0000000000000000e+0
-       Max RelError of 1.0000000000000000e+0 at index of 0.
- assert_true: expected true got false
-FAIL X ScriptProcessor output[1152:]: Expected 1 for all values but found 46848 unexpected values: 
-       Index   Actual
-       [0]     0
-       [1]     0
-       [2]     0
-       [3]     0
-       ...and 46844 more errors. assert_true: expected true got false
-FAIL < [test] 2 out of 3 assertions were failed. assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false
</del><ins>+PASS   ScriptProcessor output[1024:1151] equals [1,1.0575640201568604,1.11493718624115,1.171929121017456,1.2283508777618408,1.28401517868042,1.3387378454208374,1.3923369646072388,1.4446349143981934,1.4954586029052734,1.544638752937317,1.5920131206512451,1.6374237537384033,1.6807206869125366,1.7217600345611572,1.7604058980941772...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}. 
+PASS   ScriptProcessor output[1152:] contains only the constant 1. 
+PASS < [test] All assertions passed. (total 3 assertions) 
+PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully. 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265835 => 265836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-18 22:18:20 UTC (rev 265835)
+++ trunk/Source/WebCore/ChangeLog      2020-08-18 22:51:17 UTC (rev 265836)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2020-08-18  Chris Dumez  <cdumez@apple.com>
+
+        ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215624
+
+        Reviewed by Eric Carlson.
+
+        ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
+        If the context is an OfflineAudioContext, then it should pause processing until the script has finished
+        execution. This aligns our behavior with Blink and helps us pass more WPT tests.
+
+        No new tests, rebaselined existing test.
+
+        * Modules/webaudio/ScriptProcessorNode.cpp:
+        (WebCore::ScriptProcessorNode::ScriptProcessorNode):
+        (WebCore::ScriptProcessorNode::process):
+
</ins><span class="cx"> 2020-08-18  Eric Carlson  <eric.carlson@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [Catalyst] Video should pause automatically when switching desktops
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioScriptProcessorNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp (265835 => 265836)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp    2020-08-18 22:18:20 UTC (rev 265835)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp       2020-08-18 22:51:17 UTC (rev 265836)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> #include <JavaScriptCore/Float32Array.h>
</span><span class="cx"> #include <wtf/IsoMallocInlines.h>
</span><span class="cx"> #include <wtf/MainThread.h>
</span><ins>+#include <wtf/threads/BinarySemaphore.h>
</ins><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="lines">@@ -68,6 +69,7 @@
</span><span class="cx">     ASSERT(numberOfInputChannels <= AudioContext::maxNumberOfChannels());
</span><span class="cx"> 
</span><span class="cx">     setNodeType(NodeTypeJavaScript);
</span><ins>+    initializeDefaultNodeOptions(numberOfInputChannels, ChannelCountMode::Explicit, ChannelInterpretation::Speakers);
</ins><span class="cx">     addInput(makeUnique<AudioNodeInput>(this));
</span><span class="cx">     addOutput(makeUnique<AudioNodeOutput>(this, numberOfOutputChannels));
</span><span class="cx"> 
</span><span class="lines">@@ -197,12 +199,23 @@
</span><span class="cx">             m_doubleBufferIndexForEvent = m_doubleBufferIndex;
</span><span class="cx">             m_isRequestOutstanding = true;
</span><span class="cx"> 
</span><del>-            callOnMainThread([this] {
-                fireProcessEvent();
-
</del><ins>+            // We only wait for script code execution when the context is an offline one for performance reasons.
+            if (context().isOfflineContext()) {
+                BinarySemaphore semaphore;
+                callOnMainThread([this, &semaphore] {
+                    fireProcessEvent();
+                    semaphore.signal();
+                });
+                semaphore.wait();
</ins><span class="cx">                 // De-reference to match the ref() call in process().
</span><span class="cx">                 deref();
</span><del>-            });
</del><ins>+            } else {
+                callOnMainThread([this] {
+                    fireProcessEvent();
+                    // De-reference to match the ref() call in process().
+                    deref();
+                });
+            }
</ins><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         swapBuffers();
</span></span></pre>
</div>
</div>

</body>
</html>