<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265742] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265742">265742</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2020-08-16 12:11:06 -0700 (Sun, 16 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
https://bugs.webkit.org/show_bug.cgi?id=215533
rdar://66660924

Reviewed by Youenn Fablet.

Source/WebCore:

A static_cast from float to int, where the float value is larger than MAX_INT, produces
different results on x86_64 and arm64e. Unfortunately, fixing this exposed the fact
that we were accidentally passing the tests below on Intel.

This commit addresses the casting issue and marks the tests as now accurately
failing. Details on the new bug at: webkit.org/b/206753

Covered by:
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--height.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--width.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--height.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--width.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::containerSize const): Don't static_cast from float to int. Rather, use
the explicit IntSize constructor.

LayoutTests:

* TestExpectations: Mark some tests as failing.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoresvggraphicsSVGImagecpp">trunk/Source/WebCore/svg/graphics/SVGImage.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (265741 => 265742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2020-08-16 08:16:10 UTC (rev 265741)
+++ trunk/LayoutTests/ChangeLog 2020-08-16 19:11:06 UTC (rev 265742)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2020-08-16  Dean Jackson  <dino@apple.com>
+
+        [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
+        https://bugs.webkit.org/show_bug.cgi?id=215533
+        rdar://66660924
+
+        Reviewed by Youenn Fablet.
+
+        * TestExpectations: Mark some tests as failing.
+
</ins><span class="cx"> 2020-08-15  Lauro Moura  <lmoura@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GTK][WPE] Add provisional expectation to http/tests to allow the bots to run
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (265741 => 265742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations       2020-08-16 08:16:10 UTC (rev 265741)
+++ trunk/LayoutTests/TestExpectations  2020-08-16 19:11:06 UTC (rev 265742)
</span><span class="lines">@@ -3570,7 +3570,7 @@
</span><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--cover--percent-width-nonpercent-height-viewbox.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--cover--percent-width-omitted-height-viewbox.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--cover--percent-width-percent-height-viewbox.html [ ImageOnlyFailure ]
</span><del>-webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--cover--width.html [ ImageOnlyFailure ]
</del><ins>+webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--cover--width.html [ Pass ImageOnlyFailure ]
</ins><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/border-image-repeat-round.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/border-image-round-and-stretch.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/border-image-slice-003.xht [ ImageOnlyFailure ]
</span><span class="lines">@@ -4542,3 +4542,9 @@
</span><span class="cx"> 
</span><span class="cx"> # WebKit2 only.
</span><span class="cx"> js/throw-large-string-oom.html [ Skip ]
</span><ins>+
+webkit.org/b/215531 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--height.html [ ImageOnlyFailure ]
+webkit.org/b/215531 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--width.html [ ImageOnlyFailure ]
+webkit.org/b/215531 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--height.html [ ImageOnlyFailure ]
+webkit.org/b/215531 imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--width.html [ ImageOnlyFailure ]
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265741 => 265742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-16 08:16:10 UTC (rev 265741)
+++ trunk/Source/WebCore/ChangeLog      2020-08-16 19:11:06 UTC (rev 265742)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2020-08-16  Dean Jackson  <dino@apple.com>
+
+        [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
+        https://bugs.webkit.org/show_bug.cgi?id=215533
+        rdar://66660924
+
+        Reviewed by Youenn Fablet.
+
+        A static_cast from float to int, where the float value is larger than MAX_INT, produces
+        different results on x86_64 and arm64e. Unfortunately, fixing this exposed the fact
+        that we were accidentally passing the tests below on Intel.
+
+        This commit addresses the casting issue and marks the tests as now accurately
+        failing. Details on the new bug at: webkit.org/b/206753
+
+        Covered by:
+        imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--height.html
+        imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/tall--contain--width.html
+        imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--height.html
+        imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/wide--contain--width.html
+
+        * svg/graphics/SVGImage.cpp:
+        (WebCore::SVGImage::containerSize const): Don't static_cast from float to int. Rather, use
+        the explicit IntSize constructor.
+
</ins><span class="cx"> 2020-08-15  Andres Gonzalez  <andresg_22@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Revert unnecessary change for https://bugs.webkit.org/show_bug.cgi?id=215521.
</span></span></pre></div>
<a id="trunkSourceWebCoresvggraphicsSVGImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/graphics/SVGImage.cpp (265741 => 265742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/graphics/SVGImage.cpp   2020-08-16 08:16:10 UTC (rev 265741)
+++ trunk/Source/WebCore/svg/graphics/SVGImage.cpp      2020-08-16 19:11:06 UTC (rev 265742)
</span><span class="lines">@@ -170,11 +170,11 @@
</span><span class="cx">     else
</span><span class="cx">         currentSize = rootElement->currentViewBoxRect().size();
</span><span class="cx"> 
</span><del>-    if (!currentSize.isEmpty())
-        return IntSize(static_cast<int>(ceilf(currentSize.width())), static_cast<int>(ceilf(currentSize.height())));
</del><ins>+    // Use the default CSS intrinsic size if the above failed.
+    if (currentSize.isEmpty())
+        return IntSize(300, 150);
</ins><span class="cx"> 
</span><del>-    // As last resort, use CSS default intrinsic size.
-    return IntSize(300, 150);
</del><ins>+    return IntSize(currentSize);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> ImageDrawResult SVGImage::drawForContainer(GraphicsContext& context, const FloatSize containerSize, float containerZoom, const URL& initialFragmentURL, const FloatRect& dstRect,
</span></span></pre>
</div>
</div>

</body>
</html>