<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265676] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265676">265676</a></dd>
<dt>Author</dt> <dd>youenn@apple.com</dd>
<dt>Date</dt> <dd>2020-08-14 10:26:11 -0700 (Fri, 14 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>WritableStreamDefaultWriterEnsureReadyPromiseRejected should create a new readPromise if the current readyPromise is not pending
https://bugs.webkit.org/show_bug.cgi?id=215500

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

* web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
* web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:
* web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
* web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:
* web-platform-tests/streams/writable-streams/close.any-expected.txt:
* web-platform-tests/streams/writable-streams/close.any.worker-expected.txt:
* web-platform-tests/streams/writable-streams/general.any-expected.txt:
* web-platform-tests/streams/writable-streams/general.any.worker-expected.txt:
* web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt:
* web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt:

Source/WebCore:

Create new promise if current is not pending.
Also mark it as handled so that it does not end up call onunhandledrejection.
Covered by rebased tests.

* Modules/streams/WritableStreamInternals.js:
(writableStreamDefaultWriterEnsureClosedPromiseRejected):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsabortinganyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsabortinganyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsbadunderlyingsinksanyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsbadunderlyingsinksanyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamscloseanyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamscloseanyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any.worker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsgeneralanyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsgeneralanyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any.worker-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsreentrantstrategyanyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsreentrantstrategyanyworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsWritableStreamInternalsjs">trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2020-08-14  Youenn Fablet  <youenn@apple.com>
+
+        WritableStreamDefaultWriterEnsureReadyPromiseRejected should create a new readPromise if the current readyPromise is not pending
+        https://bugs.webkit.org/show_bug.cgi?id=215500
+
+        Reviewed by Geoffrey Garen.
+
+        * web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
+        * web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:
+        * web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
+        * web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:
+        * web-platform-tests/streams/writable-streams/close.any-expected.txt:
+        * web-platform-tests/streams/writable-streams/close.any.worker-expected.txt:
+        * web-platform-tests/streams/writable-streams/general.any-expected.txt:
+        * web-platform-tests/streams/writable-streams/general.any.worker-expected.txt:
+        * web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt:
+        * web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt:
+
</ins><span class="cx"> 2020-08-13  Sergio Villar Senin  <svillar@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [WebXR] Implement WebXRSession::updateRenderState()
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsabortinganyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any-expected.txt     2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any-expected.txt        2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,8 +1,8 @@
</span><span class="cx"> 
</span><del>-Harness Error (FAIL), message = Unhandled rejection
</del><ins>+Harness Error (FAIL), message = Unhandled rejection: writableStreamDefaultWriterRelease
</ins><span class="cx"> 
</span><span class="cx"> PASS Aborting a WritableStream before it starts should cause the writer's unsettled ready promise to reject 
</span><del>-FAIL Aborting a WritableStream should cause the writer's fulfilled ready promise to reset to a rejected one assert_not_equals: the ready promise property should change got disallowed value object "[object Promise]"
</del><ins>+PASS Aborting a WritableStream should cause the writer's fulfilled ready promise to reset to a rejected one 
</ins><span class="cx"> PASS abort() on a released writer rejects 
</span><span class="cx"> PASS Aborting a WritableStream immediately prevents future writes 
</span><span class="cx"> PASS Aborting a WritableStream prevents further writes after any that are in progress 
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx"> PASS WritableStream if sink's abort throws, the promise returned by ws.abort() rejects 
</span><span class="cx"> PASS WritableStream if sink's abort throws, for an abort performed during a write, the promise returned by ws.abort() rejects 
</span><span class="cx"> PASS Aborting a WritableStream passes through the given reason 
</span><del>-FAIL Aborting a WritableStream puts it in an errored state with the error passed to abort() assert_unreached: Should have rejected: ready should reject with error1 Reached unreachable code
</del><ins>+PASS Aborting a WritableStream puts it in an errored state with the error passed to abort() 
</ins><span class="cx"> PASS Aborting a WritableStream causes any outstanding write() promises to be rejected with the reason supplied 
</span><span class="cx"> PASS Closing but then immediately aborting a WritableStream causes the stream to error 
</span><span class="cx"> PASS Closing a WritableStream and aborting it while it closes causes the stream to ignore the abort attempt 
</span><span class="lines">@@ -31,23 +31,23 @@
</span><span class="cx"> PASS if a writer is created for a stream with a pending abort, its ready should be rejected with the abort error 
</span><span class="cx"> PASS writer close() promise should resolve before abort() promise 
</span><span class="cx"> PASS writer.ready should reject on controller error without waiting for underlying write 
</span><del>-FAIL writer.abort() while there is an in-flight write, and then finish the write with rejection promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort() while there is an in-flight write, and then finish the write with rejection promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL writer.abort(), controller.error() while there is an in-flight write, and then finish the write promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort(), controller.error() while there is an in-flight write, and then finish the write promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL writer.abort(), controller.error() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.ready must reject with the error from abort Reached unreachable code
-FAIL controller.error(), writer.abort() while there is an in-flight write, and then finish the write promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error2: error2" ("error2") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort(), controller.error() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.closed must be rejected with an error indicating release Reached unreachable code
+FAIL controller.error(), writer.abort() while there is an in-flight write, and then finish the write promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error2: error2" ("error2") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL controller.error(), writer.abort() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.ready must reject with the error passed to the controller's error method Reached unreachable code
</del><ins>+FAIL controller.error(), writer.abort() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.closed must be rejected with an error indicating release Reached unreachable code
</ins><span class="cx"> PASS releaseLock() while aborting should reject the original closed promise 
</span><span class="cx"> PASS releaseLock() during delayed async abort() should reject the writer.closed promise 
</span><span class="cx"> PASS sink abort() should not be called until sink start() is done 
</span><span class="cx"> PASS if start attempts to error the controller after abort() has been called, then it should lose 
</span><span class="cx"> PASS stream abort() promise should still resolve if sink start() rejects 
</span><del>-FAIL writer abort() during sink start() should replace the writer.ready promise synchronously assert_not_equals: abort() should replace the ready promise with a rejected one got disallowed value object "[object Promise]"
</del><ins>+PASS writer abort() during sink start() should replace the writer.ready promise synchronously 
</ins><span class="cx"> PASS promises returned from other writer methods should be rejected when writer abort() happens during sink start() 
</span><span class="cx"> PASS abort() should succeed despite rejection from write 
</span><span class="cx"> PASS abort() should be rejected with the rejection returned from close() 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsabortinganyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt      2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt 2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,8 +1,8 @@
</span><span class="cx"> 
</span><del>-Harness Error (FAIL), message = Unhandled rejection
</del><ins>+Harness Error (FAIL), message = Unhandled rejection: writableStreamDefaultWriterRelease
</ins><span class="cx"> 
</span><span class="cx"> PASS Aborting a WritableStream before it starts should cause the writer's unsettled ready promise to reject 
</span><del>-FAIL Aborting a WritableStream should cause the writer's fulfilled ready promise to reset to a rejected one assert_not_equals: the ready promise property should change got disallowed value object "[object Promise]"
</del><ins>+PASS Aborting a WritableStream should cause the writer's fulfilled ready promise to reset to a rejected one 
</ins><span class="cx"> PASS abort() on a released writer rejects 
</span><span class="cx"> PASS Aborting a WritableStream immediately prevents future writes 
</span><span class="cx"> PASS Aborting a WritableStream prevents further writes after any that are in progress 
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx"> PASS WritableStream if sink's abort throws, the promise returned by ws.abort() rejects 
</span><span class="cx"> PASS WritableStream if sink's abort throws, for an abort performed during a write, the promise returned by ws.abort() rejects 
</span><span class="cx"> PASS Aborting a WritableStream passes through the given reason 
</span><del>-FAIL Aborting a WritableStream puts it in an errored state with the error passed to abort() assert_unreached: Should have rejected: ready should reject with error1 Reached unreachable code
</del><ins>+PASS Aborting a WritableStream puts it in an errored state with the error passed to abort() 
</ins><span class="cx"> PASS Aborting a WritableStream causes any outstanding write() promises to be rejected with the reason supplied 
</span><span class="cx"> PASS Closing but then immediately aborting a WritableStream causes the stream to error 
</span><span class="cx"> PASS Closing a WritableStream and aborting it while it closes causes the stream to ignore the abort attempt 
</span><span class="lines">@@ -31,23 +31,23 @@
</span><span class="cx"> PASS if a writer is created for a stream with a pending abort, its ready should be rejected with the abort error 
</span><span class="cx"> PASS writer close() promise should resolve before abort() promise 
</span><span class="cx"> PASS writer.ready should reject on controller error without waiting for underlying write 
</span><del>-FAIL writer.abort() while there is an in-flight write, and then finish the write with rejection promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort() while there is an in-flight write, and then finish the write with rejection promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL writer.abort(), controller.error() while there is an in-flight write, and then finish the write promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort(), controller.error() while there is an in-flight write, and then finish the write promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error1: error1" ("error1") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL writer.abort(), controller.error() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.ready must reject with the error from abort Reached unreachable code
-FAIL controller.error(), writer.abort() while there is an in-flight write, and then finish the write promise_rejects_js: writer.ready must be rejected with an error indicating release function "function () { throw e }" threw object "error2: error2" ("error2") expected instance of function "function TypeError() {
</del><ins>+FAIL writer.abort(), controller.error() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.closed must be rejected with an error indicating release Reached unreachable code
+FAIL controller.error(), writer.abort() while there is an in-flight write, and then finish the write promise_rejects_js: writer.closed must be rejected with an error indicating release function "function () { throw e }" threw object "error2: error2" ("error2") expected instance of function "function TypeError() {
</ins><span class="cx">     [native code]
</span><span class="cx"> }" ("TypeError")
</span><del>-FAIL controller.error(), writer.abort() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.ready must reject with the error passed to the controller's error method Reached unreachable code
</del><ins>+FAIL controller.error(), writer.abort() while there is an in-flight close, and then finish the close assert_unreached: Should have rejected: writer.closed must be rejected with an error indicating release Reached unreachable code
</ins><span class="cx"> PASS releaseLock() while aborting should reject the original closed promise 
</span><span class="cx"> PASS releaseLock() during delayed async abort() should reject the writer.closed promise 
</span><span class="cx"> PASS sink abort() should not be called until sink start() is done 
</span><span class="cx"> PASS if start attempts to error the controller after abort() has been called, then it should lose 
</span><span class="cx"> PASS stream abort() promise should still resolve if sink start() rejects 
</span><del>-FAIL writer abort() during sink start() should replace the writer.ready promise synchronously assert_not_equals: abort() should replace the ready promise with a rejected one got disallowed value object "[object Promise]"
</del><ins>+PASS writer abort() during sink start() should replace the writer.ready promise synchronously 
</ins><span class="cx"> PASS promises returned from other writer methods should be rejected when writer abort() happens during sink start() 
</span><span class="cx"> PASS abort() should succeed despite rejection from write 
</span><span class="cx"> PASS abort() should be rejected with the rejection returned from close() 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsbadunderlyingsinksanyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt 2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt    2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -2,8 +2,8 @@
</span><span class="cx"> Harness Error (FAIL), message = Unhandled rejection: error1
</span><span class="cx"> 
</span><span class="cx"> PASS start: errors in start cause WritableStream constructor to throw 
</span><del>-FAIL close: throwing method should cause writer close() and ready to reject assert_unreached: Should have rejected: ready promise must reject with the thrown error Reached unreachable code
-FAIL close: returning a rejected promise should cause writer close() and ready to reject assert_unreached: Should have rejected: ready promise must reject with the same error Reached unreachable code
</del><ins>+PASS close: throwing method should cause writer close() and ready to reject 
+PASS close: returning a rejected promise should cause writer close() and ready to reject 
</ins><span class="cx"> PASS close: throwing getter should cause constructor to throw 
</span><span class="cx"> PASS write: throwing getter should cause write() and closed to reject 
</span><span class="cx"> PASS write: throwing method should cause write() and closed to reject 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsbadunderlyingsinksanyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt  2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt     2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -2,8 +2,8 @@
</span><span class="cx"> Harness Error (FAIL), message = Unhandled rejection: error1
</span><span class="cx"> 
</span><span class="cx"> PASS start: errors in start cause WritableStream constructor to throw 
</span><del>-FAIL close: throwing method should cause writer close() and ready to reject assert_unreached: Should have rejected: ready promise must reject with the thrown error Reached unreachable code
-FAIL close: returning a rejected promise should cause writer close() and ready to reject assert_unreached: Should have rejected: ready promise must reject with the same error Reached unreachable code
</del><ins>+PASS close: throwing method should cause writer close() and ready to reject 
+PASS close: returning a rejected promise should cause writer close() and ready to reject 
</ins><span class="cx"> PASS close: throwing getter should cause constructor to throw 
</span><span class="cx"> PASS write: throwing getter should cause write() and closed to reject 
</span><span class="cx"> PASS write: throwing method should cause write() and closed to reject 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamscloseanyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any-expected.txt        2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any-expected.txt   2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> 
</span><del>-Harness Error (FAIL), message = Unhandled rejection: error1
</del><ins>+Harness Error (FAIL), message = Unhandled rejection: writableStreamDefaultWriterRelease
</ins><span class="cx"> 
</span><span class="cx"> PASS fulfillment value of writer.close() call must be undefined even if the underlying sink returns a non-undefined value 
</span><span class="cx"> PASS when sink calls error asynchronously while sink close is in-flight, the stream should not become errored 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamscloseanyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any.worker-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any.worker-expected.txt 2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/close.any.worker-expected.txt    2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> 
</span><del>-Harness Error (FAIL), message = Unhandled rejection: error1
</del><ins>+Harness Error (FAIL), message = Unhandled rejection: writableStreamDefaultWriterRelease
</ins><span class="cx"> 
</span><span class="cx"> PASS fulfillment value of writer.close() call must be undefined even if the underlying sink returns a non-undefined value 
</span><span class="cx"> PASS when sink calls error asynchronously while sink close is in-flight, the stream should not become errored 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsgeneralanyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any-expected.txt      2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any-expected.txt 2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx"> PASS ws.getWriter() on a closed WritableStream 
</span><span class="cx"> PASS ws.getWriter() on an aborted WritableStream 
</span><span class="cx"> PASS ws.getWriter() on an errored WritableStream 
</span><del>-FAIL closed and ready on a released writer assert_unreached: writer.ready fulfilled unexpectedly with: undefined Reached unreachable code
</del><ins>+PASS closed and ready on a released writer 
</ins><span class="cx"> PASS WritableStream should call underlying sink methods as methods 
</span><span class="cx"> PASS methods should not not have .apply() or .call() called 
</span><span class="cx"> PASS WritableStream's strategy.size should not be called as a method 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsgeneralanyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any.worker-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any.worker-expected.txt       2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/general.any.worker-expected.txt  2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx"> PASS ws.getWriter() on a closed WritableStream 
</span><span class="cx"> PASS ws.getWriter() on an aborted WritableStream 
</span><span class="cx"> PASS ws.getWriter() on an errored WritableStream 
</span><del>-FAIL closed and ready on a released writer assert_unreached: writer.ready fulfilled unexpectedly with: undefined Reached unreachable code
</del><ins>+PASS closed and ready on a released writer 
</ins><span class="cx"> PASS WritableStream should call underlying sink methods as methods 
</span><span class="cx"> PASS methods should not not have .apply() or .call() called 
</span><span class="cx"> PASS WritableStream's strategy.size should not be called as a method 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsreentrantstrategyanyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt   2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any-expected.txt      2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,9 +1,9 @@
</span><span class="cx"> 
</span><span class="cx"> PASS writes should be written in the standard order 
</span><span class="cx"> PASS writer.write() promises should resolve in the standard order 
</span><del>-FAIL controller.error() should work when called from within strategy.size() assert_unreached: Should have rejected: ready should reject with error1 Reached unreachable code
</del><ins>+PASS controller.error() should work when called from within strategy.size() 
</ins><span class="cx"> PASS close() should work when called from within strategy.size() 
</span><span class="cx"> PASS abort() should work when called from within strategy.size() 
</span><del>-FAIL releaseLock() should abort the write() when called within strategy.size() assert_unreached: Should have rejected: ready promise should reject Reached unreachable code
-FAIL original reader should error when new reader is created within strategy.size() assert_unreached: Should have rejected: ready promise should reject Reached unreachable code
</del><ins>+PASS releaseLock() should abort the write() when called within strategy.size() 
+PASS original reader should error when new reader is created within strategy.size() 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsstreamswritablestreamsreentrantstrategyanyworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt    2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/writable-streams/reentrant-strategy.any.worker-expected.txt       2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,9 +1,9 @@
</span><span class="cx"> 
</span><span class="cx"> PASS writes should be written in the standard order 
</span><span class="cx"> PASS writer.write() promises should resolve in the standard order 
</span><del>-FAIL controller.error() should work when called from within strategy.size() assert_unreached: Should have rejected: ready should reject with error1 Reached unreachable code
</del><ins>+PASS controller.error() should work when called from within strategy.size() 
</ins><span class="cx"> PASS close() should work when called from within strategy.size() 
</span><span class="cx"> PASS abort() should work when called from within strategy.size() 
</span><del>-FAIL releaseLock() should abort the write() when called within strategy.size() assert_unreached: Should have rejected: ready promise should reject Reached unreachable code
-FAIL original reader should error when new reader is created within strategy.size() assert_unreached: Should have rejected: ready promise should reject Reached unreachable code
</del><ins>+PASS releaseLock() should abort the write() when called within strategy.size() 
+PASS original reader should error when new reader is created within strategy.size() 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/Source/WebCore/ChangeLog      2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2020-08-14  Youenn Fablet  <youenn@apple.com>
+
+        WritableStreamDefaultWriterEnsureReadyPromiseRejected should create a new readPromise if the current readyPromise is not pending
+        https://bugs.webkit.org/show_bug.cgi?id=215500
+
+        Reviewed by Geoffrey Garen.
+
+        Create new promise if current is not pending.
+        Also mark it as handled so that it does not end up call onunhandledrejection.
+        Covered by rebased tests.
+
+        * Modules/streams/WritableStreamInternals.js:
+        (writableStreamDefaultWriterEnsureClosedPromiseRejected):
+
</ins><span class="cx"> 2020-08-13  Sergio Villar Senin  <svillar@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [WebXR] Implement WebXRSession::updateRenderState()
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsWritableStreamInternalsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js (265675 => 265676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js  2020-08-14 17:22:40 UTC (rev 265675)
+++ trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js     2020-08-14 17:26:11 UTC (rev 265676)
</span><span class="lines">@@ -380,7 +380,17 @@
</span><span class="cx"> 
</span><span class="cx"> function writableStreamDefaultWriterEnsureReadyPromiseRejected(writer, error)
</span><span class="cx"> {
</span><del>-    @getByIdDirectPrivate(writer, "readyPromise").@reject.@call(@undefined, error);
</del><ins>+    let readyPromiseCapability = @getByIdDirectPrivate(writer, "readyPromise");
+    let readyPromise = readyPromiseCapability.@promise;
+
+    if ((@getPromiseInternalField(readyPromise, @promiseFieldFlags) & @promiseStateMask) !== @promiseStatePending) {
+        readyPromiseCapability = @newPromiseCapability(@Promise);
+        readyPromise = readyPromiseCapability.@promise;
+        @putByIdDirectPrivate(writer, "readyPromise", readyPromiseCapability);
+    }
+
+    readyPromiseCapability.@reject.@call(@undefined, error);
+    @putPromiseInternalField(readyPromise, @promiseFieldFlags, @getPromiseInternalField(readyPromise, @promiseFieldFlags) | @promiseFlagsIsHandled);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> function writableStreamDefaultWriterGetDesiredSize(writer)
</span></span></pre>
</div>
</div>

</body>
</html>