<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265388] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265388">265388</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2020-08-07 13:02:29 -0700 (Fri, 07 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>length attribute is missing on OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215287

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

length attribute is missing on OfflineAudioContext:
- https://www.w3.org/TR/webaudio/#dom-offlineaudiocontext-length

Test: webaudio/offlineaudiocontext-length.html

* Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::renderTarget const):
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::length const):
* Modules/webaudio/OfflineAudioContext.h:
* Modules/webaudio/OfflineAudioContext.idl:

LayoutTests:

Add layout test coverage.

* webaudio/offlineaudiocontext-length-expected.txt: Added.
* webaudio/offlineaudiocontext-length.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebaudioidlharnesshttpswindowexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioBaseAudioContexth">trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioOfflineAudioContexth">trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioOfflineAudioContextidl">trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestswebaudioofflineaudiocontextlengthexpectedtxt">trunk/LayoutTests/webaudio/offlineaudiocontext-length-expected.txt</a></li>
<li><a href="#trunkLayoutTestswebaudioofflineaudiocontextlengthhtml">trunk/LayoutTests/webaudio/offlineaudiocontext-length.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/LayoutTests/ChangeLog 2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2020-08-07  Chris Dumez  <cdumez@apple.com>
+
+        length attribute is missing on OfflineAudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215287
+
+        Reviewed by Geoffrey Garen.
+
+        Add layout test coverage.
+
+        * webaudio/offlineaudiocontext-length-expected.txt: Added.
+        * webaudio/offlineaudiocontext-length.html: Added.
+
</ins><span class="cx"> 2020-08-07  Alexey Shvayka  <shvaikalesh@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Reduce the amount of custom binding code for JSXPathNSResolver
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2020-08-07  Chris Dumez  <cdumez@apple.com>
+
+        length attribute is missing on OfflineAudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215287
+
+        Reviewed by Geoffrey Garen.
+
+        Rebaseline WPT test now that more checks are passing.
+
+        * web-platform-tests/webaudio/idlharness.https.window-expected.txt:
+
</ins><span class="cx"> 2020-08-07  Alexey Shvayka  <shvaikalesh@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Reduce the amount of custom binding code for JSXPathNSResolver
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebaudioidlharnesshttpswindowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt  2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt     2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> PASS OfflineAudioContext interface: operation startRendering() 
</span><span class="cx"> PASS OfflineAudioContext interface: operation resume() 
</span><span class="cx"> FAIL OfflineAudioContext interface: operation suspend(double) assert_equals: property has wrong .length expected 1 but got 0
</span><del>-FAIL OfflineAudioContext interface: attribute length assert_true: The prototype object must have a property "length" expected true got false
</del><ins>+PASS OfflineAudioContext interface: attribute length 
</ins><span class="cx"> PASS OfflineAudioContext interface: attribute oncomplete 
</span><span class="cx"> PASS OfflineAudioContext must be primary interface of new OfflineAudioContext(1, 1, sample_rate) 
</span><span class="cx"> PASS Stringification of new OfflineAudioContext(1, 1, sample_rate) 
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> PASS OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "resume()" with the proper type 
</span><span class="cx"> PASS OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "suspend(double)" with the proper type 
</span><span class="cx"> PASS OfflineAudioContext interface: calling suspend(double) on new OfflineAudioContext(1, 1, sample_rate) with too few arguments must throw TypeError 
</span><del>-FAIL OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "length" with the proper type assert_inherits: property "length" not found in prototype chain
</del><ins>+PASS OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "length" with the proper type 
</ins><span class="cx"> PASS OfflineAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "oncomplete" with the proper type 
</span><span class="cx"> PASS BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "destination" with the proper type 
</span><span class="cx"> PASS BaseAudioContext interface: new OfflineAudioContext(1, 1, sample_rate) must inherit property "sampleRate" with the proper type 
</span></span></pre></div>
<a id="trunkLayoutTestswebaudioofflineaudiocontextlengthexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/webaudio/offlineaudiocontext-length-expected.txt (0 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webaudio/offlineaudiocontext-length-expected.txt                               (rev 0)
+++ trunk/LayoutTests/webaudio/offlineaudiocontext-length-expected.txt  2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+Basic testing for OfflineAudioContext.length
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS context = new OfflineAudioContext({ length: 100, sampleRate: 44100 }) did not throw exception.
+PASS context.length is 100
+PASS context = new OfflineAudioContext({ length: 1000, sampleRate: 44100 }) did not throw exception.
+PASS context.length is 1000
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestswebaudioofflineaudiocontextlengthhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/webaudio/offlineaudiocontext-length.html (0 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webaudio/offlineaudiocontext-length.html                               (rev 0)
+++ trunk/LayoutTests/webaudio/offlineaudiocontext-length.html  2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../resources/js-test.js"></script>
+<script>
+description("Basic testing for OfflineAudioContext.length");
+
+shouldNotThrow("context = new OfflineAudioContext({ length: 100, sampleRate: 44100 })");
+shouldBe("context.length", "100");
+
+shouldNotThrow("context = new OfflineAudioContext({ length: 1000, sampleRate: 44100 })");
+shouldBe("context.length", "1000");
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/Source/WebCore/ChangeLog      2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2020-08-07  Chris Dumez  <cdumez@apple.com>
+
+        length attribute is missing on OfflineAudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215287
+
+        Reviewed by Geoffrey Garen.
+
+        length attribute is missing on OfflineAudioContext:
+        - https://www.w3.org/TR/webaudio/#dom-offlineaudiocontext-length
+
+        Test: webaudio/offlineaudiocontext-length.html
+
+        * Modules/webaudio/BaseAudioContext.h:
+        (WebCore::BaseAudioContext::renderTarget const):
+        * Modules/webaudio/OfflineAudioContext.cpp:
+        (WebCore::OfflineAudioContext::length const):
+        * Modules/webaudio/OfflineAudioContext.h:
+        * Modules/webaudio/OfflineAudioContext.idl:
+
</ins><span class="cx"> 2020-08-07  Alexey Shvayka  <shvaikalesh@gmail.com>
</span><span class="cx"> 
</span><span class="cx">         Reduce the amount of custom binding code for JSXPathNSResolver
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioBaseAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h 2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h    2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -133,6 +133,8 @@
</span><span class="cx">     void suspendRendering(DOMPromiseDeferred<void>&&);
</span><span class="cx">     void resumeRendering(DOMPromiseDeferred<void>&&);
</span><span class="cx"> 
</span><ins>+    AudioBuffer* renderTarget() const { return m_renderTarget.get(); }
+
</ins><span class="cx">     using State = AudioContextState;
</span><span class="cx">     State state() const { return m_state; }
</span><span class="cx">     bool isClosed() const { return m_state == State::Closed; }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp    2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp       2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -94,6 +94,11 @@
</span><span class="cx">     promise->resolve<IDLInterface<AudioBuffer>>(result.releaseReturnValue());
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+unsigned OfflineAudioContext::length() const
+{
+    return renderTarget()->length();
+}
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx"> 
</span><span class="cx"> #endif // ENABLE(WEB_AUDIO)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioOfflineAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.h (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.h      2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.h 2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -39,6 +39,8 @@
</span><span class="cx"> 
</span><span class="cx">     void startOfflineRendering(Ref<DeferredPromise>&&);
</span><span class="cx"> 
</span><ins>+    unsigned length() const;
+
</ins><span class="cx"> private:
</span><span class="cx">     OfflineAudioContext(Document&, AudioBuffer* renderTarget);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioOfflineAudioContextidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl (265387 => 265388)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl    2020-08-07 19:27:56 UTC (rev 265387)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl       2020-08-07 20:02:29 UTC (rev 265388)
</span><span class="lines">@@ -35,8 +35,7 @@
</span><span class="cx">     [ImplementedAs=resumeRendering] Promise<void> resume();
</span><span class="cx">     [ImplementedAs=suspendRendering] Promise<void> suspend(); // FIXME: Missing suspendTime parameter.
</span><span class="cx"> 
</span><del>-    // FIXME: Add support.
-    // readonly attribute unsigned long length;
</del><ins>+    readonly attribute unsigned long length;
</ins><span class="cx"> 
</span><span class="cx">     attribute EventHandler oncomplete;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>