<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265356] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265356">265356</a></dd>
<dt>Author</dt> <dd>nvasilyev@apple.com</dd>
<dt>Date</dt> <dd>2020-08-06 17:19:15 -0700 (Thu, 06 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Media & Animations timeline shouldn't shift when sorting
https://bugs.webkit.org/show_bug.cgi?id=215085

Reviewed by Devin Rousso.

* UserInterface/Views/DataGrid.css:
(.data-grid):
(.data-grid th):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th.graph-column > .timeline-ruler):
Override padding defined in `.data-grid th > .header-cell-content`.

(.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers):
(.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after):
`.header-cell-content.timeline-ruler` is different from `.header-cell-content` in the sense that the former takes the entire
height of DataGrid and has no padding. Place the chevron in the middle of `--data-grid-header-height`.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (265355 => 265356)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/ChangeLog       2020-08-07 00:19:15 UTC (rev 265356)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2020-08-06  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Media & Animations timeline shouldn't shift when sorting
+        https://bugs.webkit.org/show_bug.cgi?id=215085
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/DataGrid.css:
+        (.data-grid):
+        (.data-grid th):
+        (.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
+        * UserInterface/Views/TimelineDataGrid.css:
+        (.data-grid.timeline th.graph-column > .timeline-ruler):
+        Override padding defined in `.data-grid th > .header-cell-content`.
+
+        (.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers):
+        (.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after):
+        `.header-cell-content.timeline-ruler` is different from `.header-cell-content` in the sense that the former takes the entire
+        height of DataGrid and has no padding. Place the chevron in the middle of `--data-grid-header-height`.
+
</ins><span class="cx"> 2020-08-05  Tim Horton  <timothy_horton@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Remove all references to non-existent 10.16
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (265355 => 265356)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css     2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css        2020-08-07 00:19:15 UTC (rev 265356)
</span><span class="lines">@@ -28,6 +28,8 @@
</span><span class="cx">     outline: none;
</span><span class="cx"> 
</span><span class="cx">     --data-grid-header-horizontal-padding: 6px;
</span><ins>+    --data-grid-header-height: 22px;
+    --data-grid-sorting-indicator-height: 8px;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> .data-grid .highlight {
</span><span class="lines">@@ -77,7 +79,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> .data-grid th {
</span><del>-    height: 22px;
</del><ins>+    height: var(--data-grid-header-height);
</ins><span class="cx">     padding: 0;
</span><span class="cx">     text-align: start;
</span><span class="cx">     vertical-align: middle;
</span><span class="lines">@@ -227,7 +229,7 @@
</span><span class="cx">     top: 1px;
</span><span class="cx">     bottom: 0;
</span><span class="cx">     width: 9px;
</span><del>-    height: 8px;
</del><ins>+    height: var(--data-grid-sorting-indicator-height);
</ins><span class="cx">     margin-bottom: auto;
</span><span class="cx">     margin-top: auto;
</span><span class="cx">     content: "";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css (265355 => 265356)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css     2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css        2020-08-07 00:19:15 UTC (rev 265356)
</span><span class="lines">@@ -46,8 +46,18 @@
</span><span class="cx">     top: 0;
</span><span class="cx">     bottom: 0;
</span><span class="cx">     margin: 0;
</span><ins>+    padding: 0;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><ins>+.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers {
+    position: absolute;
+}
+
+.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after {
+    top: calc(var(--data-grid-header-height) / 2 - var(--data-grid-sorting-indicator-height) / 2);
+    bottom: unset;
+}
+
</ins><span class="cx"> .data-grid.timeline td.graph-column {
</span><span class="cx">     padding: 2px 0;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>