<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265345] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265345">265345</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2020-08-06 13:21:06 -0700 (Thu, 06 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, reverting <a href="http://trac.webkit.org/projects/webkit/changeset/265325">r265325</a>.

Caused several tests in fast/forms and editing/pasteboard to
time out

Reverted changeset:

"Remove UIScriptController.removeAllDynamicDictionaries()"
https://bugs.webkit.org/show_bug.cgi?id=215207
https://trac.webkit.org/changeset/265325</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsioscontenteditableautocorrecthtml">trunk/LayoutTests/fast/events/ios/contenteditable-autocorrect.html</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestRunnerSharedUIScriptContextBindingsUIScriptControlleridl">trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl</a></li>
<li><a href="#trunkToolsTestRunnerSharedUIScriptContextUIScriptControllerh">trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h</a></li>
<li><a href="#trunkToolsWebKitTestRunneriosTestControllerIOSmm">trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunneriosUIScriptControllerIOSh">trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h</a></li>
<li><a href="#trunkToolsWebKitTestRunneriosUIScriptControllerIOSmm">trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/LayoutTests/ChangeLog 2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2020-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Unreviewed, reverting r265325.
+
+        Caused several tests in fast/forms and editing/pasteboard to
+        time out
+
+        Reverted changeset:
+
+        "Remove UIScriptController.removeAllDynamicDictionaries()"
+        https://bugs.webkit.org/show_bug.cgi?id=215207
+        https://trac.webkit.org/changeset/265325
+
</ins><span class="cx"> 2020-08-06  Alicia Boya GarcĂ­a  <aboya@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed GStreamer MSE micro gardening
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsioscontenteditableautocorrecthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/ios/contenteditable-autocorrect.html (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/ios/contenteditable-autocorrect.html       2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/LayoutTests/fast/events/ios/contenteditable-autocorrect.html  2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx">             return new Promise(function(resolve) {
</span><span class="cx">                 let rect = editable.getBoundingClientRect();
</span><span class="cx">                 testRunner.runUIScript(`(function() {
</span><ins>+                    uiController.removeAllDynamicDictionaries();
</ins><span class="cx">                     uiController.didShowKeyboardCallback = function() {
</span><span class="cx">                         uiController.typeCharacterUsingHardwareKeyboard("t", function() {
</span><span class="cx">                             uiController.typeCharacterUsingHardwareKeyboard("i", function() {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/ChangeLog       2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2020-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Unreviewed, reverting r265325.
+
+        Caused several tests in fast/forms and editing/pasteboard to
+        time out
+
+        Reverted changeset:
+
+        "Remove UIScriptController.removeAllDynamicDictionaries()"
+        https://bugs.webkit.org/show_bug.cgi?id=215207
+        https://trac.webkit.org/changeset/265325
+
</ins><span class="cx"> 2020-08-06  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         WTF::makeString() should handle enum values
</span></span></pre></div>
<a id="trunkToolsTestRunnerSharedUIScriptContextBindingsUIScriptControlleridl"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl     2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl        2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -311,6 +311,7 @@
</span><span class="cx">     void setKeyboardInputModeIdentifier(DOMString identifier);
</span><span class="cx"> 
</span><span class="cx">     void replaceTextAtRange(DOMString text, long location, long length);
</span><ins>+    void removeAllDynamicDictionaries();
</ins><span class="cx"> 
</span><span class="cx">     readonly attribute DOMString scrollingTreeAsText;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsTestRunnerSharedUIScriptContextUIScriptControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h        2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h   2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -186,6 +186,7 @@
</span><span class="cx">     virtual void setKeyboardInputModeIdentifier(JSStringRef) { notImplemented(); }
</span><span class="cx"> 
</span><span class="cx">     virtual void replaceTextAtRange(JSStringRef, int location, int length) { notImplemented(); }
</span><ins>+    virtual void removeAllDynamicDictionaries() { notImplemented(); }
</ins><span class="cx"> 
</span><span class="cx">     virtual bool windowIsKey() const;
</span><span class="cx">     virtual void setWindowIsKey(bool);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunneriosTestControllerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm    2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm       2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -155,7 +155,6 @@
</span><span class="cx"> {
</span><span class="cx">     cocoaResetStateToConsistentValues(options);
</span><span class="cx"> 
</span><del>-    [UIKeyboard removeAllDynamicDictionaries];
</del><span class="cx">     [UIPasteboard generalPasteboard].items = @[ ];
</span><span class="cx">     [[UIApplication sharedApplication] _cancelAllTouches];
</span><span class="cx">     [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunneriosUIScriptControllerIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h 2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h    2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -118,6 +118,7 @@
</span><span class="cx">     JSObjectRef selectionCaretViewRect() const override;
</span><span class="cx">     JSObjectRef selectionRangeViewRects() const override;
</span><span class="cx">     JSObjectRef inputViewBounds() const override;
</span><ins>+    void removeAllDynamicDictionaries() override;
</ins><span class="cx">     JSRetainPtr<JSStringRef> scrollingTreeAsText() const override;
</span><span class="cx">     JSObjectRef propertiesOfLayerWithID(uint64_t layerID) const override;
</span><span class="cx">     void simulateRotation(DeviceOrientation*, JSValueRef) override;
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunneriosUIScriptControllerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (265344 => 265345)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm        2020-08-06 20:09:15 UTC (rev 265344)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm   2020-08-06 20:21:06 UTC (rev 265345)
</span><span class="lines">@@ -843,6 +843,11 @@
</span><span class="cx">     return JSValueToObject(m_context->jsContext(), [JSValue valueWithObject:toNSDictionary(webView()._inputViewBounds) inContext:[JSContext contextWithJSGlobalContextRef:m_context->jsContext()]].JSValueRef, nullptr);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void UIScriptControllerIOS::removeAllDynamicDictionaries()
+{
+    [UIKeyboard removeAllDynamicDictionaries];
+}
+
</ins><span class="cx"> JSRetainPtr<JSStringRef> UIScriptControllerIOS::scrollingTreeAsText() const
</span><span class="cx"> {
</span><span class="cx">     return adopt(JSStringCreateWithCFString((CFStringRef)[webView() _scrollingTreeAsText]));
</span></span></pre>
</div>
</div>

</body>
</html>